-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hybrid-application: merge from master #719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ea81936.
…vigation RUMM-1745 Use single handler for UIKit and SwiftUI views instrumentation
Co-authored-by: Maciek Grzybowski <maciek.grzybowski@datadoghq.com>
…pp-compilation-in-Xcode-12 RUMM-1758 Fix Example app compilation in Xcode 12
to simplify assertion of GH asset content
…e-tool-to-conditionally-include-Kronos RUMM-1744 Update release tool to conditionally validate `Kronos.xcframework`
…directly-into-SDK RUMM-1744 Embed Kronos directly into SDK (combined merge)
…spm-doc RUMM-1799 Clarify Linking Crash Reporting Using SPM
notably: `testWhenDataIsBeingUploaded_itPrintsUploadProgressInformationAndSendsErrorsThroughInternalMonitoring` The flakiness was caused by `userLogger` reference leaked in some other tests which use `DateCorrector` (e.g. all tests in `DatadogTests`). NTP sync completion block was executed no matter of `self` existence, making it send logs to current (global) `userLogger` arbitrarily. This was causing some other tests asserting `userLogger` output to receive false data, coming not from their execution.
by running each measure to fixed number of samples, instead of using time-based condition.
precisely in `testWhenCurrentValueIsObtainedFromNetworkConnectionInfoProvider_thenCrashContextProviderNotifiesNewContext`.
by ensuring autorelease VC deallocation with `autoreleasepool {}`
…ntsAreSent` by increasing number of samples to 400 (with 200 it was failing 4/500 repetitions, with 300 1/500, with 400 it's 100% success).
…om-nightly-tests RUMM-1890 Fix tests flakiness
…s-telemetry-in-internal-monitoring RUMM-1744 Collect Kronos telemetry in Internal Monitoring
buranmert
force-pushed
the
merge-from-master
branch
from
January 13, 2022 14:53
35677b2
to
2536707
Compare
buranmert
force-pushed
the
merge-from-master
branch
from
January 13, 2022 15:09
2536707
to
beeb9bb
Compare
maxep
approved these changes
Jan 13, 2022
apigirl
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the md file looks good for docs
ncreated
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
master
intofeature/hybrid-application