Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2054 Build xcframework with tvos slices #783

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

maxep
Copy link
Member

@maxep maxep commented Mar 18, 2022

What and why?

Build and validate XCFrameworks with tvOS slices for sdk versions greater or equal to 1.10.0.

How?

carthage build --platform iOS,tvOS --use-xcframeworks

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing change.

@maxep maxep requested a review from a team as a code owner March 18, 2022 13:58
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are not well compatible with the way we use distribution tool 💡.

Please mind that Module Stability is broken in dd-sdk-ios (due to https://bugs.swift.org/browse/SR-14195) and we can't ship portable XCFrameworks (more on this in our Confluence).

Due to lack of Module Stability we must be able to re-build XCFrameworks for arbitrary Xcode versions and sometimes do it on-demand (e.g. see 1.9.0 release). This is the reason why Kronos XCFramework validator is still a part of the distribution tool (for the sake of re-building 1.8.x or earlier. For the same reason, tvOS slices must be rather validated conditionally in 1.10.0 and above.

Ensuring this compatibility is a bit inconvenient and adds more work to configuring the tool, but this is the only "smooth" way we found so far 😞. In the past we tried using the tool version from tag instead of sourcing it from master, but this required even more hacks and required manual interventions for almost every release.

tools/distribution/src/release/assets/gh_asset.py Outdated Show resolved Hide resolved
tools/distribution/src/release/assets/gh_asset.py Outdated Show resolved Hide resolved
tools/distribution/src/release/assets/gh_asset.py Outdated Show resolved Hide resolved
@maxep maxep force-pushed the maxep/RUMM-2054/tvos-xcframework branch from bc37c48 to f2b1546 Compare March 21, 2022 16:30
@maxep
Copy link
Member Author

maxep commented Mar 21, 2022

Thanks for the clarification @ncreated 👍 I've made the change to be able to test tvos slices based on the sdk version. It involves changes in XCFrameworkValidator and GHAsset interfaces.

@maxep maxep requested a review from ncreated March 22, 2022 13:55
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌✨

tools/distribution/src/release/assets/gh_asset.py Outdated Show resolved Hide resolved
@maxep maxep merged commit 67f8a73 into feature/tvos Mar 28, 2022
@maxep maxep deleted the maxep/RUMM-2054/tvos-xcframework branch March 28, 2022 09:58
@maxep maxep mentioned this pull request Mar 28, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants