Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2079 time_spent can't be lower than 1ns #802

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

maxep
Copy link
Member

@maxep maxep commented Apr 5, 2022

What and why?

Prevent sending negative view.time_spent.

How?

Report time_spent with a minimal value of 1 nano second.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing change.

@maxep maxep requested a review from a team as a code owner April 5, 2022 14:05
@maxep maxep self-assigned this Apr 5, 2022
@maxep maxep force-pushed the maxep/RUMM-2079/minimum-view-time-spent branch 2 times, most recently from 3c8731a to 3e7b007 Compare April 5, 2022 15:59
@maxep maxep force-pushed the maxep/RUMM-2079/minimum-view-time-spent branch from 3e7b007 to 3d746ed Compare April 5, 2022 19:30
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌

@maxep maxep merged commit 2401434 into develop Apr 6, 2022
@maxep maxep deleted the maxep/RUMM-2079/minimum-view-time-spent branch April 6, 2022 08:38
@ncreated ncreated mentioned this pull request Apr 6, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants