Fix CI Visiblity testing #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxep
reviewed
Apr 5, 2022
Makefile
Outdated
Comment on lines
7
to
10
| FRAMEWORK_SEARCH_PATHS[sdk=iphonesimulator*]=$(inherited) $(SRCROOT)/../instrumented-tests/DatadogSDKTesting.xcframework/ios-arm64_x86_64-simulator/\n | ||
| LD_RUNPATH_SEARCH_PATHS[sdk=iphonesimulator*]=$(inherited) $(SRCROOT)/../instrumented-tests/DatadogSDKTesting.xcframework/ios-arm64_x86_64-simulator/\n | ||
| FRAMEWORK_SEARCH_PATHS[sdk=appletvsimulator*]==$(inherited) $(SRCROOT)/../instrumented-tests/DatadogSDKTesting.xcframework/tvos-arm64_x86_64-simulator/\n | ||
| LD_RUNPATH_SEARCH_PATHS[sdk=appletvsimulator*]=$(inherited) $(SRCROOT)/../instrumented-tests/DatadogSDKTesting.xcframework/tvos-arm64_x86_64-simulator/\n |
There was a problem hiding this comment.
Looks like it cannot find the framework now, see https://app.bitrise.io/build/a4712031-ae45-4825-809a-15ab2b7bfb4f
ld: framework not found DatadogSDKTesting
There was a problem hiding this comment.
Yes, I think I missed the double $$ needed for the makefile
ncreated
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Fix CI Visiblity testing.
How?
FRAMEWORK_SEARCH_PATHS and LD_RUNPATH_SEARCH_PATHS were not properly set
Expand test environment variables in tvOS targets
Review checklist