RUMM-392 SDK is set dynamic in SPM

[buranmert]

What and why?

Swift Package Manager encourages us to leave library type for itself to decide either dynamic or static
Yet, it doesn't change to use dynamic when needed.

Example case

We have 3 targets:

1. App: links Datadog, Framework1 and Framework2
2. Framework1: links Datadog
3. Framework2: links Datadog

When we build App, Xcode emits the following error:

Swift package product 'Datadog' is linked as a static library by 'Framework1' and 'Framework2'. This will result in duplication of library code

Solution

Either

1. we can change our SDK's type in Package.swift to dynamic or
2. our users can use DISABLE_DIAMOND_PROBLEM_DIAGNOSTIC build setting to silence the error

We implemented the change in Package.swift in this PR

Important note

Xcode builds App Extensions and alikes without this problem (unless symbols are duplicated in binaries)

That makes the example case above an edge case IMO

Conclusion

Given that the error occurs only in an edge case, giving up on static linking may not be the best solution.
I suggest not fixing the issue and

1. waiting for Xcode/SwiftPackageManager to fix the issue on their end
2. providing information about possible workarounds to our users (eg: in README.md or TROUBLESHOOT.md)

Review checklist

• Feature or bugfix MUST have appropriate tests (unit, integration)
• Make sure each commit and the PR mention the Issue number or JIRA reference

[ncreated]

IMO it is better to provide any solution that we can later iterate on, instead of having no SPM support for modular architectures at all. Let's start with dynamic framework and we'll see what future versions of SPM will bring 🙂.