Steven/dd base service tag 2 #6079

bouwkast · 2024-09-25T12:01:11Z

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Co-authored-by: Andrew Lock <andrew.lock@datadoghq.com>

github-actions · 2024-09-25T12:01:56Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

2 occurrences of :

+        "_dd.base_service": "AspNetCoreSmokeTest"

19 occurrences of :

+      _dd.base_service: Samples.Aerospike

16 occurrences of :

+      _dd.base_service: Samples.AWS.DynamoDBv2

4 occurrences of :

+      _dd.base_service: Samples.AWS.Kinesis

37 occurrences of :

+      _dd.base_service: Samples.AWS.Lambda

1 occurrences of :

+      _dd.base_service: Samples.Amazon.Lambda.RuntimeSupport

7 occurrences of :

+      _dd.base_service: Samples.AWS.SimpleNotificationService

54 occurrences of :

+      _dd.base_service: Samples.AWS.SQS

10 occurrences of :

+      _dd.base_service: AzureFunctionsAllTriggers

14 occurrences of :

-      span.kind: client,
-      _dd.git.commit.sha: aaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbb,
-      _dd.git.repository_url: https://github.com/DataDog/dd-trace-dotnet
+      span.kind: client

30 occurrences of :

-      _dd.git.commit.sha: aaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbb,
-      _dd.git.repository_url: https://github.com/DataDog/dd-trace-dotnet,

66 occurrences of :

+      _dd.base_service: Samples.Couchbase3

590 occurrences of :

+      _dd.base_service: Samples.Elasticsearch

22 occurrences of :

+      _dd.base_service: Samples.GraphQL

22 occurrences of :

+      _dd.base_service: Samples.GraphQL3

11 occurrences of :

+      _dd.base_service: Samples.GraphQL4

16 occurrences of :

+      _dd.base_service: Samples.GraphQL7

45 occurrences of :

+      _dd.base_service: Samples.GrpcDotNet

14 occurrences of :

+      _dd.base_service: Samples.GrpcLegacy

14 occurrences of :

+      _dd.base_service: Samples.HotChocolate

6 occurrences of :

+      _dd.base_service: Samples.ManualInstrumentation

1 occurrences of :

+      _dd.base_service: updated-name

49 occurrences of :

+      _dd.base_service: Samples.MongoDB

2 occurrences of :

-    Name: Main(),
+    Name: internal,

6 occurrences of :

-      version: 1.0.0,
-      _dd.git.commit.sha: aaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbb,
-      _dd.git.repository_url: https://github.com/DataDog/dd-trace-dotnet
+      version: 1.0.0

2 occurrences of :

-    Name: sync-calls,
+    Name: internal,

2 occurrences of :

-      version: 1.0.0,
-      _dd.git.commit.sha: aaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbb,
-      _dd.git.repository_url: https://github.com/DataDog/dd-trace-dotnet
+      version: 1.0.0
[...]
-    Name: async-calls,
+    Name: internal,

2 occurrences of :

-      version: 1.0.0,
-      _dd.git.commit.sha: aaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbb,
-      _dd.git.repository_url: https://github.com/DataDog/dd-trace-dotnet
+      version: 1.0.0
[...]
-    Name: sync-calls,
+    Name: internal,

17 occurrences of :

-      _dd.git.commit.sha: aaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbb,
-      _dd.git.repository_url: https://github.com/DataDog/dd-trace-dotnet
+      _dd.base_service: Samples.MongoDB

1 occurrences of :

-    Name: sync-calls-execute,
+    Name: internal,

2 occurrences of :

-      version: 1.0.0,
-      _dd.git.commit.sha: aaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbb,
-      _dd.git.repository_url: https://github.com/DataDog/dd-trace-dotnet
+      version: 1.0.0
[...]
-    Name: async-calls-execute,
+    Name: internal,

1 occurrences of :

-      _dd.git.commit.sha: aaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbb,
-      _dd.git.repository_url: https://github.com/DataDog/dd-trace-dotnet,
[...]
-    Name: sync-calls-execute,
+    Name: internal,

294 occurrences of :

+      _dd.base_service: Samples.MySql,

294 occurrences of :

+      _dd.base_service: Samples.MySql

147 occurrences of :

+      _dd.base_service: Samples.Npgsql,

147 occurrences of :

+      _dd.base_service: Samples.Npgsql

40 occurrences of :

+      _dd.base_service: Samples.ProcessStart

228 occurrences of :

+      _dd.base_service: Samples.RabbitMQ

8 occurrences of :

+      _dd.base_service: Samples.Remoting

13 occurrences of :

+      _dd.base_service: Samples.ServiceStack.Redis

609 occurrences of :

+      _dd.base_service: Samples.StackExchange.Redis

168 occurrences of :

+      _dd.base_service: Samples.SqlServer,

168 occurrences of :

+      _dd.base_service: Samples.SqlServer

2 occurrences of :

+      _dd.base_service: Samples.Telemetry

2 occurrences of :

+      _dd.base_service: Samples.Yarp.DistributedTracing

andrewlock · 2024-09-25T12:32:55Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6079) - mean (71ms)  : 68, 74
     .   : milestone, 71,
    master - mean (71ms)  : 68, 73
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6079) - mean (1,111ms)  : 1093, 1130
     .   : milestone, 1111,
    master - mean (1,110ms)  : 1087, 1132
     .   : milestone, 1110,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6079) - mean (110ms)  : 106, 113
     .   : milestone, 110,
    master - mean (110ms)  : 107, 112
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6079) - mean (775ms)  : 753, 798
     .   : milestone, 775,
    master - mean (775ms)  : 759, 791
     .   : milestone, 775,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6079) - mean (94ms)  : 90, 98
     .   : milestone, 94,
    master - mean (94ms)  : 90, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (6079) - mean (734ms)  : 711, 756
     .   : milestone, 734,
    master - mean (734ms)  : 713, 756
     .   : milestone, 734,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6079) - mean (191ms)  : 188, 195
     .   : milestone, 191,
    master - mean (191ms)  : 188, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6079) - mean (1,204ms)  : 1180, 1229
     .   : milestone, 1204,
    master - mean (1,199ms)  : 1176, 1222
     .   : milestone, 1199,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6079) - mean (278ms)  : 272, 283
     .   : milestone, 278,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6079) - mean (944ms)  : 924, 963
     .   : milestone, 944,
    master - mean (941ms)  : 920, 962
     .   : milestone, 941,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6079) - mean (266ms)  : 261, 270
     .   : milestone, 266,
    master - mean (266ms)  : 263, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6079) - mean (925ms)  : 908, 942
     .   : milestone, 925,
    master - mean (930ms)  : 910, 951
     .   : milestone, 930,

datadog-ddstaging · 2024-09-25T12:56:23Z

Datadog Report

Branch report: steven/dd-base-service-tag-2
Commit report: a4ce52e
Test service: dd-trace-dotnet

✅ 0 Failed, 366230 Passed, 2062 Skipped, 15h 19m 27.48s Total Time

andrewlock · 2024-09-25T15:47:56Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6079) (9.032M)   : 0, 9032141
    master (10.819M)   : 0, 10818800
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6079) (7.391M)   : 0, 7390709
    master (7.086M)   : 0, 7085538
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.483M)   : 0, 7483104

    section Manual
    master (10.866M)   : 0, 10866444

    section Manual + Automatic
    This PR (6079) (6.803M)   : 0, 6803180
    master (6.588M)   : 0, 6588413

    section DD_TRACE_ENABLED=0
    master (9.952M)   : 0, 9951884

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6079) (9.346M)   : 0, 9345843
    master (9.658M)   : 0, 9657695
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6079) (6.589M)   : 0, 6589075
    master (6.551M)   : 0, 6550999

    section Trace stats
    master (6.916M)   : 0, 6915928

    section Manual
    master (9.641M)   : 0, 9641297

    section Manual + Automatic
    This PR (6079) (6.061M)   : 0, 6060510
    master (6.049M)   : 0, 6049383

    section DD_TRACE_ENABLED=0
    master (8.866M)   : 0, 8865668

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6079) (9.931M)   : 0, 9931400
    master (9.871M)   : 0, 9871342
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6079) (6.562M)   : 0, 6561840
    master (6.743M)   : 0, 6743042
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.264M)   : 0, 7264470

    section Manual
    master (9.831M)   : 0, 9831485

    section Manual + Automatic
    This PR (6079) (6.312M)   : 0, 6311683
    master (6.328M)   : 0, 6327608

    section DD_TRACE_ENABLED=0
    master (9.339M)   : 0, 9338594

andrewlock · 2024-09-25T16:45:39Z

Benchmarks Report for tracer 🐌

Benchmarks for #6079 compared to master:

1 benchmarks are faster, with geometric mean 1.115
1 benchmarks are slower, with geometric mean 1.141
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.82μs	45.1ns	361ns	0.0153	0.00765	0	5.42 KB
master	`StartStopWithChild`	netcoreapp3.1	9.78μs	54.3ns	339ns	0.0143	0.00478	0	5.61 KB
master	`StartStopWithChild`	net472	16.1μs	59.8ns	232ns	1.01	0.293	0.0951	6.06 KB
#6079	`StartStopWithChild`	net6.0	7.68μs	42.6ns	266ns	0.0195	0.0078	0	5.43 KB
#6079	`StartStopWithChild`	netcoreapp3.1	9.79μs	52.8ns	274ns	0.0186	0.00465	0	5.61 KB
#6079	`StartStopWithChild`	net472	16.1μs	69ns	267ns	1.03	0.312	0.104	6.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	479μs	242ns	937ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	629μs	306ns	1.19μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	832μs	728ns	2.82μs	0.419	3.3 KB
#6079	`WriteAndFlushEnrichedTraces`	net6.0	480μs	307ns	1.15μs	0	2.7 KB
#6079	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	632μs	310ns	1.16μs	0	2.7 KB
#6079	`WriteAndFlushEnrichedTraces`	net472	837μs	452ns	1.75μs	0.417	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	198μs	882ns	3.3μs	0.211	18.45 KB
master	`SendRequest`	netcoreapp3.1	219μs	1.26μs	9.58μs	0.216	20.61 KB
master	`SendRequest`	net472	0.000333ns	0.000216ns	0.000806ns	0	0 b
#6079	`SendRequest`	net6.0	193μs	974ns	6μs	0.198	18.45 KB
#6079	`SendRequest`	netcoreapp3.1	219μs	1.25μs	8.93μs	0.216	20.61 KB
#6079	`SendRequest`	net472	0.00682ns	0.00146ns	0.00567ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	572μs	2.38μs	10.4μs	0.571	0	0	41.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	684μs	3.63μs	18.2μs	0.329	0	0	41.64 KB
master	`WriteAndFlushEnrichedTraces`	net472	873μs	3.25μs	12.2μs	8.25	2.6	0.434	53.27 KB
#6079	`WriteAndFlushEnrichedTraces`	net6.0	559μs	1.81μs	6.77μs	0.595	0	0	41.52 KB
#6079	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	678μs	2.96μs	12.2μs	0.326	0	0	41.68 KB
#6079	`WriteAndFlushEnrichedTraces`	net472	865μs	4.09μs	16.9μs	8.25	2.6	0.434	53.32 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.22μs	1.22ns	4.71ns	0.0141	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.79μs	1.11ns	4.3ns	0.0133	1.02 KB
master	`ExecuteNonQuery`	net472	2.09μs	2.37ns	8.85ns	0.156	987 B
#6079	`ExecuteNonQuery`	net6.0	1.25μs	0.879ns	3.41ns	0.0144	1.02 KB
#6079	`ExecuteNonQuery`	netcoreapp3.1	1.82μs	0.838ns	3.02ns	0.0134	1.02 KB
#6079	`ExecuteNonQuery`	net472	2.06μs	2.05ns	7.93ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6079

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472	1.115	2,719.82	2,439.62

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.16μs	0.648ns	2.51ns	0.0139	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.51μs	0.765ns	2.96ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.48μs	1.4ns	5.43ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.29μs	2.44ns	9.46ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	0.799ns	2.99ns	0.0141	1.02 KB
master	`CallElasticsearchAsync`	net472	2.72μs	2.24ns	8.68ns	0.167	1.05 KB
#6079	`CallElasticsearch`	net6.0	1.19μs	0.908ns	3.52ns	0.0138	976 B
#6079	`CallElasticsearch`	netcoreapp3.1	1.5μs	1.06ns	3.81ns	0.0134	976 B
#6079	`CallElasticsearch`	net472	2.47μs	1.24ns	4.79ns	0.157	995 B
#6079	`CallElasticsearchAsync`	net6.0	1.32μs	1.19ns	4.6ns	0.0132	952 B
#6079	`CallElasticsearchAsync`	netcoreapp3.1	1.71μs	0.876ns	3.39ns	0.0137	1.02 KB
#6079	`CallElasticsearchAsync`	net472	2.44μs	1.58ns	5.9ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.28μs	0.682ns	2.64ns	0.0129	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.62μs	0.467ns	1.75ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.74μs	0.721ns	2.7ns	0.145	915 B
#6079	`ExecuteAsync`	net6.0	1.17μs	0.969ns	3.63ns	0.0135	952 B
#6079	`ExecuteAsync`	netcoreapp3.1	1.58μs	0.503ns	1.81ns	0.0127	952 B
#6079	`ExecuteAsync`	net472	1.76μs	0.895ns	3.23ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.1μs	2.41ns	9.33ns	0.0306	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.06μs	2.66ns	10.3ns	0.036	2.76 KB
master	`SendAsync`	net472	7.84μs	2.17ns	8.4ns	0.498	3.15 KB
#6079	`SendAsync`	net6.0	4.06μs	1.48ns	5.72ns	0.0306	2.22 KB
#6079	`SendAsync`	netcoreapp3.1	5.05μs	2.34ns	9.07ns	0.0354	2.76 KB
#6079	`SendAsync`	net472	7.97μs	3.57ns	13.8ns	0.498	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.44μs	1.11ns	4.29ns	0.0231	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.26μs	0.979ns	3.53ns	0.0228	1.64 KB
master	`EnrichedLog`	net472	2.58μs	0.884ns	3.43ns	0.25	1.57 KB
#6079	`EnrichedLog`	net6.0	1.44μs	0.577ns	2.16ns	0.0232	1.64 KB
#6079	`EnrichedLog`	netcoreapp3.1	2.1μs	1.13ns	4.21ns	0.0221	1.64 KB
#6079	`EnrichedLog`	net472	2.59μs	0.605ns	2.18ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	152ns	588ns	0.0569	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	180ns	695ns	0.0592	0	4.28 KB
master	`EnrichedLog`	net472	146μs	201ns	780ns	0.656	0.219	4.46 KB
#6079	`EnrichedLog`	net6.0	116μs	211ns	816ns	0.0572	0	4.28 KB
#6079	`EnrichedLog`	netcoreapp3.1	119μs	117ns	454ns	0	0	4.28 KB
#6079	`EnrichedLog`	net472	146μs	189ns	731ns	0.65	0.217	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.05μs	0.612ns	2.37ns	0.0303	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.34μs	1.4ns	5.22ns	0.0282	2.2 KB
master	`EnrichedLog`	net472	4.7μs	1.36ns	5.09ns	0.321	2.02 KB
#6079	`EnrichedLog`	net6.0	2.87μs	0.97ns	3.63ns	0.0301	2.2 KB
#6079	`EnrichedLog`	netcoreapp3.1	4.46μs	4.52ns	16.3ns	0.0289	2.2 KB
#6079	`EnrichedLog`	net472	4.86μs	1.4ns	5.44ns	0.321	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.34μs	0.59ns	2.13ns	0.016	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.65μs	1.13ns	4.24ns	0.0158	0	1.14 KB
master	`SendReceive`	net472	2.05μs	1.3ns	5.05ns	0.183	0.00103	1.16 KB
#6079	`SendReceive`	net6.0	1.44μs	0.428ns	1.6ns	0.0165	0	1.14 KB
#6079	`SendReceive`	netcoreapp3.1	1.78μs	1ns	3.76ns	0.0153	0	1.14 KB
#6079	`SendReceive`	net472	2.03μs	0.799ns	3.1ns	0.183	0.00102	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.76μs	1.03ns	3.86ns	0.0221	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.92μs	1.46ns	5.67ns	0.0218	1.65 KB
master	`EnrichedLog`	net472	4.23μs	1.88ns	7.04ns	0.323	2.04 KB
#6079	`EnrichedLog`	net6.0	2.74μs	0.963ns	3.6ns	0.0218	1.6 KB
#6079	`EnrichedLog`	netcoreapp3.1	3.93μs	1.54ns	5.95ns	0.0215	1.65 KB
#6079	`EnrichedLog`	net472	4.32μs	2.78ns	10.8ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	394ns	0.306ns	1.19ns	0.00813	576 B
master	`StartFinishSpan`	netcoreapp3.1	659ns	0.498ns	1.93ns	0.00755	576 B
master	`StartFinishSpan`	net472	672ns	0.514ns	1.85ns	0.0917	578 B
master	`StartFinishScope`	net6.0	550ns	0.281ns	1.09ns	0.00965	696 B
master	`StartFinishScope`	netcoreapp3.1	742ns	1.23ns	4.6ns	0.00959	696 B
master	`StartFinishScope`	net472	862ns	3.83ns	14.8ns	0.104	658 B
#6079	`StartFinishSpan`	net6.0	397ns	0.14ns	0.541ns	0.00818	576 B
#6079	`StartFinishSpan`	netcoreapp3.1	623ns	2.41ns	9.31ns	0.00777	576 B
#6079	`StartFinishSpan`	net472	667ns	1.27ns	4.91ns	0.0916	578 B
#6079	`StartFinishScope`	net6.0	497ns	0.0935ns	0.35ns	0.00967	696 B
#6079	`StartFinishScope`	netcoreapp3.1	794ns	0.393ns	1.52ns	0.00948	696 B
#6079	`StartFinishScope`	net472	889ns	0.949ns	3.68ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6079

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1	1.141	923.97	1,054.63

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	647ns	1.36ns	5.07ns	0.00998	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	923ns	1.07ns	4.14ns	0.00961	696 B
master	`RunOnMethodBegin`	net472	1.12μs	4.75ns	18.4ns	0.104	658 B
#6079	`RunOnMethodBegin`	net6.0	688ns	0.352ns	1.32ns	0.00957	696 B
#6079	`RunOnMethodBegin`	netcoreapp3.1	1.05μs	0.411ns	1.54ns	0.0095	696 B
#6079	`RunOnMethodBegin`	net472	1.11μs	0.394ns	1.47ns	0.104	658 B

bouwkast and others added 11 commits September 24, 2024 12:01

Set _dd.base_service correctly

800c97a

Update tests

69180a5

Fix TagsListTests

526c17c

Update snapshots

368dc8a

Add missing _dd.base_service to meta data rules

a253344

Update more snapshots

0fdf93c

Update the smoke test snapshots

b273b2d

Properly dispose of the tracer in test

84bad6c

Co-authored-by: Andrew Lock <andrew.lock@datadoghq.com>

Revert to using a mock

87d74fc

Update snapshots

269cea7

Update snapshot

a4ce52e

bouwkast closed this Sep 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Steven/dd base service tag 2 #6079

Steven/dd base service tag 2 #6079

bouwkast commented Sep 25, 2024

github-actions bot commented Sep 25, 2024

andrewlock commented Sep 25, 2024

datadog-ddstaging bot commented Sep 25, 2024 •

edited

Loading

andrewlock commented Sep 25, 2024

andrewlock commented Sep 25, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6079

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6079

Raw results

Steven/dd base service tag 2 #6079

Steven/dd base service tag 2 #6079

Conversation

bouwkast commented Sep 25, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

github-actions bot commented Sep 25, 2024

Snapshots difference summary

andrewlock commented Sep 25, 2024

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Sep 25, 2024 • edited Loading

Datadog Report

andrewlock commented Sep 25, 2024

Throughput/Crank Report ⚡

andrewlock commented Sep 25, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6079

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6079

Raw results

datadog-ddstaging bot commented Sep 25, 2024 •

edited

Loading