Remove warning about non-serializable test data #6102

bouwkast · 2024-09-30T20:40:26Z

Summary of changes

Removes warnings about non-serializable test data

Datadog.Trace.Tests: Non-serializable data ('System.Object[]') found for 'Datadog.Trace.Tests.Tagging.ActivityTagsTests.Tags_ShouldBe_PlacedInMetricsOrMeta'; falling back to single test case.

Reason for change

Warnings about Non-serializable data ('System.Object[]').

Implementation details

Ignored them by setting DisableDiscoveryEnumeration = true on MemberData.

Test coverage

Ran tests locally, warning gone.

Other details

Maybe I could've changed them to have serializable test data 🤷

lucaspimentel · 2024-09-30T20:56:57Z

tracer/test/Datadog.Trace.Tests/Agent/MessagePack/SpanMetaStructTests.cs

@@ -103,7 +103,7 @@ public class SpanMetaStructTests
            }
       };

-    [MemberData(nameof(Data))]
+    [MemberData(nameof(Data), DisableDiscoveryEnumeration = true)]


Don't we want to fix the underlying issue instead of disabling the warning? The warning says "falling back to single test case" which makes me think it will only run one tests case instead of all of them.

See #5089

I mean, maybe? But I think they are useless warnings.

which makes me thing it will only run on tests case instead of all of them.

I don't think so, the tests all run locally on the CLI and via the VS Test Explorer.

What is happening is that xunit (I think or maybe the test host) is attempting to enumerate all of the individual theory data lines just so that you could run an individual Theory data by itself instead of the entire test.

That is what the Non-serializable data ('System.Object[]') found for 'Datadog.Trace.Tests.Tagging.ActivityTagsTests.Tags_ShouldBe_PlacedInMetricsOrMeta'; falling back to single test case. is ultimately meaning.

I didn't see that we have been fixing them to be serializable previously

But I'll swap to fix it to be consistent.

I am curious if that enumeration is slowing our tests down 🤔

Relevant comment in the xunit code: https://github.com/xunit/xunit/blob/414e2c88661d9122f1c3e9b595839647a3188119/src/xunit.v3.core/Framework/TheoryDiscoverer.cs#L190-L196

You're right it still runs all the cases at run time, so meh. Thanks for looking into this!

Yeah, the analysis is 100 correct, it just gives a worse local dev experience, I only learned that after raising an issue for it here 😄 xunit/xunit#2866

I am curious if that enumeration is slowing our tests down

My strong suspicion is that it's a drop in the ocean and not worth worrying about 😃

datadog-ddstaging · 2024-09-30T21:02:40Z

Datadog Report

Branch report: steven/non-serial-xunit
Commit report: 9e66e52
Test service: dd-trace-dotnet

✅ 0 Failed, 362359 Passed, 2069 Skipped, 15h 57m 50.01s Total Time

andrewlock · 2024-09-30T21:11:03Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6102) - mean (70ms)  : 68, 73
     .   : milestone, 70,
    master - mean (71ms)  : 68, 73
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6102) - mean (1,107ms)  : 1087, 1128
     .   : milestone, 1107,
    master - mean (1,103ms)  : 1076, 1131
     .   : milestone, 1103,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6102) - mean (110ms)  : 107, 114
     .   : milestone, 110,
    master - mean (110ms)  : 105, 115
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6102) - mean (768ms)  : 754, 782
     .   : milestone, 768,
    master - mean (772ms)  : 757, 787
     .   : milestone, 772,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6102) - mean (93ms)  : 90, 96
     .   : milestone, 93,
    master - mean (93ms)  : 90, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6102) - mean (731ms)  : 710, 753
     .   : milestone, 731,
    master - mean (727ms)  : 711, 744
     .   : milestone, 727,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6102) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6102) - mean (1,203ms)  : 1172, 1235
     .   : milestone, 1203,
    master - mean (1,197ms)  : 1171, 1224
     .   : milestone, 1197,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6102) - mean (276ms)  : 272, 281
     .   : milestone, 276,
    master - mean (277ms)  : 273, 281
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6102) - mean (944ms)  : 920, 969
     .   : milestone, 944,
    master - mean (938ms)  : 918, 958
     .   : milestone, 938,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6102) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (265ms)  : 260, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6102) - mean (925ms)  : 909, 941
     .   : milestone, 925,
    master - mean (927ms)  : 906, 949
     .   : milestone, 927,

andrewlock · 2024-09-30T21:38:57Z

Benchmarks Report for tracer 🐌

Benchmarks for #6102 compared to master:

1 benchmarks are faster, with geometric mean 1.234
1 benchmarks are slower, with geometric mean 1.161
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.66μs	42.4ns	268ns	0.0151	0.00757	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.87μs	55ns	335ns	0.0189	0.00947	0	5.61 KB
master	`StartStopWithChild`	net472	16.3μs	60.7ns	235ns	1.04	0.324	0.103	6.06 KB
#6102	`StartStopWithChild`	net6.0	7.71μs	42.3ns	243ns	0.0193	0.00772	0	5.43 KB
#6102	`StartStopWithChild`	netcoreapp3.1	9.93μs	54.6ns	345ns	0.0238	0.00953	0	5.61 KB
#6102	`StartStopWithChild`	net472	16.2μs	49.1ns	190ns	0.999	0.282	0.0805	6.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	479μs	266ns	996ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	641μs	312ns	1.17μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	836μs	443ns	1.71μs	0.419	3.3 KB
#6102	`WriteAndFlushEnrichedTraces`	net6.0	517μs	436ns	1.57μs	0	2.7 KB
#6102	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	634μs	501ns	1.94μs	0	2.7 KB
#6102	`WriteAndFlushEnrichedTraces`	net472	834μs	457ns	1.77μs	0.411	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	191μs	1.05μs	6.12μs	0.199	18.45 KB
master	`SendRequest`	netcoreapp3.1	212μs	894ns	3.46μs	0.211	20.61 KB
master	`SendRequest`	net472	0.000501ns	0.000304ns	0.00114ns	0	0 b
#6102	`SendRequest`	net6.0	192μs	1.09μs	8.6μs	0.203	18.45 KB
#6102	`SendRequest`	netcoreapp3.1	220μs	1.2μs	7.38μs	0.22	20.61 KB
#6102	`SendRequest`	net472	0.00191ns	0.000775ns	0.0029ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6102

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.85 KB	41.54 KB	-305 B	-0.73%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	596μs	3.27μs	20.2μs	0.576	0	0	41.85 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	667μs	2.67μs	9.98μs	0.329	0	0	41.71 KB
master	`WriteAndFlushEnrichedTraces`	net472	875μs	2.56μs	9.9μs	8.36	2.64	0.44	53.27 KB
#6102	`WriteAndFlushEnrichedTraces`	net6.0	559μs	2.34μs	10.4μs	0.551	0	0	41.54 KB
#6102	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	679μs	3.42μs	17.5μs	0.331	0	0	41.92 KB
#6102	`WriteAndFlushEnrichedTraces`	net472	856μs	3.97μs	15.9μs	8.28	2.48	0.414	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.29μs	1.32ns	5.12ns	0.0142	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	2.4ns	9.31ns	0.014	1.02 KB
master	`ExecuteNonQuery`	net472	2.11μs	2.74ns	10.6ns	0.157	987 B
#6102	`ExecuteNonQuery`	net6.0	1.31μs	1.11ns	4.29ns	0.0145	1.02 KB
#6102	`ExecuteNonQuery`	netcoreapp3.1	1.84μs	4.47ns	17.3ns	0.0136	1.02 KB
#6102	`ExecuteNonQuery`	net472	2.04μs	2.71ns	10.5ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.25μs	0.413ns	1.6ns	0.0138	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.49μs	0.919ns	3.31ns	0.0135	976 B
master	`CallElasticsearch`	net472	2.52μs	1.33ns	5.13ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.26μs	1.29ns	4.83ns	0.0132	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.59μs	0.468ns	1.81ns	0.0135	1.02 KB
master	`CallElasticsearchAsync`	net472	2.58μs	1.12ns	4.18ns	0.167	1.05 KB
#6102	`CallElasticsearch`	net6.0	1.25μs	1.37ns	5.29ns	0.0137	976 B
#6102	`CallElasticsearch`	netcoreapp3.1	1.59μs	0.716ns	2.77ns	0.0134	976 B
#6102	`CallElasticsearch`	net472	2.56μs	1.1ns	4.26ns	0.157	995 B
#6102	`CallElasticsearchAsync`	net6.0	1.3μs	0.705ns	2.73ns	0.0136	952 B
#6102	`CallElasticsearchAsync`	netcoreapp3.1	1.62μs	1.21ns	4.68ns	0.0138	1.02 KB
#6102	`CallElasticsearchAsync`	net472	2.57μs	1.77ns	6.84ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.34μs	0.895ns	3.47ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.67μs	0.819ns	3.07ns	0.0129	952 B
master	`ExecuteAsync`	net472	1.82μs	0.806ns	3.12ns	0.145	915 B
#6102	`ExecuteAsync`	net6.0	1.26μs	0.965ns	3.61ns	0.0132	952 B
#6102	`ExecuteAsync`	netcoreapp3.1	1.71μs	0.932ns	3.49ns	0.0128	952 B
#6102	`ExecuteAsync`	net472	1.76μs	0.714ns	2.57ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.14μs	1.7ns	6.37ns	0.031	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.02μs	1.82ns	6.55ns	0.0377	2.76 KB
master	`SendAsync`	net472	7.84μs	1.61ns	6.23ns	0.497	3.15 KB
#6102	`SendAsync`	net6.0	4.21μs	1.59ns	6.18ns	0.0296	2.22 KB
#6102	`SendAsync`	netcoreapp3.1	4.9μs	2.4ns	8.65ns	0.0343	2.76 KB
#6102	`SendAsync`	net472	7.77μs	1.8ns	6.75ns	0.499	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.47μs	0.657ns	2.46ns	0.0228	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.21μs	1.71ns	6.62ns	0.0224	1.64 KB
master	`EnrichedLog`	net472	2.5μs	1.02ns	3.81ns	0.249	1.57 KB
#6102	`EnrichedLog`	net6.0	1.44μs	0.582ns	2.18ns	0.0233	1.64 KB
#6102	`EnrichedLog`	netcoreapp3.1	2.23μs	0.914ns	3.42ns	0.0219	1.64 KB
#6102	`EnrichedLog`	net472	2.54μs	1.46ns	5.27ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	114μs	176ns	680ns	0.0574	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	176ns	659ns	0.0588	0	4.28 KB
master	`EnrichedLog`	net472	148μs	153ns	592ns	0.663	0.221	4.46 KB
#6102	`EnrichedLog`	net6.0	116μs	174ns	673ns	0.0569	0	4.28 KB
#6102	`EnrichedLog`	netcoreapp3.1	119μs	103ns	398ns	0	0	4.28 KB
#6102	`EnrichedLog`	net472	147μs	87.7ns	328ns	0.657	0.219	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.99μs	9.04ns	35ns	0.0306	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.12μs	4.41ns	17.1ns	0.029	2.2 KB
master	`EnrichedLog`	net472	4.97μs	1.94ns	7.5ns	0.321	2.02 KB
#6102	`EnrichedLog`	net6.0	3.1μs	1.05ns	4.05ns	0.0312	2.2 KB
#6102	`EnrichedLog`	netcoreapp3.1	4.18μs	2.09ns	8.1ns	0.0293	2.2 KB
#6102	`EnrichedLog`	net472	4.8μs	0.912ns	3.41ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.31μs	0.617ns	2.39ns	0.0159	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.73μs	0.831ns	3.11ns	0.0156	0	1.14 KB
master	`SendReceive`	net472	2.11μs	1.9ns	7.35ns	0.183	0.00106	1.16 KB
#6102	`SendReceive`	net6.0	1.35μs	0.71ns	2.56ns	0.0162	0	1.14 KB
#6102	`SendReceive`	netcoreapp3.1	1.72μs	0.602ns	2.33ns	0.0155	0	1.14 KB
#6102	`SendReceive`	net472	2.12μs	1.24ns	4.81ns	0.183	0	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.66μs	0.929ns	3.6ns	0.0226	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.8μs	1.81ns	7.02ns	0.0227	1.65 KB
master	`EnrichedLog`	net472	4.42μs	1.66ns	6.43ns	0.322	2.04 KB
#6102	`EnrichedLog`	net6.0	2.79μs	1.04ns	4.03ns	0.0224	1.6 KB
#6102	`EnrichedLog`	netcoreapp3.1	3.9μs	2.09ns	8.09ns	0.0217	1.65 KB
#6102	`EnrichedLog`	net472	4.3μs	2.26ns	8.76ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6102

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.161	547.79	636.19

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`StartFinishSpan`	net6.0	398ns	0.109ns	0.422ns	0.008	0	576 B
master	`StartFinishSpan`	netcoreapp3.1	548ns	0.359ns	1.39ns	0.00777	0	576 B
master	`StartFinishSpan`	net472	663ns	0.333ns	1.29ns	0.0916	0	578 B
master	`StartFinishScope`	net6.0	545ns	0.287ns	1.07ns	0.00966	0	696 B
master	`StartFinishScope`	netcoreapp3.1	785ns	0.298ns	1.16ns	0.0094	0	696 B
master	`StartFinishScope`	net472	838ns	0.422ns	1.64ns	0.104	0	658 B
#6102	`StartFinishSpan`	net6.0	392ns	0.159ns	0.618ns	0.00808	0	576 B
#6102	`StartFinishSpan`	netcoreapp3.1	636ns	0.613ns	2.3ns	0.00797	0	576 B
#6102	`StartFinishSpan`	net472	650ns	0.299ns	1.16ns	0.0916	0	578 B
#6102	`StartFinishScope`	net6.0	553ns	0.144ns	0.558ns	0.00972	0	696 B
#6102	`StartFinishScope`	netcoreapp3.1	748ns	0.617ns	2.39ns	0.00933	0	696 B
#6102	`StartFinishScope`	net472	822ns	0.244ns	0.943ns	0.105	0.000418	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6102

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.234	736.19	596.45

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	736ns	0.208ns	0.807ns	0.00958	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	935ns	0.37ns	1.28ns	0.00942	696 B
master	`RunOnMethodBegin`	net472	1.1μs	0.959ns	3.72ns	0.105	658 B
#6102	`RunOnMethodBegin`	net6.0	597ns	0.197ns	0.711ns	0.00976	696 B
#6102	`RunOnMethodBegin`	netcoreapp3.1	994ns	0.804ns	3.12ns	0.00895	696 B
#6102	`RunOnMethodBegin`	net472	1.19μs	0.357ns	1.38ns	0.104	658 B

andrewlock · 2024-09-30T21:41:44Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6102) (11.043M)   : 0, 11042703
    master (11.044M)   : 0, 11043629
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6102) (7.388M)   : 0, 7387880
    master (7.395M)   : 0, 7394522
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.557M)   : 0, 7557283

    section Manual
    master (11.055M)   : 0, 11055042

    section Manual + Automatic
    This PR (6102) (6.846M)   : 0, 6846480
    master (6.782M)   : 0, 6782217

    section DD_TRACE_ENABLED=0
    master (10.158M)   : 0, 10158294

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6102) (9.604M)   : 0, 9603596
    master (9.515M)   : 0, 9514989
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6102) (6.577M)   : 0, 6576619
    master (6.542M)   : 0, 6542150

    section Trace stats
    master (6.818M)   : 0, 6817856

    section Manual
    master (9.487M)   : 0, 9486904

    section Manual + Automatic
    This PR (6102) (6.108M)   : 0, 6107738
    master (6.140M)   : 0, 6139999

    section DD_TRACE_ENABLED=0
    master (8.979M)   : 0, 8979042

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6102) (10.300M)   : 0, 10300130
    master (10.290M)   : 0, 10290194
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6102) (6.669M)   : 0, 6669334
    master (6.598M)   : 0, 6597608
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.423M)   : 0, 7423419

    section Manual
    master (10.074M)   : 0, 10074124

    section Manual + Automatic
    This PR (6102) (6.226M)   : 0, 6226133
    master (6.290M)   : 0, 6290240

    section DD_TRACE_ENABLED=0
    master (9.460M)   : 0, 9460167

andrewlock

Thanks!

## Summary of changes Removes warnings about non-serializable test data ``` Datadog.Trace.Tests: Non-serializable data ('System.Object[]') found for 'Datadog.Trace.Tests.Tagging.ActivityTagsTests.Tags_ShouldBe_PlacedInMetricsOrMeta'; falling back to single test case. ``` ## Reason for change Warnings about `Non-serializable data ('System.Object[]')`. ## Implementation details Ignored them by setting `DisableDiscoveryEnumeration = true` on `MemberData`. ## Test coverage Ran tests locally, warning gone. ## Other details Maybe I could've changed them to have serializable test data 🤷

Remove warning about non-serializable test data

9e66e52

bouwkast requested a review from a team as a code owner September 30, 2024 20:40

lucaspimentel reviewed Sep 30, 2024

View reviewed changes

lucaspimentel requested review from a team and andrewlock September 30, 2024 21:08

lucaspimentel approved these changes Sep 30, 2024

View reviewed changes

lucaspimentel requested review from a team and removed request for andrewlock September 30, 2024 21:22

andrewlock approved these changes Oct 1, 2024

View reviewed changes

bouwkast merged commit d09331a into master Oct 1, 2024
74 checks passed

bouwkast deleted the steven/non-serial-xunit branch October 1, 2024 15:00

github-actions bot added this to the vNext-v3 milestone Oct 1, 2024

andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests labels Oct 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove warning about non-serializable test data #6102

Remove warning about non-serializable test data #6102

bouwkast commented Sep 30, 2024 •

edited by lucaspimentel

Loading

lucaspimentel Sep 30, 2024 •

edited

Loading

bouwkast Sep 30, 2024 •

edited

Loading

bouwkast Sep 30, 2024

bouwkast Sep 30, 2024

lucaspimentel Sep 30, 2024

andrewlock Oct 1, 2024

datadog-ddstaging bot commented Sep 30, 2024 •

edited

Loading

andrewlock commented Sep 30, 2024

andrewlock commented Sep 30, 2024

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6102

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6102

Raw results

Faster 🎉 in #6102

Raw results

andrewlock commented Sep 30, 2024

andrewlock left a comment

Remove warning about non-serializable test data #6102

Remove warning about non-serializable test data #6102

Conversation

bouwkast commented Sep 30, 2024 • edited by lucaspimentel Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

lucaspimentel Sep 30, 2024 • edited Loading

Choose a reason for hiding this comment

bouwkast Sep 30, 2024 • edited Loading

Choose a reason for hiding this comment

bouwkast Sep 30, 2024

Choose a reason for hiding this comment

bouwkast Sep 30, 2024

Choose a reason for hiding this comment

lucaspimentel Sep 30, 2024

Choose a reason for hiding this comment

andrewlock Oct 1, 2024

Choose a reason for hiding this comment

datadog-ddstaging bot commented Sep 30, 2024 • edited Loading

Datadog Report

andrewlock commented Sep 30, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Sep 30, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6102

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6102

Raw results

Faster 🎉 in #6102

Raw results

andrewlock commented Sep 30, 2024

Throughput/Crank Report ⚡

andrewlock left a comment

Choose a reason for hiding this comment

bouwkast commented Sep 30, 2024 •

edited by lucaspimentel

Loading

lucaspimentel Sep 30, 2024 •

edited

Loading

bouwkast Sep 30, 2024 •

edited

Loading

datadog-ddstaging bot commented Sep 30, 2024 •

edited

Loading