Include pID in managed logs filename #6161

andrewlock · 2024-10-17T14:08:36Z

Summary of changes

Adds the process ID to the managed logs filename
~~Enables buffering in .NET Core~~ Reverted this change, as not required and caused test failures. Should be invetigated later

Reason for change

While investigating #6147, we discovered that if you have two app pools, running under different users, the second app domain is unable to write managed logs. This is because it's unable to hold the shared mutex that's used to synchronize access to the file.

Implementation details

Include the pID in the filename, so each process writes to a separate file.

I originally enabled buffering, but removed it

As a consequence, if we only have one tracer instance writing to a managed file, then we no longer need to have a shared logger, and can enable buffering, which should improve performance by buffering writes to the file.

We can't assume this in .NET Framework, as we can have multiple app domains writing to the same file, so this is only enabled for .NET Core.
_Theoretically_ this is a problem in version conflict, where we could have a v2 tracer loaded at the same time as a v3 tracer. However, as this PR changes the file name to differ from v2, that's not an issue, so we should still be safe
For the buffering, we need to choose a flush interval. I plucked 1s out of the sky - any other suggestions?

However, I reverted this change as it broke the dynamic instrumentation tests, because they ended up reading partial lines. We should fix this so that we can get the perf benefit of buffering etc, but it's tangential to the bug fix, so removed for now.

Test coverage

Yeah... the existing integration tests obviously write a bunch of logs... any suggestion for additional tests we should add would be gratefully received...

Other details

I also updated the file-rolling behaviour. Having daily file rolling in addition to split by pid and file size limit seemed more confusing than anything else.

For customers that have multi-day-long processes with high log volume, the results should be broadly the same, as they're limited by rolling file size
For customers that have multi-day-long processes with low log volume, log volume overall may increase, as they won't roll until they hit the log limit? I think, this one I'm struggling to visualize
For customers with short-lived processes, they will have more files but these will use the same amount of space.

datadog-ddstaging · 2024-10-17T14:31:01Z

Datadog Report

Branch report: andrew/include-pid-in-serilog-log
Commit report: b82b961
Test service: dd-trace-dotnet

✅ 0 Failed, 365285 Passed, 2072 Skipped, 15h 7m 58.26s Total Time

andrewlock · 2024-10-17T14:39:26Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6161) - mean (70ms)  : 68, 73
     .   : milestone, 70,
    master - mean (71ms)  : 68, 74
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6161) - mean (1,115ms)  : 1090, 1140
     .   : milestone, 1115,
    master - mean (1,114ms)  : 1095, 1134
     .   : milestone, 1114,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6161) - mean (110ms)  : 107, 114
     .   : milestone, 110,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6161) - mean (779ms)  : 762, 796
     .   : milestone, 779,
    master - mean (776ms)  : 760, 791
     .   : milestone, 776,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6161) - mean (93ms)  : 91, 95
     .   : milestone, 93,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6161) - mean (731ms)  : 717, 746
     .   : milestone, 731,
    master - mean (732ms)  : 716, 748
     .   : milestone, 732,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6161) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6161) - mean (1,200ms)  : 1179, 1221
     .   : milestone, 1200,
    master - mean (1,201ms)  : 1174, 1229
     .   : milestone, 1201,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6161) - mean (275ms)  : 272, 279
     .   : milestone, 275,
    master - mean (275ms)  : 270, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6161) - mean (945ms)  : 930, 960
     .   : milestone, 945,
    master - mean (942ms)  : 926, 957
     .   : milestone, 942,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6161) - mean (264ms)  : 259, 269
     .   : milestone, 264,
    master - mean (264ms)  : 261, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6161) - mean (928ms)  : 906, 950
     .   : milestone, 928,
    master - mean (926ms)  : 908, 944
     .   : milestone, 926,

andrewlock · 2024-10-17T15:07:22Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6161) (11.243M)   : 0, 11242918
    master (11.104M)   : 0, 11103664
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6161) (7.246M)   : 0, 7245725
    master (7.451M)   : 0, 7451232
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.650M)   : 0, 7650132

    section Manual
    master (10.970M)   : 0, 10969909

    section Manual + Automatic
    This PR (6161) (6.830M)   : 0, 6830112
    master (6.739M)   : 0, 6738527

    section DD_TRACE_ENABLED=0
    master (10.201M)   : 0, 10200693

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6161) (9.558M)   : 0, 9558269
    master (9.349M)   : 0, 9348819
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6161) (6.593M)   : 0, 6593065
    master (6.606M)   : 0, 6605850

    section Trace stats
    master (6.912M)   : 0, 6912026

    section Manual
    master (9.553M)   : 0, 9553151

    section Manual + Automatic
    This PR (6161) (6.061M)   : 0, 6060724
    master (6.147M)   : 0, 6146859

    section DD_TRACE_ENABLED=0
    master (8.673M)   : 0, 8672514

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6161) (10.310M)   : 0, 10309834
    master (10.078M)   : 0, 10078234
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6161) (6.607M)   : 0, 6607258
    master (6.880M)   : 0, 6879934
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.380M)   : 0, 7379916

    section Manual
    master (10.105M)   : 0, 10105196

    section Manual + Automatic
    This PR (6161) (6.245M)   : 0, 6245168
    master (6.301M)   : 0, 6300577

    section DD_TRACE_ENABLED=0
    master (9.521M)   : 0, 9521448

andrewlock · 2024-10-17T15:08:49Z

Benchmarks Report for tracer 🐌

Benchmarks for #6161 compared to master:

1 benchmarks are slower, with geometric mean 1.164
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.72μs	42.2ns	260ns	0.0224	0.0112	0	5.42 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	54.2ns	325ns	0.0244	0.00978	0	5.61 KB
master	`StartStopWithChild`	net472	16.6μs	72.2ns	280ns	1.04	0.326	0.1	6.07 KB
#6161	`StartStopWithChild`	net6.0	7.9μs	41.9ns	240ns	0.0153	0.00767	0	5.43 KB
#6161	`StartStopWithChild`	netcoreapp3.1	9.6μs	47.4ns	201ns	0.0231	0.00924	0	5.62 KB
#6161	`StartStopWithChild`	net472	16.9μs	41.9ns	157ns	1.02	0.313	0.0989	6.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	482μs	263ns	1.02μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	637μs	198ns	740ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	829μs	505ns	1.95μs	0.417	3.3 KB
#6161	`WriteAndFlushEnrichedTraces`	net6.0	487μs	233ns	902ns	0	2.7 KB
#6161	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	651μs	325ns	1.26μs	0	2.7 KB
#6161	`WriteAndFlushEnrichedTraces`	net472	847μs	506ns	1.89μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	196μs	1.11μs	9.6μs	0.191	18.45 KB
master	`SendRequest`	netcoreapp3.1	218μs	1.2μs	7.28μs	0.215	20.61 KB
master	`SendRequest`	net472	0.00238ns	0.00101ns	0.00393ns	0	0 b
#6161	`SendRequest`	net6.0	197μs	1.12μs	8.16μs	0.195	18.45 KB
#6161	`SendRequest`	netcoreapp3.1	219μs	1.27μs	11.4μs	0.21	20.61 KB
#6161	`SendRequest`	net472	0.0218ns	0.0052ns	0.0195ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6161

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.88 KB	41.56 KB	-321 B	-0.77%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	578μs	2.79μs	10.8μs	0.558	0	0	41.88 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	705μs	3.62μs	17μs	0.347	0	0	41.94 KB
master	`WriteAndFlushEnrichedTraces`	net472	888μs	2.88μs	11.2μs	8.3	2.62	0.437	53.32 KB
#6161	`WriteAndFlushEnrichedTraces`	net6.0	556μs	1.92μs	7.43μs	0.556	0	0	41.56 KB
#6161	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	688μs	2.86μs	11.1μs	0.34	0	0	41.75 KB
#6161	`WriteAndFlushEnrichedTraces`	net472	895μs	4.1μs	15.9μs	8.36	2.64	0.44	53.33 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.23μs	1.1ns	4.28ns	0.0141	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.83μs	1.15ns	4.32ns	0.0136	1.02 KB
master	`ExecuteNonQuery`	net472	2.09μs	1.19ns	4.61ns	0.156	987 B
#6161	`ExecuteNonQuery`	net6.0	1.25μs	0.682ns	2.64ns	0.0143	1.02 KB
#6161	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	2.07ns	8ns	0.0132	1.02 KB
#6161	`ExecuteNonQuery`	net472	2.17μs	3.34ns	12.9ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.22μs	0.691ns	2.68ns	0.014	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.51μs	0.931ns	3.61ns	0.0128	976 B
master	`CallElasticsearch`	net472	2.61μs	1.31ns	4.9ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.25μs	0.553ns	2.07ns	0.0132	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.59μs	1.03ns	3.73ns	0.0135	1.02 KB
master	`CallElasticsearchAsync`	net472	2.57μs	2.45ns	9.48ns	0.166	1.05 KB
#6161	`CallElasticsearch`	net6.0	1.18μs	0.831ns	3.11ns	0.0136	976 B
#6161	`CallElasticsearch`	netcoreapp3.1	1.56μs	0.568ns	2.12ns	0.0126	976 B
#6161	`CallElasticsearch`	net472	2.48μs	0.79ns	2.96ns	0.157	995 B
#6161	`CallElasticsearchAsync`	net6.0	1.32μs	0.543ns	2.1ns	0.0134	952 B
#6161	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	2.6ns	10.1ns	0.0135	1.02 KB
#6161	`CallElasticsearchAsync`	net472	2.5μs	0.964ns	3.61ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net6.0	1.24μs	0.629ns	2.35ns	0.0136	0	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.68μs	1.18ns	4.43ns	0.0128	0	952 B
master	`ExecuteAsync`	net472	1.81μs	1.65ns	6.39ns	0.145	0.000912	915 B
#6161	`ExecuteAsync`	net6.0	1.3μs	0.744ns	2.79ns	0.0129	0	952 B
#6161	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.666ns	2.58ns	0.0132	0	952 B
#6161	`ExecuteAsync`	net472	1.82μs	0.614ns	2.3ns	0.145	0	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.21μs	2.76ns	10.7ns	0.0316	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.02μs	4.21ns	15.8ns	0.0385	2.76 KB
master	`SendAsync`	net472	7.82μs	2.86ns	11.1ns	0.497	3.15 KB
#6161	`SendAsync`	net6.0	4.11μs	3.06ns	11.5ns	0.0308	2.22 KB
#6161	`SendAsync`	netcoreapp3.1	5.17μs	1.56ns	6.05ns	0.0362	2.76 KB
#6161	`SendAsync`	net472	7.93μs	1.54ns	5.77ns	0.499	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.47μs	0.708ns	2.74ns	0.0228	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.28μs	2.14ns	8.29ns	0.0217	1.64 KB
master	`EnrichedLog`	net472	2.68μs	0.972ns	3.64ns	0.25	1.57 KB
#6161	`EnrichedLog`	net6.0	1.47μs	0.678ns	2.54ns	0.0231	1.64 KB
#6161	`EnrichedLog`	netcoreapp3.1	2.15μs	0.796ns	2.98ns	0.0219	1.64 KB
#6161	`EnrichedLog`	net472	2.56μs	0.801ns	3ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	118μs	154ns	596ns	0.059	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	122μs	120ns	432ns	0.0619	0	4.28 KB
master	`EnrichedLog`	net472	153μs	200ns	773ns	0.679	0.226	4.46 KB
#6161	`EnrichedLog`	net6.0	116μs	344ns	1.33μs	0	0	4.28 KB
#6161	`EnrichedLog`	netcoreapp3.1	122μs	111ns	414ns	0	0	4.28 KB
#6161	`EnrichedLog`	net472	149μs	154ns	597ns	0.671	0.224	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.98μs	0.873ns	3.15ns	0.0312	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.13μs	1.16ns	4.33ns	0.0289	2.2 KB
master	`EnrichedLog`	net472	4.84μs	1.97ns	7.61ns	0.32	2.02 KB
#6161	`EnrichedLog`	net6.0	3.2μs	0.833ns	3.23ns	0.0304	2.2 KB
#6161	`EnrichedLog`	netcoreapp3.1	4.27μs	1.95ns	7.55ns	0.0299	2.2 KB
#6161	`EnrichedLog`	net472	5.05μs	5.33ns	19.2ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.41μs	4.91ns	19ns	0.016	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.68μs	0.757ns	2.83ns	0.015	0	1.14 KB
master	`SendReceive`	net472	2.17μs	1.19ns	4.61ns	0.183	0	1.16 KB
#6161	`SendReceive`	net6.0	1.31μs	0.741ns	2.77ns	0.0156	0	1.14 KB
#6161	`SendReceive`	netcoreapp3.1	1.75μs	1.5ns	5.81ns	0.0148	0	1.14 KB
#6161	`SendReceive`	net472	2.06μs	1.3ns	4.68ns	0.183	0.00104	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.86μs	0.801ns	3.1ns	0.0228	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.83μs	1.88ns	6.79ns	0.0212	1.65 KB
master	`EnrichedLog`	net472	4.36μs	1.98ns	7.67ns	0.323	2.04 KB
#6161	`EnrichedLog`	net6.0	2.78μs	0.965ns	3.74ns	0.0224	1.6 KB
#6161	`EnrichedLog`	netcoreapp3.1	3.9μs	1.15ns	4.15ns	0.0214	1.65 KB
#6161	`EnrichedLog`	net472	4.29μs	1.36ns	5.28ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	396ns	0.234ns	0.906ns	0.00799	576 B
master	`StartFinishSpan`	netcoreapp3.1	564ns	0.249ns	0.897ns	0.00788	576 B
master	`StartFinishSpan`	net472	742ns	0.153ns	0.551ns	0.0915	578 B
master	`StartFinishScope`	net6.0	485ns	0.224ns	0.837ns	0.00965	696 B
master	`StartFinishScope`	netcoreapp3.1	712ns	0.461ns	1.66ns	0.00937	696 B
master	`StartFinishScope`	net472	902ns	0.604ns	2.26ns	0.105	658 B
#6161	`StartFinishSpan`	net6.0	414ns	0.343ns	1.33ns	0.00798	576 B
#6161	`StartFinishSpan`	netcoreapp3.1	552ns	1.07ns	4.14ns	0.00792	576 B
#6161	`StartFinishSpan`	net472	686ns	0.804ns	3.12ns	0.0918	578 B
#6161	`StartFinishScope`	net6.0	499ns	0.401ns	1.55ns	0.00965	696 B
#6161	`StartFinishScope`	netcoreapp3.1	758ns	0.212ns	0.823ns	0.00944	696 B
#6161	`StartFinishScope`	net472	869ns	1.55ns	6.01ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6161

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.164	590.87	687.79

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	591ns	0.355ns	1.37ns	0.00978	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	934ns	0.488ns	1.83ns	0.00944	696 B
master	`RunOnMethodBegin`	net472	1.17μs	0.661ns	2.47ns	0.104	658 B
#6161	`RunOnMethodBegin`	net6.0	688ns	0.236ns	0.883ns	0.00965	696 B
#6161	`RunOnMethodBegin`	netcoreapp3.1	1.02μs	0.681ns	2.64ns	0.00923	696 B
#6161	`RunOnMethodBegin`	net472	1.15μs	0.971ns	3.76ns	0.104	658 B

kevingosse

Please update the PR description since you don't actually enable buffering

andrewlock added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Oct 17, 2024

Include PID in managed logs filename

00b3776

andrewlock force-pushed the andrew/include-pid-in-serilog-log branch from ed190c3 to 00b3776 Compare October 18, 2024 08:18

Remove buffering as it breaks dynamic instrumentation tests

b82b961

andrewlock added the type:bug label Oct 18, 2024

andrewlock marked this pull request as ready for review October 18, 2024 08:32

andrewlock requested a review from a team as a code owner October 18, 2024 08:32

kevingosse approved these changes Oct 21, 2024

View reviewed changes

andrewlock merged commit 09cb0f4 into master Oct 21, 2024
74 checks passed

andrewlock deleted the andrew/include-pid-in-serilog-log branch October 21, 2024 12:30

github-actions bot added this to the vNext-v3 milestone Oct 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include pID in managed logs filename #6161

Include pID in managed logs filename #6161

andrewlock commented Oct 17, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 17, 2024 •

edited

Loading

andrewlock commented Oct 17, 2024 •

edited

Loading

andrewlock commented Oct 17, 2024 •

edited

Loading

andrewlock commented Oct 17, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6161

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6161

Raw results

kevingosse left a comment

Include pID in managed logs filename #6161

Include pID in managed logs filename #6161

Conversation

andrewlock commented Oct 17, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Oct 17, 2024 • edited Loading

Datadog Report

andrewlock commented Oct 17, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 17, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Oct 17, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6161

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6161

Raw results

kevingosse left a comment

Choose a reason for hiding this comment

andrewlock commented Oct 17, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 17, 2024 •

edited

Loading

andrewlock commented Oct 17, 2024 •

edited

Loading

andrewlock commented Oct 17, 2024 •

edited

Loading

andrewlock commented Oct 17, 2024 •

edited

Loading