[Profiler] Remove non open source third party reference #6163

chrisnas · 2024-10-17T15:15:02Z

Summary of changes

Remove Obfuscation test scenario

Reason for change

Remove the non open source reference

Implementation details

Test coverage

Other details

bouwkast

Thanks!

datadog-ddstaging · 2024-10-17T15:33:30Z

Datadog Report

Branch report: chrisnas/remove_third_party
Commit report: 26e5ad1
Test service: dd-trace-dotnet

✅ 0 Failed, 369451 Passed, 2424 Skipped, 16h 21m 38.21s Total Time
⌛ 5 Performance Regressions

⌛ Performance Regressions vs Default Branch (5)

Baseline_cpu - scenarios 2.48s (+129.28ms, +6%) - Details
Profiler_cpu_walltime_old_stackwalk - scenarios 2.47s (+131.73ms, +6%) - Details
Profiler_cpu_walltime - scenarios 2.47s (+130.67ms, +6%) - Details
Profiler_walltime - scenarios 2.47s (+123.87ms, +5%) - Details
Profiler_cpu_walltime_timer_create - scenarios 2.47s (+128.24ms, +5%) - Details

andrewlock · 2024-10-17T15:55:52Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6163) - mean (71ms)  : 68, 74
     .   : milestone, 71,
    master - mean (71ms)  : 67, 75
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (6163) - mean (1,115ms)  : 1095, 1136
     .   : milestone, 1115,
    master - mean (1,118ms)  : 1097, 1138
     .   : milestone, 1118,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6163) - mean (110ms)  : 106, 115
     .   : milestone, 110,
    master - mean (111ms)  : 107, 114
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (6163) - mean (776ms)  : 754, 798
     .   : milestone, 776,
    master - mean (780ms)  : 766, 794
     .   : milestone, 780,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6163) - mean (92ms)  : 90, 95
     .   : milestone, 92,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6163) - mean (729ms)  : 713, 746
     .   : milestone, 729,
    master - mean (732ms)  : 719, 746
     .   : milestone, 732,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6163) - mean (191ms)  : 187, 194
     .   : milestone, 191,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6163) - mean (1,202ms)  : 1172, 1231
     .   : milestone, 1202,
    master - mean (1,196ms)  : 1168, 1223
     .   : milestone, 1196,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6163) - mean (276ms)  : 273, 280
     .   : milestone, 276,
    master - mean (276ms)  : 270, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6163) - mean (943ms)  : 928, 958
     .   : milestone, 943,
    master - mean (944ms)  : 921, 968
     .   : milestone, 944,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6163) - mean (264ms)  : 260, 268
     .   : milestone, 264,
    master - mean (264ms)  : 261, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6163) - mean (929ms)  : 909, 950
     .   : milestone, 929,
    master - mean (928ms)  : 909, 948
     .   : milestone, 928,

andrewlock · 2024-10-17T16:12:47Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6163) (11.105M)   : 0, 11105020
    master (11.101M)   : 0, 11101291
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6163) (7.518M)   : 0, 7517799
    master (7.268M)   : 0, 7267999
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.704M)   : 0, 7704450

    section Manual
    master (11.209M)   : 0, 11208771

    section Manual + Automatic
    This PR (6163) (6.816M)   : 0, 6816191
    master (6.752M)   : 0, 6751506

    section DD_TRACE_ENABLED=0
    master (10.100M)   : 0, 10099574

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6163) (9.566M)   : 0, 9565583
    master (9.512M)   : 0, 9511557
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6163) (6.579M)   : 0, 6579262
    master (6.377M)   : 0, 6376530

    section Trace stats
    master (6.600M)   : 0, 6600483

    section Manual
    master (9.557M)   : 0, 9556775

    section Manual + Automatic
    This PR (6163) (6.144M)   : 0, 6144492
    master (6.104M)   : 0, 6104007

    section DD_TRACE_ENABLED=0
    master (8.956M)   : 0, 8956228

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6163) (10.198M)   : 0, 10197726
    master (10.099M)   : 0, 10098545
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6163) (6.650M)   : 0, 6649632
    master (6.828M)   : 0, 6828171
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.506M)   : 0, 7506436

    section Manual
    master (10.332M)   : 0, 10331782

    section Manual + Automatic
    This PR (6163) (6.080M)   : crit ,0, 6079749
    master (6.429M)   : 0, 6429465

    section DD_TRACE_ENABLED=0
    master (9.501M)   : 0, 9501392

andrewlock · 2024-10-17T16:57:37Z

Benchmarks Report for tracer 🐌

Benchmarks for #6163 compared to master:

2 benchmarks are faster, with geometric mean 1.160
1 benchmarks are slower, with geometric mean 1.159
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.86μs	43.9ns	295ns	0.0117	0.00391	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	55.6ns	319ns	0.0207	0.00516	0	5.62 KB
master	`StartStopWithChild`	net472	16.8μs	44.7ns	173ns	1.01	0.294	0.0898	6.07 KB
#6163	`StartStopWithChild`	net6.0	7.87μs	45.4ns	372ns	0.016	0.00802	0	5.43 KB
#6163	`StartStopWithChild`	netcoreapp3.1	9.82μs	48.3ns	199ns	0.0194	0.00972	0	5.62 KB
#6163	`StartStopWithChild`	net472	17.1μs	78.3ns	303ns	1.01	0.294	0.0864	6.05 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	481μs	718ns	2.78μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	629μs	219ns	818ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	840μs	324ns	1.26μs	0.417	3.3 KB
#6163	`WriteAndFlushEnrichedTraces`	net6.0	487μs	925ns	3.58μs	0	2.7 KB
#6163	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	647μs	293ns	1.13μs	0	2.7 KB
#6163	`WriteAndFlushEnrichedTraces`	net472	850μs	461ns	1.73μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	196μs	1.12μs	8.66μs	0.189	18.45 KB
master	`SendRequest`	netcoreapp3.1	218μs	1.25μs	9.87μs	0.159	20.61 KB
master	`SendRequest`	net472	5.49E‑05ns	5.49E‑05ns	0.000206ns	0	0 b
#6163	`SendRequest`	net6.0	194μs	1.11μs	8.34μs	0.198	18.45 KB
#6163	`SendRequest`	netcoreapp3.1	222μs	1.24μs	8.88μs	0.208	20.61 KB
#6163	`SendRequest`	net472	0.00131ns	0.000418ns	0.00162ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6163

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.51 KB	41.82 KB	316 B	0.76%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	572μs	2.89μs	13.6μs	0.534	0	0	41.51 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	672μs	2.89μs	11.9μs	0.343	0	0	41.76 KB
master	`WriteAndFlushEnrichedTraces`	net472	881μs	4.09μs	16.3μs	8.3	2.62	0.437	53.36 KB
#6163	`WriteAndFlushEnrichedTraces`	net6.0	583μs	3.08μs	16.8μs	0.576	0	0	41.82 KB
#6163	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	679μs	3.21μs	12.4μs	0.336	0	0	41.71 KB
#6163	`WriteAndFlushEnrichedTraces`	net472	907μs	4.38μs	18μs	8.09	2.25	0.45	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.32μs	1.5ns	5.81ns	0.0139	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.76μs	0.682ns	2.64ns	0.0134	1.02 KB
master	`ExecuteNonQuery`	net472	2.08μs	1.73ns	6.71ns	0.156	987 B
#6163	`ExecuteNonQuery`	net6.0	1.39μs	1.33ns	5.15ns	0.0146	1.02 KB
#6163	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	1.57ns	5.88ns	0.0138	1.02 KB
#6163	`ExecuteNonQuery`	net472	2.11μs	1.51ns	5.66ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.25μs	2.43ns	9.4ns	0.0138	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.58μs	0.764ns	2.96ns	0.0134	976 B
master	`CallElasticsearch`	net472	2.33μs	1.55ns	6.02ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.31μs	0.719ns	2.69ns	0.0131	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	0.932ns	3.49ns	0.0133	1.02 KB
master	`CallElasticsearchAsync`	net472	2.67μs	1.67ns	6.48ns	0.166	1.05 KB
#6163	`CallElasticsearch`	net6.0	1.22μs	0.424ns	1.58ns	0.0135	976 B
#6163	`CallElasticsearch`	netcoreapp3.1	1.61μs	2.43ns	9.4ns	0.0135	976 B
#6163	`CallElasticsearch`	net472	2.5μs	5.88ns	22.8ns	0.158	995 B
#6163	`CallElasticsearchAsync`	net6.0	1.31μs	0.556ns	2.08ns	0.0131	952 B
#6163	`CallElasticsearchAsync`	netcoreapp3.1	1.61μs	1.63ns	6.1ns	0.0136	1.02 KB
#6163	`CallElasticsearchAsync`	net472	2.6μs	0.926ns	3.21ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.27μs	0.379ns	1.47ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.6μs	0.893ns	3.34ns	0.0125	952 B
master	`ExecuteAsync`	net472	1.85μs	1.54ns	5.95ns	0.145	915 B
#6163	`ExecuteAsync`	net6.0	1.16μs	0.854ns	3.19ns	0.0133	952 B
#6163	`ExecuteAsync`	netcoreapp3.1	1.59μs	1.36ns	5.08ns	0.0127	952 B
#6163	`ExecuteAsync`	net472	1.84μs	0.516ns	2ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendAsync`	net6.0	4.17μs	2.79ns	10.4ns	0.0313	0	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.1μs	1.84ns	6.89ns	0.0381	0	2.76 KB
master	`SendAsync`	net472	7.92μs	2.67ns	10.3ns	0.499	0	3.15 KB
#6163	`SendAsync`	net6.0	4.04μs	1.16ns	4.33ns	0.0305	0	2.22 KB
#6163	`SendAsync`	netcoreapp3.1	5.1μs	1.83ns	7.1ns	0.0356	0	2.76 KB
#6163	`SendAsync`	net472	7.84μs	2.03ns	7.88ns	0.498	0.00392	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.59μs	1.02ns	3.94ns	0.0228	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.24μs	0.673ns	2.61ns	0.0225	1.64 KB
master	`EnrichedLog`	net472	2.62μs	1.42ns	5.5ns	0.249	1.57 KB
#6163	`EnrichedLog`	net6.0	1.67μs	1ns	3.75ns	0.0227	1.64 KB
#6163	`EnrichedLog`	netcoreapp3.1	2.19μs	1.16ns	4.34ns	0.022	1.64 KB
#6163	`EnrichedLog`	net472	2.61μs	0.625ns	2.25ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	116μs	180ns	696ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	278ns	1.08μs	0	0	4.28 KB
master	`EnrichedLog`	net472	152μs	122ns	473ns	0.684	0.228	4.46 KB
#6163	`EnrichedLog`	net6.0	115μs	86.9ns	337ns	0.0576	0	4.28 KB
#6163	`EnrichedLog`	netcoreapp3.1	121μs	124ns	482ns	0.0609	0	4.28 KB
#6163	`EnrichedLog`	net472	152μs	65.8ns	246ns	0.682	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.18μs	0.875ns	3.16ns	0.0305	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.2μs	1.98ns	7.67ns	0.0293	2.2 KB
master	`EnrichedLog`	net472	4.94μs	3ns	11.6ns	0.319	2.02 KB
#6163	`EnrichedLog`	net6.0	3.12μs	0.727ns	2.72ns	0.0312	2.2 KB
#6163	`EnrichedLog`	netcoreapp3.1	4.13μs	2.3ns	8.92ns	0.029	2.2 KB
#6163	`EnrichedLog`	net472	4.82μs	1.31ns	5.06ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6163

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0	1.162	1,436.81	1,236.19

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.44μs	1.04ns	4.04ns	0.0157	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.72μs	1.27ns	4.76ns	0.0156	0	1.14 KB
master	`SendReceive`	net472	2.21μs	1.02ns	3.68ns	0.183	0.00111	1.16 KB
#6163	`SendReceive`	net6.0	1.24μs	0.465ns	1.8ns	0.016	0	1.14 KB
#6163	`SendReceive`	netcoreapp3.1	1.73μs	1.08ns	4.19ns	0.0155	0	1.14 KB
#6163	`SendReceive`	net472	2.1μs	3ns	11.2ns	0.183	0.00105	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.75μs	0.656ns	2.45ns	0.0219	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.84μs	1.52ns	5.7ns	0.0211	1.65 KB
master	`EnrichedLog`	net472	4.32μs	1.93ns	7.21ns	0.323	2.04 KB
#6163	`EnrichedLog`	net6.0	2.83μs	0.838ns	3.25ns	0.0226	1.6 KB
#6163	`EnrichedLog`	netcoreapp3.1	4.02μs	3.1ns	12ns	0.0221	1.65 KB
#6163	`EnrichedLog`	net472	4.73μs	12.2ns	47.4ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6163

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.159	484.12	560.87

Faster 🎉 in #6163

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1	1.158	792.51	684.64

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	460ns	0.236ns	0.913ns	0.00806	576 B
master	`StartFinishSpan`	netcoreapp3.1	546ns	0.32ns	1.24ns	0.00797	576 B
master	`StartFinishSpan`	net472	700ns	0.281ns	1.05ns	0.0918	578 B
master	`StartFinishScope`	net6.0	484ns	0.211ns	0.816ns	0.0097	696 B
master	`StartFinishScope`	netcoreapp3.1	792ns	0.54ns	2.09ns	0.00914	696 B
master	`StartFinishScope`	net472	831ns	1.11ns	4.29ns	0.104	658 B
#6163	`StartFinishSpan`	net6.0	484ns	0.201ns	0.777ns	0.00805	576 B
#6163	`StartFinishSpan`	netcoreapp3.1	563ns	0.374ns	1.45ns	0.00791	576 B
#6163	`StartFinishSpan`	net472	687ns	1.37ns	5.32ns	0.0917	578 B
#6163	`StartFinishScope`	net6.0	561ns	0.609ns	2.2ns	0.00979	696 B
#6163	`StartFinishScope`	netcoreapp3.1	683ns	0.709ns	2.75ns	0.00932	696 B
#6163	`StartFinishScope`	net472	909ns	2.81ns	10.9ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	656ns	0.302ns	1.13ns	0.00983	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	935ns	0.469ns	1.69ns	0.00903	696 B
master	`RunOnMethodBegin`	net472	1.18μs	0.843ns	3.04ns	0.104	658 B
#6163	`RunOnMethodBegin`	net6.0	679ns	0.303ns	1.13ns	0.00988	696 B
#6163	`RunOnMethodBegin`	netcoreapp3.1	940ns	0.586ns	2.27ns	0.00952	696 B
#6163	`RunOnMethodBegin`	net472	1.17μs	0.73ns	2.63ns	0.104	658 B

Remove non open source third party reference

26e5ad1

chrisnas requested a review from a team as a code owner October 17, 2024 15:15

chrisnas requested a review from bouwkast October 17, 2024 15:15

github-actions bot added the area:profiler Issues related to the continous-profiler label Oct 17, 2024

bouwkast approved these changes Oct 17, 2024

View reviewed changes

gleocadie approved these changes Oct 22, 2024

View reviewed changes

gleocadie merged commit 1b256c0 into master Oct 25, 2024
80 of 82 checks passed

gleocadie deleted the chrisnas/remove_third_party branch October 25, 2024 17:41

github-actions bot added this to the vNext-v3 milestone Oct 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Profiler] Remove non open source third party reference #6163

[Profiler] Remove non open source third party reference #6163

chrisnas commented Oct 17, 2024

bouwkast left a comment

datadog-ddstaging bot commented Oct 17, 2024 •

edited

Loading

andrewlock commented Oct 17, 2024

andrewlock commented Oct 17, 2024

andrewlock commented Oct 17, 2024

Raw results

Raw results

Raw results

More allocations ⚠️ in #6163

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6163

Raw results

Raw results

Slower ⚠️ in #6163

Faster 🎉 in #6163

Raw results

Raw results

[Profiler] Remove non open source third party reference #6163

[Profiler] Remove non open source third party reference #6163

Conversation

chrisnas commented Oct 17, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

bouwkast left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Oct 17, 2024 • edited Loading

Datadog Report

⌛ Performance Regressions vs Default Branch (5)

andrewlock commented Oct 17, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 17, 2024

Throughput/Crank Report ⚡

andrewlock commented Oct 17, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #6163

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6163

Raw results

Raw results

Slower ⚠️ in #6163

Faster 🎉 in #6163

Raw results

Raw results

datadog-ddstaging bot commented Oct 17, 2024 •

edited

Loading