Baggage part 3/3: add public api to `Datadog.Trace.Manual` #6190

lucaspimentel · 2024-10-23T17:54:24Z

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

lucaspimentel · 2024-10-23T17:54:37Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Baggage part 3/3: add public api to Datadog.Trace.Manual #6190 👈
Baggage part 2/3: propagation #6158
Baggage part 1/3: change propagator signatures #6157
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lucaspimentel and the rest of your teammates on Graphite

datadog-ddstaging · 2024-10-23T18:15:20Z

Datadog Report

Branch report: lpimentel/baggage-datadog-api-3
Commit report: 722e574
Test service: dd-trace-dotnet

❌ 129 Failed (4 Known Flaky), 282730 Passed, 1885 Skipped, 12h 10m 27.09s Total Time

❌ Failed Tests (129)

This report shows up to 5 failed tests.

EarlyFlakeDetection - Datadog.Trace.ClrProfiler.IntegrationTests.CI.PipesXUnitEvpTests - Details
Expand for error
```
 
 Actual:   119 Failure
```
ManualAndAutomatic - Datadog.Trace.ClrProfiler.IntegrationTests.ManualInstrumentationTests - ❄️ Known flaky - Details
Expand for error
```
 Expected exit code: 0, actual exit code: 134.
```
ManualAndAutomatic - Datadog.Trace.ClrProfiler.IntegrationTests.ManualInstrumentationTests - ❄️ Known flaky - Details
Expand for error
```
 Expected exit code: 0, actual exit code: -532462766.
```
ManualAndAutomatic - Datadog.Trace.ClrProfiler.IntegrationTests.ManualInstrumentationTests - Details
Expand for error
```
 Expected exit code: 0, actual exit code: 134.
```
ManualAndAutomatic - Datadog.Trace.ClrProfiler.IntegrationTests.ManualInstrumentationTests - Details
Expand for error
```
 Expected exit code: 0, actual exit code: 134.
```

andrewlock · 2024-10-23T18:34:49Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6190) - mean (71ms)  : 68, 74
     .   : milestone, 71,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6190) - mean (1,122ms)  : 1102, 1142
     .   : milestone, 1122,
    master - mean (1,117ms)  : 1100, 1135
     .   : milestone, 1117,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6190) - mean (111ms)  : 105, 116
     .   : milestone, 111,
    master - mean (111ms)  : 108, 114
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (6190) - mean (773ms)  : 757, 789
     .   : milestone, 773,
    master - mean (780ms)  : 762, 797
     .   : milestone, 780,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6190) - mean (93ms)  : 91, 96
     .   : milestone, 93,
    master - mean (94ms)  : 91, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (6190) - mean (731ms)  : 715, 748
     .   : milestone, 731,
    master - mean (735ms)  : 718, 752
     .   : milestone, 735,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6190) - mean (190ms)  : 187, 192
     .   : milestone, 190,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6190) - mean (1,220ms)  : 1184, 1255
     .   : milestone, 1220,
    master - mean (1,204ms)  : 1182, 1226
     .   : milestone, 1204,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6190) - mean (277ms)  : 272, 281
     .   : milestone, 277,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6190) - mean (941ms)  : 925, 958
     .   : milestone, 941,
    master - mean (946ms)  : 928, 963
     .   : milestone, 946,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6190) - mean (264ms)  : 260, 268
     .   : milestone, 264,
    master - mean (264ms)  : 260, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6190) - mean (927ms)  : 910, 944
     .   : milestone, 927,
    master - mean (926ms)  : 907, 945
     .   : milestone, 926,

andrewlock · 2024-10-23T20:31:06Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6190) (11.021M)   : 0, 11021032
    master (11.226M)   : 0, 11226424
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6190) (7.286M)   : 0, 7286067
    master (7.333M)   : 0, 7332814
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.694M)   : 0, 7694111

    section Manual
    master (10.976M)   : 0, 10975947

    section Manual + Automatic
    This PR (6190) (6.444M)   : crit ,0, 6444433
    master (6.797M)   : 0, 6796973

    section DD_TRACE_ENABLED=0
    master (10.273M)   : 0, 10272898

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6190) (9.463M)   : 0, 9463261
    master (9.814M)   : 0, 9814194
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6190) (6.483M)   : 0, 6483493
    master (6.631M)   : 0, 6631124

    section Trace stats
    master (6.694M)   : 0, 6694154

    section Manual
    master (9.462M)   : 0, 9461559

    section Manual + Automatic
    This PR (6190) (5.932M)   : 0, 5932459
    master (6.167M)   : 0, 6166825

    section DD_TRACE_ENABLED=0
    master (8.879M)   : 0, 8879082

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6190) (9.774M)   : 0, 9774215
    master (9.833M)   : 0, 9833269
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6190) (6.265M)   : 0, 6264512
    master (6.309M)   : 0, 6308709
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.061M)   : 0, 7060512

    section Manual
    master (9.653M)   : 0, 9652511

    section Manual + Automatic
    This PR (6190) (5.724M)   : 0, 5724162
    master (5.845M)   : 0, 5844711

    section DD_TRACE_ENABLED=0
    master (9.195M)   : 0, 9195277

andrewlock · 2024-10-24T02:34:19Z

Benchmarks Report for tracer 🐌

Benchmarks for #6190 compared to master:

1 benchmarks are faster, with geometric mean 1.171
3 benchmarks are slower, with geometric mean 1.165
1 benchmarks have fewer allocations
8 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6190

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0	5.43 KB	5.61 KB	180 B	3.32%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1	5.62 KB	5.8 KB	181 B	3.22%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472	6.07 KB	6.2 KB	131 B	2.16%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.58μs	40.7ns	207ns	0.0251	0.0108	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.81μs	51.5ns	262ns	0.019	0.0095	0	5.62 KB
master	`StartStopWithChild`	net472	16.2μs	59ns	221ns	1.02	0.306	0.105	6.07 KB
#6190	`StartStopWithChild`	net6.0	7.94μs	43.8ns	266ns	0.0154	0.0077	0	5.61 KB
#6190	`StartStopWithChild`	netcoreapp3.1	10.2μs	57.2ns	383ns	0.02	0.00499	0	5.8 KB
#6190	`StartStopWithChild`	net472	16.2μs	46.7ns	181ns	1.06	0.323	0.105	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	468μs	402ns	1.5μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	645μs	388ns	1.5μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	831μs	491ns	1.84μs	0.417	3.3 KB
#6190	`WriteAndFlushEnrichedTraces`	net6.0	499μs	173ns	625ns	0	2.7 KB
#6190	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	626μs	435ns	1.68μs	0	2.7 KB
#6190	`WriteAndFlushEnrichedTraces`	net472	847μs	285ns	1.1μs	0.419	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6190

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑net6.0	18.45 KB	18.73 KB	279 B	1.51%
Benchmarks.Trace.AspNetCoreBenchmark.SendRequest‑netcoreapp3.1	20.61 KB	20.89 KB	280 B	1.36%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	199μs	1.15μs	10.7μs	0.194	18.45 KB
master	`SendRequest`	netcoreapp3.1	223μs	1.3μs	11.3μs	0.224	20.61 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#6190	`SendRequest`	net6.0	200μs	1.09μs	6.7μs	0.198	18.73 KB
#6190	`SendRequest`	netcoreapp3.1	220μs	1.11μs	6.82μs	0.205	20.89 KB
#6190	`SendRequest`	net472	0.00142ns	0.000506ns	0.00182ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6190

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.93 KB	41.68 KB	-256 B	-0.61%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	567μs	2.6μs	10.1μs	0.571	0	0	41.63 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	686μs	3.41μs	15.3μs	0.334	0	0	41.93 KB
master	`WriteAndFlushEnrichedTraces`	net472	855μs	4.05μs	16.2μs	8.87	2.53	0.422	53.27 KB
#6190	`WriteAndFlushEnrichedTraces`	net6.0	573μs	3.2μs	20.2μs	0.566	0	0	41.66 KB
#6190	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	679μs	3.49μs	15.6μs	0.336	0	0	41.68 KB
#6190	`WriteAndFlushEnrichedTraces`	net472	878μs	4.15μs	17.1μs	8.08	2.55	0.425	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.28μs	0.89ns	3.33ns	0.0141	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.7μs	2.56ns	9.56ns	0.0137	1.02 KB
master	`ExecuteNonQuery`	net472	2.08μs	1.66ns	6.43ns	0.157	987 B
#6190	`ExecuteNonQuery`	net6.0	1.21μs	0.698ns	2.7ns	0.0141	1.02 KB
#6190	`ExecuteNonQuery`	netcoreapp3.1	1.71μs	0.742ns	2.87ns	0.0138	1.02 KB
#6190	`ExecuteNonQuery`	net472	2.06μs	2.02ns	7.82ns	0.156	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.26μs	0.533ns	1.92ns	0.014	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.58μs	0.815ns	3.05ns	0.0127	976 B
master	`CallElasticsearch`	net472	2.54μs	1.02ns	3.82ns	0.158	995 B
master	`CallElasticsearchAsync`	net6.0	1.25μs	0.672ns	2.6ns	0.0131	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	1.17ns	4.4ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.66μs	0.834ns	3.12ns	0.167	1.05 KB
#6190	`CallElasticsearch`	net6.0	1.22μs	0.628ns	2.43ns	0.014	976 B
#6190	`CallElasticsearch`	netcoreapp3.1	1.55μs	1.2ns	4.65ns	0.0131	976 B
#6190	`CallElasticsearch`	net472	2.54μs	1.86ns	7.2ns	0.157	995 B
#6190	`CallElasticsearchAsync`	net6.0	1.22μs	0.486ns	1.82ns	0.0129	952 B
#6190	`CallElasticsearchAsync`	netcoreapp3.1	1.51μs	1.88ns	7.27ns	0.0135	1.02 KB
#6190	`CallElasticsearchAsync`	net472	2.51μs	2.05ns	7.39ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.24μs	0.351ns	1.31ns	0.013	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.6μs	1.15ns	4.44ns	0.0129	952 B
master	`ExecuteAsync`	net472	1.75μs	1.01ns	3.92ns	0.145	915 B
#6190	`ExecuteAsync`	net6.0	1.17μs	0.532ns	1.99ns	0.0134	952 B
#6190	`ExecuteAsync`	netcoreapp3.1	1.6μs	0.799ns	2.99ns	0.0125	952 B
#6190	`ExecuteAsync`	net472	1.78μs	1.9ns	7.36ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #6190

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.HttpClientBenchmark.SendAsync‑net6.0	2.22 KB	2.31 KB	88 B	3.96%
Benchmarks.Trace.HttpClientBenchmark.SendAsync‑netcoreapp3.1	2.76 KB	2.85 KB	88 B	3.19%
Benchmarks.Trace.HttpClientBenchmark.SendAsync‑net472	3.15 KB	3.19 KB	48 B	1.53%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.27μs	1.55ns	5.81ns	0.0323	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.02μs	1.87ns	7.24ns	0.0351	2.76 KB
master	`SendAsync`	net472	7.75μs	2.08ns	8.05ns	0.5	3.15 KB
#6190	`SendAsync`	net6.0	4.47μs	1.07ns	4ns	0.0313	2.31 KB
#6190	`SendAsync`	netcoreapp3.1	5.22μs	1.32ns	5.12ns	0.0366	2.85 KB
#6190	`SendAsync`	net472	7.9μs	2.74ns	10.6ns	0.506	3.19 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.52μs	0.938ns	3.63ns	0.0228	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.2μs	0.716ns	2.77ns	0.0219	1.64 KB
master	`EnrichedLog`	net472	2.64μs	0.724ns	2.8ns	0.248	1.57 KB
#6190	`EnrichedLog`	net6.0	1.63μs	1.87ns	6.49ns	0.0227	1.64 KB
#6190	`EnrichedLog`	netcoreapp3.1	2.16μs	1.16ns	4.49ns	0.0226	1.64 KB
#6190	`EnrichedLog`	net472	2.62μs	0.844ns	3.04ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	117μs	125ns	450ns	0.059	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	120μs	138ns	518ns	0	0	4.28 KB
master	`EnrichedLog`	net472	151μs	146ns	566ns	0.681	0.227	4.46 KB
#6190	`EnrichedLog`	net6.0	116μs	149ns	578ns	0.0579	0	4.28 KB
#6190	`EnrichedLog`	netcoreapp3.1	121μs	205ns	767ns	0	0	4.28 KB
#6190	`EnrichedLog`	net472	152μs	261ns	976ns	0.682	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.15μs	0.804ns	3.01ns	0.0306	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.19μs	1.15ns	4.45ns	0.0295	2.2 KB
master	`EnrichedLog`	net472	5.02μs	1.63ns	6.3ns	0.318	2.02 KB
#6190	`EnrichedLog`	net6.0	3.08μs	0.545ns	2.11ns	0.0308	2.2 KB
#6190	`EnrichedLog`	netcoreapp3.1	4.31μs	4.24ns	16.4ns	0.0299	2.2 KB
#6190	`EnrichedLog`	net472	4.86μs	1.84ns	7.12ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.39μs	2.25ns	8.71ns	0.0161	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.68μs	0.862ns	3.34ns	0.015	0	1.14 KB
master	`SendReceive`	net472	2.19μs	2.66ns	10.3ns	0.183	0.00109	1.16 KB
#6190	`SendReceive`	net6.0	1.43μs	1.12ns	4.33ns	0.0164	0	1.14 KB
#6190	`SendReceive`	netcoreapp3.1	1.72μs	1.11ns	4.17ns	0.0154	0	1.14 KB
#6190	`SendReceive`	net472	2.13μs	1.44ns	5.39ns	0.183	0	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.7μs	1.01ns	3.77ns	0.0216	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.82μs	3.35ns	13ns	0.0211	1.65 KB
master	`EnrichedLog`	net472	4.28μs	2.81ns	10.9ns	0.323	2.04 KB
#6190	`EnrichedLog`	net6.0	2.79μs	1.36ns	5.27ns	0.0223	1.6 KB
#6190	`EnrichedLog`	netcoreapp3.1	3.9μs	2.58ns	10ns	0.0215	1.65 KB
#6190	`EnrichedLog`	net472	4.47μs	1.51ns	5.86ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6190

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.237	403.13	498.84
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.134	671.06	760.71
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.127	480.66	541.51

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	404ns	0.574ns	2.22ns	0.00811	576 B
master	`StartFinishSpan`	netcoreapp3.1	607ns	0.783ns	2.93ns	0.00786	576 B
master	`StartFinishSpan`	net472	671ns	0.815ns	2.94ns	0.0917	578 B
master	`StartFinishScope`	net6.0	481ns	0.365ns	1.41ns	0.00986	696 B
master	`StartFinishScope`	netcoreapp3.1	718ns	0.59ns	2.29ns	0.00942	696 B
master	`StartFinishScope`	net472	912ns	0.33ns	1.19ns	0.105	658 B
#6190	`StartFinishSpan`	net6.0	499ns	0.269ns	1.04ns	0.00797	576 B
#6190	`StartFinishSpan`	netcoreapp3.1	603ns	0.704ns	2.54ns	0.00776	576 B
#6190	`StartFinishSpan`	net472	760ns	0.357ns	1.38ns	0.0918	578 B
#6190	`StartFinishScope`	net6.0	541ns	0.354ns	1.37ns	0.00968	696 B
#6190	`StartFinishScope`	netcoreapp3.1	730ns	0.672ns	2.6ns	0.00944	696 B
#6190	`StartFinishScope`	net472	904ns	1.17ns	4.53ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6190

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.171	745.43	636.31

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	745ns	0.469ns	1.82ns	0.00965	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	886ns	0.421ns	1.63ns	0.00946	696 B
master	`RunOnMethodBegin`	net472	1.14μs	1.3ns	5.02ns	0.104	658 B
#6190	`RunOnMethodBegin`	net6.0	636ns	0.82ns	3.18ns	0.00991	696 B
#6190	`RunOnMethodBegin`	netcoreapp3.1	936ns	1.11ns	4.31ns	0.00894	696 B
#6190	`RunOnMethodBegin`	net472	1.14μs	1.16ns	4.48ns	0.104	658 B

andrewlock · 2024-10-31T09:03:21Z

...Trace/ClrProfiler/AutoInstrumentation/ManualInstrumentation/Baggage/SetCurrentIntegration.cs

+{
+    internal static CallTargetState OnMethodBegin<TTarget>(ref IDictionary<string, string>? value)
+    {
+        Trace.Baggage.Current = new Trace.Baggage(value);


is null an ok value to pass to new Trace.Baggage()?

lucaspimentel mentioned this pull request Oct 23, 2024

Baggage part 2/3: propagation #6158

Open

lucaspimentel mentioned this pull request Oct 23, 2024

Baggage part 1/3: change propagator signatures #6157

Open

lucaspimentel changed the title ~~add no-pop Baggage to Datadog.Trace.Manual~~ add no-op Baggage to Datadog.Trace.Manual Oct 23, 2024

lucaspimentel changed the title ~~add no-op Baggage to Datadog.Trace.Manual~~ Baggage part 3/3: add public api to Datadog.Trace.Manual Oct 23, 2024

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from 4e13e08 to 909841c Compare October 23, 2024 20:59

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from 909841c to d61d185 Compare October 25, 2024 14:36

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-3 branch from ad32a8f to f2266b1 Compare October 25, 2024 14:36

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from d61d185 to ba0ca33 Compare October 25, 2024 16:43

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-3 branch from f2266b1 to 07f07b8 Compare October 25, 2024 16:43

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from ba0ca33 to eecdaf9 Compare October 29, 2024 18:49

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-3 branch from 07f07b8 to b87fe14 Compare October 29, 2024 18:49

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from eecdaf9 to 5655899 Compare October 29, 2024 20:59

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-3 branch 2 times, most recently from 9fd32aa to 0aca775 Compare October 30, 2024 20:15

lucaspimentel added 11 commits October 30, 2024 18:00

add new types

67eb307

add PropagatorType property to IContextInjector and IContextExtractor

82c6f6c

change IContextInjector and IContextExtractor to use PropagationContext

a36f665

refactor SpanContextPropagator to use PropagationContext

be0cf0f

refactor all propagators to use PropagationContext

9bd24bb

fix propagator usages

4db1b57

fix propagator usages in tests

b965656

assert that baggage is null in the trace context extraction tests

9c27c4e

initialize the AsyncLocal<Baggage>

16dd844

simplify merging Baggage in SpanContextPropagator.Extract()

ed90208

rename method

4bf593c

lucaspimentel added 8 commits October 30, 2024 18:00

let SpanContextPropagator.Extract return null Baggage again

f9ef2cd

make Baggage sealed and add a nullable annotation

10896aa

move Remove() methods together

05b2d03

implements Contains() and move Contains() methods together

f826ad1

imeplement CopyTo()

7e24731

merge extracted baggage in RabbitMQIntegration

7676362

misc clean up

9d3ec6d

fix comment

61ee33c

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from 5655899 to 60a858e Compare October 30, 2024 22:51

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-3 branch from 0aca775 to 89b0391 Compare October 30, 2024 22:54

lucaspimentel added 16 commits October 30, 2024 18:58

use Baggage collection initializer syntax in tests

c9bad77

misc clean up

e018a77

add ICancellableObserver

49023f9

add Baggage.ForEach()

6e36560

update xml doc comments in ContextPropagationHeaderStyle

a36e2a9

add ContextPropagationHeaderStyle.Baggage

8ea8176

add new settings

7fc00bd

add baggage to telemetry metric tags

c57a116

add W3CBaggagePropagator

4672daf

add support for W3CBaggagePropagator in SpanContextPropagatorFactory

f5f3d0d

update SpanContextPropagatorFactoryTests

21c1d0f

add W3CBaggagePropagatorTests

e836d52

add Baggage class to Datadog.Trace.Manual

5b98b18

add get/set integrations for Baggage.Current

624cab5

update auto-generated files

2ad950a

assert baggage header in Samples.ManualInstrumentation

722e574

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from 60a858e to e836d52 Compare October 30, 2024 22:59

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-3 branch from 89b0391 to 722e574 Compare October 30, 2024 23:00

andrewlock reviewed Oct 31, 2024

View reviewed changes

lucaspimentel force-pushed the lpimentel/baggage-datadog-api-2 branch from e836d52 to 8e199be Compare October 31, 2024 17:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Baggage part 3/3: add public api to `Datadog.Trace.Manual` #6190

Baggage part 3/3: add public api to `Datadog.Trace.Manual` #6190

lucaspimentel commented Oct 23, 2024

lucaspimentel commented Oct 23, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 23, 2024 •

edited

Loading

andrewlock commented Oct 23, 2024 •

edited

Loading

andrewlock commented Oct 23, 2024 •

edited

Loading

andrewlock commented Oct 24, 2024 •

edited

Loading

More allocations ⚠️ in #6190

Raw results

Raw results

More allocations ⚠️ in #6190

Raw results

Fewer allocations 🎉 in #6190

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #6190

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6190

Raw results

Faster 🎉 in #6190

Raw results

andrewlock Oct 31, 2024

Baggage part 3/3: add public api to Datadog.Trace.Manual #6190

Are you sure you want to change the base?

Baggage part 3/3: add public api to Datadog.Trace.Manual #6190

Conversation

lucaspimentel commented Oct 23, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

lucaspimentel commented Oct 23, 2024 • edited Loading

datadog-ddstaging bot commented Oct 23, 2024 • edited Loading

Datadog Report

❌ Failed Tests (129)

andrewlock commented Oct 23, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Oct 23, 2024 • edited Loading

Throughput/Crank Report ⚡

andrewlock commented Oct 24, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

More allocations ⚠️ in #6190

Raw results

Raw results

More allocations ⚠️ in #6190

Raw results

Fewer allocations 🎉 in #6190

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #6190

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6190

Raw results

Faster 🎉 in #6190

Raw results

andrewlock Oct 31, 2024

Choose a reason for hiding this comment

Baggage part 3/3: add public api to `Datadog.Trace.Manual` #6190

Baggage part 3/3: add public api to `Datadog.Trace.Manual` #6190

lucaspimentel commented Oct 23, 2024 •

edited

Loading

datadog-ddstaging bot commented Oct 23, 2024 •

edited

Loading

andrewlock commented Oct 23, 2024 •

edited

Loading

andrewlock commented Oct 23, 2024 •

edited

Loading

andrewlock commented Oct 24, 2024 •

edited

Loading