Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiling scenario to onboarding tests #6201

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

szegedi
Copy link
Collaborator

@szegedi szegedi commented Oct 25, 2024

Summary of changes

The one APM pipeline by default runs the SIMPLE_INSTALLER_AUTO_INJECTION scenario. This adds SIMPLE_AUTO_INJECTION_PROFILING.

Reason for change

Profiling scenarios for .NET now work correctly in nightly onboarding system tests runs. Adding one of them here helps catch breakage of SSI profiling functionality early.

Implementation details

Test coverage

The sole reason of this change is expanding test coverage.

Other details

JIRA PROF-10811

@szegedi szegedi requested a review from a team as a code owner October 25, 2024 09:05
@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 25, 2024
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - except the scenarios are failing 😅

@szegedi
Copy link
Collaborator Author

szegedi commented Oct 28, 2024

LGTM - except the scenarios are failing 😅

Fair enough, I failed at Yaml. There should be no dash before "SCENARIO"; fixed now.

Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@szegedi szegedi merged commit e20259b into master Oct 29, 2024
108 of 109 checks passed
@szegedi szegedi deleted the szegedi/add-profiling-onboarding-tests branch October 29, 2024 13:02
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants