Fix flake in Ngen ManualInstrumentationTests

[andrewlock]

Summary of changes

Try to make sure the new Ngen tests don't flake

Reason for change

#6184 added some new tests which use NGEN. Those tests seem to be flaky (on x86 particularly). AFAICT it's a timeout issue with the ngen.exe execution, not an issue with the underlying implementation.

Implementation details

• Increase the ngen.exe timeout
• Remove the call to ngen display - it was only added for debugging, and seems to take a long time
• Add the tests to a collection (in .NET FX) so that they don't run in parallel with other tests

Test coverage

This is the test

[datadog-ddstaging]

Datadog Report

Branch report: andrew/ci/ngen-flake
Commit report: b3a3a9c
Test service: dd-trace-dotnet

✅ 0 Failed, 365496 Passed, 2105 Skipped, 14h 35m 11.42s Total Time

[andrewlock]

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

• This PR (6214)
• master

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6214) - mean (71ms)  : 67, 75
     .   : milestone, 71,
    master - mean (70ms)  : 68, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6214) - mean (1,116ms)  : 1096, 1136
     .   : milestone, 1116,
    master - mean (1,115ms)  : 1089, 1141
     .   : milestone, 1115,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6214) - mean (110ms)  : 106, 114
     .   : milestone, 110,
    master - mean (110ms)  : 107, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (6214) - mean (776ms)  : 757, 795
     .   : milestone, 776,
    master - mean (779ms)  : 761, 797
     .   : milestone, 779,

Loading

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6214) - mean (94ms)  : 89, 98
     .   : milestone, 94,
    master - mean (93ms)  : 90, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6214) - mean (733ms)  : 715, 752
     .   : milestone, 733,
    master - mean (732ms)  : 717, 747
     .   : milestone, 732,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6214) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 192
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6214) - mean (1,203ms)  : 1177, 1229
     .   : milestone, 1203,
    master - mean (1,203ms)  : 1179, 1227
     .   : milestone, 1203,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6214) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (275ms)  : 270, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6214) - mean (942ms)  : 924, 960
     .   : milestone, 942,
    master - mean (947ms)  : 927, 967
     .   : milestone, 947,

Loading

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6214) - mean (264ms)  : 260, 269
     .   : milestone, 264,
    master - mean (264ms)  : 261, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6214) - mean (930ms)  : 912, 948
     .   : milestone, 930,
    master - mean (928ms)  : 909, 948
     .   : milestone, 928,

Loading