Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run aspnetcore tests in other TFMs #6217

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

andrewlock
Copy link
Member

@andrewlock andrewlock commented Oct 29, 2024

Summary of changes

Runs the MVC AspNetCore tests in .NET 5+ too

Reason for change

Previously we were only running these in .NET Core 2.1/3.0/3.1 which seems... odd, and increases the chance of missing something

Implementation details

Added the TFMs and thankfully everything just worked 😅

Test coverage

More now. Confirmed it's working for all TFMs in this build.

Other details

We were always running the minimal APIs in .NET 6+, and security have some other tests, and this seemed like an oversight

Unfortunately, we're now running into timeouts in the arm64 integration test builds. I've seen these a few times, and they're benign (we just need to update the images) so just bumped the timeout

@andrewlock andrewlock added the area:tests unit tests, integration tests label Oct 29, 2024
@andrewlock andrewlock requested review from a team as code owners October 29, 2024 15:01
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Oct 29, 2024

Datadog Report

Branch report: andrew/ci/run-more-aspnetcore-tests
Commit report: e90511c
Test service: dd-trace-dotnet

❌ 3 Failed (0 Known Flaky), 368125 Passed, 2086 Skipped, 15h 3m 26.86s Total Time

❌ Failed Tests (3)

  • EnrichedLog - Benchmarks.Trace.ILoggerBenchmark - Details

  • EnrichedLog - Benchmarks.Trace.Log4netBenchmark - Details

  • SendReceive - Benchmarks.Trace.RedisBenchmark - Details

@andrewlock
Copy link
Member Author

andrewlock commented Oct 29, 2024

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6217) - mean (71ms)  : 67, 74
     .   : milestone, 71,
    master - mean (70ms)  : 68, 72
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6217) - mean (1,119ms)  : 1096, 1142
     .   : milestone, 1119,
    master - mean (1,119ms)  : 1098, 1140
     .   : milestone, 1119,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6217) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (109ms)  : 107, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6217) - mean (777ms)  : 762, 792
     .   : milestone, 777,
    master - mean (773ms)  : 753, 794
     .   : milestone, 773,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6217) - mean (94ms)  : 90, 97
     .   : milestone, 94,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6217) - mean (727ms)  : 714, 740
     .   : milestone, 727,
    master - mean (733ms)  : 714, 752
     .   : milestone, 733,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6217) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6217) - mean (1,205ms)  : 1176, 1234
     .   : milestone, 1205,
    master - mean (1,200ms)  : 1167, 1233
     .   : milestone, 1200,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6217) - mean (277ms)  : 272, 281
     .   : milestone, 277,
    master - mean (278ms)  : 271, 284
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6217) - mean (946ms)  : 927, 965
     .   : milestone, 946,
    master - mean (945ms)  : 923, 967
     .   : milestone, 945,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6217) - mean (265ms)  : 261, 269
     .   : milestone, 265,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6217) - mean (924ms)  : 904, 944
     .   : milestone, 924,
    master - mean (929ms)  : 911, 948
     .   : milestone, 929,

Loading

@andrewlock
Copy link
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #6217 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.123
  • 1 benchmarks are slower, with geometric mean 1.164
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.67μs 40.2ns 201ns 0.0157 0.00785 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.89μs 47.2ns 189ns 0.0311 0.0155 0 5.61 KB
master StartStopWithChild net472 16.2μs 47.4ns 184ns 1.02 0.307 0.0944 6.07 KB
#6217 StartStopWithChild net6.0 7.87μs 44.3ns 287ns 0.0152 0.00759 0 5.43 KB
#6217 StartStopWithChild netcoreapp3.1 9.99μs 54.5ns 308ns 0.0202 0.0101 0 5.62 KB
#6217 StartStopWithChild net472 16.1μs 68.3ns 265ns 1.03 0.32 0.082 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 488μs 454ns 1.7μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 633μs 281ns 1.01μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 838μs 396ns 1.48μs 0.417 0 0 3.3 KB
#6217 WriteAndFlushEnrichedTraces net6.0 486μs 516ns 2μs 0 0 0 2.7 KB
#6217 WriteAndFlushEnrichedTraces netcoreapp3.1 637μs 439ns 1.7μs 0 0 0 2.7 KB
#6217 WriteAndFlushEnrichedTraces net472 839μs 305ns 1.14μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 203μs 1.11μs 6.57μs 0.196 0 0 18.45 KB
master SendRequest netcoreapp3.1 225μs 1.29μs 11.6μs 0.229 0 0 20.61 KB
master SendRequest net472 0.000902ns 0.000448ns 0.00174ns 0 0 0 0 b
#6217 SendRequest net6.0 204μs 1.19μs 11.3μs 0.208 0 0 18.45 KB
#6217 SendRequest netcoreapp3.1 224μs 1.25μs 8.11μs 0.215 0 0 20.61 KB
#6217 SendRequest net472 0.000703ns 0.000304ns 0.0011ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 565μs 2.63μs 9.85μs 0.59 0 0 41.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 676μs 2.46μs 8.85μs 0.342 0 0 41.68 KB
master WriteAndFlushEnrichedTraces net472 858μs 3.12μs 12.1μs 8.19 2.59 0.431 53.28 KB
#6217 WriteAndFlushEnrichedTraces net6.0 560μs 2.83μs 13.3μs 0.291 0 0 41.56 KB
#6217 WriteAndFlushEnrichedTraces netcoreapp3.1 683μs 3.24μs 13.4μs 0.342 0 0 41.77 KB
#6217 WriteAndFlushEnrichedTraces net472 902μs 4.45μs 18.9μs 8.74 2.62 0.437 53.34 KB
Benchmarks.Trace.DbCommandBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6217

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.164 1,192.99 1,388.64

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.2μs 1.62ns 6.29ns 0.0143 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.77μs 1.44ns 5.18ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.08μs 1.77ns 6.84ns 0.157 0 0 987 B
#6217 ExecuteNonQuery net6.0 1.39μs 4.46ns 17.3ns 0.0144 0 0 1.02 KB
#6217 ExecuteNonQuery netcoreapp3.1 1.74μs 1.85ns 7.15ns 0.0137 0 0 1.02 KB
#6217 ExecuteNonQuery net472 2.07μs 2.95ns 10.6ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.29μs 0.612ns 2.37ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.51μs 0.658ns 2.46ns 0.0129 0 0 976 B
master CallElasticsearch net472 2.64μs 1.37ns 5.29ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.38μs 0.946ns 3.54ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 1.66ns 6.21ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.64μs 1.13ns 4.36ns 0.167 0 0 1.05 KB
#6217 CallElasticsearch net6.0 1.21μs 1.5ns 5.79ns 0.0138 0 0 976 B
#6217 CallElasticsearch netcoreapp3.1 1.52μs 0.938ns 3.51ns 0.013 0 0 976 B
#6217 CallElasticsearch net472 2.67μs 9.17ns 33.1ns 0.158 0 0 995 B
#6217 CallElasticsearchAsync net6.0 1.28μs 0.479ns 1.79ns 0.0135 0 0 952 B
#6217 CallElasticsearchAsync netcoreapp3.1 1.64μs 1.34ns 4.82ns 0.0138 0 0 1.02 KB
#6217 CallElasticsearchAsync net472 2.64μs 1.95ns 7.55ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.2μs 0.639ns 2.48ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.62μs 0.81ns 3.03ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.75μs 0.507ns 1.97ns 0.145 0 0 915 B
#6217 ExecuteAsync net6.0 1.23μs 0.604ns 2.26ns 0.0136 0 0 952 B
#6217 ExecuteAsync netcoreapp3.1 1.69μs 0.68ns 2.55ns 0.0127 0 0 952 B
#6217 ExecuteAsync net472 1.82μs 0.531ns 2.06ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.22μs 1.68ns 6.27ns 0.0316 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.13μs 2.45ns 8.82ns 0.0359 0 0 2.76 KB
master SendAsync net472 7.83μs 2.24ns 8.69ns 0.496 0 0 3.15 KB
#6217 SendAsync net6.0 4.1μs 2.43ns 9.1ns 0.0308 0 0 2.22 KB
#6217 SendAsync netcoreapp3.1 5.07μs 2.54ns 9.52ns 0.038 0 0 2.76 KB
#6217 SendAsync net472 7.76μs 1.67ns 6.47ns 0.498 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.53μs 0.835ns 2.89ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.34μs 3.75ns 14ns 0.0218 0 0 1.64 KB
master EnrichedLog net472 2.67μs 0.889ns 3.33ns 0.249 0 0 1.57 KB
#6217 EnrichedLog net6.0 1.45μs 1.18ns 4.41ns 0.0233 0 0 1.64 KB
#6217 EnrichedLog netcoreapp3.1 2.22μs 1.12ns 4.21ns 0.0222 0 0 1.64 KB
#6217 EnrichedLog net472 2.6μs 1.38ns 4.99ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 117μs 259ns 1μs 0.0585 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 185ns 715ns 0 0 0 4.28 KB
master EnrichedLog net472 152μs 338ns 1.31μs 0.678 0.226 0 4.46 KB
#6217 EnrichedLog net6.0 116μs 198ns 768ns 0.0581 0 0 4.28 KB
#6217 EnrichedLog netcoreapp3.1 122μs 259ns 1μs 0 0 0 4.28 KB
#6217 EnrichedLog net472 149μs 146ns 526ns 0.668 0.223 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3μs 0.782ns 3.03ns 0.03 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.21μs 2.31ns 8.95ns 0.0294 0 0 2.2 KB
master EnrichedLog net472 4.85μs 1.18ns 4.56ns 0.319 0 0 2.02 KB
#6217 EnrichedLog net6.0 3.01μs 0.973ns 3.77ns 0.0301 0 0 2.2 KB
#6217 EnrichedLog netcoreapp3.1 4.15μs 1.14ns 4.42ns 0.0291 0 0 2.2 KB
#6217 EnrichedLog net472 5.03μs 1.43ns 5.34ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.36μs 1.21ns 4.68ns 0.0163 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.71μs 0.949ns 3.68ns 0.0155 0 0 1.14 KB
master SendReceive net472 2.08μs 1.13ns 4.24ns 0.184 0 0 1.16 KB
#6217 SendReceive net6.0 1.42μs 1.24ns 4.78ns 0.0163 0 0 1.14 KB
#6217 SendReceive netcoreapp3.1 1.84μs 1.14ns 4.41ns 0.0155 0 0 1.14 KB
#6217 SendReceive net472 2.07μs 0.892ns 3.45ns 0.184 0.00103 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.68μs 0.749ns 2.9ns 0.0215 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.86μs 1.5ns 5.79ns 0.0212 0 0 1.65 KB
master EnrichedLog net472 4.3μs 3.23ns 12.5ns 0.322 0 0 2.04 KB
#6217 EnrichedLog net6.0 2.86μs 1.25ns 4.84ns 0.0224 0 0 1.6 KB
#6217 EnrichedLog netcoreapp3.1 3.93μs 2.24ns 8.69ns 0.0217 0 0 1.65 KB
#6217 EnrichedLog net472 4.39μs 4.4ns 17ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6217

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.123 804.72 716.37

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 417ns 0.222ns 0.859ns 0.00804 0 0 576 B
master StartFinishSpan netcoreapp3.1 654ns 1.26ns 4.89ns 0.00783 0 0 576 B
master StartFinishSpan net472 675ns 0.735ns 2.75ns 0.0917 0 0 578 B
master StartFinishScope net6.0 483ns 0.469ns 1.82ns 0.00971 0 0 696 B
master StartFinishScope netcoreapp3.1 805ns 0.344ns 1.33ns 0.00926 0 0 696 B
master StartFinishScope net472 933ns 1.02ns 3.94ns 0.105 0 0 658 B
#6217 StartFinishSpan net6.0 405ns 0.145ns 0.541ns 0.00813 0 0 576 B
#6217 StartFinishSpan netcoreapp3.1 587ns 0.189ns 0.706ns 0.00763 0 0 576 B
#6217 StartFinishSpan net472 651ns 0.427ns 1.65ns 0.0918 0 0 578 B
#6217 StartFinishScope net6.0 489ns 0.207ns 0.802ns 0.00982 0 0 696 B
#6217 StartFinishScope netcoreapp3.1 714ns 1.38ns 5.33ns 0.00962 0 0 696 B
#6217 StartFinishScope net472 890ns 1.31ns 5.09ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 625ns 0.693ns 2.68ns 0.00977 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 910ns 2.06ns 7.97ns 0.00893 0 0 696 B
master RunOnMethodBegin net472 1.09μs 0.792ns 3.07ns 0.104 0 0 658 B
#6217 RunOnMethodBegin net6.0 628ns 0.374ns 1.45ns 0.00975 0 0 696 B
#6217 RunOnMethodBegin netcoreapp3.1 894ns 0.402ns 1.5ns 0.00961 0 0 696 B
#6217 RunOnMethodBegin net472 1.18μs 1.01ns 3.9ns 0.105 0 0 658 B

@andrewlock
Copy link
Member Author

andrewlock commented Oct 29, 2024

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6217) (11.208M)   : 0, 11207695
    master (10.970M)   : 0, 10969978
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6217) (7.449M)   : 0, 7449152
    master (7.292M)   : 0, 7292209
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.582M)   : 0, 7581616

    section Manual
    master (10.995M)   : 0, 10995398

    section Manual + Automatic
    This PR (6217) (6.823M)   : 0, 6823138
    master (6.739M)   : 0, 6738798

    section DD_TRACE_ENABLED=0
    master (10.175M)   : 0, 10175402

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6217) (9.519M)   : 0, 9518782
    master (9.569M)   : 0, 9568691
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6217) (6.550M)   : 0, 6550354
    master (6.420M)   : 0, 6420401

    section Trace stats
    master (6.834M)   : 0, 6833970

    section Manual
    master (9.445M)   : 0, 9445274

    section Manual + Automatic
    This PR (6217) (6.016M)   : 0, 6016467
    master (6.093M)   : 0, 6093411

    section DD_TRACE_ENABLED=0
    master (9.051M)   : 0, 9051079

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6217) (10.168M)   : 0, 10168239
    master (9.836M)   : 0, 9836175
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6217) (6.525M)   : 0, 6525028
    master (6.529M)   : 0, 6529158
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.181M)   : 0, 7181034

    section Manual
    master (9.635M)   : 0, 9634854

    section Manual + Automatic
    This PR (6217) (6.044M)   : 0, 6044033
    master (5.980M)   : 0, 5980484

    section DD_TRACE_ENABLED=0
    master (9.130M)   : 0, 9130402

Loading

@andrewlock andrewlock requested a review from a team as a code owner October 30, 2024 10:15
@andrewlock andrewlock merged commit 15fba9c into master Oct 30, 2024
72 of 74 checks passed
@andrewlock andrewlock deleted the andrew/ci/run-more-aspnetcore-tests branch October 30, 2024 15:09
@github-actions github-actions bot added this to the vNext-v3 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests unit tests, integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants