Skip to content

Commit

Permalink
internal/civisibility: stop closing unfinished tests
Browse files Browse the repository at this point in the history
  • Loading branch information
tonyredondo committed Oct 30, 2024
1 parent 844a72a commit 3f3579d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/civisibility/integrations/manual_api_ddtest.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ func createTest(suite *tslvTestSuite, name string, startTime time.Time) DdTest {
},
}

// Ensure to close everything before CI visibility exits. In CI visibility mode, we try to never lose data.
PushCiVisibilityCloseAction(func() { t.Close(ResultStatusFail) })
// Note: if the process is killed some tests will not be closed and will be lost. This is a known limitation.
// We will not close it because there's no a good test status to report in this case, and we don't want to report a false positive (pass, fail, or skip).

return t
}
Expand Down

0 comments on commit 3f3579d

Please sign in to comment.