contrib/go-redis/redis: support v7

[kamatama41]

go-redis/redis was updated to v7 and it changed its import path to github.com/go-redis/redis/v7. So dd-trace cannot be used with go-redis/redis/v7 by the incompatibility between v7 and earlier versions.

ref: Changelog for go-redis/redis
https://github.com/go-redis/redis/blob/20a182ceb1d1360f9689230d84fa1db47db215f4/CHANGELOG.md#v7

[knusbaum]

Thanks, @kamatama41. We will look at what needs to be done to support go-redis/redis v7.

[gbbr]

This is related to #543. We can't use those import paths yet, before we switch to modules.

I guess this starts to bring the priority of switching to modules to a more higher level. We should consider doing it soon. We will keep track of this in the related issue here: #471

[johejo]

This is the POC using v7 redis.Hook api.
https://gist.github.com/johejo/b82d5fc533596db357ec46ba95b89192

[johejo]

Hi.
I have created a package that supports v7, v8 of go-redis/redis.
https://github.com/johejo/dd-trace-go-redis
If you are interested, please give it a try.
Bug reports and Pull Requests are welcome.
But I'm just a DataDog user so it is not official support.

[gbbr]

#672 has been merged, so we should be able to do this work now, if there is still interest. Please see also Please see also #471 (comment)

[dselim]

Is the plan for go-redis/redis v7 (and future v8) to have a redis.v7 directory along side the current redis in contrib ?

It is my understanding that it was done for echo v4 #543

[gbbr]

Correct. For each major version we want to have a separate package.

[knusbaum]

There is a PR open for go-redis/redis.v8 #727

[kamatama41]

I have confirmed dd-trace works on go-redis/redis/v8.
Although v7 is still not supported, it's ok for my case (as we already migrated to v8).

So I will close this issue, thank you very much 😃

[AnhTaFP]

Hi,

May I ask if there is still any plan to add support for redis v7? I want to update to v8, but I got some other dependencies on v7 :) I can help adding v7 support if needed.

[knusbaum]

@AnhTaFP
This issue was closed earlier, but v7 support is in now.