Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/labstack/echo: support v4 #543

Closed
kuchlein opened this issue Dec 5, 2019 · 4 comments
Closed

contrib/labstack/echo: support v4 #543

kuchlein opened this issue Dec 5, 2019 · 4 comments
Labels
apm:ecosystem contrib/* related feature requests or bugs modules proposal more in depth change that requires full team approval
Milestone

Comments

@kuchlein
Copy link

kuchlein commented Dec 5, 2019

Echo recently changed the way that they package and ship their code. Specifically version 4 uses a new import scheme (see echo git where they'd like you to use an import of github.com/labstack/echo/v4 rather than github.com/labstack/echo which was used before. In order to get the contributed code to work I had to make a minor change to the imports in echotrace.go from:

import (
	"math"
	"strconv"

	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace"
	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/ext"
	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"

	"github.com/labstack/echo"
)

to

import (
	"math"
	"strconv"

	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace"
	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/ext"
	"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"

	echo "github.com/labstack/echo/v4"
)

I'm not sure how you want to handle this but it would be helpful to add support for Echo V4?

@gbbr
Copy link
Contributor

gbbr commented Dec 9, 2019

Sure. Are you willing to commit to a PR? We should duplicate the folder and create a contrib/labstack/echo.v4 as per the guidelines I have recently added here.

kuchlein added a commit to kuchlein/dd-trace-go that referenced this issue Dec 15, 2019
Copied the contents of contrib/labstack/echo to echo.v4 and appended /v4
to any imports that referenced echo.

Fixes: DataDog#543
@gbbr gbbr added the modules label Jan 9, 2020
@knusbaum knusbaum added apm:ecosystem contrib/* related feature requests or bugs proposal more in depth change that requires full team approval labels Mar 2, 2020
@gbbr
Copy link
Contributor

gbbr commented Jun 5, 2020

#672 has been merged, so we should be able to do this work now, if there is still interest.

@gbbr
Copy link
Contributor

gbbr commented Jun 5, 2020

There's a v1.25.0-rc2 out for testing. It contains a few other changes too. Feel free to try it out and give feedback. This does not mean that we freeze master and have started to prepare for releasing 1.25. It is just an intermediate testing step which requires tagging. Development and merging PRs should continue as usual.

This tag also contains an integration for an integration for github.com/labstach/echo/v4 here which only works with modules enabled.

@knusbaum
Copy link
Contributor

This has been merged in #698 and will be released in v1.26.0

@knusbaum knusbaum added this to the 1.26.0 milestone Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs modules proposal more in depth change that requires full team approval
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants