-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/labstack/echo: support v4 #543
Comments
Sure. Are you willing to commit to a PR? We should duplicate the folder and create a |
Copied the contents of contrib/labstack/echo to echo.v4 and appended /v4 to any imports that referenced echo. Fixes: DataDog#543
#672 has been merged, so we should be able to do this work now, if there is still interest. |
There's a v1.25.0-rc2 out for testing. It contains a few other changes too. Feel free to try it out and give feedback. This does not mean that we freeze master and have started to prepare for releasing 1.25. It is just an intermediate testing step which requires tagging. Development and merging PRs should continue as usual. This tag also contains an integration for an integration for |
This has been merged in #698 and will be released in |
Echo recently changed the way that they package and ship their code. Specifically version 4 uses a new import scheme (see echo git where they'd like you to use an import of
github.com/labstack/echo/v4
rather thangit.luolix.top/labstack/echo
which was used before. In order to get the contributed code to work I had to make a minor change to the imports in echotrace.go from:to
I'm not sure how you want to handle this but it would be helpful to add support for Echo V4?
The text was updated successfully, but these errors were encountered: