Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/labstack/echo.v4: add support for echo@v4 #698

Merged
merged 1 commit into from
Jul 22, 2020
Merged

contrib/labstack/echo.v4: add support for echo@v4 #698

merged 1 commit into from
Jul 22, 2020

Conversation

knusbaum
Copy link
Contributor

No description provided.

@knusbaum knusbaum added this to the 1.27.0 milestone Jul 21, 2020
gbbr
gbbr approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried out a small example program with Datadog to make sure it works? If yes, this is good to merge.

@knusbaum
Copy link
Contributor Author

Yep! I used the example in the echo README.md.

@knusbaum knusbaum merged commit bf1cbc5 into v1 Jul 22, 2020
@knusbaum knusbaum modified the milestones: 1.27.0, 1.26.0 Jul 22, 2020
@knusbaum knusbaum deleted the knusbaum/echov4 branch July 22, 2020 13:44
@priyanshi-gupta priyanshi-gupta mentioned this pull request Jul 29, 2020
Closed
@knusbaum
Copy link
Contributor Author

Fixes #543

@knusbaum knusbaum mentioned this pull request Jul 29, 2020
Closed
mingrammer pushed a commit to mingrammer/dd-trace-go that referenced this pull request Dec 22, 2020
@knusbaum @mingrammer
contrib/labstack/echo.v4: add support for echo@v4 (DataDog#698)
f5c3d19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbr gbbr gbbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@knusbaum @gbbr