ddtrace/tracer: runtime metrics v2 (exclude from release notes) #2772
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -62,6 +62,10 @@ func (tg *TestStatsdClient) Gauge(name string, value float64, tags []string, rat | |||
| }) | |||
| } | |||
|
|
|||
| func (tg *TestStatsdClient) GaugeWithTimestamp(name string, value float64, tags []string, rate float64, timestamp time.Time) error { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
unused-parameter: parameter 'name' seems to be unused, consider removing or renaming it as _ (revive)
| @@ -81,6 +85,10 @@ | |||
| }) | |||
| } | |||
|
|
|||
| func (tg *TestStatsdClient) CountWithTimestamp(name string, value int64, tags []string, rate float64, timestamp time.Time) error { | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
unused-parameter: parameter 'name' seems to be unused, consider removing or renaming it as _ (revive)
| @@ -47,6 +47,7 @@ func startTelemetry(c *config) { | |||
| {Name: "agent_url", Value: c.agentURL.String()}, | |||
| {Name: "agent_hostname", Value: c.hostname}, | |||
| {Name: "runtime_metrics_enabled", Value: c.runtimeMetrics}, | |||
| {Name: "runtime_metrics_v2_enabled", Value: c.runtimeMetricsV2}, | |||
There was a problem hiding this comment.
TODO: I think we also have a startup logging thing somewhere that tries to log all the config values. check if we need to log runtimeMetricsV2 there as well.
felixge
changed the title
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
…ROF-8665-experimental-runtime-v2-metrics
BenchmarksBenchmark execution time: 2024-10-23 14:36:41 Comparing candidate commit 535a60a in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 1 unstable metrics. scenario:BenchmarkInjectW3C-24
|
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
@felixge When it's planned to open the PR for review/merge? |
|
I'm planning to merge this merged, probably in 1.5 weeks from now (got time blocked to work on this project every 2 weeks). |
…ROF-8665-experimental-runtime-v2-metrics
What does this PR do?
Important: No mention in the release notes for this yet.
Motivation
Reviewer's Checklist
Unsure? Have a question? Request a review!