internal/apps: Add two new apps #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-09-17 09:41:31 Comparing candidate commit 111c73d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
felixge
changed the title
felixge
changed the title
The internal apps are usually meant to demonstrate new features or to produce screenshots for blog posts. In both cases it is better to be using the latest version of Go as it might contain new features that are needed, or simply to make the screenshots show an up-to-date Go version.
This allows giving nicer names to the services for screenshots.
felixge
force-pushed
the
PROF-9130/demo-apps-for-blog
branch
from
ffa7cfd
to
0001a9e
Compare
felixge
force-pushed
the
PROF-9130/demo-apps-for-blog
branch
from
b5378a0
to
8e3358e
Compare
felixge
changed the title
Remove go version workaround. This will be addressed by merging #2871 first. Use go1.23.0 instead of go1.23 since the latter includes pre-release versions which we don't want here.
|
Updated. But needs #2871 to land first. |
Co-authored-by: Nick Ripley <nick.ripley@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add two new internal apps. They are not meant to run in CI (not hooked up), but rather to stage screenshots for blog posts when we need them.
Also upgrade internal apps to use go1.23 since I sometimes get a
go_version:tag in my screenshot and I want it to be the latest. Additionally I wanted to use some go1.23 convenience features while coding up the test apps.Motivation
The primary motivation is to produce screenshots for an upcoming blog post about cost savings.
One part of the blog will talk about using the CPU profile to identify cost saving opportunities:
This might reveal a high amount of CPU time in GC. The allocated memory profile can be used to figure out how to reduce the frequency of GC cycles:
Additionally the Heap Live Objects profile can help with figuring out how to reduce the cost per GC cycle.
For apps that are bottlenecked on Memory rather than CPU, the Heap Live Size profile can help.
And for queue processing applications that don't manage to utilize their available HW resources efficiently, the timeline feature can help with revealing Off-CPU bottlenecks:
Reviewer's Checklist
Unsure? Have a question? Request a review!