-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/confluentinc/confluent-kafka-go: split tracing code #2907
Merged
darccio
merged 11 commits into
main
from
rarguelloF/APPSEC-53286/refactor-ckgo-orchestrion
Oct 21, 2024
Merged
contrib/confluentinc/confluent-kafka-go: split tracing code #2907
darccio
merged 11 commits into
main
from
rarguelloF/APPSEC-53286/refactor-ckgo-orchestrion
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
apm:ecosystem
contrib/* related feature requests or bugs
label
Oct 3, 2024
BenchmarksBenchmark execution time: 2024-10-16 14:21:05 Comparing candidate commit 7f43533 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics. |
6 tasks
RomainMuller
approved these changes
Oct 14, 2024
darccio
approved these changes
Oct 18, 2024
darccio
added a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: Dario Castañé <dario.castane@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor confluent-kafka-go kafka so the tracing code can be reused in Orchestrion (DataDog/orchestrion#320)
Motivation
Reviewer's Checklist
Unsure? Have a question? Request a review!