Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.circleci: checkout github.com/kubernetes/client-go v0.17.3 #595

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

knusbaum
Copy link
Contributor

client-go recently merged an API-breaking change on master, and so instead we
check out the latest working release of kubernetes/client-go. This is a stop-gap
solution for the dependency management issue that should be addressed
with modules as we move towards v2 (#471)

client-go recently merged an API-breaking change on master, and so instead we
check out the latest working release of kubernetes/client-go. This is a stop-gap
solution for the dependency management issue that should be addressed
with modules as we move towards v2 (#471)
@knusbaum
Copy link
Contributor Author

To be clear, the newest changes to github.com/kubernetes/client-go haven't been released with a version tag yet. I'm guessing they'll release under a major version number, but I'm not sure.
When they do, we can look at adding a .v1 directory with an updated version of the integration.

Copy link
Contributor

@cgilmour cgilmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gbbr gbbr merged commit 06bd0fe into v1 Feb 13, 2020
@gbbr gbbr deleted the knusbaum/fix-kubernetes-go branch February 13, 2020 08:35
@gbbr
Copy link
Contributor

gbbr commented Feb 13, 2020

Oh my! We should probably make it a new rule from lessons learned not to merge integrations for v0 (unstable) things. Thoughts?

@knusbaum
Copy link
Contributor Author

Probably worth an issue, or maybe we can discuss on #544

mingrammer pushed a commit to mingrammer/dd-trace-go that referenced this pull request Dec 22, 2020
…#595)

client-go recently merged an API-breaking change on master, and so instead we
check out the latest working release of kubernetes/client-go. This is a stop-gap
solution for the dependency management issue that should be addressed
with modules as we move towards v2 (DataDog#471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants