fix

DataDog · Apr 10, 2024 · 830be9a · 830be9a
1 parent 645db4b
commit 830be9a
Show file tree

Hide file tree

Showing 10 changed files with 11 additions and 3 deletions.
diff --git a/dd-java-agent/agent-iast/src/main/java/com/datadog/iast/sink/ApplicationModuleImpl.java b/dd-java-agent/agent-iast/src/main/java/com/datadog/iast/sink/ApplicationModuleImpl.java
@@ -316,7 +316,7 @@ private void reportAdminConsoleActive(AgentSpan span, final String evidence) {
   }
 
   private void reportDefaultAppDeployed(final AgentSpan span, final String evidence) {
-    reporter.report(
+    reporter.noDedupReport(
         span,
         new Vulnerability(
             VulnerabilityType.DEFAULT_APP_DEPLOYED,

diff --git a/dd-java-agent/agent-iast/src/test/groovy/com/datadog/iast/sink/ApplicationModuleTest.groovy b/dd-java-agent/agent-iast/src/test/groovy/com/datadog/iast/sink/ApplicationModuleTest.groovy
@@ -70,8 +70,9 @@ class ApplicationModuleTest extends IastModuleImplTestBase {
     'report'         | 'application/directorylistingleak/insecure/websphere/xmi'        | DIRECTORY_LISTING_LEAK      | 'Directory listings configured'                             | 1
     'report'         | 'application/directorylistingleak/insecure/websphere/xml'        | DIRECTORY_LISTING_LEAK      | 'Directory listings configured'                             | 10
     'noDedupReport'  | 'application/adminconsoleactive/secure'           | null                        | null                                                       | _
-    'noDedupReport'  | 'application/adminconsoleactive/insecure/tomcat/manager'         | DEFAULT_APP_DEPLOYED        | ApplicationModuleImpl.TOMCAT_MANAGER_APP                    | NO_LINE
-    'noDedupReport'  | 'application/adminconsoleactive/insecure/tomcat/host'            | DEFAULT_APP_DEPLOYED        | ApplicationModuleImpl.TOMCAT_HOST_MANAGER_APP               | NO_LINE
+    'noDedupReport'  | 'application/adminconsoleactive/insecure/tomcat/manager'         | ADMIN_CONSOLE_ACTIVE        | ApplicationModuleImpl.TOMCAT_MANAGER_APP                    | NO_LINE
+    'noDedupReport'  | 'application/adminconsoleactive/insecure/tomcat/host'            | ADMIN_CONSOLE_ACTIVE        | ApplicationModuleImpl.TOMCAT_HOST_MANAGER_APP               | NO_LINE
+    'noDedupReport'  | 'application/defaultappdeployed/secure'           | null                        | null                                                       | _
     'noDedupReport'  | 'application/defaultappdeployed/insecure/tomcat/samples'         | DEFAULT_APP_DEPLOYED        | ApplicationModuleImpl.TOMCAT_SAMPLES_APP                    | NO_LINE
     'noDedupReport'  | 'application/defaultappdeployed/insecure/jetty/async'            | DEFAULT_APP_DEPLOYED        | ApplicationModuleImpl.JETTY_ASYNC_REST_APP                  | NO_LINE
     'noDedupReport'  | 'application/defaultappdeployed/insecure/jetty/jaas'             | DEFAULT_APP_DEPLOYED        | ApplicationModuleImpl.JETTY_JAAS_APP                        | NO_LINE

diff --git a/...tive/insecure/jetty/async/WEB-INF/web.xml → ...oyed/insecure/jetty/async/WEB-INF/web.xml b/...tive/insecure/jetty/async/WEB-INF/web.xml → ...oyed/insecure/jetty/async/WEB-INF/web.xml
diff --git a/...ctive/insecure/jetty/jaas/WEB-INF/web.xml → ...loyed/insecure/jetty/jaas/WEB-INF/web.xml b/...ctive/insecure/jetty/jaas/WEB-INF/web.xml → ...loyed/insecure/jetty/jaas/WEB-INF/web.xml
diff --git a/...ve/insecure/jetty/javadoc/WEB-INF/web.xml → ...ed/insecure/jetty/javadoc/WEB-INF/web.xml b/...ve/insecure/jetty/javadoc/WEB-INF/web.xml → ...ed/insecure/jetty/javadoc/WEB-INF/web.xml
diff --git a/...ctive/insecure/jetty/jndi/WEB-INF/web.xml → ...loyed/insecure/jetty/jndi/WEB-INF/web.xml b/...ctive/insecure/jetty/jndi/WEB-INF/web.xml → ...loyed/insecure/jetty/jndi/WEB-INF/web.xml
diff --git a/...ctive/insecure/jetty/spec/WEB-INF/web.xml → ...loyed/insecure/jetty/spec/WEB-INF/web.xml b/...ctive/insecure/jetty/spec/WEB-INF/web.xml → ...loyed/insecure/jetty/spec/WEB-INF/web.xml
diff --git a/...ctive/insecure/jetty/test/WEB-INF/web.xml → ...loyed/insecure/jetty/test/WEB-INF/web.xml b/...ctive/insecure/jetty/test/WEB-INF/web.xml → ...loyed/insecure/jetty/test/WEB-INF/web.xml
diff --git a/...e/insecure/tomcat/samples/WEB-INF/web.xml → ...d/insecure/tomcat/samples/WEB-INF/web.xml b/...e/insecure/tomcat/samples/WEB-INF/web.xml → ...d/insecure/tomcat/samples/WEB-INF/web.xml
diff --git a/...agent/agent-iast/src/test/resources/application/defaultappdeployed/secure/WEB-INF/web.xml b/...agent/agent-iast/src/test/resources/application/defaultappdeployed/secure/WEB-INF/web.xml
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<web-app xmlns="http://xmlns.jcp.org/xml/ns/javaee"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/web-app_4_0.xsd"
+         version="4.0">
+  <display-name>Test app</display-name>
+</web-app>