Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to libddwaf 1.18.0 (libddwaf-java 10.0.0) #7006

Merged
merged 2 commits into from
May 10, 2024
Merged

Upgrade to libddwaf 1.18.0 (libddwaf-java 10.0.0) #7006

merged 2 commits into from
May 10, 2024

Conversation

ValentinZakharov
Copy link
Contributor

@ValentinZakharov ValentinZakharov commented May 8, 2024 •
edited by jira bot
Loading

What Does This Do

Upgraded libddwaf to the latest version, see:

Motivation

This PR is preparatory work for the ASM Exploit Prevention (RASP)

Additional Notes

Jira ticket: APPSEC-52825

@ValentinZakharov ValentinZakharov added the comp: asm waf Application Security Management (WAF) label May 8, 2024
@ValentinZakharov ValentinZakharov self-assigned this May 8, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 8, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vzakharov/update-libddwaf-1.18.0
git_commit_date 1715279552 1715342342
git_commit_sha 6df14c1 7f04a56
release_version 1.35.0-SNAPSHOT~6df14c1b0f 1.34.0-SNAPSHOT~7f04a5629b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715345618 1715345618
ci_job_id 508725688 508725688
ci_pipeline_id 34023739 34023739
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 46 metrics, 16 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:appsec:AppSec worse
[+3.131ms; +4.657ms] or [+2.106%; +3.133%]		 152.536ms 148.642ms
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.34.0-SNAPSHOT~7f04a5629b, baseline=1.35.0-SNAPSHOT~6df14c1b0f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076601
Total [baseline] (10.362 s) : 0, 10362469
Agent [candidate] (1.083 s) : 0, 1083209
Total [candidate] (10.437 s) : 0, 10436687
section appsec
Agent [baseline] (1.19 s) : 0, 1189800
Total [baseline] (10.428 s) : 0, 10427964
Agent [candidate] (1.196 s) : 0, 1196124
Total [candidate] (10.481 s) : 0, 10481114
section iast
Agent [baseline] (1.201 s) : 0, 1201192
Total [baseline] (10.755 s) : 0, 10755057
Agent [candidate] (1.216 s) : 0, 1216070
Total [candidate] (10.817 s) : 0, 10816597
section profiling
Agent [baseline] (1.277 s) : 0, 1277082
Total [baseline] (10.637 s) : 0, 10636633
Agent [candidate] (1.272 s) : 0, 1271850
Total [candidate] (10.618 s) : 0, 10618427
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.077 s -
Agent appsec 1.19 s 113.199 ms (10.5%)
Agent iast 1.201 s 124.591 ms (11.6%)
Agent profiling 1.277 s 200.481 ms (18.6%)
Total tracing 10.362 s -
Total appsec 10.428 s 65.496 ms (0.6%)
Total iast 10.755 s 392.589 ms (3.8%)
Total profiling 10.637 s 274.165 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.083 s -
Agent appsec 1.196 s 112.914 ms (10.4%)
Agent iast 1.216 s 132.861 ms (12.3%)
Agent profiling 1.272 s 188.641 ms (17.4%)
Total tracing 10.437 s -
Total appsec 10.481 s 44.427 ms (0.4%)
Total iast 10.817 s 379.91 ms (3.6%)
Total profiling 10.618 s 181.74 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.34.0-SNAPSHOT~7f04a5629b, baseline=1.35.0-SNAPSHOT~6df14c1b0f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.68 ms) : 0, 673680
BytebuddyAgent [candidate] (677.591 ms) : 0, 677591
GlobalTracer [baseline] (310.714 ms) : 0, 310714
GlobalTracer [candidate] (312.811 ms) : 0, 312811
AppSec [baseline] (49.591 ms) : 0, 49591
AppSec [candidate] (49.85 ms) : 0, 49850
Remote Config [baseline] (657.418 µs) : 0, 657
Remote Config [candidate] (669.013 µs) : 0, 669
Telemetry [baseline] (7.677 ms) : 0, 7677
Telemetry [candidate] (7.691 ms) : 0, 7691
section appsec
BytebuddyAgent [baseline] (694.474 ms) : 0, 694474
BytebuddyAgent [candidate] (696.361 ms) : 0, 696361
GlobalTracer [baseline] (292.709 ms) : 0, 292709
GlobalTracer [candidate] (293.742 ms) : 0, 293742
AppSec [baseline] (148.642 ms) : 0, 148642
AppSec [candidate] (152.536 ms) : 0, 152536
Remote Config [baseline] (617.543 µs) : 0, 618
Remote Config [candidate] (623.093 µs) : 0, 623
Telemetry [baseline] (9.477 ms) : 0, 9477
Telemetry [candidate] (8.736 ms) : 0, 8736
IAST [baseline] (19.251 ms) : 0, 19251
IAST [candidate] (19.442 ms) : 0, 19442
section iast
BytebuddyAgent [baseline] (793.208 ms) : 0, 793208
BytebuddyAgent [candidate] (805.059 ms) : 0, 805059
GlobalTracer [baseline] (290.592 ms) : 0, 290592
GlobalTracer [candidate] (293.607 ms) : 0, 293607
AppSec [baseline] (51.122 ms) : 0, 51122
AppSec [candidate] (50.139 ms) : 0, 50139
Remote Config [baseline] (611.155 µs) : 0, 611
Remote Config [candidate] (1.29 ms) : 0, 1290
Telemetry [baseline] (7.46 ms) : 0, 7460
Telemetry [candidate] (6.691 ms) : 0, 6691
IAST [baseline] (23.84 ms) : 0, 23840
IAST [candidate] (24.424 ms) : 0, 24424
section profiling
BytebuddyAgent [baseline] (681.418 ms) : 0, 681418
BytebuddyAgent [candidate] (677.357 ms) : 0, 677357
GlobalTracer [baseline] (383.261 ms) : 0, 383261
GlobalTracer [candidate] (383.327 ms) : 0, 383327
AppSec [baseline] (50.561 ms) : 0, 50561
AppSec [candidate] (50.321 ms) : 0, 50321
Remote Config [baseline] (724.674 µs) : 0, 725
Remote Config [candidate] (700.435 µs) : 0, 700
Telemetry [baseline] (7.599 ms) : 0, 7599
Telemetry [candidate] (7.487 ms) : 0, 7487
ProfilingAgent [baseline] (96.815 ms) : 0, 96815
ProfilingAgent [candidate] (96.401 ms) : 0, 96401
Profiling [baseline] (96.839 ms) : 0, 96839
Profiling [candidate] (96.425 ms) : 0, 96425
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.34.0-SNAPSHOT~7f04a5629b, baseline=1.35.0-SNAPSHOT~6df14c1b0f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079550
Total [baseline] (8.554 s) : 0, 8553639
Agent [candidate] (1.081 s) : 0, 1081160
Total [candidate] (8.555 s) : 0, 8555189
section iast
Agent [baseline] (1.2 s) : 0, 1199955
Total [baseline] (9.019 s) : 0, 9019405
Agent [candidate] (1.216 s) : 0, 1216392
Total [candidate] (9.007 s) : 0, 9006787
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.206 s) : 0, 1205778
Total [baseline] (8.975 s) : 0, 8974545
Agent [candidate] (1.21 s) : 0, 1209513
Total [candidate] (9.004 s) : 0, 9004267
section iast_TELEMETRY_OFF
Agent [baseline] (1.196 s) : 0, 1196388
Total [baseline] (8.985 s) : 0, 8985330
Agent [candidate] (1.199 s) : 0, 1198669
Total [candidate] (8.997 s) : 0, 8997035
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.2 s 120.405 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.206 s 126.228 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.196 s 116.838 ms (10.8%)
Total tracing 8.554 s -
Total iast 9.019 s 465.766 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.975 s 420.905 ms (4.9%)
Total iast_TELEMETRY_OFF 8.985 s 431.691 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.081 s -
Agent iast 1.216 s 135.232 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.21 s 128.352 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.199 s 117.508 ms (10.9%)
Total tracing 8.555 s -
Total iast 9.007 s 451.597 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.004 s 449.078 ms (5.2%)
Total iast_TELEMETRY_OFF 8.997 s 441.846 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.34.0-SNAPSHOT~7f04a5629b, baseline=1.35.0-SNAPSHOT~6df14c1b0f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (676.604 ms) : 0, 676604
BytebuddyAgent [candidate] (676.755 ms) : 0, 676755
GlobalTracer [baseline] (310.693 ms) : 0, 310693
GlobalTracer [candidate] (312.011 ms) : 0, 312011
AppSec [baseline] (49.557 ms) : 0, 49557
AppSec [candidate] (49.668 ms) : 0, 49668
Remote Config [baseline] (659.152 µs) : 0, 659
Remote Config [candidate] (661.337 µs) : 0, 661
Telemetry [baseline] (7.583 ms) : 0, 7583
Telemetry [candidate] (7.625 ms) : 0, 7625
section iast
BytebuddyAgent [baseline] (792.708 ms) : 0, 792708
BytebuddyAgent [candidate] (805.371 ms) : 0, 805371
GlobalTracer [baseline] (290.678 ms) : 0, 290678
GlobalTracer [candidate] (293.759 ms) : 0, 293759
AppSec [baseline] (49.399 ms) : 0, 49399
AppSec [candidate] (51.047 ms) : 0, 51047
Remote Config [baseline] (1.321 ms) : 0, 1321
Remote Config [candidate] (585.507 µs) : 0, 586
Telemetry [baseline] (6.628 ms) : 0, 6628
Telemetry [candidate] (6.641 ms) : 0, 6641
IAST [baseline] (24.961 ms) : 0, 24961
IAST [candidate] (24.206 ms) : 0, 24206
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.096 ms) : 0, 797096
BytebuddyAgent [candidate] (799.74 ms) : 0, 799740
GlobalTracer [baseline] (291.573 ms) : 0, 291573
GlobalTracer [candidate] (292.441 ms) : 0, 292441
AppSec [baseline] (50.198 ms) : 0, 50198
AppSec [candidate] (50.595 ms) : 0, 50595
Remote Config [baseline] (1.308 ms) : 0, 1308
Remote Config [candidate] (594.136 µs) : 0, 594
Telemetry [baseline] (6.602 ms) : 0, 6602
Telemetry [candidate] (7.317 ms) : 0, 7317
IAST [baseline] (24.653 ms) : 0, 24653
IAST [candidate] (24.26 ms) : 0, 24260
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (789.471 ms) : 0, 789471
BytebuddyAgent [candidate] (792.038 ms) : 0, 792038
GlobalTracer [baseline] (290.262 ms) : 0, 290262
GlobalTracer [candidate] (290.428 ms) : 0, 290428
AppSec [baseline] (49.648 ms) : 0, 49648
AppSec [candidate] (51.182 ms) : 0, 51182
Remote Config [baseline] (589.829 µs) : 0, 590
Remote Config [candidate] (596.99 µs) : 0, 597
Telemetry [baseline] (7.336 ms) : 0, 7336
Telemetry [candidate] (6.542 ms) : 0, 6542
IAST [baseline] (24.782 ms) : 0, 24782
IAST [candidate] (23.6 ms) : 0, 23600
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-10T12:24:28 2024-05-10T12:31:15
git_branch master vzakharov/update-libddwaf-1.18.0
git_commit_date 1715279552 1715342342
git_commit_sha 6df14c1 7f04a56
release_version 1.35.0-SNAPSHOT~6df14c1b0f 1.34.0-SNAPSHOT~7f04a5629b
start_time 2024-05-10T12:24:15 2024-05-10T12:31:01
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715344619 1715344619
ci_job_id 508725689 508725689
ci_pipeline_id 34023739 34023739
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~7f04a5629b, baseline=1.35.0-SNAPSHOT~6df14c1b0f
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.398 µs) : 352, 392
.   : milestone, 372,
iast (478.912 µs) : 458, 500
.   : milestone, 479,
iast_FULL (543.12 µs) : 522, 564
.   : milestone, 543,
iast_GLOBAL (510.065 µs) : 487, 533
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (472.224 µs) : 451, 494
.   : milestone, 472,
iast_INACTIVE (437.438 µs) : 417, 458
.   : milestone, 437,
iast_TELEMETRY_OFF (467.755 µs) : 446, 489
.   : milestone, 468,
tracing (442.238 µs) : 421, 463
.   : milestone, 442,
section candidate
no_agent (371.109 µs) : 350, 392
.   : milestone, 371,
iast (477.042 µs) : 457, 497
.   : milestone, 477,
iast_FULL (543.482 µs) : 523, 564
.   : milestone, 543,
iast_GLOBAL (498.942 µs) : 478, 520
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (478.041 µs) : 457, 499
.   : milestone, 478,
iast_INACTIVE (447.243 µs) : 427, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (476.573 µs) : 455, 499
.   : milestone, 477,
tracing (444.354 µs) : 424, 465
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.398 µs [352.391 µs, 392.406 µs] -
iast 478.912 µs [458.148 µs, 499.676 µs] 106.514 µs (28.6%)
iast_FULL 543.12 µs [522.415 µs, 563.824 µs] 170.721 µs (45.8%)
iast_GLOBAL 510.065 µs [487.408 µs, 532.721 µs] 137.666 µs (37.0%)
iast_HARDCODED_SECRET_DISABLED 472.224 µs [450.871 µs, 493.577 µs] 99.826 µs (26.8%)
iast_INACTIVE 437.438 µs [417.069 µs, 457.807 µs] 65.04 µs (17.5%)
iast_TELEMETRY_OFF 467.755 µs [446.152 µs, 489.358 µs] 95.357 µs (25.6%)
tracing 442.238 µs [421.413 µs, 463.062 µs] 69.839 µs (18.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.109 µs [349.861 µs, 392.357 µs] -
iast 477.042 µs [456.623 µs, 497.461 µs] 105.933 µs (28.5%)
iast_FULL 543.482 µs [522.711 µs, 564.254 µs] 172.374 µs (46.4%)
iast_GLOBAL 498.942 µs [477.838 µs, 520.047 µs] 127.834 µs (34.4%)
iast_HARDCODED_SECRET_DISABLED 478.041 µs [457.315 µs, 498.766 µs] 106.932 µs (28.8%)
iast_INACTIVE 447.243 µs [426.53 µs, 467.957 µs] 76.135 µs (20.5%)
iast_TELEMETRY_OFF 476.573 µs [454.528 µs, 498.619 µs] 105.465 µs (28.4%)
tracing 444.354 µs [423.92 µs, 464.787 µs] 73.245 µs (19.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.34.0-SNAPSHOT~7f04a5629b, baseline=1.35.0-SNAPSHOT~6df14c1b0f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.333 ms) : 1314, 1352
.   : milestone, 1333,
appsec (1.686 ms) : 1662, 1710
.   : milestone, 1686,
appsec_no_iast (1.721 ms) : 1698, 1745
.   : milestone, 1721,
iast (1.47 ms) : 1448, 1493
.   : milestone, 1470,
profiling (1.48 ms) : 1455, 1505
.   : milestone, 1480,
tracing (1.479 ms) : 1455, 1503
.   : milestone, 1479,
section candidate
no_agent (1.357 ms) : 1337, 1377
.   : milestone, 1357,
appsec (1.733 ms) : 1708, 1758
.   : milestone, 1733,
appsec_no_iast (1.719 ms) : 1696, 1742
.   : milestone, 1719,
iast (1.482 ms) : 1460, 1505
.   : milestone, 1482,
profiling (1.509 ms) : 1484, 1534
.   : milestone, 1509,
tracing (1.481 ms) : 1457, 1505
.   : milestone, 1481,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.333 ms [1.314 ms, 1.352 ms] -
appsec 1.686 ms [1.662 ms, 1.71 ms] 352.908 µs (26.5%)
appsec_no_iast 1.721 ms [1.698 ms, 1.745 ms] 388.399 µs (29.1%)
iast 1.47 ms [1.448 ms, 1.493 ms] 137.207 µs (10.3%)
profiling 1.48 ms [1.455 ms, 1.505 ms] 146.712 µs (11.0%)
tracing 1.479 ms [1.455 ms, 1.503 ms] 146.0 µs (11.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.337 ms, 1.377 ms] -
appsec 1.733 ms [1.708 ms, 1.758 ms] 376.127 µs (27.7%)
appsec_no_iast 1.719 ms [1.696 ms, 1.742 ms] 362.055 µs (26.7%)
iast 1.482 ms [1.46 ms, 1.505 ms] 125.243 µs (9.2%)
profiling 1.509 ms [1.484 ms, 1.534 ms] 152.009 µs (11.2%)
tracing 1.481 ms [1.457 ms, 1.505 ms] 123.998 µs (9.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master vzakharov/update-libddwaf-1.18.0
git_commit_date 1715279552 1715342342
git_commit_sha 6df14c1 7f04a56
release_version 1.35.0-SNAPSHOT~6df14c1b0f 1.34.0-SNAPSHOT~7f04a5629b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715345137 1715345137
ci_job_id 508725690 508725690
ci_pipeline_id 34023739 34023739
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~7f04a5629b, baseline=1.35.0-SNAPSHOT~6df14c1b0f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.463 ms) : 1452, 1475
.   : milestone, 1463,
appsec (2.205 ms) : 2171, 2239
.   : milestone, 2205,
iast (1.875 ms) : 1840, 1910
.   : milestone, 1875,
iast_GLOBAL (1.916 ms) : 1881, 1951
.   : milestone, 1916,
profiling (1.86 ms) : 1827, 1893
.   : milestone, 1860,
tracing (1.828 ms) : 1796, 1860
.   : milestone, 1828,
section candidate
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.212 ms) : 2178, 2245
.   : milestone, 2212,
iast (1.874 ms) : 1840, 1909
.   : milestone, 1874,
iast_GLOBAL (1.915 ms) : 1880, 1950
.   : milestone, 1915,
profiling (2.336 ms) : 2154, 2518
.   : milestone, 2336,
tracing (1.836 ms) : 1804, 1867
.   : milestone, 1836,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.452 ms, 1.475 ms] -
appsec 2.205 ms [2.171 ms, 2.239 ms] 741.45 µs (50.7%)
iast 1.875 ms [1.84 ms, 1.91 ms] 411.869 µs (28.1%)
iast_GLOBAL 1.916 ms [1.881 ms, 1.951 ms] 452.352 µs (30.9%)
profiling 1.86 ms [1.827 ms, 1.893 ms] 396.408 µs (27.1%)
tracing 1.828 ms [1.796 ms, 1.86 ms] 364.764 µs (24.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.212 ms [2.178 ms, 2.245 ms] 749.771 µs (51.3%)
iast 1.874 ms [1.84 ms, 1.909 ms] 412.53 µs (28.2%)
iast_GLOBAL 1.915 ms [1.88 ms, 1.95 ms] 453.274 µs (31.0%)
profiling 2.336 ms [2.154 ms, 2.518 ms] 874.366 µs (59.8%)
tracing 1.836 ms [1.804 ms, 1.867 ms] 373.692 µs (25.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.34.0-SNAPSHOT~7f04a5629b, baseline=1.35.0-SNAPSHOT~6df14c1b0f
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.958 s) : 14958000, 14958000
.   : milestone, 14958000,
appsec (15.045 s) : 15045000, 15045000
.   : milestone, 15045000,
iast (18.836 s) : 18836000, 18836000
.   : milestone, 18836000,
iast_GLOBAL (17.63 s) : 17630000, 17630000
.   : milestone, 17630000,
profiling (15.04 s) : 15040000, 15040000
.   : milestone, 15040000,
tracing (15.512 s) : 15512000, 15512000
.   : milestone, 15512000,
section candidate
no_agent (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
appsec (15.118 s) : 15118000, 15118000
.   : milestone, 15118000,
iast (18.867 s) : 18867000, 18867000
.   : milestone, 18867000,
iast_GLOBAL (18.055 s) : 18055000, 18055000
.   : milestone, 18055000,
profiling (14.951 s) : 14951000, 14951000
.   : milestone, 14951000,
tracing (15.059 s) : 15059000, 15059000
.   : milestone, 15059000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.958 s [14.958 s, 14.958 s] -
appsec 15.045 s [15.045 s, 15.045 s] 87.0 ms (0.6%)
iast 18.836 s [18.836 s, 18.836 s] 3.878 s (25.9%)
iast_GLOBAL 17.63 s [17.63 s, 17.63 s] 2.672 s (17.9%)
profiling 15.04 s [15.04 s, 15.04 s] 82.0 ms (0.5%)
tracing 15.512 s [15.512 s, 15.512 s] 554.0 ms (3.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.049 s [15.049 s, 15.049 s] -
appsec 15.118 s [15.118 s, 15.118 s] 69.0 ms (0.5%)
iast 18.867 s [18.867 s, 18.867 s] 3.818 s (25.4%)
iast_GLOBAL 18.055 s [18.055 s, 18.055 s] 3.006 s (20.0%)
profiling 14.951 s [14.951 s, 14.951 s] -98.0 ms (-0.7%)
tracing 15.059 s [15.059 s, 15.059 s] 10.0 ms (0.1%)

@ValentinZakharov ValentinZakharov marked this pull request as ready for review May 9, 2024 08:48
@ValentinZakharov ValentinZakharov requested a review from a team as a code owner May 9, 2024 08:48
@smola smola changed the title Upgrade to libddwaf 1.18.0 (libsqreen 10.0.0) Upgrade to libddwaf 1.18.0 (libddwaf-java 10.0.0) May 9, 2024
@ValentinZakharov ValentinZakharov force-pushed the vzakharov/update-libddwaf-1.18.0 branch from 29211fa to 7f04a56 Compare May 10, 2024 12:06
@ValentinZakharov ValentinZakharov merged commit 73385c9 into master May 10, 2024
80 checks passed
@ValentinZakharov ValentinZakharov deleted the vzakharov/update-libddwaf-1.18.0 branch May 10, 2024 14:23
@github-actions github-actions bot added this to the 1.35.0 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@smola smola smola approved these changes

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 is a code owner automatically assigned from DataDog/asm-java

Assignees

@ValentinZakharov ValentinZakharov

Labels
comp: asm waf Application Security Management (WAF)
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ValentinZakharov @smola @manuel-alvarez-alvarez