Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug log on sampling #7021

Merged
merged 1 commit into from
May 13, 2024
Merged

Remove debug log on sampling #7021

merged 1 commit into from
May 13, 2024

Conversation

jpbempel
Copy link
Member

What Does This Do

remove unnecessary verbose debug log

Motivation

verbose logs

Additional Notes

@jpbempel
Remove debug log on sampling
f8a29b8 
unnecessary verbose debug log
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label May 13, 2024
@jpbempel jpbempel requested a review from a team as a code owner May 13, 2024 12:53
@jpbempel jpbempel requested review from ojung and removed request for a team May 13, 2024 12:53
@pr-commenter
Copy link

pr-commenter bot commented May 13, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-debug-log-sampling
git_commit_date 1715602718 1715604726
git_commit_sha ed71fed f8a29b8
release_version 1.35.0-SNAPSHOT~ed71fed7b3 1.35.0-SNAPSHOT~f8a29b88da
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715607280 1715607280
ci_job_id 509978424 509978424
ci_pipeline_id 34132496 34132496
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~f8a29b88da, baseline=1.35.0-SNAPSHOT~ed71fed7b3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078042
Total [baseline] (8.591 s) : 0, 8591435
Agent [candidate] (1.093 s) : 0, 1093452
Total [candidate] (8.664 s) : 0, 8664391
section iast
Agent [baseline] (1.216 s) : 0, 1216136
Total [baseline] (9.059 s) : 0, 9058501
Agent [candidate] (1.227 s) : 0, 1227081
Total [candidate] (9.045 s) : 0, 9045370
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.203 s) : 0, 1202994
Total [baseline] (8.999 s) : 0, 8999428
Agent [candidate] (1.199 s) : 0, 1199094
Total [candidate] (9.01 s) : 0, 9010043
section iast_TELEMETRY_OFF
Agent [baseline] (1.212 s) : 0, 1211714
Total [baseline] (9.018 s) : 0, 9017753
Agent [candidate] (1.208 s) : 0, 1207837
Total [candidate] (9.054 s) : 0, 9054249
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent iast 1.216 s 138.094 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.203 s 124.952 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.212 s 133.672 ms (12.4%)
Total tracing 8.591 s -
Total iast 9.059 s 467.066 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.999 s 407.993 ms (4.7%)
Total iast_TELEMETRY_OFF 9.018 s 426.318 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.093 s -
Agent iast 1.227 s 133.628 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.199 s 105.642 ms (9.7%)
Agent iast_TELEMETRY_OFF 1.208 s 114.385 ms (10.5%)
Total tracing 8.664 s -
Total iast 9.045 s 380.979 ms (4.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.01 s 345.652 ms (4.0%)
Total iast_TELEMETRY_OFF 9.054 s 389.858 ms (4.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~f8a29b88da, baseline=1.35.0-SNAPSHOT~ed71fed7b3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.799 ms) : 0, 674799
BytebuddyAgent [candidate] (684.756 ms) : 0, 684756
GlobalTracer [baseline] (310.755 ms) : 0, 310755
GlobalTracer [candidate] (315.61 ms) : 0, 315610
AppSec [baseline] (49.828 ms) : 0, 49828
AppSec [candidate] (49.955 ms) : 0, 49955
Remote Config [baseline] (669.72 µs) : 0, 670
Remote Config [candidate] (663.761 µs) : 0, 664
Telemetry [baseline] (7.637 ms) : 0, 7637
Telemetry [candidate] (7.615 ms) : 0, 7615
section iast
BytebuddyAgent [baseline] (804.549 ms) : 0, 804549
BytebuddyAgent [candidate] (812.067 ms) : 0, 812067
GlobalTracer [baseline] (293.591 ms) : 0, 293591
GlobalTracer [candidate] (296.364 ms) : 0, 296364
AppSec [baseline] (51.522 ms) : 0, 51522
AppSec [candidate] (51.814 ms) : 0, 51814
IAST [baseline] (24.449 ms) : 0, 24449
IAST [candidate] (23.765 ms) : 0, 23765
Remote Config [baseline] (614.29 µs) : 0, 614
Remote Config [candidate] (598.415 µs) : 0, 598
Telemetry [baseline] (6.762 ms) : 0, 6762
Telemetry [candidate] (7.455 ms) : 0, 7455
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (796.402 ms) : 0, 796402
BytebuddyAgent [candidate] (792.024 ms) : 0, 792024
GlobalTracer [baseline] (290.39 ms) : 0, 290390
GlobalTracer [candidate] (290.5 ms) : 0, 290500
AppSec [baseline] (49.206 ms) : 0, 49206
AppSec [candidate] (53.088 ms) : 0, 53088
IAST [baseline] (25.502 ms) : 0, 25502
IAST [candidate] (21.968 ms) : 0, 21968
Remote Config [baseline] (579.658 µs) : 0, 580
Remote Config [candidate] (589.883 µs) : 0, 590
Telemetry [baseline] (6.597 ms) : 0, 6597
Telemetry [candidate] (6.717 ms) : 0, 6717
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.791 ms) : 0, 801791
BytebuddyAgent [candidate] (797.131 ms) : 0, 797131
GlobalTracer [baseline] (293.204 ms) : 0, 293204
GlobalTracer [candidate] (292.77 ms) : 0, 292770
AppSec [baseline] (51.74 ms) : 0, 51740
AppSec [candidate] (49.43 ms) : 0, 49430
IAST [baseline] (23.111 ms) : 0, 23111
IAST [candidate] (23.67 ms) : 0, 23670
Remote Config [baseline] (605.81 µs) : 0, 606
Remote Config [candidate] (601.938 µs) : 0, 602
Telemetry [baseline] (6.569 ms) : 0, 6569
Telemetry [candidate] (9.558 ms) : 0, 9558
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~f8a29b88da, baseline=1.35.0-SNAPSHOT~ed71fed7b3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080340
Total [baseline] (10.423 s) : 0, 10423152
Agent [candidate] (1.079 s) : 0, 1079399
Total [candidate] (10.417 s) : 0, 10417091
section appsec
Agent [baseline] (1.2 s) : 0, 1200116
Total [baseline] (10.478 s) : 0, 10477859
Agent [candidate] (1.198 s) : 0, 1198001
Total [candidate] (10.488 s) : 0, 10488144
section iast
Agent [baseline] (1.203 s) : 0, 1202885
Total [baseline] (10.821 s) : 0, 10821268
Agent [candidate] (1.2 s) : 0, 1200197
Total [candidate] (10.77 s) : 0, 10770255
section profiling
Agent [baseline] (1.285 s) : 0, 1285219
Total [baseline] (10.715 s) : 0, 10714674
Agent [candidate] (1.272 s) : 0, 1272440
Total [candidate] (10.612 s) : 0, 10611597
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.2 s 119.776 ms (11.1%)
Agent iast 1.203 s 122.545 ms (11.3%)
Agent profiling 1.285 s 204.88 ms (19.0%)
Total tracing 10.423 s -
Total appsec 10.478 s 54.707 ms (0.5%)
Total iast 10.821 s 398.116 ms (3.8%)
Total profiling 10.715 s 291.523 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.198 s 118.602 ms (11.0%)
Agent iast 1.2 s 120.798 ms (11.2%)
Agent profiling 1.272 s 193.041 ms (17.9%)
Total tracing 10.417 s -
Total appsec 10.488 s 71.053 ms (0.7%)
Total iast 10.77 s 353.163 ms (3.4%)
Total profiling 10.612 s 194.506 ms (1.9%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~f8a29b88da, baseline=1.35.0-SNAPSHOT~ed71fed7b3

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (676.667 ms) : 0, 676667
BytebuddyAgent [candidate] (675.327 ms) : 0, 675327
GlobalTracer [baseline] (311.364 ms) : 0, 311364
GlobalTracer [candidate] (311.927 ms) : 0, 311927
AppSec [baseline] (49.61 ms) : 0, 49610
AppSec [candidate] (49.406 ms) : 0, 49406
Remote Config [baseline] (662.477 µs) : 0, 662
Remote Config [candidate] (663.26 µs) : 0, 663
Telemetry [baseline] (7.64 ms) : 0, 7640
Telemetry [candidate] (7.649 ms) : 0, 7649
section appsec
BytebuddyAgent [baseline] (699.016 ms) : 0, 699016
BytebuddyAgent [candidate] (697.553 ms) : 0, 697553
GlobalTracer [baseline] (294.701 ms) : 0, 294701
GlobalTracer [candidate] (294.27 ms) : 0, 294270
AppSec [baseline] (153.056 ms) : 0, 153056
AppSec [candidate] (152.759 ms) : 0, 152759
Remote Config [baseline] (621.213 µs) : 0, 621
Remote Config [candidate] (620.521 µs) : 0, 621
Telemetry [baseline] (8.55 ms) : 0, 8550
Telemetry [candidate] (8.725 ms) : 0, 8725
IAST [baseline] (19.339 ms) : 0, 19339
IAST [candidate] (19.302 ms) : 0, 19302
section iast
BytebuddyAgent [baseline] (795.866 ms) : 0, 795866
BytebuddyAgent [candidate] (792.948 ms) : 0, 792948
GlobalTracer [baseline] (290.518 ms) : 0, 290518
GlobalTracer [candidate] (290.655 ms) : 0, 290655
AppSec [baseline] (50.252 ms) : 0, 50252
AppSec [candidate] (48.569 ms) : 0, 48569
Remote Config [baseline] (575.973 µs) : 0, 576
Remote Config [candidate] (713.89 µs) : 0, 714
Telemetry [baseline] (6.584 ms) : 0, 6584
Telemetry [candidate] (6.488 ms) : 0, 6488
IAST [baseline] (24.714 ms) : 0, 24714
IAST [candidate] (26.495 ms) : 0, 26495
section profiling
ProfilingAgent [baseline] (96.139 ms) : 0, 96139
ProfilingAgent [candidate] (95.49 ms) : 0, 95490
BytebuddyAgent [baseline] (686.865 ms) : 0, 686865
BytebuddyAgent [candidate] (679.17 ms) : 0, 679170
GlobalTracer [baseline] (385.832 ms) : 0, 385832
GlobalTracer [candidate] (382.628 ms) : 0, 382628
AppSec [baseline] (50.75 ms) : 0, 50750
AppSec [candidate] (50.294 ms) : 0, 50294
Remote Config [baseline] (738.741 µs) : 0, 739
Remote Config [candidate] (713.777 µs) : 0, 714
Telemetry [baseline] (7.52 ms) : 0, 7520
Telemetry [candidate] (7.491 ms) : 0, 7491
Profiling [baseline] (96.163 ms) : 0, 96163
Profiling [candidate] (95.514 ms) : 0, 95514
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-13T13:05:22 2024-05-13T13:12:14
git_branch master jpbempel/fix-debug-log-sampling
git_commit_date 1715602718 1715604726
git_commit_sha ed71fed f8a29b8
release_version 1.35.0-SNAPSHOT~ed71fed7b3 1.35.0-SNAPSHOT~f8a29b88da
start_time 2024-05-13T13:05:09 2024-05-13T13:12:01
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715606279 1715606279
ci_job_id 509978426 509978426
ci_pipeline_id 34132496 34132496
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~f8a29b88da, baseline=1.35.0-SNAPSHOT~ed71fed7b3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1327, 1367
.   : milestone, 1347,
appsec (1.734 ms) : 1710, 1757
.   : milestone, 1734,
appsec_no_iast (1.751 ms) : 1727, 1775
.   : milestone, 1751,
iast (1.467 ms) : 1444, 1490
.   : milestone, 1467,
profiling (1.536 ms) : 1511, 1561
.   : milestone, 1536,
tracing (1.49 ms) : 1466, 1514
.   : milestone, 1490,
section candidate
no_agent (1.349 ms) : 1330, 1368
.   : milestone, 1349,
appsec (1.707 ms) : 1683, 1731
.   : milestone, 1707,
appsec_no_iast (1.744 ms) : 1721, 1767
.   : milestone, 1744,
iast (1.476 ms) : 1454, 1498
.   : milestone, 1476,
profiling (1.55 ms) : 1523, 1576
.   : milestone, 1550,
tracing (1.481 ms) : 1457, 1505
.   : milestone, 1481,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.327 ms, 1.367 ms] -
appsec 1.734 ms [1.71 ms, 1.757 ms] 386.434 µs (28.7%)
appsec_no_iast 1.751 ms [1.727 ms, 1.775 ms] 403.399 µs (29.9%)
iast 1.467 ms [1.444 ms, 1.49 ms] 119.797 µs (8.9%)
profiling 1.536 ms [1.511 ms, 1.561 ms] 188.321 µs (14.0%)
tracing 1.49 ms [1.466 ms, 1.514 ms] 142.6 µs (10.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.33 ms, 1.368 ms] -
appsec 1.707 ms [1.683 ms, 1.731 ms] 358.458 µs (26.6%)
appsec_no_iast 1.744 ms [1.721 ms, 1.767 ms] 395.305 µs (29.3%)
iast 1.476 ms [1.454 ms, 1.498 ms] 127.29 µs (9.4%)
profiling 1.55 ms [1.523 ms, 1.576 ms] 201.059 µs (14.9%)
tracing 1.481 ms [1.457 ms, 1.505 ms] 132.094 µs (9.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~f8a29b88da, baseline=1.35.0-SNAPSHOT~ed71fed7b3
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.995 µs) : 358, 396
.   : milestone, 377,
iast (487.164 µs) : 466, 508
.   : milestone, 487,
iast_FULL (556.647 µs) : 535, 578
.   : milestone, 557,
iast_GLOBAL (504.64 µs) : 484, 525
.   : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (484.511 µs) : 463, 506
.   : milestone, 485,
iast_INACTIVE (456.958 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (474.593 µs) : 453, 496
.   : milestone, 475,
tracing (450.508 µs) : 429, 472
.   : milestone, 451,
section candidate
no_agent (369.805 µs) : 350, 390
.   : milestone, 370,
iast (476.62 µs) : 453, 501
.   : milestone, 477,
iast_FULL (539.886 µs) : 519, 561
.   : milestone, 540,
iast_GLOBAL (494.279 µs) : 474, 515
.   : milestone, 494,
iast_HARDCODED_SECRET_DISABLED (477.845 µs) : 457, 499
.   : milestone, 478,
iast_INACTIVE (448.483 µs) : 428, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (477.811 µs) : 457, 499
.   : milestone, 478,
tracing (449.748 µs) : 429, 471
.   : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.995 µs [357.586 µs, 396.404 µs] -
iast 487.164 µs [466.093 µs, 508.234 µs] 110.169 µs (29.2%)
iast_FULL 556.647 µs [535.315 µs, 577.978 µs] 179.652 µs (47.7%)
iast_GLOBAL 504.64 µs [483.851 µs, 525.429 µs] 127.645 µs (33.9%)
iast_HARDCODED_SECRET_DISABLED 484.511 µs [463.252 µs, 505.77 µs] 107.516 µs (28.5%)
iast_INACTIVE 456.958 µs [435.62 µs, 478.296 µs] 79.963 µs (21.2%)
iast_TELEMETRY_OFF 474.593 µs [453.446 µs, 495.74 µs] 97.598 µs (25.9%)
tracing 450.508 µs [429.345 µs, 471.671 µs] 73.513 µs (19.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.805 µs [349.531 µs, 390.08 µs] -
iast 476.62 µs [452.698 µs, 500.542 µs] 106.815 µs (28.9%)
iast_FULL 539.886 µs [519.256 µs, 560.516 µs] 170.081 µs (46.0%)
iast_GLOBAL 494.279 µs [473.712 µs, 514.845 µs] 124.473 µs (33.7%)
iast_HARDCODED_SECRET_DISABLED 477.845 µs [456.948 µs, 498.742 µs] 108.039 µs (29.2%)
iast_INACTIVE 448.483 µs [427.754 µs, 469.212 µs] 78.678 µs (21.3%)
iast_TELEMETRY_OFF 477.811 µs [456.542 µs, 499.08 µs] 108.005 µs (29.2%)
tracing 449.748 µs [428.6 µs, 470.897 µs] 79.943 µs (21.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-debug-log-sampling
git_commit_date 1715602718 1715604726
git_commit_sha ed71fed f8a29b8
release_version 1.35.0-SNAPSHOT~ed71fed7b3 1.35.0-SNAPSHOT~f8a29b88da
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715606791 1715606791
ci_job_id 509978427 509978427
ci_pipeline_id 34132496 34132496
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:dacapo:tomcat:iast_GLOBAL better
[-125.477µs; -42.816µs] or [-6.244%; -2.131%]		 1.925ms 2.010ms
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~f8a29b88da, baseline=1.35.0-SNAPSHOT~ed71fed7b3
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
appsec (15.285 s) : 15285000, 15285000
.   : milestone, 15285000,
iast (18.912 s) : 18912000, 18912000
.   : milestone, 18912000,
iast_GLOBAL (17.72 s) : 17720000, 17720000
.   : milestone, 17720000,
profiling (15.181 s) : 15181000, 15181000
.   : milestone, 15181000,
tracing (15.233 s) : 15233000, 15233000
.   : milestone, 15233000,
section candidate
no_agent (15.122 s) : 15122000, 15122000
.   : milestone, 15122000,
appsec (15.0 s) : 15000000, 15000000
.   : milestone, 15000000,
iast (19.055 s) : 19055000, 19055000
.   : milestone, 19055000,
iast_GLOBAL (17.996 s) : 17996000, 17996000
.   : milestone, 17996000,
profiling (15.562 s) : 15562000, 15562000
.   : milestone, 15562000,
tracing (14.955 s) : 14955000, 14955000
.   : milestone, 14955000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.988 s [14.988 s, 14.988 s] -
appsec 15.285 s [15.285 s, 15.285 s] 297.0 ms (2.0%)
iast 18.912 s [18.912 s, 18.912 s] 3.924 s (26.2%)
iast_GLOBAL 17.72 s [17.72 s, 17.72 s] 2.732 s (18.2%)
profiling 15.181 s [15.181 s, 15.181 s] 193.0 ms (1.3%)
tracing 15.233 s [15.233 s, 15.233 s] 245.0 ms (1.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.122 s [15.122 s, 15.122 s] -
appsec 15.0 s [15.0 s, 15.0 s] -122.0 ms (-0.8%)
iast 19.055 s [19.055 s, 19.055 s] 3.933 s (26.0%)
iast_GLOBAL 17.996 s [17.996 s, 17.996 s] 2.874 s (19.0%)
profiling 15.562 s [15.562 s, 15.562 s] 440.0 ms (2.9%)
tracing 14.955 s [14.955 s, 14.955 s] -167.0 ms (-1.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~f8a29b88da, baseline=1.35.0-SNAPSHOT~ed71fed7b3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.202 ms) : 2168, 2236
.   : milestone, 2202,
iast (1.969 ms) : 1928, 2010
.   : milestone, 1969,
iast_GLOBAL (2.01 ms) : 1969, 2050
.   : milestone, 2010,
profiling (1.856 ms) : 1823, 1890
.   : milestone, 1856,
tracing (1.841 ms) : 1809, 1874
.   : milestone, 1841,
section candidate
no_agent (1.473 ms) : 1461, 1485
.   : milestone, 1473,
appsec (2.213 ms) : 2179, 2247
.   : milestone, 2213,
iast (1.901 ms) : 1865, 1937
.   : milestone, 1901,
iast_GLOBAL (1.925 ms) : 1890, 1961
.   : milestone, 1925,
profiling (1.848 ms) : 1815, 1880
.   : milestone, 1848,
tracing (1.836 ms) : 1803, 1869
.   : milestone, 1836,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.202 ms [2.168 ms, 2.236 ms] 733.686 µs (50.0%)
iast 1.969 ms [1.928 ms, 2.01 ms] 501.235 µs (34.1%)
iast_GLOBAL 2.01 ms [1.969 ms, 2.05 ms] 541.518 µs (36.9%)
profiling 1.856 ms [1.823 ms, 1.89 ms] 388.295 µs (26.4%)
tracing 1.841 ms [1.809 ms, 1.874 ms] 373.151 µs (25.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.485 ms] -
appsec 2.213 ms [2.179 ms, 2.247 ms] 740.066 µs (50.2%)
iast 1.901 ms [1.865 ms, 1.937 ms] 427.775 µs (29.0%)
iast_GLOBAL 1.925 ms [1.89 ms, 1.961 ms] 452.56 µs (30.7%)
profiling 1.848 ms [1.815 ms, 1.88 ms] 374.647 µs (25.4%)
tracing 1.836 ms [1.803 ms, 1.869 ms] 363.037 µs (24.6%)

@jpbempel jpbempel merged commit 17ae744 into master May 13, 2024
81 of 82 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-debug-log-sampling branch May 13, 2024 13:38
@github-actions github-actions bot added this to the 1.35.0 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimi cimi cimi approved these changes

@ojung ojung Awaiting requested review from ojung ojung is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @cimi