Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support loading trace extensions from a comma-separated list of jars, or directories containing jars #7030

Merged
merged 1 commit into from
May 15, 2024
Merged

Support loading trace extensions from a comma-separated list of jars, or directories containing jars #7030

merged 1 commit into from
May 15, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented May 15, 2024 •
edited by jira bot
Loading

What Does This Do

Users can add trace extensions to the dd-java-agent jar at runtime by setting this environment variable:

DD_TRACE_EXTENSIONS_PATH=my_extension.jar,my_other_extensions_dir

or adding this JVM option:

-Ddd.trace.extensions.path=my_extension.jar,my_other_extensions_dir

This PR supports extensions based on InstrumenterModule; future PRs will add support for other modules.

Motivation

Provide a mechanism to add custom integrations to an existing installation of the Java tracer.

Jira ticket: APMAPI-66

@mcculls mcculls force-pushed the mcculls/support-trace-extensions branch from 40b8647 to f231e24 Compare May 15, 2024 09:22
@pr-commenter
Copy link

pr-commenter bot commented May 15, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/support-trace-extensions
git_commit_date 1715699528 1715764923
git_commit_sha 199ac65 f231e24
release_version 1.35.0-SNAPSHOT~199ac65155 1.35.0-SNAPSHOT~f231e245a9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715767726 1715767726
ci_job_id 512532993 512532993
ci_pipeline_id 34342014 34342014
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~f231e245a9, baseline=1.35.0-SNAPSHOT~199ac65155

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1078503
Total [baseline] (10.391 s) : 0, 10391199
Agent [candidate] (1.079 s) : 0, 1078756
Total [candidate] (10.424 s) : 0, 10423781
section appsec
Agent [baseline] (1.196 s) : 0, 1196327
Total [baseline] (10.472 s) : 0, 10472467
Agent [candidate] (1.202 s) : 0, 1201618
Total [candidate] (10.445 s) : 0, 10444803
section iast
Agent [baseline] (1.206 s) : 0, 1205692
Total [baseline] (10.766 s) : 0, 10766221
Agent [candidate] (1.213 s) : 0, 1213375
Total [candidate] (10.756 s) : 0, 10755534
section profiling
Agent [baseline] (1.273 s) : 0, 1273130
Total [baseline] (10.666 s) : 0, 10666255
Agent [candidate] (1.28 s) : 0, 1280124
Total [candidate] (10.638 s) : 0, 10638229
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.196 s 117.824 ms (10.9%)
Agent iast 1.206 s 127.189 ms (11.8%)
Agent profiling 1.273 s 194.627 ms (18.0%)
Total tracing 10.391 s -
Total appsec 10.472 s 81.268 ms (0.8%)
Total iast 10.766 s 375.021 ms (3.6%)
Total profiling 10.666 s 275.055 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.202 s 122.862 ms (11.4%)
Agent iast 1.213 s 134.619 ms (12.5%)
Agent profiling 1.28 s 201.367 ms (18.7%)
Total tracing 10.424 s -
Total appsec 10.445 s 21.021 ms (0.2%)
Total iast 10.756 s 331.753 ms (3.2%)
Total profiling 10.638 s 214.448 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~f231e245a9, baseline=1.35.0-SNAPSHOT~199ac65155

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.955 ms) : 0, 674955
BytebuddyAgent [candidate] (675.119 ms) : 0, 675119
GlobalTracer [baseline] (311.552 ms) : 0, 311552
GlobalTracer [candidate] (311.384 ms) : 0, 311384
AppSec [baseline] (49.382 ms) : 0, 49382
AppSec [candidate] (49.56 ms) : 0, 49560
Remote Config [baseline] (662.471 µs) : 0, 662
Remote Config [candidate] (658.099 µs) : 0, 658
Telemetry [baseline] (7.583 ms) : 0, 7583
Telemetry [candidate] (7.578 ms) : 0, 7578
section appsec
BytebuddyAgent [baseline] (696.863 ms) : 0, 696863
BytebuddyAgent [candidate] (700.817 ms) : 0, 700817
GlobalTracer [baseline] (293.786 ms) : 0, 293786
GlobalTracer [candidate] (294.73 ms) : 0, 294730
AppSec [baseline] (152.858 ms) : 0, 152858
AppSec [candidate] (152.551 ms) : 0, 152551
Remote Config [baseline] (624.063 µs) : 0, 624
Remote Config [candidate] (625.934 µs) : 0, 626
Telemetry [baseline] (8.45 ms) : 0, 8450
Telemetry [candidate] (8.775 ms) : 0, 8775
IAST [baseline] (18.891 ms) : 0, 18891
IAST [candidate] (18.923 ms) : 0, 18923
section iast
BytebuddyAgent [baseline] (798.276 ms) : 0, 798276
BytebuddyAgent [candidate] (803.708 ms) : 0, 803708
GlobalTracer [baseline] (291.108 ms) : 0, 291108
GlobalTracer [candidate] (293.212 ms) : 0, 293212
AppSec [baseline] (49.528 ms) : 0, 49528
AppSec [candidate] (50.903 ms) : 0, 50903
Remote Config [baseline] (616.747 µs) : 0, 617
Remote Config [candidate] (614.916 µs) : 0, 615
Telemetry [baseline] (7.392 ms) : 0, 7392
Telemetry [candidate] (6.63 ms) : 0, 6630
IAST [baseline] (24.419 ms) : 0, 24419
IAST [candidate] (23.717 ms) : 0, 23717
section profiling
BytebuddyAgent [baseline] (679.074 ms) : 0, 679074
BytebuddyAgent [candidate] (684.661 ms) : 0, 684661
GlobalTracer [baseline] (382.675 ms) : 0, 382675
GlobalTracer [candidate] (382.771 ms) : 0, 382771
AppSec [baseline] (50.108 ms) : 0, 50108
AppSec [candidate] (50.389 ms) : 0, 50389
Remote Config [baseline] (717.569 µs) : 0, 718
Remote Config [candidate] (715.509 µs) : 0, 716
Telemetry [baseline] (7.545 ms) : 0, 7545
Telemetry [candidate] (7.512 ms) : 0, 7512
ProfilingAgent [baseline] (96.361 ms) : 0, 96361
ProfilingAgent [candidate] (97.133 ms) : 0, 97133
Profiling [baseline] (96.384 ms) : 0, 96384
Profiling [candidate] (97.158 ms) : 0, 97158
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~f231e245a9, baseline=1.35.0-SNAPSHOT~199ac65155

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079688
Total [baseline] (8.554 s) : 0, 8553699
Agent [candidate] (1.08 s) : 0, 1080497
Total [candidate] (8.635 s) : 0, 8634840
section iast
Agent [baseline] (1.207 s) : 0, 1206708
Total [baseline] (9.072 s) : 0, 9071968
Agent [candidate] (1.208 s) : 0, 1208088
Total [candidate] (9.089 s) : 0, 9088664
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.217 s) : 0, 1216551
Total [baseline] (9.014 s) : 0, 9014005
Agent [candidate] (1.208 s) : 0, 1208087
Total [candidate] (9.008 s) : 0, 9008045
section iast_TELEMETRY_OFF
Agent [baseline] (1.211 s) : 0, 1211166
Total [baseline] (9.036 s) : 0, 9035681
Agent [candidate] (1.201 s) : 0, 1200928
Total [candidate] (9.001 s) : 0, 9001188
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.207 s 127.021 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.217 s 136.863 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.211 s 131.478 ms (12.2%)
Total tracing 8.554 s -
Total iast 9.072 s 518.269 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.014 s 460.306 ms (5.4%)
Total iast_TELEMETRY_OFF 9.036 s 481.982 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.208 s 127.591 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.208 s 127.59 ms (11.8%)
Agent iast_TELEMETRY_OFF 1.201 s 120.431 ms (11.1%)
Total tracing 8.635 s -
Total iast 9.089 s 453.825 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.008 s 373.206 ms (4.3%)
Total iast_TELEMETRY_OFF 9.001 s 366.348 ms (4.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~f231e245a9, baseline=1.35.0-SNAPSHOT~199ac65155

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.463 ms) : 0, 675463
BytebuddyAgent [candidate] (675.121 ms) : 0, 675121
GlobalTracer [baseline] (311.865 ms) : 0, 311865
GlobalTracer [candidate] (312.864 ms) : 0, 312864
AppSec [baseline] (49.717 ms) : 0, 49717
AppSec [candidate] (49.853 ms) : 0, 49853
Remote Config [baseline] (663.78 µs) : 0, 664
Remote Config [candidate] (665.113 µs) : 0, 665
Telemetry [baseline] (7.557 ms) : 0, 7557
Telemetry [candidate] (7.616 ms) : 0, 7616
section iast
BytebuddyAgent [baseline] (796.883 ms) : 0, 796883
BytebuddyAgent [candidate] (797.532 ms) : 0, 797532
GlobalTracer [baseline] (292.981 ms) : 0, 292981
GlobalTracer [candidate] (293.861 ms) : 0, 293861
AppSec [baseline] (51.162 ms) : 0, 51162
AppSec [candidate] (50.535 ms) : 0, 50535
Remote Config [baseline] (628.418 µs) : 0, 628
Remote Config [candidate] (626.833 µs) : 0, 627
Telemetry [baseline] (6.722 ms) : 0, 6722
Telemetry [candidate] (6.638 ms) : 0, 6638
IAST [baseline] (23.944 ms) : 0, 23944
IAST [candidate] (24.571 ms) : 0, 24571
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (805.562 ms) : 0, 805562
BytebuddyAgent [candidate] (799.74 ms) : 0, 799740
GlobalTracer [baseline] (293.626 ms) : 0, 293626
GlobalTracer [candidate] (292.023 ms) : 0, 292023
AppSec [baseline] (51.039 ms) : 0, 51039
AppSec [candidate] (51.209 ms) : 0, 51209
Remote Config [baseline] (619.441 µs) : 0, 619
Remote Config [candidate] (580.481 µs) : 0, 580
Telemetry [baseline] (6.757 ms) : 0, 6757
Telemetry [candidate] (6.546 ms) : 0, 6546
IAST [baseline] (24.187 ms) : 0, 24187
IAST [candidate] (23.511 ms) : 0, 23511
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.762 ms) : 0, 800762
BytebuddyAgent [candidate] (793.37 ms) : 0, 793370
GlobalTracer [baseline] (293.618 ms) : 0, 293618
GlobalTracer [candidate] (291.966 ms) : 0, 291966
AppSec [baseline] (49.673 ms) : 0, 49673
AppSec [candidate] (52.249 ms) : 0, 52249
Remote Config [baseline] (656.671 µs) : 0, 657
Remote Config [candidate] (583.114 µs) : 0, 583
Telemetry [baseline] (6.549 ms) : 0, 6549
Telemetry [candidate] (6.501 ms) : 0, 6501
IAST [baseline] (25.227 ms) : 0, 25227
IAST [candidate] (21.903 ms) : 0, 21903
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-15T09:39:35 2024-05-15T09:46:27
git_branch master mcculls/support-trace-extensions
git_commit_date 1715699528 1715764923
git_commit_sha 199ac65 f231e24
release_version 1.35.0-SNAPSHOT~199ac65155 1.35.0-SNAPSHOT~f231e245a9
start_time 2024-05-15T09:39:22 2024-05-15T09:46:13
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715766734 1715766734
ci_job_id 512532994 512532994
ci_pipeline_id 34342014 34342014
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~f231e245a9, baseline=1.35.0-SNAPSHOT~199ac65155
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.356 ms) : 1337, 1376
.   : milestone, 1356,
appsec (1.704 ms) : 1681, 1726
.   : milestone, 1704,
appsec_no_iast (1.701 ms) : 1678, 1725
.   : milestone, 1701,
iast (1.48 ms) : 1458, 1503
.   : milestone, 1480,
profiling (1.56 ms) : 1534, 1586
.   : milestone, 1560,
tracing (1.479 ms) : 1455, 1503
.   : milestone, 1479,
section candidate
no_agent (1.345 ms) : 1326, 1365
.   : milestone, 1345,
appsec (1.73 ms) : 1706, 1753
.   : milestone, 1730,
appsec_no_iast (1.728 ms) : 1704, 1752
.   : milestone, 1728,
iast (1.488 ms) : 1465, 1511
.   : milestone, 1488,
profiling (1.524 ms) : 1498, 1550
.   : milestone, 1524,
tracing (1.51 ms) : 1487, 1534
.   : milestone, 1510,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.356 ms [1.337 ms, 1.376 ms] -
appsec 1.704 ms [1.681 ms, 1.726 ms] 347.664 µs (25.6%)
appsec_no_iast 1.701 ms [1.678 ms, 1.725 ms] 345.203 µs (25.5%)
iast 1.48 ms [1.458 ms, 1.503 ms] 124.276 µs (9.2%)
profiling 1.56 ms [1.534 ms, 1.586 ms] 204.206 µs (15.1%)
tracing 1.479 ms [1.455 ms, 1.503 ms] 122.517 µs (9.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.365 ms] -
appsec 1.73 ms [1.706 ms, 1.753 ms] 384.285 µs (28.6%)
appsec_no_iast 1.728 ms [1.704 ms, 1.752 ms] 382.955 µs (28.5%)
iast 1.488 ms [1.465 ms, 1.511 ms] 142.683 µs (10.6%)
profiling 1.524 ms [1.498 ms, 1.55 ms] 178.676 µs (13.3%)
tracing 1.51 ms [1.487 ms, 1.534 ms] 165.161 µs (12.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~f231e245a9, baseline=1.35.0-SNAPSHOT~199ac65155
    dateFormat X
    axisFormat %s
section baseline
no_agent (371.214 µs) : 351, 391
.   : milestone, 371,
iast (489.186 µs) : 468, 510
.   : milestone, 489,
iast_FULL (560.768 µs) : 539, 582
.   : milestone, 561,
iast_GLOBAL (512.75 µs) : 491, 535
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (485.37 µs) : 464, 507
.   : milestone, 485,
iast_INACTIVE (458.159 µs) : 436, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (471.29 µs) : 450, 492
.   : milestone, 471,
tracing (443.841 µs) : 424, 464
.   : milestone, 444,
section candidate
no_agent (375.412 µs) : 356, 395
.   : milestone, 375,
iast (480.933 µs) : 459, 503
.   : milestone, 481,
iast_FULL (552.637 µs) : 531, 574
.   : milestone, 553,
iast_GLOBAL (509.898 µs) : 488, 532
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (486.125 µs) : 465, 508
.   : milestone, 486,
iast_INACTIVE (458.721 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (471.233 µs) : 450, 492
.   : milestone, 471,
tracing (449.227 µs) : 428, 471
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.214 µs [351.413 µs, 391.016 µs] -
iast 489.186 µs [467.89 µs, 510.482 µs] 117.972 µs (31.8%)
iast_FULL 560.768 µs [539.085 µs, 582.451 µs] 189.554 µs (51.1%)
iast_GLOBAL 512.75 µs [490.799 µs, 534.701 µs] 141.536 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED 485.37 µs [464.036 µs, 506.704 µs] 114.156 µs (30.8%)
iast_INACTIVE 458.159 µs [436.296 µs, 480.021 µs] 86.944 µs (23.4%)
iast_TELEMETRY_OFF 471.29 µs [450.27 µs, 492.311 µs] 100.076 µs (27.0%)
tracing 443.841 µs [423.53 µs, 464.153 µs] 72.627 µs (19.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.412 µs [355.968 µs, 394.856 µs] -
iast 480.933 µs [459.316 µs, 502.549 µs] 105.521 µs (28.1%)
iast_FULL 552.637 µs [531.457 µs, 573.818 µs] 177.225 µs (47.2%)
iast_GLOBAL 509.898 µs [488.271 µs, 531.525 µs] 134.486 µs (35.8%)
iast_HARDCODED_SECRET_DISABLED 486.125 µs [464.533 µs, 507.717 µs] 110.713 µs (29.5%)
iast_INACTIVE 458.721 µs [437.623 µs, 479.819 µs] 83.309 µs (22.2%)
iast_TELEMETRY_OFF 471.233 µs [450.173 µs, 492.294 µs] 95.821 µs (25.5%)
tracing 449.227 µs [427.74 µs, 470.713 µs] 73.815 µs (19.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/support-trace-extensions
git_commit_date 1715699528 1715764923
git_commit_sha 199ac65 f231e24
release_version 1.35.0-SNAPSHOT~199ac65155 1.35.0-SNAPSHOT~f231e245a9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715767242 1715767242
ci_job_id 512532995 512532995
ci_pipeline_id 34342014 34342014
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~f231e245a9, baseline=1.35.0-SNAPSHOT~199ac65155
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.45 ms) : 1439, 1461
.   : milestone, 1450,
appsec (2.189 ms) : 2155, 2223
.   : milestone, 2189,
iast (1.955 ms) : 1914, 1996
.   : milestone, 1955,
iast_GLOBAL (1.992 ms) : 1951, 2033
.   : milestone, 1992,
profiling (1.825 ms) : 1791, 1858
.   : milestone, 1825,
tracing (1.82 ms) : 1788, 1852
.   : milestone, 1820,
section candidate
no_agent (1.454 ms) : 1443, 1465
.   : milestone, 1454,
appsec (2.193 ms) : 2160, 2227
.   : milestone, 2193,
iast (1.945 ms) : 1905, 1986
.   : milestone, 1945,
iast_GLOBAL (1.979 ms) : 1938, 2019
.   : milestone, 1979,
profiling (1.833 ms) : 1800, 1865
.   : milestone, 1833,
tracing (1.821 ms) : 1789, 1853
.   : milestone, 1821,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.45 ms [1.439 ms, 1.461 ms] -
appsec 2.189 ms [2.155 ms, 2.223 ms] 739.212 µs (51.0%)
iast 1.955 ms [1.914 ms, 1.996 ms] 504.648 µs (34.8%)
iast_GLOBAL 1.992 ms [1.951 ms, 2.033 ms] 542.042 µs (37.4%)
profiling 1.825 ms [1.791 ms, 1.858 ms] 374.513 µs (25.8%)
tracing 1.82 ms [1.788 ms, 1.852 ms] 370.18 µs (25.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.454 ms [1.443 ms, 1.465 ms] -
appsec 2.193 ms [2.16 ms, 2.227 ms] 739.395 µs (50.9%)
iast 1.945 ms [1.905 ms, 1.986 ms] 491.493 µs (33.8%)
iast_GLOBAL 1.979 ms [1.938 ms, 2.019 ms] 524.513 µs (36.1%)
profiling 1.833 ms [1.8 ms, 1.865 ms] 378.715 µs (26.0%)
tracing 1.821 ms [1.789 ms, 1.853 ms] 367.204 µs (25.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~f231e245a9, baseline=1.35.0-SNAPSHOT~199ac65155
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.031 s) : 15031000, 15031000
.   : milestone, 15031000,
appsec (14.81 s) : 14810000, 14810000
.   : milestone, 14810000,
iast (19.085 s) : 19085000, 19085000
.   : milestone, 19085000,
iast_GLOBAL (17.774 s) : 17774000, 17774000
.   : milestone, 17774000,
profiling (15.033 s) : 15033000, 15033000
.   : milestone, 15033000,
tracing (15.259 s) : 15259000, 15259000
.   : milestone, 15259000,
section candidate
no_agent (15.466 s) : 15466000, 15466000
.   : milestone, 15466000,
appsec (14.99 s) : 14990000, 14990000
.   : milestone, 14990000,
iast (18.879 s) : 18879000, 18879000
.   : milestone, 18879000,
iast_GLOBAL (17.717 s) : 17717000, 17717000
.   : milestone, 17717000,
profiling (15.159 s) : 15159000, 15159000
.   : milestone, 15159000,
tracing (15.221 s) : 15221000, 15221000
.   : milestone, 15221000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.031 s [15.031 s, 15.031 s] -
appsec 14.81 s [14.81 s, 14.81 s] -221.0 ms (-1.5%)
iast 19.085 s [19.085 s, 19.085 s] 4.054 s (27.0%)
iast_GLOBAL 17.774 s [17.774 s, 17.774 s] 2.743 s (18.2%)
profiling 15.033 s [15.033 s, 15.033 s] 2.0 ms (0.0%)
tracing 15.259 s [15.259 s, 15.259 s] 228.0 ms (1.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.466 s [15.466 s, 15.466 s] -
appsec 14.99 s [14.99 s, 14.99 s] -476.0 ms (-3.1%)
iast 18.879 s [18.879 s, 18.879 s] 3.413 s (22.1%)
iast_GLOBAL 17.717 s [17.717 s, 17.717 s] 2.251 s (14.6%)
profiling 15.159 s [15.159 s, 15.159 s] -307.0 ms (-2.0%)
tracing 15.221 s [15.221 s, 15.221 s] -245.0 ms (-1.6%)

@mcculls mcculls marked this pull request as ready for review May 15, 2024 09:53
@mcculls mcculls requested a review from a team as a code owner May 15, 2024 09:53
@mcculls mcculls requested review from PerfectSlayer and am312 May 15, 2024 09:53
PerfectSlayer
PerfectSlayer approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update our instrumentation guides and reference notes to reflect this new feature?

dd-trace-api/src/main/java/datadog/trace/api/config/TraceInstrumentationConfig.java Show resolved Hide resolved
@mcculls mcculls merged commit 3e1ef9f into master May 15, 2024
80 checks passed
@mcculls mcculls deleted the mcculls/support-trace-extensions branch May 15, 2024 13:22
@github-actions github-actions bot added this to the 1.35.0 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core type: feature request
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @PerfectSlayer