Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gradle instrumentation: do not fail if Jacoco excluded CL list is immutable #7044

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix Gradle instrumentation: do not fail if Jacoco excluded CL list is immutable #7044

merged 1 commit into from
May 17, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented May 16, 2024 •
edited by jira bot
Loading

What Does This Do

Fixes CI Visibility's Gradle instrumentation: if the instrumentation determines that Gradle Jacoco plugin is used in the instrumented project, it modifies Jacoco's list of ignored classloaders (the main reason is to add the tracer's classloader to the list to avoid instrumenting tracer classes).
It is possible for the modified list to be immutable, in which case it needs to be replaced with a newly constructed list.

Jira ticket: CIVIS-10049

@nikita-tkachenko-datadog nikita-tkachenko-datadog added type: bug comp: ci visibility Continuous Integration Visibility labels May 16, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 16, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/fix-gradle-instrumentation-immutabe-cl-list
git_commit_date 1715875335 1715877101
git_commit_sha 3eb2828 4ecbde7
release_version 1.35.0-SNAPSHOT~3eb2828b6a 1.35.0-SNAPSHOT~4ecbde78d7
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715879707 1715879707
ci_job_id 514431230 514431230
ci_pipeline_id 34475643 34475643
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~4ecbde78d7, baseline=1.35.0-SNAPSHOT~3eb2828b6a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077804
Total [baseline] (10.294 s) : 0, 10293800
Agent [candidate] (1.078 s) : 0, 1078096
Total [candidate] (10.43 s) : 0, 10429920
section appsec
Agent [baseline] (1.204 s) : 0, 1204211
Total [baseline] (10.516 s) : 0, 10515610
Agent [candidate] (1.196 s) : 0, 1195754
Total [candidate] (10.564 s) : 0, 10564101
section iast
Agent [baseline] (1.205 s) : 0, 1205323
Total [baseline] (10.811 s) : 0, 10811265
Agent [candidate] (1.203 s) : 0, 1203288
Total [candidate] (10.78 s) : 0, 10780047
section profiling
Agent [baseline] (1.272 s) : 0, 1272342
Total [baseline] (10.651 s) : 0, 10650924
Agent [candidate] (1.271 s) : 0, 1271078
Total [candidate] (10.652 s) : 0, 10651762
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.204 s 126.408 ms (11.7%)
Agent iast 1.205 s 127.519 ms (11.8%)
Agent profiling 1.272 s 194.538 ms (18.0%)
Total tracing 10.294 s -
Total appsec 10.516 s 221.81 ms (2.2%)
Total iast 10.811 s 517.465 ms (5.0%)
Total profiling 10.651 s 357.124 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.196 s 117.658 ms (10.9%)
Agent iast 1.203 s 125.192 ms (11.6%)
Agent profiling 1.271 s 192.982 ms (17.9%)
Total tracing 10.43 s -
Total appsec 10.564 s 134.181 ms (1.3%)
Total iast 10.78 s 350.127 ms (3.4%)
Total profiling 10.652 s 221.842 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~4ecbde78d7, baseline=1.35.0-SNAPSHOT~3eb2828b6a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.792 ms) : 0, 675792
BytebuddyAgent [candidate] (675.85 ms) : 0, 675850
GlobalTracer [baseline] (309.819 ms) : 0, 309819
GlobalTracer [candidate] (310.073 ms) : 0, 310073
AppSec [baseline] (49.648 ms) : 0, 49648
AppSec [candidate] (49.454 ms) : 0, 49454
Remote Config [baseline] (653.132 µs) : 0, 653
Remote Config [candidate] (660.393 µs) : 0, 660
Telemetry [baseline] (7.467 ms) : 0, 7467
Telemetry [candidate] (7.64 ms) : 0, 7640
section appsec
BytebuddyAgent [baseline] (701.674 ms) : 0, 701674
BytebuddyAgent [candidate] (696.756 ms) : 0, 696756
GlobalTracer [baseline] (295.247 ms) : 0, 295247
GlobalTracer [candidate] (293.629 ms) : 0, 293629
AppSec [baseline] (153.358 ms) : 0, 153358
AppSec [candidate] (152.498 ms) : 0, 152498
IAST [baseline] (19.128 ms) : 0, 19128
IAST [candidate] (18.864 ms) : 0, 18864
Remote Config [baseline] (620.004 µs) : 0, 620
Remote Config [candidate] (617.343 µs) : 0, 617
Telemetry [baseline] (9.124 ms) : 0, 9124
Telemetry [candidate] (8.385 ms) : 0, 8385
section iast
BytebuddyAgent [baseline] (797.933 ms) : 0, 797933
BytebuddyAgent [candidate] (796.209 ms) : 0, 796209
GlobalTracer [baseline] (290.984 ms) : 0, 290984
GlobalTracer [candidate] (290.641 ms) : 0, 290641
AppSec [baseline] (49.66 ms) : 0, 49660
AppSec [candidate] (49.443 ms) : 0, 49443
IAST [baseline] (24.477 ms) : 0, 24477
IAST [candidate] (25.365 ms) : 0, 25365
Remote Config [baseline] (599.76 µs) : 0, 600
Remote Config [candidate] (645.458 µs) : 0, 645
Telemetry [baseline] (7.307 ms) : 0, 7307
Telemetry [candidate] (6.667 ms) : 0, 6667
section profiling
BytebuddyAgent [baseline] (678.159 ms) : 0, 678159
BytebuddyAgent [candidate] (678.152 ms) : 0, 678152
GlobalTracer [baseline] (383.06 ms) : 0, 383060
GlobalTracer [candidate] (382.028 ms) : 0, 382028
AppSec [baseline] (50.171 ms) : 0, 50171
AppSec [candidate] (50.302 ms) : 0, 50302
Remote Config [baseline] (694.935 µs) : 0, 695
Remote Config [candidate] (696.875 µs) : 0, 697
Telemetry [baseline] (7.4 ms) : 0, 7400
Telemetry [candidate] (7.441 ms) : 0, 7441
ProfilingAgent [baseline] (96.397 ms) : 0, 96397
ProfilingAgent [candidate] (96.133 ms) : 0, 96133
Profiling [baseline] (96.421 ms) : 0, 96421
Profiling [candidate] (96.157 ms) : 0, 96157
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~4ecbde78d7, baseline=1.35.0-SNAPSHOT~3eb2828b6a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084936
Total [baseline] (8.593 s) : 0, 8593094
Agent [candidate] (1.084 s) : 0, 1083502
Total [candidate] (8.594 s) : 0, 8594097
section iast
Agent [baseline] (1.201 s) : 0, 1200638
Total [baseline] (9.011 s) : 0, 9011155
Agent [candidate] (1.203 s) : 0, 1203334
Total [candidate] (9.018 s) : 0, 9018137
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.203 s) : 0, 1202843
Total [baseline] (8.978 s) : 0, 8977591
Agent [candidate] (1.203 s) : 0, 1203118
Total [candidate] (8.988 s) : 0, 8988151
section iast_TELEMETRY_OFF
Agent [baseline] (1.21 s) : 0, 1210461
Total [baseline] (9.022 s) : 0, 9021897
Agent [candidate] (1.216 s) : 0, 1216440
Total [candidate] (9.067 s) : 0, 9066596
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.085 s -
Agent iast 1.201 s 115.702 ms (10.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.203 s 117.907 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.21 s 125.525 ms (11.6%)
Total tracing 8.593 s -
Total iast 9.011 s 418.061 ms (4.9%)
Total iast_HARDCODED_SECRET_DISABLED 8.978 s 384.498 ms (4.5%)
Total iast_TELEMETRY_OFF 9.022 s 428.804 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent iast 1.203 s 119.833 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.203 s 119.616 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.216 s 132.938 ms (12.3%)
Total tracing 8.594 s -
Total iast 9.018 s 424.041 ms (4.9%)
Total iast_HARDCODED_SECRET_DISABLED 8.988 s 394.054 ms (4.6%)
Total iast_TELEMETRY_OFF 9.067 s 472.499 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~4ecbde78d7, baseline=1.35.0-SNAPSHOT~3eb2828b6a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.798 ms) : 0, 679798
BytebuddyAgent [candidate] (679.346 ms) : 0, 679346
GlobalTracer [baseline] (312.433 ms) : 0, 312433
GlobalTracer [candidate] (311.562 ms) : 0, 311562
AppSec [baseline] (49.804 ms) : 0, 49804
AppSec [candidate] (49.697 ms) : 0, 49697
Remote Config [baseline] (665.414 µs) : 0, 665
Remote Config [candidate] (670.09 µs) : 0, 670
Telemetry [baseline] (7.597 ms) : 0, 7597
Telemetry [candidate] (7.638 ms) : 0, 7638
section iast
BytebuddyAgent [baseline] (794.511 ms) : 0, 794511
BytebuddyAgent [candidate] (795.777 ms) : 0, 795777
GlobalTracer [baseline] (290.311 ms) : 0, 290311
GlobalTracer [candidate] (291.071 ms) : 0, 291071
AppSec [baseline] (51.549 ms) : 0, 51549
AppSec [candidate] (50.253 ms) : 0, 50253
IAST [baseline] (22.779 ms) : 0, 22779
IAST [candidate] (24.704 ms) : 0, 24704
Remote Config [baseline] (607.436 µs) : 0, 607
Remote Config [candidate] (593.5 µs) : 0, 593
Telemetry [baseline] (6.61 ms) : 0, 6610
Telemetry [candidate] (6.606 ms) : 0, 6606
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (796.432 ms) : 0, 796432
BytebuddyAgent [candidate] (797.107 ms) : 0, 797107
GlobalTracer [baseline] (290.652 ms) : 0, 290652
GlobalTracer [candidate] (290.342 ms) : 0, 290342
AppSec [baseline] (52.014 ms) : 0, 52014
AppSec [candidate] (50.805 ms) : 0, 50805
IAST [baseline] (22.058 ms) : 0, 22058
IAST [candidate] (23.411 ms) : 0, 23411
Remote Config [baseline] (594.254 µs) : 0, 594
Remote Config [candidate] (581.265 µs) : 0, 581
Telemetry [baseline] (6.661 ms) : 0, 6661
Telemetry [candidate] (6.56 ms) : 0, 6560
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (800.475 ms) : 0, 800475
BytebuddyAgent [candidate] (804.586 ms) : 0, 804586
GlobalTracer [baseline] (293.228 ms) : 0, 293228
GlobalTracer [candidate] (294.731 ms) : 0, 294731
AppSec [baseline] (51.26 ms) : 0, 51260
AppSec [candidate] (49.214 ms) : 0, 49214
IAST [baseline] (22.039 ms) : 0, 22039
IAST [candidate] (24.363 ms) : 0, 24363
Remote Config [baseline] (605.332 µs) : 0, 605
Remote Config [candidate] (602.789 µs) : 0, 603
Telemetry [baseline] (8.203 ms) : 0, 8203
Telemetry [candidate] (8.02 ms) : 0, 8020
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-16T16:45:52 2024-05-16T16:52:43
git_branch master nikita-tkachenko/fix-gradle-instrumentation-immutabe-cl-list
git_commit_date 1715875335 1715877101
git_commit_sha 3eb2828 4ecbde7
release_version 1.35.0-SNAPSHOT~3eb2828b6a 1.35.0-SNAPSHOT~4ecbde78d7
start_time 2024-05-16T16:45:39 2024-05-16T16:52:30
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715878708 1715878708
ci_job_id 514431231 514431231
ci_pipeline_id 34475643 34475643
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~4ecbde78d7, baseline=1.35.0-SNAPSHOT~3eb2828b6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (367.361 µs) : 347, 388
.   : milestone, 367,
iast (483.462 µs) : 462, 505
.   : milestone, 483,
iast_FULL (552.128 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (516.87 µs) : 494, 540
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (481.538 µs) : 460, 503
.   : milestone, 482,
iast_INACTIVE (462.035 µs) : 440, 484
.   : milestone, 462,
iast_TELEMETRY_OFF (465.531 µs) : 445, 486
.   : milestone, 466,
tracing (439.418 µs) : 419, 460
.   : milestone, 439,
section candidate
no_agent (370.497 µs) : 351, 390
.   : milestone, 370,
iast (477.675 µs) : 457, 499
.   : milestone, 478,
iast_FULL (549.803 µs) : 529, 571
.   : milestone, 550,
iast_GLOBAL (501.289 µs) : 480, 522
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (476.305 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (456.617 µs) : 435, 479
.   : milestone, 457,
iast_TELEMETRY_OFF (481.585 µs) : 460, 504
.   : milestone, 482,
tracing (439.551 µs) : 419, 460
.   : milestone, 440,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.361 µs [346.819 µs, 387.903 µs] -
iast 483.462 µs [462.123 µs, 504.8 µs] 116.101 µs (31.6%)
iast_FULL 552.128 µs [530.923 µs, 573.333 µs] 184.767 µs (50.3%)
iast_GLOBAL 516.87 µs [493.659 µs, 540.081 µs] 149.509 µs (40.7%)
iast_HARDCODED_SECRET_DISABLED 481.538 µs [460.438 µs, 502.639 µs] 114.177 µs (31.1%)
iast_INACTIVE 462.035 µs [439.733 µs, 484.337 µs] 94.674 µs (25.8%)
iast_TELEMETRY_OFF 465.531 µs [444.639 µs, 486.423 µs] 98.17 µs (26.7%)
tracing 439.418 µs [419.02 µs, 459.817 µs] 72.057 µs (19.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.497 µs [351.189 µs, 389.806 µs] -
iast 477.675 µs [456.524 µs, 498.826 µs] 107.178 µs (28.9%)
iast_FULL 549.803 µs [528.64 µs, 570.966 µs] 179.306 µs (48.4%)
iast_GLOBAL 501.289 µs [480.225 µs, 522.354 µs] 130.792 µs (35.3%)
iast_HARDCODED_SECRET_DISABLED 476.305 µs [455.473 µs, 497.137 µs] 105.808 µs (28.6%)
iast_INACTIVE 456.617 µs [434.58 µs, 478.654 µs] 86.12 µs (23.2%)
iast_TELEMETRY_OFF 481.585 µs [459.521 µs, 503.649 µs] 111.088 µs (30.0%)
tracing 439.551 µs [419.43 µs, 459.672 µs] 69.054 µs (18.6%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~4ecbde78d7, baseline=1.35.0-SNAPSHOT~3eb2828b6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1375
.   : milestone, 1355,
appsec (1.712 ms) : 1689, 1734
.   : milestone, 1712,
appsec_no_iast (1.722 ms) : 1698, 1746
.   : milestone, 1722,
iast (1.472 ms) : 1449, 1495
.   : milestone, 1472,
profiling (1.528 ms) : 1502, 1553
.   : milestone, 1528,
tracing (1.481 ms) : 1457, 1504
.   : milestone, 1481,
section candidate
no_agent (1.338 ms) : 1319, 1357
.   : milestone, 1338,
appsec (1.701 ms) : 1677, 1725
.   : milestone, 1701,
appsec_no_iast (1.72 ms) : 1696, 1744
.   : milestone, 1720,
iast (1.471 ms) : 1448, 1493
.   : milestone, 1471,
profiling (1.548 ms) : 1522, 1575
.   : milestone, 1548,
tracing (1.453 ms) : 1429, 1477
.   : milestone, 1453,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.335 ms, 1.375 ms] -
appsec 1.712 ms [1.689 ms, 1.734 ms] 356.838 µs (26.3%)
appsec_no_iast 1.722 ms [1.698 ms, 1.746 ms] 366.891 µs (27.1%)
iast 1.472 ms [1.449 ms, 1.495 ms] 117.258 µs (8.7%)
profiling 1.528 ms [1.502 ms, 1.553 ms] 172.703 µs (12.7%)
tracing 1.481 ms [1.457 ms, 1.504 ms] 125.696 µs (9.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.319 ms, 1.357 ms] -
appsec 1.701 ms [1.677 ms, 1.725 ms] 362.983 µs (27.1%)
appsec_no_iast 1.72 ms [1.696 ms, 1.744 ms] 382.125 µs (28.6%)
iast 1.471 ms [1.448 ms, 1.493 ms] 132.654 µs (9.9%)
profiling 1.548 ms [1.522 ms, 1.575 ms] 210.603 µs (15.7%)
tracing 1.453 ms [1.429 ms, 1.477 ms] 115.384 µs (8.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/fix-gradle-instrumentation-immutabe-cl-list
git_commit_date 1715875335 1715877101
git_commit_sha 3eb2828 4ecbde7
release_version 1.35.0-SNAPSHOT~3eb2828b6a 1.35.0-SNAPSHOT~4ecbde78d7
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715879199 1715879199
ci_job_id 514431232 514431232
ci_pipeline_id 34475643 34475643
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~4ecbde78d7, baseline=1.35.0-SNAPSHOT~3eb2828b6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.509 s) : 15509000, 15509000
.   : milestone, 15509000,
appsec (15.178 s) : 15178000, 15178000
.   : milestone, 15178000,
iast (18.725 s) : 18725000, 18725000
.   : milestone, 18725000,
iast_GLOBAL (17.72 s) : 17720000, 17720000
.   : milestone, 17720000,
profiling (15.443 s) : 15443000, 15443000
.   : milestone, 15443000,
tracing (14.886 s) : 14886000, 14886000
.   : milestone, 14886000,
section candidate
no_agent (15.145 s) : 15145000, 15145000
.   : milestone, 15145000,
appsec (15.216 s) : 15216000, 15216000
.   : milestone, 15216000,
iast (18.717 s) : 18717000, 18717000
.   : milestone, 18717000,
iast_GLOBAL (17.793 s) : 17793000, 17793000
.   : milestone, 17793000,
profiling (14.783 s) : 14783000, 14783000
.   : milestone, 14783000,
tracing (15.041 s) : 15041000, 15041000
.   : milestone, 15041000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.509 s [15.509 s, 15.509 s] -
appsec 15.178 s [15.178 s, 15.178 s] -331.0 ms (-2.1%)
iast 18.725 s [18.725 s, 18.725 s] 3.216 s (20.7%)
iast_GLOBAL 17.72 s [17.72 s, 17.72 s] 2.211 s (14.3%)
profiling 15.443 s [15.443 s, 15.443 s] -66.0 ms (-0.4%)
tracing 14.886 s [14.886 s, 14.886 s] -623.0 ms (-4.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.145 s [15.145 s, 15.145 s] -
appsec 15.216 s [15.216 s, 15.216 s] 71.0 ms (0.5%)
iast 18.717 s [18.717 s, 18.717 s] 3.572 s (23.6%)
iast_GLOBAL 17.793 s [17.793 s, 17.793 s] 2.648 s (17.5%)
profiling 14.783 s [14.783 s, 14.783 s] -362.0 ms (-2.4%)
tracing 15.041 s [15.041 s, 15.041 s] -104.0 ms (-0.7%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~4ecbde78d7, baseline=1.35.0-SNAPSHOT~3eb2828b6a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1450, 1473
.   : milestone, 1461,
appsec (2.199 ms) : 2165, 2233
.   : milestone, 2199,
iast (1.969 ms) : 1928, 2010
.   : milestone, 1969,
iast_GLOBAL (1.995 ms) : 1954, 2036
.   : milestone, 1995,
profiling (1.842 ms) : 1810, 1875
.   : milestone, 1842,
tracing (1.833 ms) : 1801, 1865
.   : milestone, 1833,
section candidate
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.2 ms) : 2166, 2234
.   : milestone, 2200,
iast (1.96 ms) : 1919, 2001
.   : milestone, 1960,
iast_GLOBAL (2.001 ms) : 1960, 2042
.   : milestone, 2001,
profiling (1.848 ms) : 1816, 1881
.   : milestone, 1848,
tracing (1.83 ms) : 1798, 1862
.   : milestone, 1830,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.45 ms, 1.473 ms] -
appsec 2.199 ms [2.165 ms, 2.233 ms] 737.539 µs (50.5%)
iast 1.969 ms [1.928 ms, 2.01 ms] 507.902 µs (34.8%)
iast_GLOBAL 1.995 ms [1.954 ms, 2.036 ms] 533.987 µs (36.5%)
profiling 1.842 ms [1.81 ms, 1.875 ms] 381.127 µs (26.1%)
tracing 1.833 ms [1.801 ms, 1.865 ms] 371.645 µs (25.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.462 ms [1.45 ms, 1.473 ms] -
appsec 2.2 ms [2.166 ms, 2.234 ms] 738.292 µs (50.5%)
iast 1.96 ms [1.919 ms, 2.001 ms] 498.689 µs (34.1%)
iast_GLOBAL 2.001 ms [1.96 ms, 2.042 ms] 539.304 µs (36.9%)
profiling 1.848 ms [1.816 ms, 1.881 ms] 386.817 µs (26.5%)
tracing 1.83 ms [1.798 ms, 1.862 ms] 368.491 µs (25.2%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review May 16, 2024 19:33
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner May 16, 2024 19:33
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit e59015b into master May 17, 2024
82 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/fix-gradle-instrumentation-immutabe-cl-list branch May 17, 2024 09:06
@github-actions github-actions bot added this to the 1.35.0 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmarchenko anmarchenko anmarchenko approved these changes

@tonyredondo tonyredondo tonyredondo approved these changes

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility type: bug
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nikita-tkachenko-datadog @tonyredondo @anmarchenko