-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use backend parameters for histograms #7050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
reviewed
May 20, 2024
dd-trace-core/src/main/java/datadog/trace/core/histogram/Histograms.java
Show resolved
Hide resolved
mcculls
approved these changes
May 20, 2024
kr-igor
approved these changes
May 20, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~824461cee6, baseline=1.35.0-RC1~64a0120d55
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058577
Total [baseline] (8.564 s) : 0, 8563819
Agent [candidate] (1.058 s) : 0, 1058455
Total [candidate] (8.523 s) : 0, 8522902
section iast
Agent [baseline] (1.164 s) : 0, 1163808
Total [baseline] (8.993 s) : 0, 8993378
Agent [candidate] (1.169 s) : 0, 1168512
Total [candidate] (9.012 s) : 0, 9011537
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1168892
Total [baseline] (9.026 s) : 0, 9026161
Agent [candidate] (1.167 s) : 0, 1166968
Total [candidate] (9.016 s) : 0, 9016042
section iast_TELEMETRY_OFF
Agent [baseline] (1.165 s) : 0, 1164907
Total [baseline] (9.005 s) : 0, 9004803
Agent [candidate] (1.163 s) : 0, 1162567
Total [candidate] (9.039 s) : 0, 9039156
gantt
title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~824461cee6, baseline=1.35.0-RC1~64a0120d55
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (652.024 ms) : 0, 652024
BytebuddyAgent [candidate] (651.815 ms) : 0, 651815
GlobalTracer [baseline] (313.659 ms) : 0, 313659
GlobalTracer [candidate] (313.855 ms) : 0, 313855
AppSec [baseline] (50.15 ms) : 0, 50150
AppSec [candidate] (50.228 ms) : 0, 50228
Remote Config [baseline] (756.386 µs) : 0, 756
Remote Config [candidate] (712.169 µs) : 0, 712
Telemetry [baseline] (7.633 ms) : 0, 7633
Telemetry [candidate] (7.515 ms) : 0, 7515
section iast
BytebuddyAgent [baseline] (775.804 ms) : 0, 775804
BytebuddyAgent [candidate] (779.424 ms) : 0, 779424
GlobalTracer [baseline] (292.478 ms) : 0, 292478
GlobalTracer [candidate] (293.84 ms) : 0, 293840
AppSec [baseline] (46.37 ms) : 0, 46370
AppSec [candidate] (46.739 ms) : 0, 46739
IAST [baseline] (27.79 ms) : 0, 27790
IAST [candidate] (26.965 ms) : 0, 26965
Remote Config [baseline] (574.226 µs) : 0, 574
Remote Config [candidate] (589.508 µs) : 0, 590
Telemetry [baseline] (7.585 ms) : 0, 7585
Telemetry [candidate] (7.644 ms) : 0, 7644
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.481 ms) : 0, 779481
BytebuddyAgent [candidate] (779.031 ms) : 0, 779031
GlobalTracer [baseline] (293.61 ms) : 0, 293610
GlobalTracer [candidate] (293.562 ms) : 0, 293562
AppSec [baseline] (46.602 ms) : 0, 46602
AppSec [candidate] (46.594 ms) : 0, 46594
IAST [baseline] (26.134 ms) : 0, 26134
IAST [candidate] (25.408 ms) : 0, 25408
Remote Config [baseline] (585.955 µs) : 0, 586
Remote Config [candidate] (580.752 µs) : 0, 581
Telemetry [baseline] (9.167 ms) : 0, 9167
Telemetry [candidate] (8.463 ms) : 0, 8463
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.504 ms) : 0, 776504
BytebuddyAgent [candidate] (775.724 ms) : 0, 775724
GlobalTracer [baseline] (293.818 ms) : 0, 293818
GlobalTracer [candidate] (294.231 ms) : 0, 294231
AppSec [baseline] (49.565 ms) : 0, 49565
AppSec [candidate] (47.238 ms) : 0, 47238
IAST [baseline] (23.592 ms) : 0, 23592
IAST [candidate] (24.613 ms) : 0, 24613
Remote Config [baseline] (579.092 µs) : 0, 579
Remote Config [candidate] (581.804 µs) : 0, 582
Telemetry [baseline] (7.535 ms) : 0, 7535
Telemetry [candidate] (6.872 ms) : 0, 6872
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~824461cee6, baseline=1.35.0-RC1~64a0120d55
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068819
Total [baseline] (10.436 s) : 0, 10435789
Agent [candidate] (1.056 s) : 0, 1055876
Total [candidate] (10.347 s) : 0, 10347183
section appsec
Agent [baseline] (1.176 s) : 0, 1176043
Total [baseline] (10.472 s) : 0, 10471894
Agent [candidate] (1.18 s) : 0, 1180307
Total [candidate] (10.492 s) : 0, 10492233
section iast
Agent [baseline] (1.168 s) : 0, 1167636
Total [baseline] (10.745 s) : 0, 10744830
Agent [candidate] (1.172 s) : 0, 1171663
Total [candidate] (10.758 s) : 0, 10757865
section profiling
Agent [baseline] (1.261 s) : 0, 1261039
Total [baseline] (10.684 s) : 0, 10684096
Agent [candidate] (1.267 s) : 0, 1267164
Total [candidate] (10.655 s) : 0, 10654580
gantt
title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~824461cee6, baseline=1.35.0-RC1~64a0120d55
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (657.54 ms) : 0, 657540
BytebuddyAgent [candidate] (650.73 ms) : 0, 650730
GlobalTracer [baseline] (317.344 ms) : 0, 317344
GlobalTracer [candidate] (312.911 ms) : 0, 312911
AppSec [baseline] (50.874 ms) : 0, 50874
AppSec [candidate] (49.741 ms) : 0, 49741
Remote Config [baseline] (724.627 µs) : 0, 725
Remote Config [candidate] (725.452 µs) : 0, 725
Telemetry [baseline] (7.685 ms) : 0, 7685
Telemetry [candidate] (7.507 ms) : 0, 7507
section appsec
BytebuddyAgent [baseline] (674.007 ms) : 0, 674007
BytebuddyAgent [candidate] (676.511 ms) : 0, 676511
GlobalTracer [baseline] (296.198 ms) : 0, 296198
GlobalTracer [candidate] (296.777 ms) : 0, 296777
AppSec [baseline] (153.076 ms) : 0, 153076
AppSec [candidate] (152.903 ms) : 0, 152903
IAST [baseline] (21.719 ms) : 0, 21719
IAST [candidate] (23.554 ms) : 0, 23554
Remote Config [baseline] (662.054 µs) : 0, 662
Remote Config [candidate] (683.55 µs) : 0, 684
Telemetry [baseline] (6.85 ms) : 0, 6850
Telemetry [candidate] (7.166 ms) : 0, 7166
section iast
BytebuddyAgent [baseline] (778.506 ms) : 0, 778506
BytebuddyAgent [candidate] (780.158 ms) : 0, 780158
GlobalTracer [baseline] (293.966 ms) : 0, 293966
GlobalTracer [candidate] (294.789 ms) : 0, 294789
AppSec [baseline] (46.344 ms) : 0, 46344
AppSec [candidate] (47.036 ms) : 0, 47036
IAST [baseline] (27.439 ms) : 0, 27439
IAST [candidate] (28.905 ms) : 0, 28905
Remote Config [baseline] (573.821 µs) : 0, 574
Remote Config [candidate] (588.164 µs) : 0, 588
Telemetry [baseline] (7.614 ms) : 0, 7614
Telemetry [candidate] (6.925 ms) : 0, 6925
section profiling
BytebuddyAgent [baseline] (662.801 ms) : 0, 662801
BytebuddyAgent [candidate] (665.666 ms) : 0, 665666
GlobalTracer [baseline] (386.331 ms) : 0, 386331
GlobalTracer [candidate] (388.276 ms) : 0, 388276
AppSec [baseline] (50.879 ms) : 0, 50879
AppSec [candidate] (51.003 ms) : 0, 51003
Remote Config [baseline] (788.914 µs) : 0, 789
Remote Config [candidate] (782.491 µs) : 0, 782
Telemetry [baseline] (7.363 ms) : 0, 7363
Telemetry [candidate] (7.379 ms) : 0, 7379
ProfilingAgent [baseline] (96.291 ms) : 0, 96291
ProfilingAgent [candidate] (97.337 ms) : 0, 97337
Profiling [baseline] (96.316 ms) : 0, 96316
Profiling [candidate] (97.361 ms) : 0, 97361
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 22 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~824461cee6, baseline=1.35.0-RC1~64a0120d55
dateFormat X
axisFormat %s
section baseline
no_agent (451.8 µs) : 423, 481
. : milestone, 452,
iast (587.044 µs) : 556, 618
. : milestone, 587,
iast_FULL (676.71 µs) : 645, 709
. : milestone, 677,
iast_GLOBAL (615.207 µs) : 584, 647
. : milestone, 615,
iast_HARDCODED_SECRET_DISABLED (582.601 µs) : 552, 614
. : milestone, 583,
iast_INACTIVE (557.714 µs) : 526, 589
. : milestone, 558,
iast_TELEMETRY_OFF (579.525 µs) : 548, 611
. : milestone, 580,
tracing (542.027 µs) : 512, 572
. : milestone, 542,
section candidate
no_agent (454.986 µs) : 426, 484
. : milestone, 455,
iast (584.137 µs) : 552, 616
. : milestone, 584,
iast_FULL (689.463 µs) : 657, 722
. : milestone, 689,
iast_GLOBAL (614.935 µs) : 583, 647
. : milestone, 615,
iast_HARDCODED_SECRET_DISABLED (586.663 µs) : 555, 618
. : milestone, 587,
iast_INACTIVE (554.097 µs) : 523, 586
. : milestone, 554,
iast_TELEMETRY_OFF (576.741 µs) : 545, 608
. : milestone, 577,
tracing (538.192 µs) : 508, 568
. : milestone, 538,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~824461cee6, baseline=1.35.0-RC1~64a0120d55
dateFormat X
axisFormat %s
section baseline
no_agent (1.713 ms) : 1688, 1739
. : milestone, 1713,
appsec (2.189 ms) : 2158, 2221
. : milestone, 2189,
appsec_no_iast (2.19 ms) : 2158, 2222
. : milestone, 2190,
iast (1.891 ms) : 1862, 1920
. : milestone, 1891,
profiling (1.964 ms) : 1927, 2000
. : milestone, 1964,
tracing (1.88 ms) : 1848, 1913
. : milestone, 1880,
section candidate
no_agent (1.706 ms) : 1681, 1731
. : milestone, 1706,
appsec (2.18 ms) : 2149, 2210
. : milestone, 2180,
appsec_no_iast (2.158 ms) : 2126, 2190
. : milestone, 2158,
iast (1.919 ms) : 1889, 1949
. : milestone, 1919,
profiling (1.951 ms) : 1915, 1987
. : milestone, 1951,
tracing (1.877 ms) : 1845, 1908
. : milestone, 1877,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~824461cee6, baseline=1.35.0-RC1~64a0120d55
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.214 ms) : 2179, 2248
. : milestone, 2214,
iast (1.964 ms) : 1923, 2005
. : milestone, 1964,
iast_GLOBAL (2.007 ms) : 1966, 2049
. : milestone, 2007,
profiling (1.851 ms) : 1817, 1884
. : milestone, 1851,
tracing (1.84 ms) : 1808, 1872
. : milestone, 1840,
section candidate
no_agent (1.462 ms) : 1451, 1474
. : milestone, 1462,
appsec (2.196 ms) : 2162, 2230
. : milestone, 2196,
iast (1.962 ms) : 1921, 2003
. : milestone, 1962,
iast_GLOBAL (1.995 ms) : 1954, 2035
. : milestone, 1995,
profiling (1.862 ms) : 1827, 1897
. : milestone, 1862,
tracing (1.82 ms) : 1789, 1852
. : milestone, 1820,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~824461cee6, baseline=1.35.0-RC1~64a0120d55
dateFormat X
axisFormat %s
section baseline
no_agent (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
appsec (15.213 s) : 15213000, 15213000
. : milestone, 15213000,
iast (18.857 s) : 18857000, 18857000
. : milestone, 18857000,
iast_GLOBAL (17.891 s) : 17891000, 17891000
. : milestone, 17891000,
profiling (14.979 s) : 14979000, 14979000
. : milestone, 14979000,
tracing (15.18 s) : 15180000, 15180000
. : milestone, 15180000,
section candidate
no_agent (15.469 s) : 15469000, 15469000
. : milestone, 15469000,
appsec (15.107 s) : 15107000, 15107000
. : milestone, 15107000,
iast (19.13 s) : 19130000, 19130000
. : milestone, 19130000,
iast_GLOBAL (18.032 s) : 18032000, 18032000
. : milestone, 18032000,
profiling (14.847 s) : 14847000, 14847000
. : milestone, 14847000,
tracing (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
|
PerfectSlayer
changed the title
data streams: Use backend parameters for histograms
Use backend parameters for histograms
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Update parameters of histograms to skip a conversion in the backend, that is impacting relative accuracy and is pretty costly.
Additional Notes
Jira ticket: [PROJ-IDENT]