Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report exception when deserializing config #7092

Merged
merged 1 commit into from
May 31, 2024
Merged

Report exception when deserializing config #7092

merged 1 commit into from
May 31, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented May 30, 2024 •
edited by jira bot
Loading

What Does This Do

Send probe diagnostic messages when an error occurred during config deserialization (compatibility issue, unsupported feature, malformed json, parsing bug)

Motivation

Report error to the user

Additional Notes

Jira ticket: DEBUG-2418

@jpbempel
Report exception when deserializing config
e9626a5 
Send probe diagnostic messages when an error occurred during config
deserialization (compatibility issue, unsupported feature, malformed
json, parsing bug)
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label May 30, 2024
@jpbempel jpbempel requested a review from a team as a code owner May 30, 2024 10:43
@jpbempel jpbempel requested review from shatzi and removed request for a team May 30, 2024 10:43
@pr-commenter
Copy link

pr-commenter bot commented May 30, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/report-error-on-config-error
git_commit_date 1717061093 1717065742
git_commit_sha 4b5cad9 e9626a5
release_version 1.35.0-SNAPSHOT~4b5cad9604 1.35.0-SNAPSHOT~e9626a524b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717068411 1717068411
ci_job_id 527065153 527065153
ci_pipeline_id 35442153 35442153
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~e9626a524b, baseline=1.35.0-SNAPSHOT~4b5cad9604

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056756
Total [baseline] (8.548 s) : 0, 8548322
Agent [candidate] (1.062 s) : 0, 1061549
Total [candidate] (8.58 s) : 0, 8580076
section iast
Agent [baseline] (1.178 s) : 0, 1177571
Total [baseline] (9.047 s) : 0, 9047138
Agent [candidate] (1.184 s) : 0, 1183894
Total [candidate] (8.995 s) : 0, 8994765
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.164 s) : 0, 1164054
Total [baseline] (8.96 s) : 0, 8960355
Agent [candidate] (1.201 s) : 0, 1200916
Total [candidate] (9.012 s) : 0, 9011885
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168582
Total [baseline] (8.984 s) : 0, 8984454
Agent [candidate] (1.187 s) : 0, 1187178
Total [candidate] (8.991 s) : 0, 8990914
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.178 s 120.814 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.164 s 107.298 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.169 s 111.825 ms (10.6%)
Total tracing 8.548 s -
Total iast 9.047 s 498.817 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.96 s 412.034 ms (4.8%)
Total iast_TELEMETRY_OFF 8.984 s 436.132 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.184 s 122.344 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.201 s 139.367 ms (13.1%)
Agent iast_TELEMETRY_OFF 1.187 s 125.629 ms (11.8%)
Total tracing 8.58 s -
Total iast 8.995 s 414.688 ms (4.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.012 s 431.809 ms (5.0%)
Total iast_TELEMETRY_OFF 8.991 s 410.838 ms (4.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~e9626a524b, baseline=1.35.0-SNAPSHOT~4b5cad9604

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (652.124 ms) : 0, 652124
BytebuddyAgent [candidate] (655.549 ms) : 0, 655549
GlobalTracer [baseline] (311.904 ms) : 0, 311904
GlobalTracer [candidate] (313.47 ms) : 0, 313470
AppSec [baseline] (49.947 ms) : 0, 49947
AppSec [candidate] (49.721 ms) : 0, 49721
Remote Config [baseline] (662.331 µs) : 0, 662
Remote Config [candidate] (671.553 µs) : 0, 672
Telemetry [baseline] (7.579 ms) : 0, 7579
Telemetry [candidate] (7.629 ms) : 0, 7629
section iast
BytebuddyAgent [baseline] (788.521 ms) : 0, 788521
BytebuddyAgent [candidate] (776.242 ms) : 0, 776242
GlobalTracer [baseline] (295.042 ms) : 0, 295042
GlobalTracer [candidate] (291.816 ms) : 0, 291816
AppSec [baseline] (49.76 ms) : 0, 49760
AppSec [candidate] (47.291 ms) : 0, 47291
IAST [baseline] (23.249 ms) : 0, 23249
IAST [candidate] (26.269 ms) : 0, 26269
Remote Config [baseline] (604.894 µs) : 0, 605
Remote Config [candidate] (594.074 µs) : 0, 594
Telemetry [baseline] (6.993 ms) : 0, 6993
Telemetry [candidate] (7.334 ms) : 0, 7334
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (776.485 ms) : 0, 776485
BytebuddyAgent [candidate] (787.806 ms) : 0, 787806
GlobalTracer [baseline] (291.365 ms) : 0, 291365
GlobalTracer [candidate] (295.999 ms) : 0, 295999
AppSec [baseline] (49.018 ms) : 0, 49018
AppSec [candidate] (48.31 ms) : 0, 48310
IAST [baseline] (24.961 ms) : 0, 24961
IAST [candidate] (25.845 ms) : 0, 25845
Remote Config [baseline] (590.962 µs) : 0, 591
Remote Config [candidate] (600.894 µs) : 0, 601
Telemetry [baseline] (8.347 ms) : 0, 8347
Telemetry [candidate] (7.479 ms) : 0, 7479
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.746 ms) : 0, 779746
BytebuddyAgent [candidate] (777.519 ms) : 0, 777519
GlobalTracer [baseline] (293.174 ms) : 0, 293174
GlobalTracer [candidate] (293.916 ms) : 0, 293916
AppSec [baseline] (49.798 ms) : 0, 49798
AppSec [candidate] (53.183 ms) : 0, 53183
IAST [baseline] (22.879 ms) : 0, 22879
IAST [candidate] (21.171 ms) : 0, 21171
Remote Config [baseline] (579.976 µs) : 0, 580
Remote Config [candidate] (582.719 µs) : 0, 583
Telemetry [baseline] (9.045 ms) : 0, 9045
Telemetry [candidate] (6.446 ms) : 0, 6446
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~e9626a524b, baseline=1.35.0-SNAPSHOT~4b5cad9604

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055918
Total [baseline] (10.303 s) : 0, 10303228
Agent [candidate] (1.063 s) : 0, 1062733
Total [candidate] (10.419 s) : 0, 10419183
section appsec
Agent [baseline] (1.174 s) : 0, 1173540
Total [baseline] (10.462 s) : 0, 10461798
Agent [candidate] (1.177 s) : 0, 1176936
Total [candidate] (10.49 s) : 0, 10490319
section iast
Agent [baseline] (1.168 s) : 0, 1167822
Total [baseline] (10.786 s) : 0, 10785823
Agent [candidate] (1.187 s) : 0, 1187172
Total [candidate] (10.809 s) : 0, 10808894
section profiling
Agent [baseline] (1.258 s) : 0, 1257987
Total [baseline] (10.569 s) : 0, 10569394
Agent [candidate] (1.273 s) : 0, 1273202
Total [candidate] (10.589 s) : 0, 10589340
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.174 s 117.622 ms (11.1%)
Agent iast 1.168 s 111.904 ms (10.6%)
Agent profiling 1.258 s 202.069 ms (19.1%)
Total tracing 10.303 s -
Total appsec 10.462 s 158.571 ms (1.5%)
Total iast 10.786 s 482.595 ms (4.7%)
Total profiling 10.569 s 266.166 ms (2.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.177 s 114.203 ms (10.7%)
Agent iast 1.187 s 124.439 ms (11.7%)
Agent profiling 1.273 s 210.469 ms (19.8%)
Total tracing 10.419 s -
Total appsec 10.49 s 71.136 ms (0.7%)
Total iast 10.809 s 389.711 ms (3.7%)
Total profiling 10.589 s 170.157 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~e9626a524b, baseline=1.35.0-SNAPSHOT~4b5cad9604

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (652.002 ms) : 0, 652002
BytebuddyAgent [candidate] (655.714 ms) : 0, 655714
GlobalTracer [baseline] (311.806 ms) : 0, 311806
GlobalTracer [candidate] (314.219 ms) : 0, 314219
AppSec [baseline] (49.546 ms) : 0, 49546
AppSec [candidate] (49.834 ms) : 0, 49834
Remote Config [baseline] (662.095 µs) : 0, 662
Remote Config [candidate] (679.661 µs) : 0, 680
Telemetry [baseline] (7.603 ms) : 0, 7603
Telemetry [candidate] (7.687 ms) : 0, 7687
section appsec
BytebuddyAgent [baseline] (673.089 ms) : 0, 673089
BytebuddyAgent [candidate] (675.578 ms) : 0, 675578
GlobalTracer [baseline] (295.133 ms) : 0, 295133
GlobalTracer [candidate] (296.013 ms) : 0, 296013
AppSec [baseline] (152.618 ms) : 0, 152618
AppSec [candidate] (153.002 ms) : 0, 153002
IAST [baseline] (18.688 ms) : 0, 18688
IAST [candidate] (18.84 ms) : 0, 18840
Remote Config [baseline] (614.568 µs) : 0, 615
Remote Config [candidate] (633.544 µs) : 0, 634
Telemetry [baseline] (8.371 ms) : 0, 8371
Telemetry [candidate] (7.78 ms) : 0, 7780
section iast
BytebuddyAgent [baseline] (782.123 ms) : 0, 782123
BytebuddyAgent [candidate] (778.187 ms) : 0, 778187
GlobalTracer [baseline] (291.621 ms) : 0, 291621
GlobalTracer [candidate] (292.727 ms) : 0, 292727
AppSec [baseline] (48.626 ms) : 0, 48626
AppSec [candidate] (49.963 ms) : 0, 49963
IAST [baseline] (23.944 ms) : 0, 23944
IAST [candidate] (23.969 ms) : 0, 23969
Remote Config [baseline] (595.709 µs) : 0, 596
Remote Config [candidate] (590.176 µs) : 0, 590
Telemetry [baseline] (7.65 ms) : 0, 7650
Telemetry [candidate] (7.362 ms) : 0, 7362
section profiling
BytebuddyAgent [baseline] (661.575 ms) : 0, 661575
BytebuddyAgent [candidate] (670.863 ms) : 0, 670863
GlobalTracer [baseline] (385.622 ms) : 0, 385622
GlobalTracer [candidate] (388.567 ms) : 0, 388567
AppSec [baseline] (50.374 ms) : 0, 50374
AppSec [candidate] (51.099 ms) : 0, 51099
Remote Config [baseline] (910.131 µs) : 0, 910
Remote Config [candidate] (812.502 µs) : 0, 813
Telemetry [baseline] (7.476 ms) : 0, 7476
Telemetry [candidate] (7.534 ms) : 0, 7534
ProfilingAgent [baseline] (95.491 ms) : 0, 95491
ProfilingAgent [candidate] (97.046 ms) : 0, 97046
Profiling [baseline] (95.516 ms) : 0, 95516
Profiling [candidate] (97.07 ms) : 0, 97070
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-30T10:57:33 2024-05-30T11:04:20
git_branch master jpbempel/report-error-on-config-error
git_commit_date 1717061093 1717065742
git_commit_sha 4b5cad9 e9626a5
release_version 1.35.0-SNAPSHOT~4b5cad9604 1.35.0-SNAPSHOT~e9626a524b
start_time 2024-05-30T10:57:20 2024-05-30T11:04:07
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717067403 1717067403
ci_job_id 527065154 527065154
ci_pipeline_id 35442153 35442153
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~e9626a524b, baseline=1.35.0-SNAPSHOT~4b5cad9604
    dateFormat X
    axisFormat %s
section baseline
no_agent (370.337 µs) : 350, 390
.   : milestone, 370,
iast (477.923 µs) : 457, 499
.   : milestone, 478,
iast_FULL (538.622 µs) : 518, 559
.   : milestone, 539,
iast_GLOBAL (503.43 µs) : 482, 525
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (473.687 µs) : 453, 495
.   : milestone, 474,
iast_INACTIVE (446.468 µs) : 426, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (468.883 µs) : 447, 490
.   : milestone, 469,
tracing (435.137 µs) : 415, 455
.   : milestone, 435,
section candidate
no_agent (361.837 µs) : 341, 382
.   : milestone, 362,
iast (475.519 µs) : 455, 496
.   : milestone, 476,
iast_FULL (546.803 µs) : 526, 568
.   : milestone, 547,
iast_GLOBAL (498.392 µs) : 478, 519
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (479.383 µs) : 457, 502
.   : milestone, 479,
iast_INACTIVE (446.117 µs) : 425, 467
.   : milestone, 446,
iast_TELEMETRY_OFF (476.781 µs) : 454, 500
.   : milestone, 477,
tracing (440.883 µs) : 420, 462
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.337 µs [350.399 µs, 390.274 µs] -
iast 477.923 µs [456.747 µs, 499.099 µs] 107.586 µs (29.1%)
iast_FULL 538.622 µs [517.748 µs, 559.495 µs] 168.285 µs (45.4%)
iast_GLOBAL 503.43 µs [481.767 µs, 525.093 µs] 133.093 µs (35.9%)
iast_HARDCODED_SECRET_DISABLED 473.687 µs [452.742 µs, 494.632 µs] 103.351 µs (27.9%)
iast_INACTIVE 446.468 µs [425.683 µs, 467.252 µs] 76.131 µs (20.6%)
iast_TELEMETRY_OFF 468.883 µs [447.293 µs, 490.473 µs] 98.547 µs (26.6%)
tracing 435.137 µs [414.91 µs, 455.365 µs] 64.801 µs (17.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.837 µs [341.192 µs, 382.482 µs] -
iast 475.519 µs [454.56 µs, 496.478 µs] 113.682 µs (31.4%)
iast_FULL 546.803 µs [525.632 µs, 567.974 µs] 184.966 µs (51.1%)
iast_GLOBAL 498.392 µs [477.564 µs, 519.22 µs] 136.555 µs (37.7%)
iast_HARDCODED_SECRET_DISABLED 479.383 µs [457.214 µs, 501.551 µs] 117.545 µs (32.5%)
iast_INACTIVE 446.117 µs [425.307 µs, 466.926 µs] 84.28 µs (23.3%)
iast_TELEMETRY_OFF 476.781 µs [453.748 µs, 499.815 µs] 114.944 µs (31.8%)
tracing 440.883 µs [419.764 µs, 462.002 µs] 79.046 µs (21.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~e9626a524b, baseline=1.35.0-SNAPSHOT~4b5cad9604
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.348 ms) : 1328, 1367
.   : milestone, 1348,
appsec (1.706 ms) : 1681, 1731
.   : milestone, 1706,
appsec_no_iast (1.716 ms) : 1691, 1740
.   : milestone, 1716,
iast (1.464 ms) : 1441, 1486
.   : milestone, 1464,
profiling (1.471 ms) : 1447, 1495
.   : milestone, 1471,
tracing (1.486 ms) : 1463, 1510
.   : milestone, 1486,
section candidate
no_agent (1.34 ms) : 1320, 1359
.   : milestone, 1340,
appsec (1.702 ms) : 1678, 1727
.   : milestone, 1702,
appsec_no_iast (1.687 ms) : 1662, 1712
.   : milestone, 1687,
iast (1.467 ms) : 1444, 1489
.   : milestone, 1467,
profiling (1.521 ms) : 1495, 1546
.   : milestone, 1521,
tracing (1.459 ms) : 1434, 1483
.   : milestone, 1459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.348 ms [1.328 ms, 1.367 ms] -
appsec 1.706 ms [1.681 ms, 1.731 ms] 358.335 µs (26.6%)
appsec_no_iast 1.716 ms [1.691 ms, 1.74 ms] 367.974 µs (27.3%)
iast 1.464 ms [1.441 ms, 1.486 ms] 116.115 µs (8.6%)
profiling 1.471 ms [1.447 ms, 1.495 ms] 123.223 µs (9.1%)
tracing 1.486 ms [1.463 ms, 1.51 ms] 138.658 µs (10.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.34 ms [1.32 ms, 1.359 ms] -
appsec 1.702 ms [1.678 ms, 1.727 ms] 362.595 µs (27.1%)
appsec_no_iast 1.687 ms [1.662 ms, 1.712 ms] 347.186 µs (25.9%)
iast 1.467 ms [1.444 ms, 1.489 ms] 126.882 µs (9.5%)
profiling 1.521 ms [1.495 ms, 1.546 ms] 180.764 µs (13.5%)
tracing 1.459 ms [1.434 ms, 1.483 ms] 118.697 µs (8.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/report-error-on-config-error
git_commit_date 1717061093 1717065742
git_commit_sha 4b5cad9 e9626a5
release_version 1.35.0-SNAPSHOT~4b5cad9604 1.35.0-SNAPSHOT~e9626a524b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717067922 1717067922
ci_job_id 527065155 527065155
ci_pipeline_id 35442153 35442153
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~e9626a524b, baseline=1.35.0-SNAPSHOT~4b5cad9604
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.152 s) : 15152000, 15152000
.   : milestone, 15152000,
appsec (15.041 s) : 15041000, 15041000
.   : milestone, 15041000,
iast (18.671 s) : 18671000, 18671000
.   : milestone, 18671000,
iast_GLOBAL (17.838 s) : 17838000, 17838000
.   : milestone, 17838000,
profiling (15.427 s) : 15427000, 15427000
.   : milestone, 15427000,
tracing (15.285 s) : 15285000, 15285000
.   : milestone, 15285000,
section candidate
no_agent (15.159 s) : 15159000, 15159000
.   : milestone, 15159000,
appsec (15.056 s) : 15056000, 15056000
.   : milestone, 15056000,
iast (18.547 s) : 18547000, 18547000
.   : milestone, 18547000,
iast_GLOBAL (17.856 s) : 17856000, 17856000
.   : milestone, 17856000,
profiling (15.535 s) : 15535000, 15535000
.   : milestone, 15535000,
tracing (15.094 s) : 15094000, 15094000
.   : milestone, 15094000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.152 s [15.152 s, 15.152 s] -
appsec 15.041 s [15.041 s, 15.041 s] -111.0 ms (-0.7%)
iast 18.671 s [18.671 s, 18.671 s] 3.519 s (23.2%)
iast_GLOBAL 17.838 s [17.838 s, 17.838 s] 2.686 s (17.7%)
profiling 15.427 s [15.427 s, 15.427 s] 275.0 ms (1.8%)
tracing 15.285 s [15.285 s, 15.285 s] 133.0 ms (0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.159 s [15.159 s, 15.159 s] -
appsec 15.056 s [15.056 s, 15.056 s] -103.0 ms (-0.7%)
iast 18.547 s [18.547 s, 18.547 s] 3.388 s (22.3%)
iast_GLOBAL 17.856 s [17.856 s, 17.856 s] 2.697 s (17.8%)
profiling 15.535 s [15.535 s, 15.535 s] 376.0 ms (2.5%)
tracing 15.094 s [15.094 s, 15.094 s] -65.0 ms (-0.4%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~e9626a524b, baseline=1.35.0-SNAPSHOT~4b5cad9604
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.457 ms) : 1446, 1468
.   : milestone, 1457,
appsec (2.204 ms) : 2169, 2239
.   : milestone, 2204,
iast (1.959 ms) : 1918, 2001
.   : milestone, 1959,
iast_GLOBAL (1.996 ms) : 1954, 2038
.   : milestone, 1996,
profiling (1.834 ms) : 1801, 1866
.   : milestone, 1834,
tracing (1.822 ms) : 1791, 1854
.   : milestone, 1822,
section candidate
no_agent (1.455 ms) : 1444, 1466
.   : milestone, 1455,
appsec (2.202 ms) : 2168, 2236
.   : milestone, 2202,
iast (1.956 ms) : 1915, 1996
.   : milestone, 1956,
iast_GLOBAL (1.995 ms) : 1954, 2035
.   : milestone, 1995,
profiling (1.843 ms) : 1810, 1877
.   : milestone, 1843,
tracing (1.82 ms) : 1788, 1852
.   : milestone, 1820,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.468 ms] -
appsec 2.204 ms [2.169 ms, 2.239 ms] 747.078 µs (51.3%)
iast 1.959 ms [1.918 ms, 2.001 ms] 502.332 µs (34.5%)
iast_GLOBAL 1.996 ms [1.954 ms, 2.038 ms] 539.185 µs (37.0%)
profiling 1.834 ms [1.801 ms, 1.866 ms] 376.793 µs (25.9%)
tracing 1.822 ms [1.791 ms, 1.854 ms] 365.438 µs (25.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.466 ms] -
appsec 2.202 ms [2.168 ms, 2.236 ms] 747.079 µs (51.3%)
iast 1.956 ms [1.915 ms, 1.996 ms] 500.547 µs (34.4%)
iast_GLOBAL 1.995 ms [1.954 ms, 2.035 ms] 539.857 µs (37.1%)
profiling 1.843 ms [1.81 ms, 1.877 ms] 388.441 µs (26.7%)
tracing 1.82 ms [1.788 ms, 1.852 ms] 364.818 µs (25.1%)

shatzi
shatzi approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@shatzi shatzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also want to write error this to telemetry?

@jpbempel
Copy link
Member Author

jpbempel commented May 31, 2024 •
edited
Loading

should we also want to write error this to telemetry?

because we are logging the exception with:
LOGGER.warn("Error handling probe configuration: {}", configId, ex);
it is also send to telemetry

@jpbempel jpbempel merged commit 11a1f41 into master May 31, 2024
83 checks passed
@jpbempel jpbempel deleted the jpbempel/report-error-on-config-error branch May 31, 2024 09:19
@github-actions github-actions bot added this to the 1.35.0 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @shatzi