Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps opentracing-tracerresolver to 0.1.6 #7093

Merged
merged 1 commit into from
May 30, 2024

Conversation

fedefernandez
Copy link
Contributor

What Does This Do

Bumps io.opentracing.contrib:opentracing-tracerresolver version to 0.1.6

Motivation

Current version (0.1.0) depends on opentracing-api 0.21.0 while the project depends on opentracing-api 0.32.0.

Setting dependency version to 0.1.6 aligns the opentracing-api version.

Additional Notes

<opentracing-api.version>0.32.0</opentracing-api.version>

@PerfectSlayer PerfectSlayer added tag: dependencies Dependencies related changes comp: opentracing OpenTracing tag: community Community contribution labels May 30, 2024
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fedefernandez

Thanks for your contribution.
I checked at the history and it seems like we bumped OpenTracing dependencies from 0.30.0 to 0.32.0 without upgrading opentracing-tracerresolver from this commit: c5288e1#diff-b2705df3687d801b9e491dd8e2d0b45c588fda6de93e2a2794d4e58b25f46929

Thanks for spotting the issue!
I am curious to know how did you find it in the first place?

@fedefernandez
Copy link
Contributor Author

fedefernandez commented May 30, 2024

Thanks for spotting the issue!
I am curious to know how did you find it in the first place?

No problem! We're using the library in our Scala projects and SBT highlighted the conflict with the Eviction Warning feature.

The message we get in our projects is:

[warn] Found version conflict(s) in library dependencies; some are suspected to be binary incompatible:
[warn] 	* io.opentracing:opentracing-api:0.32.0 is selected over 0.21.0
[warn] 	    +- com.datadoghq:dd-trace-ot:1.34.0                   (depends on 0.32.0)
[warn] 	    +- io.opentracing:opentracing-util:0.32.0             (depends on 0.32.0)
[warn] 	    +- io.opentracing:opentracing-noop:0.32.0             (depends on 0.32.0)
[warn] 	    +- io.opentracing.contrib:opentracing-tracerresolver:0.1.0 (depends on 0.21.0)

BTW, the build is failing with the following:

Caused by: org.gradle.process.internal.ExecException: Process 'command '/home/circleci/dd-trace-java/mvnw'' finished with non-zero exit value 1

Is there something I need to update? Thank you!

@mcculls
Copy link
Contributor

mcculls commented May 30, 2024

@fedefernandez system test failures are expected for external PRs - I updated the branch to pull in the latest changes from master which should address the other failures.

@mcculls mcculls marked this pull request as ready for review May 30, 2024 16:02
@mcculls mcculls requested a review from a team as a code owner May 30, 2024 16:02
@mcculls mcculls requested review from mcculls and nayeem-kamal May 30, 2024 16:02
@mcculls mcculls merged commit 7791fa9 into DataDog:master May 30, 2024
55 of 68 checks passed
@bm1549 bm1549 added this to the 1.35.0 milestone May 30, 2024
@fedefernandez fedefernandez deleted the patch-1 branch May 31, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: opentracing OpenTracing tag: community Community contribution tag: dependencies Dependencies related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants