-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not gather coverage for skippable tests #7139
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/itr-no-coverage-for-skippable-tests
Jun 7, 2024
Merged
Do not gather coverage for skippable tests #7139
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/itr-no-coverage-for-skippable-tests
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
tag: performance
Performance related changes
comp: ci visibility
Continuous Integration Visibility
labels
Jun 7, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 18 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~b58dc72569, baseline=1.36.0-SNAPSHOT~edb2c3fa17
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075847
Total [baseline] (10.404 s) : 0, 10404191
Agent [candidate] (1.064 s) : 0, 1063811
Total [candidate] (10.323 s) : 0, 10322905
section appsec
Agent [baseline] (1.185 s) : 0, 1185338
Total [baseline] (10.551 s) : 0, 10551353
Agent [candidate] (1.183 s) : 0, 1183080
Total [candidate] (10.563 s) : 0, 10563312
section iast
Agent [baseline] (1.169 s) : 0, 1168891
Total [baseline] (10.731 s) : 0, 10731301
Agent [candidate] (1.178 s) : 0, 1177580
Total [candidate] (10.676 s) : 0, 10676327
section profiling
Agent [baseline] (1.261 s) : 0, 1260523
Total [baseline] (10.744 s) : 0, 10743650
Agent [candidate] (1.267 s) : 0, 1267360
Total [candidate] (10.706 s) : 0, 10705828
gantt
title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~b58dc72569, baseline=1.36.0-SNAPSHOT~edb2c3fa17
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.092 ms) : 0, 674092
BytebuddyAgent [candidate] (665.882 ms) : 0, 665882
GlobalTracer [baseline] (307.47 ms) : 0, 307470
GlobalTracer [candidate] (304.401 ms) : 0, 304401
AppSec [baseline] (50.623 ms) : 0, 50623
AppSec [candidate] (50.3 ms) : 0, 50300
Logs Intake [baseline] (391.993 µs) : 0, 392
Logs Intake [candidate] (390.615 µs) : 0, 391
Remote Config [baseline] (685.751 µs) : 0, 686
Remote Config [candidate] (698.04 µs) : 0, 698
Telemetry [baseline] (7.667 ms) : 0, 7667
Telemetry [candidate] (7.635 ms) : 0, 7635
section appsec
BytebuddyAgent [baseline] (678.596 ms) : 0, 678596
BytebuddyAgent [candidate] (678.051 ms) : 0, 678051
GlobalTracer [baseline] (298.965 ms) : 0, 298965
GlobalTracer [candidate] (298.202 ms) : 0, 298202
AppSec [baseline] (153.934 ms) : 0, 153934
AppSec [candidate] (153.398 ms) : 0, 153398
Logs Intake [baseline] (336.735 µs) : 0, 337
Logs Intake [candidate] (334.612 µs) : 0, 335
Remote Config [baseline] (653.405 µs) : 0, 653
Remote Config [candidate] (634.632 µs) : 0, 635
Telemetry [baseline] (7.278 ms) : 0, 7278
Telemetry [candidate] (7.562 ms) : 0, 7562
IAST [baseline] (22.027 ms) : 0, 22027
IAST [candidate] (20.744 ms) : 0, 20744
section iast
BytebuddyAgent [baseline] (779.096 ms) : 0, 779096
BytebuddyAgent [candidate] (784.88 ms) : 0, 784880
GlobalTracer [baseline] (293.556 ms) : 0, 293556
GlobalTracer [candidate] (295.438 ms) : 0, 295438
AppSec [baseline] (47.321 ms) : 0, 47321
AppSec [candidate] (47.575 ms) : 0, 47575
Logs Intake [baseline] (302.153 µs) : 0, 302
Logs Intake [candidate] (304.994 µs) : 0, 305
Remote Config [baseline] (566.296 µs) : 0, 566
Remote Config [candidate] (566.494 µs) : 0, 566
Telemetry [baseline] (8.389 ms) : 0, 8389
Telemetry [candidate] (7.632 ms) : 0, 7632
IAST [baseline] (26.422 ms) : 0, 26422
IAST [candidate] (27.826 ms) : 0, 27826
section profiling
BytebuddyAgent [baseline] (662.46 ms) : 0, 662460
BytebuddyAgent [candidate] (666.593 ms) : 0, 666593
GlobalTracer [baseline] (386.072 ms) : 0, 386072
GlobalTracer [candidate] (388.483 ms) : 0, 388483
AppSec [baseline] (50.823 ms) : 0, 50823
AppSec [candidate] (51.135 ms) : 0, 51135
Logs Intake [baseline] (329.188 µs) : 0, 329
Logs Intake [candidate] (331.202 µs) : 0, 331
Remote Config [baseline] (732.16 µs) : 0, 732
Remote Config [candidate] (754.39 µs) : 0, 754
Telemetry [baseline] (7.291 ms) : 0, 7291
Telemetry [candidate] (7.37 ms) : 0, 7370
ProfilingAgent [baseline] (96.225 ms) : 0, 96225
ProfilingAgent [candidate] (95.77 ms) : 0, 95770
Profiling [baseline] (96.25 ms) : 0, 96250
Profiling [candidate] (95.794 ms) : 0, 95794
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~b58dc72569, baseline=1.36.0-SNAPSHOT~edb2c3fa17
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060194
Total [baseline] (8.56 s) : 0, 8560242
Agent [candidate] (1.06 s) : 0, 1060039
Total [candidate] (8.542 s) : 0, 8541845
section iast
Agent [baseline] (1.168 s) : 0, 1167964
Total [baseline] (8.993 s) : 0, 8992878
Agent [candidate] (1.175 s) : 0, 1175482
Total [candidate] (9.03 s) : 0, 9029652
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175866
Total [baseline] (9.012 s) : 0, 9012096
Agent [candidate] (1.171 s) : 0, 1170651
Total [candidate] (9.0 s) : 0, 8999965
section iast_TELEMETRY_OFF
Agent [baseline] (1.161 s) : 0, 1161370
Total [baseline] (9.03 s) : 0, 9029637
Agent [candidate] (1.173 s) : 0, 1172511
Total [candidate] (9.005 s) : 0, 9004831
gantt
title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~b58dc72569, baseline=1.36.0-SNAPSHOT~edb2c3fa17
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (663.569 ms) : 0, 663569
BytebuddyAgent [candidate] (663.85 ms) : 0, 663850
GlobalTracer [baseline] (303.814 ms) : 0, 303814
GlobalTracer [candidate] (303.378 ms) : 0, 303378
AppSec [baseline] (50.023 ms) : 0, 50023
AppSec [candidate] (49.896 ms) : 0, 49896
Logs Intake [baseline] (404.583 µs) : 0, 405
Logs Intake [candidate] (405.54 µs) : 0, 406
Remote Config [baseline] (662.54 µs) : 0, 663
Remote Config [candidate] (666.142 µs) : 0, 666
Telemetry [baseline] (7.489 ms) : 0, 7489
Telemetry [candidate] (7.501 ms) : 0, 7501
section iast
BytebuddyAgent [baseline] (778.357 ms) : 0, 778357
BytebuddyAgent [candidate] (784.347 ms) : 0, 784347
GlobalTracer [baseline] (292.873 ms) : 0, 292873
GlobalTracer [candidate] (295.006 ms) : 0, 295006
AppSec [baseline] (46.897 ms) : 0, 46897
AppSec [candidate] (47.195 ms) : 0, 47195
IAST [baseline] (26.45 ms) : 0, 26450
IAST [candidate] (27.002 ms) : 0, 27002
Logs Intake [baseline] (303.91 µs) : 0, 304
Logs Intake [candidate] (319.05 µs) : 0, 319
Remote Config [baseline] (575.986 µs) : 0, 576
Remote Config [candidate] (605.506 µs) : 0, 606
Telemetry [baseline] (9.229 ms) : 0, 9229
Telemetry [candidate] (7.633 ms) : 0, 7633
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (783.759 ms) : 0, 783759
BytebuddyAgent [candidate] (780.762 ms) : 0, 780762
GlobalTracer [baseline] (295.206 ms) : 0, 295206
GlobalTracer [candidate] (294.417 ms) : 0, 294417
AppSec [baseline] (47.057 ms) : 0, 47057
AppSec [candidate] (46.54 ms) : 0, 46540
IAST [baseline] (28.571 ms) : 0, 28571
IAST [candidate] (27.089 ms) : 0, 27089
Logs Intake [baseline] (306.829 µs) : 0, 307
Logs Intake [candidate] (301.89 µs) : 0, 302
Remote Config [baseline] (582.422 µs) : 0, 582
Remote Config [candidate] (573.863 µs) : 0, 574
Telemetry [baseline] (6.966 ms) : 0, 6966
Telemetry [candidate] (7.603 ms) : 0, 7603
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (774.656 ms) : 0, 774656
BytebuddyAgent [candidate] (781.807 ms) : 0, 781807
GlobalTracer [baseline] (293.155 ms) : 0, 293155
GlobalTracer [candidate] (295.755 ms) : 0, 295755
AppSec [baseline] (49.126 ms) : 0, 49126
AppSec [candidate] (50.774 ms) : 0, 50774
IAST [baseline] (22.718 ms) : 0, 22718
IAST [candidate] (22.457 ms) : 0, 22457
Logs Intake [baseline] (299.141 µs) : 0, 299
Logs Intake [candidate] (297.473 µs) : 0, 297
Remote Config [baseline] (562.487 µs) : 0, 562
Remote Config [candidate] (553.55 µs) : 0, 554
Telemetry [baseline] (7.534 ms) : 0, 7534
Telemetry [candidate] (7.439 ms) : 0, 7439
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~b58dc72569, baseline=1.36.0-SNAPSHOT~edb2c3fa17
dateFormat X
axisFormat %s
section baseline
no_agent (371.181 µs) : 352, 391
. : milestone, 371,
iast (480.125 µs) : 459, 501
. : milestone, 480,
iast_FULL (550.13 µs) : 529, 571
. : milestone, 550,
iast_GLOBAL (503.7 µs) : 482, 526
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (479.744 µs) : 458, 501
. : milestone, 480,
iast_INACTIVE (449.11 µs) : 428, 470
. : milestone, 449,
iast_TELEMETRY_OFF (474.676 µs) : 453, 496
. : milestone, 475,
tracing (442.181 µs) : 422, 463
. : milestone, 442,
section candidate
no_agent (374.921 µs) : 354, 396
. : milestone, 375,
iast (480.168 µs) : 459, 502
. : milestone, 480,
iast_FULL (551.792 µs) : 530, 573
. : milestone, 552,
iast_GLOBAL (506.088 µs) : 484, 528
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (481.838 µs) : 460, 503
. : milestone, 482,
iast_INACTIVE (443.553 µs) : 423, 464
. : milestone, 444,
iast_TELEMETRY_OFF (472.546 µs) : 451, 494
. : milestone, 473,
tracing (445.106 µs) : 424, 466
. : milestone, 445,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~b58dc72569, baseline=1.36.0-SNAPSHOT~edb2c3fa17
dateFormat X
axisFormat %s
section baseline
no_agent (1.358 ms) : 1339, 1377
. : milestone, 1358,
appsec (1.728 ms) : 1704, 1751
. : milestone, 1728,
appsec_no_iast (1.727 ms) : 1702, 1751
. : milestone, 1727,
iast (1.481 ms) : 1457, 1505
. : milestone, 1481,
profiling (1.51 ms) : 1485, 1534
. : milestone, 1510,
tracing (1.462 ms) : 1438, 1486
. : milestone, 1462,
section candidate
no_agent (1.346 ms) : 1327, 1366
. : milestone, 1346,
appsec (1.736 ms) : 1712, 1760
. : milestone, 1736,
appsec_no_iast (1.713 ms) : 1688, 1738
. : milestone, 1713,
iast (1.478 ms) : 1455, 1501
. : milestone, 1478,
profiling (1.545 ms) : 1520, 1571
. : milestone, 1545,
tracing (1.461 ms) : 1438, 1485
. : milestone, 1461,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~b58dc72569, baseline=1.36.0-SNAPSHOT~edb2c3fa17
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.202 ms) : 2169, 2236
. : milestone, 2202,
iast (1.963 ms) : 1923, 2004
. : milestone, 1963,
iast_GLOBAL (2.009 ms) : 1967, 2050
. : milestone, 2009,
profiling (1.855 ms) : 1822, 1888
. : milestone, 1855,
tracing (1.828 ms) : 1796, 1859
. : milestone, 1828,
section candidate
no_agent (1.465 ms) : 1454, 1476
. : milestone, 1465,
appsec (2.207 ms) : 2173, 2241
. : milestone, 2207,
iast (1.962 ms) : 1921, 2002
. : milestone, 1962,
iast_GLOBAL (2.006 ms) : 1965, 2046
. : milestone, 2006,
profiling (1.851 ms) : 1818, 1884
. : milestone, 1851,
tracing (1.828 ms) : 1796, 1860
. : milestone, 1828,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~b58dc72569, baseline=1.36.0-SNAPSHOT~edb2c3fa17
dateFormat X
axisFormat %s
section baseline
no_agent (15.59 s) : 15590000, 15590000
. : milestone, 15590000,
appsec (15.205 s) : 15205000, 15205000
. : milestone, 15205000,
iast (18.767 s) : 18767000, 18767000
. : milestone, 18767000,
iast_GLOBAL (17.748 s) : 17748000, 17748000
. : milestone, 17748000,
profiling (15.466 s) : 15466000, 15466000
. : milestone, 15466000,
tracing (15.025 s) : 15025000, 15025000
. : milestone, 15025000,
section candidate
no_agent (15.287 s) : 15287000, 15287000
. : milestone, 15287000,
appsec (14.791 s) : 14791000, 14791000
. : milestone, 14791000,
iast (18.901 s) : 18901000, 18901000
. : milestone, 18901000,
iast_GLOBAL (17.713 s) : 17713000, 17713000
. : milestone, 17713000,
profiling (15.891 s) : 15891000, 15891000
. : milestone, 15891000,
tracing (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
|
nikita-tkachenko-datadog
requested review from
anmarchenko,
PerfectSlayer and
nayeem-kamal
June 7, 2024 12:34
anmarchenko
approved these changes
Jun 7, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/itr-no-coverage-for-skippable-tests
branch
June 7, 2024 12:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates ITR per-test code coverage logic: if a test case is known to be skippable (i.e. is included in the list of skippable tests retrieved from the backend), then code coverage will not be gathered for that test case.
Motivation
Reducing coverage performance overhead.
There is no point in gathering coverage for skippable tests: if a test is skippable it means no covered files were changed. So if coverage is gathered, it will be the same as before.
Jira ticket: SDTEST-441