-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use spark application name when service is set to hadoop #7294
Use spark application name when service is set to hadoop #7294
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066768
Total [baseline] (10.332 s) : 0, 10332174
Agent [candidate] (1.065 s) : 0, 1065144
Total [candidate] (10.398 s) : 0, 10398063
section appsec
Agent [baseline] (1.19 s) : 0, 1189694
Total [baseline] (10.538 s) : 0, 10537794
Agent [candidate] (1.183 s) : 0, 1182576
Total [candidate] (10.523 s) : 0, 10522696
section iast
Agent [baseline] (1.171 s) : 0, 1170776
Total [baseline] (10.696 s) : 0, 10695969
Agent [candidate] (1.173 s) : 0, 1173033
Total [candidate] (10.77 s) : 0, 10770001
section profiling
Agent [baseline] (1.265 s) : 0, 1265340
Total [baseline] (10.611 s) : 0, 10611372
Agent [candidate] (1.271 s) : 0, 1271218
Total [candidate] (10.589 s) : 0, 10588787
gantt
title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.944 ms) : 0, 666944
BytebuddyAgent [candidate] (666.324 ms) : 0, 666324
GlobalTracer [baseline] (306.306 ms) : 0, 306306
GlobalTracer [candidate] (305.309 ms) : 0, 305309
AppSec [baseline] (50.325 ms) : 0, 50325
AppSec [candidate] (50.443 ms) : 0, 50443
Remote Config [baseline] (673.135 µs) : 0, 673
Remote Config [candidate] (670.6 µs) : 0, 671
Telemetry [baseline] (7.7 ms) : 0, 7700
Telemetry [candidate] (7.688 ms) : 0, 7688
section appsec
BytebuddyAgent [baseline] (680.436 ms) : 0, 680436
BytebuddyAgent [candidate] (675.8 ms) : 0, 675800
GlobalTracer [baseline] (300.472 ms) : 0, 300472
GlobalTracer [candidate] (298.621 ms) : 0, 298621
AppSec [baseline] (154.269 ms) : 0, 154269
AppSec [candidate] (153.772 ms) : 0, 153772
IAST [baseline] (21.497 ms) : 0, 21497
IAST [candidate] (20.311 ms) : 0, 20311
Remote Config [baseline] (626.224 µs) : 0, 626
Remote Config [candidate] (618.37 µs) : 0, 618
Telemetry [baseline] (8.267 ms) : 0, 8267
Telemetry [candidate] (8.916 ms) : 0, 8916
section iast
BytebuddyAgent [baseline] (778.931 ms) : 0, 778931
BytebuddyAgent [candidate] (780.342 ms) : 0, 780342
GlobalTracer [baseline] (295.73 ms) : 0, 295730
GlobalTracer [candidate] (295.759 ms) : 0, 295759
AppSec [baseline] (47.307 ms) : 0, 47307
AppSec [candidate] (47.426 ms) : 0, 47426
IAST [baseline] (27.85 ms) : 0, 27850
IAST [candidate] (28.541 ms) : 0, 28541
Remote Config [baseline] (567.972 µs) : 0, 568
Remote Config [candidate] (555.658 µs) : 0, 556
Telemetry [baseline] (6.935 ms) : 0, 6935
Telemetry [candidate] (6.87 ms) : 0, 6870
section profiling
BytebuddyAgent [baseline] (663.4 ms) : 0, 663400
BytebuddyAgent [candidate] (667.391 ms) : 0, 667391
GlobalTracer [baseline] (389.872 ms) : 0, 389872
GlobalTracer [candidate] (389.768 ms) : 0, 389768
AppSec [baseline] (51.421 ms) : 0, 51421
AppSec [candidate] (52.011 ms) : 0, 52011
Remote Config [baseline] (645.306 µs) : 0, 645
Remote Config [candidate] (647.264 µs) : 0, 647
Telemetry [baseline] (7.336 ms) : 0, 7336
Telemetry [candidate] (7.396 ms) : 0, 7396
ProfilingAgent [baseline] (95.463 ms) : 0, 95463
ProfilingAgent [candidate] (96.32 ms) : 0, 96320
Profiling [baseline] (95.488 ms) : 0, 95488
Profiling [candidate] (96.345 ms) : 0, 96345
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062973
Total [baseline] (8.559 s) : 0, 8558951
Agent [candidate] (1.064 s) : 0, 1064156
Total [candidate] (8.495 s) : 0, 8494639
section iast
Agent [baseline] (1.182 s) : 0, 1181672
Total [baseline] (9.006 s) : 0, 9005660
Agent [candidate] (1.175 s) : 0, 1174965
Total [candidate] (8.984 s) : 0, 8984426
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1172175
Total [baseline] (8.912 s) : 0, 8911501
Agent [candidate] (1.176 s) : 0, 1176313
Total [candidate] (8.956 s) : 0, 8955638
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170331
Total [baseline] (8.956 s) : 0, 8956271
Agent [candidate] (1.168 s) : 0, 1168223
Total [candidate] (8.954 s) : 0, 8953957
gantt
title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.19 ms) : 0, 665190
BytebuddyAgent [candidate] (665.784 ms) : 0, 665784
GlobalTracer [baseline] (305.014 ms) : 0, 305014
GlobalTracer [candidate] (305.252 ms) : 0, 305252
AppSec [baseline] (49.919 ms) : 0, 49919
AppSec [candidate] (50.065 ms) : 0, 50065
Remote Config [baseline] (663.156 µs) : 0, 663
Remote Config [candidate] (675.727 µs) : 0, 676
Telemetry [baseline] (7.658 ms) : 0, 7658
Telemetry [candidate] (7.77 ms) : 0, 7770
section iast
BytebuddyAgent [baseline] (787.504 ms) : 0, 787504
BytebuddyAgent [candidate] (784.931 ms) : 0, 784931
GlobalTracer [baseline] (298.267 ms) : 0, 298267
GlobalTracer [candidate] (295.904 ms) : 0, 295904
AppSec [baseline] (47.692 ms) : 0, 47692
AppSec [candidate] (47.311 ms) : 0, 47311
IAST [baseline] (26.063 ms) : 0, 26063
IAST [candidate] (25.581 ms) : 0, 25581
Remote Config [baseline] (600.213 µs) : 0, 600
Remote Config [candidate] (576.123 µs) : 0, 576
Telemetry [baseline] (7.963 ms) : 0, 7963
Telemetry [candidate] (7.096 ms) : 0, 7096
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.325 ms) : 0, 780325
BytebuddyAgent [candidate] (783.887 ms) : 0, 783887
GlobalTracer [baseline] (295.766 ms) : 0, 295766
GlobalTracer [candidate] (297.033 ms) : 0, 297033
AppSec [baseline] (47.337 ms) : 0, 47337
AppSec [candidate] (47.702 ms) : 0, 47702
IAST [baseline] (27.694 ms) : 0, 27694
IAST [candidate] (26.522 ms) : 0, 26522
Remote Config [baseline] (574.62 µs) : 0, 575
Remote Config [candidate] (573.424 µs) : 0, 573
Telemetry [baseline] (6.936 ms) : 0, 6936
Telemetry [candidate] (6.949 ms) : 0, 6949
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.144 ms) : 0, 779144
BytebuddyAgent [candidate] (777.904 ms) : 0, 777904
GlobalTracer [baseline] (295.797 ms) : 0, 295797
GlobalTracer [candidate] (295.534 ms) : 0, 295534
AppSec [baseline] (47.398 ms) : 0, 47398
AppSec [candidate] (47.177 ms) : 0, 47177
IAST [baseline] (26.966 ms) : 0, 26966
IAST [candidate] (26.594 ms) : 0, 26594
Remote Config [baseline] (609.034 µs) : 0, 609
Remote Config [candidate] (586.002 µs) : 0, 586
Telemetry [baseline] (6.873 ms) : 0, 6873
Telemetry [candidate] (6.864 ms) : 0, 6864
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
dateFormat X
axisFormat %s
section baseline
no_agent (1.332 ms) : 1312, 1352
. : milestone, 1332,
appsec (1.692 ms) : 1668, 1717
. : milestone, 1692,
appsec_no_iast (1.729 ms) : 1705, 1752
. : milestone, 1729,
iast (1.475 ms) : 1453, 1498
. : milestone, 1475,
profiling (1.497 ms) : 1474, 1521
. : milestone, 1497,
tracing (1.469 ms) : 1445, 1493
. : milestone, 1469,
section candidate
no_agent (1.348 ms) : 1328, 1367
. : milestone, 1348,
appsec (1.702 ms) : 1678, 1725
. : milestone, 1702,
appsec_no_iast (1.705 ms) : 1680, 1730
. : milestone, 1705,
iast (1.481 ms) : 1458, 1504
. : milestone, 1481,
profiling (1.502 ms) : 1476, 1528
. : milestone, 1502,
tracing (1.473 ms) : 1449, 1497
. : milestone, 1473,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
dateFormat X
axisFormat %s
section baseline
no_agent (365.271 µs) : 346, 385
. : milestone, 365,
iast (485.326 µs) : 464, 507
. : milestone, 485,
iast_FULL (555.368 µs) : 534, 577
. : milestone, 555,
iast_GLOBAL (503.506 µs) : 482, 525
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (479.827 µs) : 459, 501
. : milestone, 480,
iast_INACTIVE (448.369 µs) : 428, 469
. : milestone, 448,
iast_TELEMETRY_OFF (467.401 µs) : 447, 488
. : milestone, 467,
tracing (434.629 µs) : 414, 455
. : milestone, 435,
section candidate
no_agent (363.389 µs) : 344, 383
. : milestone, 363,
iast (483.021 µs) : 462, 504
. : milestone, 483,
iast_FULL (551.665 µs) : 531, 573
. : milestone, 552,
iast_GLOBAL (497.523 µs) : 477, 518
. : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (476.814 µs) : 456, 498
. : milestone, 477,
iast_INACTIVE (450.234 µs) : 429, 472
. : milestone, 450,
iast_TELEMETRY_OFF (470.427 µs) : 449, 492
. : milestone, 470,
tracing (444.96 µs) : 424, 466
. : milestone, 445,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
dateFormat X
axisFormat %s
section baseline
no_agent (1.456 ms) : 1444, 1467
. : milestone, 1456,
appsec (2.232 ms) : 2196, 2268
. : milestone, 2232,
iast (1.974 ms) : 1931, 2016
. : milestone, 1974,
iast_GLOBAL (2.015 ms) : 1973, 2057
. : milestone, 2015,
profiling (1.854 ms) : 1820, 1888
. : milestone, 1854,
tracing (1.827 ms) : 1795, 1859
. : milestone, 1827,
section candidate
no_agent (1.452 ms) : 1441, 1464
. : milestone, 1452,
appsec (2.227 ms) : 2192, 2263
. : milestone, 2227,
iast (1.97 ms) : 1928, 2012
. : milestone, 1970,
iast_GLOBAL (2.007 ms) : 1964, 2050
. : milestone, 2007,
profiling (1.848 ms) : 1815, 1882
. : milestone, 1848,
tracing (1.84 ms) : 1807, 1872
. : milestone, 1840,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~2f40cd1d33, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
dateFormat X
axisFormat %s
section baseline
no_agent (15.48 s) : 15480000, 15480000
. : milestone, 15480000,
appsec (15.003 s) : 15003000, 15003000
. : milestone, 15003000,
iast (18.61 s) : 18610000, 18610000
. : milestone, 18610000,
iast_GLOBAL (17.928 s) : 17928000, 17928000
. : milestone, 17928000,
profiling (15.251 s) : 15251000, 15251000
. : milestone, 15251000,
tracing (15.219 s) : 15219000, 15219000
. : milestone, 15219000,
section candidate
no_agent (15.45 s) : 15450000, 15450000
. : milestone, 15450000,
appsec (14.835 s) : 14835000, 14835000
. : milestone, 14835000,
iast (19.005 s) : 19005000, 19005000
. : milestone, 19005000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
. : milestone, 18054000,
profiling (15.284 s) : 15284000, 15284000
. : milestone, 15284000,
tracing (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What Does This Do
DD_SPARK_APP_NAME_AS_SERVICE
also use spark.app.name as the default service if service is set tohadoop
Motivation
USM can auto-infer the service to hadoop, in this case we still want to use the spark app name as the service
Additional Notes
Follow up of: #7252