Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gradle instrumentation to support v8.10 #7443

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Fix Gradle instrumentation to support v8.10 #7443

merged 3 commits into from
Aug 15, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Aug 14, 2024 •
edited by jira bot
Loading

What Does This Do

Fixes Gradle instrumentation to work with the new release v8.10

Additional Notes

Release v8.10 changes the way internal Gradle services are registered, so the logic that injects CI Visibility Gradle listener had to be updated.
v8.3-8.9 and v8.10 use different APIs, so two different instrumentations will exist in parallel.

Contributor Checklist

Jira ticket: SDTEST-693

@nikita-tkachenko-datadog nikita-tkachenko-datadog added type: bug comp: ci visibility Continuous Integration Visibility labels Aug 14, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review August 14, 2024 17:44
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner August 14, 2024 17:44
@pr-commenter
Copy link

pr-commenter bot commented Aug 14, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/fix-gradle-v810
git_commit_date 1723647589 1723712700
git_commit_sha d37fbd5 2021119
release_version 1.39.0-SNAPSHOT~d37fbd5af5 1.39.0-SNAPSHOT~202111943e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723715156 1723715156
ci_job_id 605959644 605959644
ci_pipeline_id 41862257 41862257
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~202111943e, baseline=1.39.0-SNAPSHOT~d37fbd5af5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045911
Total [baseline] (10.397 s) : 0, 10397281
Agent [candidate] (1.047 s) : 0, 1046563
Total [candidate] (10.348 s) : 0, 10347830
section appsec
Agent [baseline] (1.176 s) : 0, 1176166
Total [baseline] (10.462 s) : 0, 10461756
Agent [candidate] (1.17 s) : 0, 1169862
Total [candidate] (10.456 s) : 0, 10456436
section iast
Agent [baseline] (1.183 s) : 0, 1183456
Total [baseline] (10.839 s) : 0, 10839109
Agent [candidate] (1.185 s) : 0, 1184594
Total [candidate] (10.805 s) : 0, 10805008
section profiling
Agent [baseline] (1.245 s) : 0, 1244592
Total [baseline] (10.601 s) : 0, 10600976
Agent [candidate] (1.245 s) : 0, 1244566
Total [candidate] (10.516 s) : 0, 10515838
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.176 s 130.255 ms (12.5%)
Agent iast 1.183 s 137.545 ms (13.2%)
Agent profiling 1.245 s 198.68 ms (19.0%)
Total tracing 10.397 s -
Total appsec 10.462 s 64.475 ms (0.6%)
Total iast 10.839 s 441.828 ms (4.2%)
Total profiling 10.601 s 203.695 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent appsec 1.17 s 123.299 ms (11.8%)
Agent iast 1.185 s 138.031 ms (13.2%)
Agent profiling 1.245 s 198.003 ms (18.9%)
Total tracing 10.348 s -
Total appsec 10.456 s 108.606 ms (1.0%)
Total iast 10.805 s 457.178 ms (4.4%)
Total profiling 10.516 s 168.008 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~202111943e, baseline=1.39.0-SNAPSHOT~d37fbd5af5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.527 ms) : 0, 667527
BytebuddyAgent [candidate] (667.652 ms) : 0, 667652
GlobalTracer [baseline] (306.068 ms) : 0, 306068
GlobalTracer [candidate] (306.268 ms) : 0, 306268
AppSec [baseline] (50.796 ms) : 0, 50796
AppSec [candidate] (51.027 ms) : 0, 51027
Remote Config [baseline] (686.441 µs) : 0, 686
Remote Config [candidate] (686.743 µs) : 0, 687
Telemetry [baseline] (7.428 ms) : 0, 7428
Telemetry [candidate] (7.506 ms) : 0, 7506
section appsec
BytebuddyAgent [baseline] (681.905 ms) : 0, 681905
BytebuddyAgent [candidate] (678.703 ms) : 0, 678703
GlobalTracer [baseline] (302.239 ms) : 0, 302239
GlobalTracer [candidate] (299.805 ms) : 0, 299805
AppSec [baseline] (158.041 ms) : 0, 158041
AppSec [candidate] (157.388 ms) : 0, 157388
IAST [baseline] (20.936 ms) : 0, 20936
IAST [candidate] (21.553 ms) : 0, 21553
Remote Config [baseline] (610.051 µs) : 0, 610
Remote Config [candidate] (604.805 µs) : 0, 605
Telemetry [baseline] (9.351 ms) : 0, 9351
Telemetry [candidate] (9.092 ms) : 0, 9092
section iast
BytebuddyAgent [baseline] (788.59 ms) : 0, 788590
BytebuddyAgent [candidate] (787.767 ms) : 0, 787767
GlobalTracer [baseline] (298.325 ms) : 0, 298325
GlobalTracer [candidate] (298.315 ms) : 0, 298315
AppSec [baseline] (52.552 ms) : 0, 52552
AppSec [candidate] (52.942 ms) : 0, 52942
IAST [baseline] (21.066 ms) : 0, 21066
IAST [candidate] (23.499 ms) : 0, 23499
Remote Config [baseline] (576.295 µs) : 0, 576
Remote Config [candidate] (576.109 µs) : 0, 576
Telemetry [baseline] (8.789 ms) : 0, 8789
Telemetry [candidate] (7.904 ms) : 0, 7904
section profiling
BytebuddyAgent [baseline] (662.555 ms) : 0, 662555
BytebuddyAgent [candidate] (662.645 ms) : 0, 662645
GlobalTracer [baseline] (390.11 ms) : 0, 390110
GlobalTracer [candidate] (390.308 ms) : 0, 390308
AppSec [baseline] (52.335 ms) : 0, 52335
AppSec [candidate] (52.154 ms) : 0, 52154
Remote Config [baseline] (692.661 µs) : 0, 693
Remote Config [candidate] (687.071 µs) : 0, 687
Telemetry [baseline] (7.392 ms) : 0, 7392
Telemetry [candidate] (7.447 ms) : 0, 7447
ProfilingAgent [baseline] (94.468 ms) : 0, 94468
ProfilingAgent [candidate] (94.223 ms) : 0, 94223
Profiling [baseline] (94.492 ms) : 0, 94492
Profiling [candidate] (94.247 ms) : 0, 94247
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~202111943e, baseline=1.39.0-SNAPSHOT~d37fbd5af5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045419
Total [baseline] (8.488 s) : 0, 8487895
Agent [candidate] (1.055 s) : 0, 1054903
Total [candidate] (8.501 s) : 0, 8500853
section iast
Agent [baseline] (1.177 s) : 0, 1177108
Total [baseline] (8.98 s) : 0, 8980198
Agent [candidate] (1.176 s) : 0, 1176304
Total [candidate] (8.961 s) : 0, 8960715
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.173 s) : 0, 1173354
Total [baseline] (8.997 s) : 0, 8996611
Agent [candidate] (1.186 s) : 0, 1186303
Total [candidate] (8.998 s) : 0, 8997998
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1180160
Total [baseline] (8.98 s) : 0, 8980231
Agent [candidate] (1.179 s) : 0, 1179366
Total [candidate] (9.006 s) : 0, 9006214
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.177 s 131.689 ms (12.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.173 s 127.935 ms (12.2%)
Agent iast_TELEMETRY_OFF 1.18 s 134.741 ms (12.9%)
Total tracing 8.488 s -
Total iast 8.98 s 492.303 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.997 s 508.715 ms (6.0%)
Total iast_TELEMETRY_OFF 8.98 s 492.336 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.176 s 121.401 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.186 s 131.399 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.179 s 124.463 ms (11.8%)
Total tracing 8.501 s -
Total iast 8.961 s 459.863 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.998 s 497.145 ms (5.8%)
Total iast_TELEMETRY_OFF 9.006 s 505.361 ms (5.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~202111943e, baseline=1.39.0-SNAPSHOT~d37fbd5af5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.582 ms) : 0, 666582
BytebuddyAgent [candidate] (673.3 ms) : 0, 673300
GlobalTracer [baseline] (306.045 ms) : 0, 306045
GlobalTracer [candidate] (308.353 ms) : 0, 308353
AppSec [baseline] (51.167 ms) : 0, 51167
AppSec [candidate] (51.446 ms) : 0, 51446
Remote Config [baseline] (686.021 µs) : 0, 686
Remote Config [candidate] (695.58 µs) : 0, 696
Telemetry [baseline] (7.546 ms) : 0, 7546
Telemetry [candidate] (7.582 ms) : 0, 7582
section iast
BytebuddyAgent [baseline] (783.159 ms) : 0, 783159
BytebuddyAgent [candidate] (783.034 ms) : 0, 783034
GlobalTracer [baseline] (296.253 ms) : 0, 296253
GlobalTracer [candidate] (295.977 ms) : 0, 295977
AppSec [baseline] (52.526 ms) : 0, 52526
AppSec [candidate] (52.95 ms) : 0, 52950
IAST [baseline] (23.179 ms) : 0, 23179
IAST [candidate] (22.414 ms) : 0, 22414
Remote Config [baseline] (587.883 µs) : 0, 588
Remote Config [candidate] (566.484 µs) : 0, 566
Telemetry [baseline] (7.927 ms) : 0, 7927
Telemetry [candidate] (7.884 ms) : 0, 7884
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.227 ms) : 0, 780227
BytebuddyAgent [candidate] (787.602 ms) : 0, 787602
GlobalTracer [baseline] (295.729 ms) : 0, 295729
GlobalTracer [candidate] (300.115 ms) : 0, 300115
AppSec [baseline] (48.451 ms) : 0, 48451
AppSec [candidate] (48.979 ms) : 0, 48979
IAST [baseline] (23.647 ms) : 0, 23647
IAST [candidate] (27.5 ms) : 0, 27500
Remote Config [baseline] (592.842 µs) : 0, 593
Remote Config [candidate] (589.638 µs) : 0, 590
Telemetry [baseline] (11.206 ms) : 0, 11206
Telemetry [candidate] (7.903 ms) : 0, 7903
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (784.863 ms) : 0, 784863
BytebuddyAgent [candidate] (784.471 ms) : 0, 784471
GlobalTracer [baseline] (298.438 ms) : 0, 298438
GlobalTracer [candidate] (298.721 ms) : 0, 298721
AppSec [baseline] (53.478 ms) : 0, 53478
AppSec [candidate] (50.902 ms) : 0, 50902
IAST [baseline] (22.107 ms) : 0, 22107
IAST [candidate] (23.975 ms) : 0, 23975
Remote Config [baseline] (632.135 µs) : 0, 632
Remote Config [candidate] (618.84 µs) : 0, 619
Telemetry [baseline] (7.065 ms) : 0, 7065
Telemetry [candidate] (7.135 ms) : 0, 7135
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-08-15T09:16:41 2024-08-15T09:23:28
git_branch master nikita-tkachenko/fix-gradle-v810
git_commit_date 1723647589 1723712700
git_commit_sha d37fbd5 2021119
release_version 1.39.0-SNAPSHOT~d37fbd5af5 1.39.0-SNAPSHOT~202111943e
start_time 2024-08-15T09:16:28 2024-08-15T09:23:15
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1723714151 1723714151
ci_job_id 605959645 605959645
ci_pipeline_id 41862257 41862257
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~202111943e, baseline=1.39.0-SNAPSHOT~d37fbd5af5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.339 ms) : 1320, 1358
.   : milestone, 1339,
appsec (1.71 ms) : 1686, 1734
.   : milestone, 1710,
appsec_no_iast (1.721 ms) : 1696, 1745
.   : milestone, 1721,
iast (1.481 ms) : 1459, 1503
.   : milestone, 1481,
profiling (1.479 ms) : 1454, 1505
.   : milestone, 1479,
tracing (1.437 ms) : 1412, 1461
.   : milestone, 1437,
section candidate
no_agent (1.321 ms) : 1302, 1340
.   : milestone, 1321,
appsec (1.706 ms) : 1683, 1729
.   : milestone, 1706,
appsec_no_iast (1.714 ms) : 1691, 1738
.   : milestone, 1714,
iast (1.486 ms) : 1463, 1508
.   : milestone, 1486,
profiling (1.49 ms) : 1466, 1515
.   : milestone, 1490,
tracing (1.454 ms) : 1431, 1478
.   : milestone, 1454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.32 ms, 1.358 ms] -
appsec 1.71 ms [1.686 ms, 1.734 ms] 371.079 µs (27.7%)
appsec_no_iast 1.721 ms [1.696 ms, 1.745 ms] 381.737 µs (28.5%)
iast 1.481 ms [1.459 ms, 1.503 ms] 141.906 µs (10.6%)
profiling 1.479 ms [1.454 ms, 1.505 ms] 140.538 µs (10.5%)
tracing 1.437 ms [1.412 ms, 1.461 ms] 97.705 µs (7.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.321 ms [1.302 ms, 1.34 ms] -
appsec 1.706 ms [1.683 ms, 1.729 ms] 385.111 µs (29.2%)
appsec_no_iast 1.714 ms [1.691 ms, 1.738 ms] 393.471 µs (29.8%)
iast 1.486 ms [1.463 ms, 1.508 ms] 164.605 µs (12.5%)
profiling 1.49 ms [1.466 ms, 1.515 ms] 169.394 µs (12.8%)
tracing 1.454 ms [1.431 ms, 1.478 ms] 133.362 µs (10.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~202111943e, baseline=1.39.0-SNAPSHOT~d37fbd5af5
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.558 µs) : 343, 384
.   : milestone, 364,
iast (476.59 µs) : 455, 498
.   : milestone, 477,
iast_FULL (546.885 µs) : 525, 569
.   : milestone, 547,
iast_GLOBAL (502.843 µs) : 480, 525
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (476.675 µs) : 455, 498
.   : milestone, 477,
iast_INACTIVE (447.081 µs) : 425, 469
.   : milestone, 447,
iast_TELEMETRY_OFF (472.424 µs) : 450, 494
.   : milestone, 472,
tracing (434.365 µs) : 414, 455
.   : milestone, 434,
section candidate
no_agent (360.909 µs) : 341, 380
.   : milestone, 361,
iast (483.001 µs) : 461, 505
.   : milestone, 483,
iast_FULL (543.146 µs) : 521, 565
.   : milestone, 543,
iast_GLOBAL (503.592 µs) : 481, 527
.   : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (475.063 µs) : 454, 496
.   : milestone, 475,
iast_INACTIVE (447.278 µs) : 425, 469
.   : milestone, 447,
iast_TELEMETRY_OFF (464.836 µs) : 444, 486
.   : milestone, 465,
tracing (438.556 µs) : 418, 460
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.558 µs [343.063 µs, 384.053 µs] -
iast 476.59 µs [454.845 µs, 498.336 µs] 113.033 µs (31.1%)
iast_FULL 546.885 µs [524.562 µs, 569.207 µs] 183.327 µs (50.4%)
iast_GLOBAL 502.843 µs [480.468 µs, 525.219 µs] 139.286 µs (38.3%)
iast_HARDCODED_SECRET_DISABLED 476.675 µs [455.488 µs, 497.861 µs] 113.117 µs (31.1%)
iast_INACTIVE 447.081 µs [424.996 µs, 469.166 µs] 83.524 µs (23.0%)
iast_TELEMETRY_OFF 472.424 µs [450.383 µs, 494.466 µs] 108.867 µs (29.9%)
tracing 434.365 µs [414.125 µs, 454.604 µs] 70.807 µs (19.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 360.909 µs [341.482 µs, 380.336 µs] -
iast 483.001 µs [460.675 µs, 505.326 µs] 122.092 µs (33.8%)
iast_FULL 543.146 µs [520.834 µs, 565.458 µs] 182.237 µs (50.5%)
iast_GLOBAL 503.592 µs [480.561 µs, 526.624 µs] 142.684 µs (39.5%)
iast_HARDCODED_SECRET_DISABLED 475.063 µs [453.661 µs, 496.465 µs] 114.154 µs (31.6%)
iast_INACTIVE 447.278 µs [425.4 µs, 469.156 µs] 86.37 µs (23.9%)
iast_TELEMETRY_OFF 464.836 µs [444.051 µs, 485.621 µs] 103.927 µs (28.8%)
tracing 438.556 µs [417.612 µs, 459.5 µs] 77.647 µs (21.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/fix-gradle-v810
git_commit_date 1723647589 1723712700
git_commit_sha d37fbd5 2021119
release_version 1.39.0-SNAPSHOT~d37fbd5af5 1.39.0-SNAPSHOT~202111943e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1723714662 1723714662
ci_job_id 605959646 605959646
ci_pipeline_id 41862257 41862257
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~202111943e, baseline=1.39.0-SNAPSHOT~d37fbd5af5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.457 ms) : 1445, 1468
.   : milestone, 1457,
appsec (2.206 ms) : 2172, 2240
.   : milestone, 2206,
iast (1.958 ms) : 1916, 1999
.   : milestone, 1958,
iast_GLOBAL (2.019 ms) : 1975, 2062
.   : milestone, 2019,
profiling (1.868 ms) : 1833, 1904
.   : milestone, 1868,
tracing (1.837 ms) : 1803, 1870
.   : milestone, 1837,
section candidate
no_agent (1.456 ms) : 1444, 1467
.   : milestone, 1456,
appsec (2.219 ms) : 2184, 2255
.   : milestone, 2219,
iast (1.965 ms) : 1923, 2007
.   : milestone, 1965,
iast_GLOBAL (1.996 ms) : 1953, 2038
.   : milestone, 1996,
profiling (1.855 ms) : 1821, 1888
.   : milestone, 1855,
tracing (1.84 ms) : 1807, 1873
.   : milestone, 1840,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.445 ms, 1.468 ms] -
appsec 2.206 ms [2.172 ms, 2.24 ms] 749.442 µs (51.4%)
iast 1.958 ms [1.916 ms, 1.999 ms] 501.265 µs (34.4%)
iast_GLOBAL 2.019 ms [1.975 ms, 2.062 ms] 561.914 µs (38.6%)
profiling 1.868 ms [1.833 ms, 1.904 ms] 411.438 µs (28.2%)
tracing 1.837 ms [1.803 ms, 1.87 ms] 380.049 µs (26.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.444 ms, 1.467 ms] -
appsec 2.219 ms [2.184 ms, 2.255 ms] 763.687 µs (52.5%)
iast 1.965 ms [1.923 ms, 2.007 ms] 509.426 µs (35.0%)
iast_GLOBAL 1.996 ms [1.953 ms, 2.038 ms] 539.957 µs (37.1%)
profiling 1.855 ms [1.821 ms, 1.888 ms] 398.906 µs (27.4%)
tracing 1.84 ms [1.807 ms, 1.873 ms] 384.637 µs (26.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~202111943e, baseline=1.39.0-SNAPSHOT~d37fbd5af5
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.962 s) : 14962000, 14962000
.   : milestone, 14962000,
appsec (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
iast (18.823 s) : 18823000, 18823000
.   : milestone, 18823000,
iast_GLOBAL (17.696 s) : 17696000, 17696000
.   : milestone, 17696000,
profiling (15.133 s) : 15133000, 15133000
.   : milestone, 15133000,
tracing (14.983 s) : 14983000, 14983000
.   : milestone, 14983000,
section candidate
no_agent (15.257 s) : 15257000, 15257000
.   : milestone, 15257000,
appsec (15.357 s) : 15357000, 15357000
.   : milestone, 15357000,
iast (18.499 s) : 18499000, 18499000
.   : milestone, 18499000,
iast_GLOBAL (18.035 s) : 18035000, 18035000
.   : milestone, 18035000,
profiling (15.158 s) : 15158000, 15158000
.   : milestone, 15158000,
tracing (15.089 s) : 15089000, 15089000
.   : milestone, 15089000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.962 s [14.962 s, 14.962 s] -
appsec 15.026 s [15.026 s, 15.026 s] 64.0 ms (0.4%)
iast 18.823 s [18.823 s, 18.823 s] 3.861 s (25.8%)
iast_GLOBAL 17.696 s [17.696 s, 17.696 s] 2.734 s (18.3%)
profiling 15.133 s [15.133 s, 15.133 s] 171.0 ms (1.1%)
tracing 14.983 s [14.983 s, 14.983 s] 21.0 ms (0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.257 s [15.257 s, 15.257 s] -
appsec 15.357 s [15.357 s, 15.357 s] 100.0 ms (0.7%)
iast 18.499 s [18.499 s, 18.499 s] 3.242 s (21.2%)
iast_GLOBAL 18.035 s [18.035 s, 18.035 s] 2.778 s (18.2%)
profiling 15.158 s [15.158 s, 15.158 s] -99.0 ms (-0.6%)
tracing 15.089 s [15.089 s, 15.089 s] -168.0 ms (-1.1%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog enabled auto-merge (squash) August 15, 2024 09:37
mcculls
mcculls approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks!

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit fcd4bc4 into master Aug 15, 2024
80 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/fix-gradle-v810 branch August 15, 2024 16:33
@github-actions github-actions bot added this to the 1.39.0 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@tonyredondo tonyredondo Awaiting requested review from tonyredondo tonyredondo is a code owner automatically assigned from DataDog/ci-app-libraries-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility type: bug
Projects
None yet
Milestone
1.39.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nikita-tkachenko-datadog @mcculls