-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Gradle Daemon process detection #7524
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/fix-gradle-daemon-detection
Aug 29, 2024
Merged
Fix Gradle Daemon process detection #7524
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/fix-gradle-daemon-detection
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
type: bug
comp: ci visibility
Continuous Integration Visibility
labels
Aug 28, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~7173f0f8db, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053568
Total [baseline] (10.403 s) : 0, 10403208
Agent [candidate] (1.057 s) : 0, 1056570
Total [candidate] (10.374 s) : 0, 10374401
section appsec
Agent [baseline] (1.178 s) : 0, 1178337
Total [baseline] (10.509 s) : 0, 10509090
Agent [candidate] (1.173 s) : 0, 1173489
Total [candidate] (10.433 s) : 0, 10433427
section iast
Agent [baseline] (1.172 s) : 0, 1172362
Total [baseline] (10.841 s) : 0, 10840840
Agent [candidate] (1.175 s) : 0, 1175277
Total [candidate] (10.826 s) : 0, 10825784
section profiling
Agent [baseline] (1.259 s) : 0, 1259212
Total [baseline] (10.615 s) : 0, 10614888
Agent [candidate] (1.25 s) : 0, 1249520
Total [candidate] (10.563 s) : 0, 10562532
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~7173f0f8db, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.847 ms) : 0, 671847
BytebuddyAgent [candidate] (674.229 ms) : 0, 674229
GlobalTracer [baseline] (308.311 ms) : 0, 308311
GlobalTracer [candidate] (308.896 ms) : 0, 308896
AppSec [baseline] (51.637 ms) : 0, 51637
AppSec [candidate] (51.628 ms) : 0, 51628
Remote Config [baseline] (672.856 µs) : 0, 673
Remote Config [candidate] (669.201 µs) : 0, 669
Telemetry [baseline] (7.499 ms) : 0, 7499
Telemetry [candidate] (7.47 ms) : 0, 7470
section appsec
BytebuddyAgent [baseline] (685.054 ms) : 0, 685054
BytebuddyAgent [candidate] (679.687 ms) : 0, 679687
GlobalTracer [baseline] (301.926 ms) : 0, 301926
GlobalTracer [candidate] (301.345 ms) : 0, 301345
AppSec [baseline] (160.147 ms) : 0, 160147
AppSec [candidate] (161.147 ms) : 0, 161147
IAST [baseline] (18.8 ms) : 0, 18800
IAST [candidate] (18.577 ms) : 0, 18577
Remote Config [baseline] (638.85 µs) : 0, 639
Remote Config [candidate] (638.489 µs) : 0, 638
Telemetry [baseline] (7.486 ms) : 0, 7486
Telemetry [candidate] (7.781 ms) : 0, 7781
section iast
BytebuddyAgent [baseline] (778.258 ms) : 0, 778258
BytebuddyAgent [candidate] (780.244 ms) : 0, 780244
GlobalTracer [baseline] (296.275 ms) : 0, 296275
GlobalTracer [candidate] (297.255 ms) : 0, 297255
AppSec [baseline] (51.94 ms) : 0, 51940
AppSec [candidate] (50.769 ms) : 0, 50769
IAST [baseline] (22.85 ms) : 0, 22850
IAST [candidate] (24.077 ms) : 0, 24077
Remote Config [baseline] (607.875 µs) : 0, 608
Remote Config [candidate] (596.768 µs) : 0, 597
Telemetry [baseline] (8.816 ms) : 0, 8816
Telemetry [candidate] (8.686 ms) : 0, 8686
section profiling
BytebuddyAgent [baseline] (670.689 ms) : 0, 670689
BytebuddyAgent [candidate] (664.999 ms) : 0, 664999
GlobalTracer [baseline] (392.393 ms) : 0, 392393
GlobalTracer [candidate] (390.509 ms) : 0, 390509
AppSec [baseline] (52.851 ms) : 0, 52851
AppSec [candidate] (52.322 ms) : 0, 52322
Remote Config [baseline] (691.656 µs) : 0, 692
Remote Config [candidate] (686.012 µs) : 0, 686
Telemetry [baseline] (7.43 ms) : 0, 7430
Telemetry [candidate] (7.359 ms) : 0, 7359
ProfilingAgent [baseline] (97.42 ms) : 0, 97420
ProfilingAgent [candidate] (96.254 ms) : 0, 96254
Profiling [baseline] (97.445 ms) : 0, 97445
Profiling [candidate] (96.278 ms) : 0, 96278
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~7173f0f8db, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051390
Total [baseline] (8.518 s) : 0, 8517799
Agent [candidate] (1.055 s) : 0, 1055373
Total [candidate] (8.564 s) : 0, 8563942
section iast
Agent [baseline] (1.191 s) : 0, 1191063
Total [baseline] (9.001 s) : 0, 9000573
Agent [candidate] (1.177 s) : 0, 1177289
Total [candidate] (8.98 s) : 0, 8980039
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.176 s) : 0, 1175630
Total [baseline] (8.942 s) : 0, 8942255
Agent [candidate] (1.173 s) : 0, 1173112
Total [candidate] (8.933 s) : 0, 8933015
section iast_TELEMETRY_OFF
Agent [baseline] (1.181 s) : 0, 1181138
Total [baseline] (8.984 s) : 0, 8983749
Agent [candidate] (1.171 s) : 0, 1171497
Total [candidate] (9.016 s) : 0, 9016061
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~7173f0f8db, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.794 ms) : 0, 670794
BytebuddyAgent [candidate] (673.419 ms) : 0, 673419
GlobalTracer [baseline] (307.213 ms) : 0, 307213
GlobalTracer [candidate] (308.645 ms) : 0, 308645
AppSec [baseline] (51.629 ms) : 0, 51629
AppSec [candidate] (51.463 ms) : 0, 51463
Remote Config [baseline] (664.345 µs) : 0, 664
Remote Config [candidate] (667.729 µs) : 0, 668
Telemetry [baseline] (7.478 ms) : 0, 7478
Telemetry [candidate] (7.497 ms) : 0, 7497
section iast
BytebuddyAgent [baseline] (791.191 ms) : 0, 791191
BytebuddyAgent [candidate] (781.619 ms) : 0, 781619
GlobalTracer [baseline] (301.176 ms) : 0, 301176
GlobalTracer [candidate] (297.388 ms) : 0, 297388
AppSec [baseline] (49.432 ms) : 0, 49432
AppSec [candidate] (51.77 ms) : 0, 51770
IAST [baseline] (26.816 ms) : 0, 26816
IAST [candidate] (23.393 ms) : 0, 23393
Remote Config [baseline] (598.316 µs) : 0, 598
Remote Config [candidate] (584.703 µs) : 0, 585
Telemetry [baseline] (8.042 ms) : 0, 8042
Telemetry [candidate] (8.847 ms) : 0, 8847
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.733 ms) : 0, 780733
BytebuddyAgent [candidate] (779.023 ms) : 0, 779023
GlobalTracer [baseline] (297.32 ms) : 0, 297320
GlobalTracer [candidate] (296.673 ms) : 0, 296673
AppSec [baseline] (49.701 ms) : 0, 49701
AppSec [candidate] (49.76 ms) : 0, 49760
IAST [baseline] (24.993 ms) : 0, 24993
IAST [candidate] (24.785 ms) : 0, 24785
Remote Config [baseline] (597.922 µs) : 0, 598
Remote Config [candidate] (584.462 µs) : 0, 584
Telemetry [baseline] (8.621 ms) : 0, 8621
Telemetry [candidate] (8.663 ms) : 0, 8663
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (782.867 ms) : 0, 782867
BytebuddyAgent [candidate] (775.774 ms) : 0, 775774
GlobalTracer [baseline] (299.014 ms) : 0, 299014
GlobalTracer [candidate] (297.15 ms) : 0, 297150
AppSec [baseline] (51.161 ms) : 0, 51161
AppSec [candidate] (49.197 ms) : 0, 49197
IAST [baseline] (23.434 ms) : 0, 23434
IAST [candidate] (25.848 ms) : 0, 25848
Remote Config [baseline] (613.495 µs) : 0, 613
Remote Config [candidate] (587.7 µs) : 0, 588
Telemetry [baseline] (10.311 ms) : 0, 10311
Telemetry [candidate] (9.303 ms) : 0, 9303
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 19 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~7173f0f8db, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section baseline
no_agent (1.327 ms) : 1307, 1346
. : milestone, 1327,
appsec (1.733 ms) : 1709, 1756
. : milestone, 1733,
appsec_no_iast (1.725 ms) : 1701, 1749
. : milestone, 1725,
iast (1.473 ms) : 1450, 1496
. : milestone, 1473,
profiling (1.46 ms) : 1437, 1482
. : milestone, 1460,
tracing (1.465 ms) : 1441, 1488
. : milestone, 1465,
section candidate
no_agent (1.346 ms) : 1326, 1365
. : milestone, 1346,
appsec (1.702 ms) : 1678, 1725
. : milestone, 1702,
appsec_no_iast (1.715 ms) : 1690, 1739
. : milestone, 1715,
iast (1.468 ms) : 1445, 1491
. : milestone, 1468,
profiling (1.48 ms) : 1457, 1504
. : milestone, 1480,
tracing (1.48 ms) : 1456, 1504
. : milestone, 1480,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~7173f0f8db, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section baseline
no_agent (363.906 µs) : 344, 384
. : milestone, 364,
iast (477.828 µs) : 455, 501
. : milestone, 478,
iast_FULL (549.828 µs) : 529, 571
. : milestone, 550,
iast_GLOBAL (501.23 µs) : 479, 523
. : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (480.958 µs) : 459, 503
. : milestone, 481,
iast_INACTIVE (444.746 µs) : 424, 466
. : milestone, 445,
iast_TELEMETRY_OFF (465.619 µs) : 443, 488
. : milestone, 466,
tracing (438.59 µs) : 418, 459
. : milestone, 439,
section candidate
no_agent (368.304 µs) : 348, 389
. : milestone, 368,
iast (482.891 µs) : 460, 505
. : milestone, 483,
iast_FULL (549.898 µs) : 529, 571
. : milestone, 550,
iast_GLOBAL (499.446 µs) : 478, 521
. : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (486.54 µs) : 464, 509
. : milestone, 487,
iast_INACTIVE (443.007 µs) : 423, 463
. : milestone, 443,
iast_TELEMETRY_OFF (476.316 µs) : 453, 499
. : milestone, 476,
tracing (444.577 µs) : 424, 466
. : milestone, 445,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~7173f0f8db, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section baseline
no_agent (1.462 ms) : 1451, 1473
. : milestone, 1462,
appsec (2.212 ms) : 2177, 2246
. : milestone, 2212,
iast (1.968 ms) : 1925, 2011
. : milestone, 1968,
iast_GLOBAL (2.025 ms) : 1981, 2069
. : milestone, 2025,
profiling (1.86 ms) : 1825, 1894
. : milestone, 1860,
tracing (1.826 ms) : 1794, 1859
. : milestone, 1826,
section candidate
no_agent (1.455 ms) : 1443, 1466
. : milestone, 1455,
appsec (2.207 ms) : 2173, 2242
. : milestone, 2207,
iast (1.964 ms) : 1921, 2006
. : milestone, 1964,
iast_GLOBAL (2.018 ms) : 1975, 2062
. : milestone, 2018,
profiling (1.866 ms) : 1830, 1901
. : milestone, 1866,
tracing (1.824 ms) : 1791, 1856
. : milestone, 1824,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~7173f0f8db, baseline=1.39.0-SNAPSHOT~01d9133076
dateFormat X
axisFormat %s
section baseline
no_agent (14.984 s) : 14984000, 14984000
. : milestone, 14984000,
appsec (15.213 s) : 15213000, 15213000
. : milestone, 15213000,
iast (18.909 s) : 18909000, 18909000
. : milestone, 18909000,
iast_GLOBAL (17.869 s) : 17869000, 17869000
. : milestone, 17869000,
profiling (15.03 s) : 15030000, 15030000
. : milestone, 15030000,
tracing (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
section candidate
no_agent (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
appsec (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
iast (18.614 s) : 18614000, 18614000
. : milestone, 18614000,
iast_GLOBAL (17.84 s) : 17840000, 17840000
. : milestone, 17840000,
profiling (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
tracing (14.952 s) : 14952000, 14952000
. : milestone, 14952000,
|
smola
approved these changes
Aug 29, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/fix-gradle-daemon-detection
branch
August 29, 2024 07:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes the logic that determines whether the tracer is attached to a JVM that runs Gradle Daemon.
Additional Notes
Previous version of the logic only relied on
org/gradle/launcher/daemon/
package being present on the classpath.This failed when the traced process was a Gradle Worker that ran tests for a Gradle Plugin (and as a consequence had plugin API classes on its classpath, some of which lived in
org/gradle/launcher/daemon/
package).Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: CIVIS-10218