-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RASP addresses ephemeral #7529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel-alvarez-alvarez
added
the
comp: asm waf
Application Security Management (WAF)
label
Aug 29, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.39.0-SNAPSHOT~9186870be7, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046366
Total [baseline] (8.486 s) : 0, 8486382
Agent [candidate] (1.048 s) : 0, 1047881
Total [candidate] (8.459 s) : 0, 8459158
section iast
Agent [baseline] (1.177 s) : 0, 1176582
Total [baseline] (9.008 s) : 0, 9008333
Agent [candidate] (1.18 s) : 0, 1180165
Total [candidate] (8.973 s) : 0, 8972996
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.189 s) : 0, 1188984
Total [baseline] (8.981 s) : 0, 8981038
Agent [candidate] (1.174 s) : 0, 1174460
Total [candidate] (8.928 s) : 0, 8927722
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170152
Total [baseline] (8.933 s) : 0, 8933469
Agent [candidate] (1.167 s) : 0, 1167480
Total [candidate] (8.942 s) : 0, 8942489
gantt
title insecure-bank - break down per module: candidate=1.39.0-SNAPSHOT~9186870be7, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.395 ms) : 0, 667395
BytebuddyAgent [candidate] (668.189 ms) : 0, 668189
GlobalTracer [baseline] (306.045 ms) : 0, 306045
GlobalTracer [candidate] (306.837 ms) : 0, 306837
AppSec [baseline] (51.241 ms) : 0, 51241
AppSec [candidate] (51.198 ms) : 0, 51198
Remote Config [baseline] (662.975 µs) : 0, 663
Remote Config [candidate] (653.698 µs) : 0, 654
Telemetry [baseline] (7.458 ms) : 0, 7458
Telemetry [candidate] (7.39 ms) : 0, 7390
section iast
BytebuddyAgent [baseline] (779.976 ms) : 0, 779976
BytebuddyAgent [candidate] (784.855 ms) : 0, 784855
GlobalTracer [baseline] (297.893 ms) : 0, 297893
GlobalTracer [candidate] (298.11 ms) : 0, 298110
AppSec [baseline] (50.192 ms) : 0, 50192
AppSec [candidate] (49.027 ms) : 0, 49027
IAST [baseline] (24.723 ms) : 0, 24723
IAST [candidate] (24.319 ms) : 0, 24319
Remote Config [baseline] (627.827 µs) : 0, 628
Remote Config [candidate] (612.52 µs) : 0, 613
Telemetry [baseline] (9.551 ms) : 0, 9551
Telemetry [candidate] (9.478 ms) : 0, 9478
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (789.562 ms) : 0, 789562
BytebuddyAgent [candidate] (780.494 ms) : 0, 780494
GlobalTracer [baseline] (300.119 ms) : 0, 300119
GlobalTracer [candidate] (295.627 ms) : 0, 295627
AppSec [baseline] (51.136 ms) : 0, 51136
AppSec [candidate] (48.114 ms) : 0, 48114
IAST [baseline] (25.81 ms) : 0, 25810
IAST [candidate] (28.064 ms) : 0, 28064
Remote Config [baseline] (589.535 µs) : 0, 590
Remote Config [candidate] (589.598 µs) : 0, 590
Telemetry [baseline] (7.973 ms) : 0, 7973
Telemetry [candidate] (7.879 ms) : 0, 7879
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.527 ms) : 0, 776527
BytebuddyAgent [candidate] (774.648 ms) : 0, 774648
GlobalTracer [baseline] (296.305 ms) : 0, 296305
GlobalTracer [candidate] (295.758 ms) : 0, 295758
AppSec [baseline] (49.71 ms) : 0, 49710
AppSec [candidate] (50.386 ms) : 0, 50386
IAST [baseline] (25.564 ms) : 0, 25564
IAST [candidate] (25.467 ms) : 0, 25467
Remote Config [baseline] (588.746 µs) : 0, 589
Remote Config [candidate] (583.42 µs) : 0, 583
Telemetry [baseline] (7.848 ms) : 0, 7848
Telemetry [candidate] (7.016 ms) : 0, 7016
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.39.0-SNAPSHOT~9186870be7, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049022
Total [baseline] (10.415 s) : 0, 10415319
Agent [candidate] (1.054 s) : 0, 1053630
Total [candidate] (10.347 s) : 0, 10347336
section appsec
Agent [baseline] (1.178 s) : 0, 1178356
Total [baseline] (10.488 s) : 0, 10488337
Agent [candidate] (1.175 s) : 0, 1175091
Total [candidate] (10.437 s) : 0, 10437021
section iast
Agent [baseline] (1.172 s) : 0, 1172207
Total [baseline] (10.741 s) : 0, 10741017
Agent [candidate] (1.174 s) : 0, 1173534
Total [candidate] (10.851 s) : 0, 10851419
section profiling
Agent [baseline] (1.246 s) : 0, 1246398
Total [baseline] (10.562 s) : 0, 10561667
Agent [candidate] (1.246 s) : 0, 1246092
Total [candidate] (10.552 s) : 0, 10551613
gantt
title petclinic - break down per module: candidate=1.39.0-SNAPSHOT~9186870be7, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.548 ms) : 0, 669548
BytebuddyAgent [candidate] (672.406 ms) : 0, 672406
GlobalTracer [baseline] (306.436 ms) : 0, 306436
GlobalTracer [candidate] (307.653 ms) : 0, 307653
AppSec [baseline] (51.34 ms) : 0, 51340
AppSec [candidate] (51.593 ms) : 0, 51593
Remote Config [baseline] (664.765 µs) : 0, 665
Remote Config [candidate] (680.386 µs) : 0, 680
Telemetry [baseline] (7.456 ms) : 0, 7456
Telemetry [candidate] (7.645 ms) : 0, 7645
section appsec
BytebuddyAgent [baseline] (683.432 ms) : 0, 683432
BytebuddyAgent [candidate] (681.263 ms) : 0, 681263
GlobalTracer [baseline] (302.043 ms) : 0, 302043
GlobalTracer [candidate] (301.453 ms) : 0, 301453
AppSec [baseline] (162.09 ms) : 0, 162090
AppSec [candidate] (161.746 ms) : 0, 161746
Remote Config [baseline] (647.395 µs) : 0, 647
Remote Config [candidate] (644.068 µs) : 0, 644
Telemetry [baseline] (7.185 ms) : 0, 7185
Telemetry [candidate] (7.154 ms) : 0, 7154
IAST [baseline] (18.645 ms) : 0, 18645
IAST [candidate] (18.4 ms) : 0, 18400
section iast
BytebuddyAgent [baseline] (778.201 ms) : 0, 778201
BytebuddyAgent [candidate] (778.362 ms) : 0, 778362
GlobalTracer [baseline] (296.315 ms) : 0, 296315
GlobalTracer [candidate] (296.68 ms) : 0, 296680
AppSec [baseline] (49.523 ms) : 0, 49523
AppSec [candidate] (48.987 ms) : 0, 48987
Remote Config [baseline] (610.569 µs) : 0, 611
Remote Config [candidate] (608.152 µs) : 0, 608
Telemetry [baseline] (10.239 ms) : 0, 10239
Telemetry [candidate] (11.614 ms) : 0, 11614
IAST [baseline] (23.754 ms) : 0, 23754
IAST [candidate] (23.661 ms) : 0, 23661
section profiling
BytebuddyAgent [baseline] (663.701 ms) : 0, 663701
BytebuddyAgent [candidate] (663.659 ms) : 0, 663659
GlobalTracer [baseline] (388.83 ms) : 0, 388830
GlobalTracer [candidate] (388.843 ms) : 0, 388843
AppSec [baseline] (52.272 ms) : 0, 52272
AppSec [candidate] (52.041 ms) : 0, 52041
Remote Config [baseline] (688.991 µs) : 0, 689
Remote Config [candidate] (689.487 µs) : 0, 689
Telemetry [baseline] (7.35 ms) : 0, 7350
Telemetry [candidate] (7.286 ms) : 0, 7286
ProfilingAgent [baseline] (96.276 ms) : 0, 96276
ProfilingAgent [candidate] (96.324 ms) : 0, 96324
Profiling [baseline] (96.299 ms) : 0, 96299
Profiling [candidate] (96.348 ms) : 0, 96348
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~9186870be7, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section baseline
no_agent (1.323 ms) : 1304, 1342
. : milestone, 1323,
appsec (1.711 ms) : 1688, 1733
. : milestone, 1711,
appsec_no_iast (1.734 ms) : 1711, 1758
. : milestone, 1734,
iast (1.477 ms) : 1454, 1500
. : milestone, 1477,
profiling (1.486 ms) : 1463, 1509
. : milestone, 1486,
tracing (1.46 ms) : 1435, 1484
. : milestone, 1460,
section candidate
no_agent (1.339 ms) : 1319, 1358
. : milestone, 1339,
appsec (1.724 ms) : 1700, 1749
. : milestone, 1724,
appsec_no_iast (1.71 ms) : 1686, 1735
. : milestone, 1710,
iast (1.47 ms) : 1447, 1492
. : milestone, 1470,
profiling (1.485 ms) : 1459, 1511
. : milestone, 1485,
tracing (1.455 ms) : 1431, 1480
. : milestone, 1455,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.39.0-SNAPSHOT~9186870be7, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section baseline
no_agent (369.368 µs) : 349, 390
. : milestone, 369,
iast (483.066 µs) : 460, 506
. : milestone, 483,
iast_FULL (551.063 µs) : 530, 572
. : milestone, 551,
iast_GLOBAL (505.099 µs) : 484, 526
. : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (481.143 µs) : 459, 503
. : milestone, 481,
iast_INACTIVE (449.665 µs) : 429, 471
. : milestone, 450,
iast_TELEMETRY_OFF (469.816 µs) : 447, 492
. : milestone, 470,
tracing (431.707 µs) : 412, 452
. : milestone, 432,
section candidate
no_agent (366.215 µs) : 346, 386
. : milestone, 366,
iast (477.676 µs) : 455, 500
. : milestone, 478,
iast_FULL (554.78 µs) : 534, 576
. : milestone, 555,
iast_GLOBAL (502.315 µs) : 481, 523
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (480.295 µs) : 458, 502
. : milestone, 480,
iast_INACTIVE (439.464 µs) : 419, 460
. : milestone, 439,
iast_TELEMETRY_OFF (469.056 µs) : 447, 491
. : milestone, 469,
tracing (433.203 µs) : 413, 453
. : milestone, 433,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~9186870be7, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section baseline
no_agent (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
appsec (15.139 s) : 15139000, 15139000
. : milestone, 15139000,
iast (18.856 s) : 18856000, 18856000
. : milestone, 18856000,
iast_GLOBAL (17.851 s) : 17851000, 17851000
. : milestone, 17851000,
profiling (15.977 s) : 15977000, 15977000
. : milestone, 15977000,
tracing (15.299 s) : 15299000, 15299000
. : milestone, 15299000,
section candidate
no_agent (15.162 s) : 15162000, 15162000
. : milestone, 15162000,
appsec (14.819 s) : 14819000, 14819000
. : milestone, 14819000,
iast (18.563 s) : 18563000, 18563000
. : milestone, 18563000,
iast_GLOBAL (17.802 s) : 17802000, 17802000
. : milestone, 17802000,
profiling (15.33 s) : 15330000, 15330000
. : milestone, 15330000,
tracing (15.047 s) : 15047000, 15047000
. : milestone, 15047000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.39.0-SNAPSHOT~9186870be7, baseline=1.39.0-SNAPSHOT~b7907a264e
dateFormat X
axisFormat %s
section baseline
no_agent (1.455 ms) : 1443, 1466
. : milestone, 1455,
appsec (2.214 ms) : 2179, 2249
. : milestone, 2214,
iast (1.975 ms) : 1931, 2019
. : milestone, 1975,
iast_GLOBAL (2.015 ms) : 1971, 2059
. : milestone, 2015,
profiling (1.861 ms) : 1824, 1897
. : milestone, 1861,
tracing (1.832 ms) : 1799, 1865
. : milestone, 1832,
section candidate
no_agent (1.451 ms) : 1440, 1462
. : milestone, 1451,
appsec (2.208 ms) : 2173, 2242
. : milestone, 2208,
iast (1.958 ms) : 1915, 2000
. : milestone, 1958,
iast_GLOBAL (2.013 ms) : 1969, 2057
. : milestone, 2013,
profiling (1.865 ms) : 1830, 1900
. : milestone, 1865,
tracing (1.837 ms) : 1805, 1870
. : milestone, 1837,
|
smola
approved these changes
Aug 29, 2024
ValentinZakharov
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Changes the RASP addresses for SQLi and SSRF in order to make them ephemeral.
Motivation
Ephemeral addresses should be used for data that has to be evaluated only once and makes no sense to hold them for future evaluations of the WAF, this is the case for SQLi and SSRF which might happen multiple times during the context of a request.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issue[ ] Update the public documentation in case of new configuration flag or behavior