-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide static checker notes when notes is enabled #7994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PerfectSlayer
added
tag: no release notes
Changes to exclude from release notes
comp: tooling
Build & Tooling
labels
Nov 21, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~5247afa447, baseline=1.43.0-SNAPSHOT~cd1b746d93
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1094972
Total [baseline] (8.637 s) : 0, 8637320
Agent [candidate] (1.097 s) : 0, 1096708
Total [candidate] (8.691 s) : 0, 8691012
section iast
Agent [baseline] (1.219 s) : 0, 1218691
Total [baseline] (9.195 s) : 0, 9194540
Agent [candidate] (1.222 s) : 0, 1222318
Total [candidate] (9.204 s) : 0, 9203942
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.217 s) : 0, 1217033
Total [baseline] (9.196 s) : 0, 9195943
Agent [candidate] (1.228 s) : 0, 1227677
Total [candidate] (9.201 s) : 0, 9200838
section iast_TELEMETRY_OFF
Agent [baseline] (1.222 s) : 0, 1221653
Total [baseline] (9.188 s) : 0, 9187829
Agent [candidate] (1.22 s) : 0, 1220492
Total [candidate] (9.211 s) : 0, 9211491
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~5247afa447, baseline=1.43.0-SNAPSHOT~cd1b746d93
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.221 ms) : 0, 697221
BytebuddyAgent [candidate] (697.303 ms) : 0, 697303
GlobalTracer [baseline] (319.312 ms) : 0, 319312
GlobalTracer [candidate] (320.443 ms) : 0, 320443
AppSec [baseline] (54.647 ms) : 0, 54647
AppSec [candidate] (55.147 ms) : 0, 55147
Remote Config [baseline] (681.759 µs) : 0, 682
Remote Config [candidate] (706.278 µs) : 0, 706
Telemetry [baseline] (9.29 ms) : 0, 9290
Telemetry [candidate] (9.255 ms) : 0, 9255
section iast
BytebuddyAgent [baseline] (809.349 ms) : 0, 809349
BytebuddyAgent [candidate] (811.597 ms) : 0, 811597
GlobalTracer [baseline] (307.685 ms) : 0, 307685
GlobalTracer [candidate] (309.704 ms) : 0, 309704
AppSec [baseline] (57.665 ms) : 0, 57665
AppSec [candidate] (58.202 ms) : 0, 58202
Remote Config [baseline] (654.089 µs) : 0, 654
Remote Config [candidate] (626.016 µs) : 0, 626
Telemetry [baseline] (7.625 ms) : 0, 7625
Telemetry [candidate] (7.48 ms) : 0, 7480
IAST [baseline] (21.98 ms) : 0, 21980
IAST [candidate] (20.824 ms) : 0, 20824
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (808.395 ms) : 0, 808395
BytebuddyAgent [candidate] (816.747 ms) : 0, 816747
GlobalTracer [baseline] (307.476 ms) : 0, 307476
GlobalTracer [candidate] (309.663 ms) : 0, 309663
AppSec [baseline] (57.592 ms) : 0, 57592
AppSec [candidate] (57.215 ms) : 0, 57215
Remote Config [baseline] (606.66 µs) : 0, 607
Remote Config [candidate] (631.165 µs) : 0, 631
Telemetry [baseline] (7.55 ms) : 0, 7550
Telemetry [candidate] (7.61 ms) : 0, 7610
IAST [baseline] (21.66 ms) : 0, 21660
IAST [candidate] (21.792 ms) : 0, 21792
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (812.556 ms) : 0, 812556
BytebuddyAgent [candidate] (810.278 ms) : 0, 810278
GlobalTracer [baseline] (307.979 ms) : 0, 307979
GlobalTracer [candidate] (309.221 ms) : 0, 309221
AppSec [baseline] (58.745 ms) : 0, 58745
AppSec [candidate] (58.348 ms) : 0, 58348
Remote Config [baseline] (622.11 µs) : 0, 622
Remote Config [candidate] (629.624 µs) : 0, 630
Telemetry [baseline] (7.499 ms) : 0, 7499
Telemetry [candidate] (7.55 ms) : 0, 7550
IAST [baseline] (20.411 ms) : 0, 20411
IAST [candidate] (20.698 ms) : 0, 20698
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~5247afa447, baseline=1.43.0-SNAPSHOT~cd1b746d93
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1095432
Total [baseline] (10.533 s) : 0, 10533036
Agent [candidate] (1.088 s) : 0, 1088481
Total [candidate] (10.509 s) : 0, 10509438
section appsec
Agent [baseline] (1.225 s) : 0, 1225361
Total [baseline] (10.761 s) : 0, 10761089
Agent [candidate] (1.229 s) : 0, 1229025
Total [candidate] (10.747 s) : 0, 10746679
section iast
Agent [baseline] (1.226 s) : 0, 1226314
Total [baseline] (10.916 s) : 0, 10916346
Agent [candidate] (1.235 s) : 0, 1234592
Total [candidate] (10.954 s) : 0, 10954297
section profiling
Agent [baseline] (1.296 s) : 0, 1295906
Total [baseline] (10.863 s) : 0, 10863034
Agent [candidate] (1.298 s) : 0, 1297619
Total [candidate] (10.873 s) : 0, 10873202
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~5247afa447, baseline=1.43.0-SNAPSHOT~cd1b746d93
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.267 ms) : 0, 696267
BytebuddyAgent [candidate] (691.296 ms) : 0, 691296
GlobalTracer [baseline] (318.984 ms) : 0, 318984
GlobalTracer [candidate] (317.428 ms) : 0, 317428
AppSec [baseline] (54.857 ms) : 0, 54857
AppSec [candidate] (54.674 ms) : 0, 54674
Remote Config [baseline] (686.111 µs) : 0, 686
Remote Config [candidate] (695.154 µs) : 0, 695
Telemetry [baseline] (10.809 ms) : 0, 10809
Telemetry [candidate] (10.652 ms) : 0, 10652
section appsec
BytebuddyAgent [baseline] (710.032 ms) : 0, 710032
BytebuddyAgent [candidate] (713.881 ms) : 0, 713881
GlobalTracer [baseline] (315.078 ms) : 0, 315078
GlobalTracer [candidate] (315.634 ms) : 0, 315634
AppSec [baseline] (166.142 ms) : 0, 166142
AppSec [candidate] (166.27 ms) : 0, 166270
Remote Config [baseline] (657.854 µs) : 0, 658
Remote Config [candidate] (645.331 µs) : 0, 645
Telemetry [baseline] (9.378 ms) : 0, 9378
Telemetry [candidate] (8.24 ms) : 0, 8240
IAST [baseline] (20.647 ms) : 0, 20647
IAST [candidate] (21.083 ms) : 0, 21083
section iast
BytebuddyAgent [baseline] (815.08 ms) : 0, 815080
BytebuddyAgent [candidate] (821.657 ms) : 0, 821657
GlobalTracer [baseline] (309.393 ms) : 0, 309393
GlobalTracer [candidate] (310.692 ms) : 0, 310692
AppSec [baseline] (58.225 ms) : 0, 58225
AppSec [candidate] (58.445 ms) : 0, 58445
Remote Config [baseline] (647.148 µs) : 0, 647
Remote Config [candidate] (619.199 µs) : 0, 619
Telemetry [baseline] (7.688 ms) : 0, 7688
Telemetry [candidate] (7.524 ms) : 0, 7524
IAST [baseline] (21.432 ms) : 0, 21432
IAST [candidate] (21.707 ms) : 0, 21707
section profiling
BytebuddyAgent [baseline] (691.259 ms) : 0, 691259
BytebuddyAgent [candidate] (692.147 ms) : 0, 692147
GlobalTracer [baseline] (403.527 ms) : 0, 403527
GlobalTracer [candidate] (403.952 ms) : 0, 403952
AppSec [baseline] (55.527 ms) : 0, 55527
AppSec [candidate] (55.649 ms) : 0, 55649
Remote Config [baseline] (687.799 µs) : 0, 688
Remote Config [candidate] (681.635 µs) : 0, 682
Telemetry [baseline] (12.23 ms) : 0, 12230
Telemetry [candidate] (10.026 ms) : 0, 10026
ProfilingAgent [baseline] (93.35 ms) : 0, 93350
ProfilingAgent [candidate] (95.742 ms) : 0, 95742
Profiling [baseline] (93.374 ms) : 0, 93374
Profiling [candidate] (95.766 ms) : 0, 95766
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~5247afa447, baseline=1.43.0-SNAPSHOT~cd1b746d93
dateFormat X
axisFormat %s
section baseline
no_agent (1.36 ms) : 1340, 1380
. : milestone, 1360,
appsec (1.772 ms) : 1747, 1796
. : milestone, 1772,
appsec_no_iast (1.715 ms) : 1690, 1740
. : milestone, 1715,
iast (1.507 ms) : 1484, 1529
. : milestone, 1507,
profiling (1.503 ms) : 1480, 1526
. : milestone, 1503,
tracing (1.502 ms) : 1478, 1526
. : milestone, 1502,
section candidate
no_agent (1.346 ms) : 1326, 1366
. : milestone, 1346,
appsec (1.751 ms) : 1726, 1776
. : milestone, 1751,
appsec_no_iast (1.731 ms) : 1706, 1756
. : milestone, 1731,
iast (1.497 ms) : 1475, 1520
. : milestone, 1497,
profiling (1.579 ms) : 1555, 1604
. : milestone, 1579,
tracing (1.494 ms) : 1469, 1518
. : milestone, 1494,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~5247afa447, baseline=1.43.0-SNAPSHOT~cd1b746d93
dateFormat X
axisFormat %s
section baseline
no_agent (371.207 µs) : 350, 392
. : milestone, 371,
iast (490.12 µs) : 469, 512
. : milestone, 490,
iast_FULL (647.492 µs) : 626, 669
. : milestone, 647,
iast_GLOBAL (512.116 µs) : 491, 533
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (484.889 µs) : 464, 506
. : milestone, 485,
iast_INACTIVE (454.535 µs) : 433, 476
. : milestone, 455,
iast_TELEMETRY_OFF (471.063 µs) : 450, 492
. : milestone, 471,
tracing (443.859 µs) : 423, 464
. : milestone, 444,
section candidate
no_agent (372.466 µs) : 352, 393
. : milestone, 372,
iast (487.551 µs) : 466, 509
. : milestone, 488,
iast_FULL (650.808 µs) : 629, 672
. : milestone, 651,
iast_GLOBAL (510.895 µs) : 490, 532
. : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (492.852 µs) : 471, 514
. : milestone, 493,
iast_INACTIVE (446.924 µs) : 426, 468
. : milestone, 447,
iast_TELEMETRY_OFF (475.97 µs) : 454, 498
. : milestone, 476,
tracing (441.203 µs) : 421, 462
. : milestone, 441,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~5247afa447, baseline=1.43.0-SNAPSHOT~cd1b746d93
dateFormat X
axisFormat %s
section baseline
no_agent (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
appsec (14.929 s) : 14929000, 14929000
. : milestone, 14929000,
iast (18.742 s) : 18742000, 18742000
. : milestone, 18742000,
iast_GLOBAL (18.098 s) : 18098000, 18098000
. : milestone, 18098000,
profiling (14.92 s) : 14920000, 14920000
. : milestone, 14920000,
tracing (15.286 s) : 15286000, 15286000
. : milestone, 15286000,
section candidate
no_agent (15.206 s) : 15206000, 15206000
. : milestone, 15206000,
appsec (14.926 s) : 14926000, 14926000
. : milestone, 14926000,
iast (18.929 s) : 18929000, 18929000
. : milestone, 18929000,
iast_GLOBAL (17.844 s) : 17844000, 17844000
. : milestone, 17844000,
profiling (15.33 s) : 15330000, 15330000
. : milestone, 15330000,
tracing (14.925 s) : 14925000, 14925000
. : milestone, 14925000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~5247afa447, baseline=1.43.0-SNAPSHOT~cd1b746d93
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.335 ms) : 2295, 2376
. : milestone, 2335,
iast (2.089 ms) : 2037, 2141
. : milestone, 2089,
iast_GLOBAL (2.126 ms) : 2074, 2179
. : milestone, 2126,
profiling (1.965 ms) : 1922, 2008
. : milestone, 1965,
tracing (1.935 ms) : 1895, 1975
. : milestone, 1935,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.337 ms) : 2296, 2378
. : milestone, 2337,
iast (2.081 ms) : 2029, 2133
. : milestone, 2081,
iast_GLOBAL (2.132 ms) : 2079, 2185
. : milestone, 2132,
profiling (2.46 ms) : 2271, 2649
. : milestone, 2460,
tracing (1.931 ms) : 1891, 1972
. : milestone, 1931,
|
ygree
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR only shows the annotation processor notes when notes is enabled.
Motivation
This aims to reduce the noise of the tool running to only the detected issues.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]