Alejandro.gonzalez/security controls #7997

jandro996 · 2024-11-22T07:29:54Z

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-datadog-prod-us1 · 2024-11-22T07:30:37Z

internal-api/src/main/java/datadog/trace/api/iast/securitycontrol/SecurityControl.java

+
+  @Nullable
+  public String[] getParameterTypes() {
+    return parameterTypes;


🟠 Code Quality Violation

Do not return an array that is a class member (...read more)

Avoid returning an array that was defined as a class member. If you want to return an array or the values of the array that is a class member, consider returning a copy of the array.

pr-commenter · 2024-11-22T08:11:12Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/security-controls
git_commit_date	1732608616	1732611243
git_commit_sha	`92e8023`	`5811241`
release_version	1.44.0-SNAPSHOT~92e8023155	1.44.0-SNAPSHOT~58112410a8

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732613598	1732613598
ci_job_id	720140155	720140155
ci_pipeline_id	49939720	49939720
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~58112410a8, baseline=1.44.0-SNAPSHOT~92e8023155

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.097 s) : 0, 1096608
Total [baseline] (10.437 s) : 0, 10437251
Agent [candidate] (1.091 s) : 0, 1090754
Total [candidate] (10.469 s) : 0, 10469337
section appsec
Agent [baseline] (1.23 s) : 0, 1229682
Total [baseline] (10.743 s) : 0, 10743263
Agent [candidate] (1.232 s) : 0, 1231699
Total [candidate] (10.734 s) : 0, 10733700
section iast
Agent [baseline] (1.215 s) : 0, 1215039
Total [baseline] (10.972 s) : 0, 10971935
Agent [candidate] (1.22 s) : 0, 1219749
Total [candidate] (11.002 s) : 0, 11002367
section profiling
Agent [baseline] (1.321 s) : 0, 1321129
Total [baseline] (10.871 s) : 0, 10871081
Agent [candidate] (1.316 s) : 0, 1316203
Total [candidate] (10.881 s) : 0, 10881416

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.097 s	-
Agent	appsec	1.23 s	133.074 ms (12.1%)
Agent	iast	1.215 s	118.431 ms (10.8%)
Agent	profiling	1.321 s	224.521 ms (20.5%)
Total	tracing	10.437 s	-
Total	appsec	10.743 s	306.012 ms (2.9%)
Total	iast	10.972 s	534.684 ms (5.1%)
Total	profiling	10.871 s	433.829 ms (4.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.091 s	-
Agent	appsec	1.232 s	140.945 ms (12.9%)
Agent	iast	1.22 s	128.995 ms (11.8%)
Agent	profiling	1.316 s	225.448 ms (20.7%)
Total	tracing	10.469 s	-
Total	appsec	10.734 s	264.364 ms (2.5%)
Total	iast	11.002 s	533.03 ms (5.1%)
Total	profiling	10.881 s	412.08 ms (3.9%)

gantt
    title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~58112410a8, baseline=1.44.0-SNAPSHOT~92e8023155

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.861 ms) : 0, 697861
BytebuddyAgent [candidate] (692.943 ms) : 0, 692943
GlobalTracer [baseline] (319.46 ms) : 0, 319460
GlobalTracer [candidate] (318.06 ms) : 0, 318060
AppSec [baseline] (54.786 ms) : 0, 54786
AppSec [candidate] (54.584 ms) : 0, 54584
Remote Config [baseline] (689.074 µs) : 0, 689
Remote Config [candidate] (675.915 µs) : 0, 676
Telemetry [baseline] (9.989 ms) : 0, 9989
Telemetry [candidate] (10.775 ms) : 0, 10775
section appsec
BytebuddyAgent [baseline] (714.88 ms) : 0, 714880
BytebuddyAgent [candidate] (715.105 ms) : 0, 715105
GlobalTracer [baseline] (316.252 ms) : 0, 316252
GlobalTracer [candidate] (316.394 ms) : 0, 316394
AppSec [baseline] (166.062 ms) : 0, 166062
AppSec [candidate] (168.508 ms) : 0, 168508
Remote Config [baseline] (651.292 µs) : 0, 651
Remote Config [candidate] (655.614 µs) : 0, 656
Telemetry [baseline] (8.555 ms) : 0, 8555
Telemetry [candidate] (7.866 ms) : 0, 7866
IAST [baseline] (19.027 ms) : 0, 19027
IAST [candidate] (18.763 ms) : 0, 18763
section iast
BytebuddyAgent [baseline] (808.76 ms) : 0, 808760
BytebuddyAgent [candidate] (811.722 ms) : 0, 811722
GlobalTracer [baseline] (305.74 ms) : 0, 305740
GlobalTracer [candidate] (307.574 ms) : 0, 307574
AppSec [baseline] (57.182 ms) : 0, 57182
AppSec [candidate] (57.885 ms) : 0, 57885
Remote Config [baseline] (621.787 µs) : 0, 622
Remote Config [candidate] (625.215 µs) : 0, 625
Telemetry [baseline] (7.516 ms) : 0, 7516
Telemetry [candidate] (7.497 ms) : 0, 7497
IAST [baseline] (21.529 ms) : 0, 21529
IAST [candidate] (20.712 ms) : 0, 20712
section profiling
BytebuddyAgent [baseline] (690.488 ms) : 0, 690488
BytebuddyAgent [candidate] (687.197 ms) : 0, 687197
GlobalTracer [baseline] (435.671 ms) : 0, 435671
GlobalTracer [candidate] (434.596 ms) : 0, 434596
AppSec [baseline] (53.487 ms) : 0, 53487
AppSec [candidate] (53.686 ms) : 0, 53686
Remote Config [baseline] (677.597 µs) : 0, 678
Remote Config [candidate] (654.549 µs) : 0, 655
Telemetry [baseline] (7.765 ms) : 0, 7765
Telemetry [candidate] (7.687 ms) : 0, 7687
ProfilingAgent [baseline] (93.792 ms) : 0, 93792
ProfilingAgent [candidate] (93.294 ms) : 0, 93294
Profiling [baseline] (93.815 ms) : 0, 93815
Profiling [candidate] (93.317 ms) : 0, 93317

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~58112410a8, baseline=1.44.0-SNAPSHOT~92e8023155

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087845
Total [baseline] (8.659 s) : 0, 8658937
Agent [candidate] (1.086 s) : 0, 1086419
Total [candidate] (8.667 s) : 0, 8666754
section iast
Agent [baseline] (1.225 s) : 0, 1224638
Total [baseline] (9.219 s) : 0, 9218695
Agent [candidate] (1.219 s) : 0, 1219042
Total [candidate] (9.204 s) : 0, 9203531
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.218 s) : 0, 1218486
Total [baseline] (9.209 s) : 0, 9209467
Agent [candidate] (1.219 s) : 0, 1218633
Total [candidate] (9.17 s) : 0, 9170287
section iast_TELEMETRY_OFF
Agent [baseline] (1.214 s) : 0, 1214359
Total [baseline] (9.204 s) : 0, 9204014
Agent [candidate] (1.216 s) : 0, 1215796
Total [candidate] (9.199 s) : 0, 9199198

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	iast	1.225 s	136.793 ms (12.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.218 s	130.641 ms (12.0%)
Agent	iast_TELEMETRY_OFF	1.214 s	126.514 ms (11.6%)
Total	tracing	8.659 s	-
Total	iast	9.219 s	559.758 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.209 s	550.53 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.204 s	545.077 ms (6.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.086 s	-
Agent	iast	1.219 s	132.623 ms (12.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.219 s	132.214 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.216 s	129.377 ms (11.9%)
Total	tracing	8.667 s	-
Total	iast	9.204 s	536.777 ms (6.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.17 s	503.533 ms (5.8%)
Total	iast_TELEMETRY_OFF	9.199 s	532.445 ms (6.1%)

gantt
    title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~58112410a8, baseline=1.44.0-SNAPSHOT~92e8023155

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.999 ms) : 0, 692999
BytebuddyAgent [candidate] (691.649 ms) : 0, 691649
GlobalTracer [baseline] (317.352 ms) : 0, 317352
GlobalTracer [candidate] (317.204 ms) : 0, 317204
AppSec [baseline] (54.624 ms) : 0, 54624
AppSec [candidate] (54.597 ms) : 0, 54597
Remote Config [baseline] (682.397 µs) : 0, 682
Remote Config [candidate] (687.637 µs) : 0, 688
Telemetry [baseline] (8.492 ms) : 0, 8492
Telemetry [candidate] (8.561 ms) : 0, 8561
section iast
BytebuddyAgent [baseline] (815.896 ms) : 0, 815896
BytebuddyAgent [candidate] (811.192 ms) : 0, 811192
GlobalTracer [baseline] (307.949 ms) : 0, 307949
GlobalTracer [candidate] (306.855 ms) : 0, 306855
AppSec [baseline] (57.134 ms) : 0, 57134
AppSec [candidate] (55.017 ms) : 0, 55017
IAST [baseline] (21.544 ms) : 0, 21544
IAST [candidate] (24.149 ms) : 0, 24149
Remote Config [baseline] (667.877 µs) : 0, 668
Remote Config [candidate] (610.601 µs) : 0, 611
Telemetry [baseline] (7.513 ms) : 0, 7513
Telemetry [candidate] (7.428 ms) : 0, 7428
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (810.334 ms) : 0, 810334
BytebuddyAgent [candidate] (811.241 ms) : 0, 811241
GlobalTracer [baseline] (307.43 ms) : 0, 307430
GlobalTracer [candidate] (307.043 ms) : 0, 307043
AppSec [baseline] (55.835 ms) : 0, 55835
AppSec [candidate] (57.516 ms) : 0, 57516
IAST [baseline] (23.118 ms) : 0, 23118
IAST [candidate] (20.869 ms) : 0, 20869
Remote Config [baseline] (631.794 µs) : 0, 632
Remote Config [candidate] (637.566 µs) : 0, 638
Telemetry [baseline] (7.423 ms) : 0, 7423
Telemetry [candidate] (7.535 ms) : 0, 7535
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (807.376 ms) : 0, 807376
BytebuddyAgent [candidate] (808.842 ms) : 0, 808842
GlobalTracer [baseline] (306.754 ms) : 0, 306754
GlobalTracer [candidate] (306.914 ms) : 0, 306914
AppSec [baseline] (57.27 ms) : 0, 57270
AppSec [candidate] (56.935 ms) : 0, 56935
IAST [baseline] (21.165 ms) : 0, 21165
IAST [candidate] (21.33 ms) : 0, 21330
Remote Config [baseline] (611.847 µs) : 0, 612
Remote Config [candidate] (631.158 µs) : 0, 631
Telemetry [baseline] (7.44 ms) : 0, 7440
Telemetry [candidate] (7.342 ms) : 0, 7342

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-11-26T09:03:26	2024-11-26T09:10:24
git_branch	master	alejandro.gonzalez/security-controls
git_commit_date	1732608616	1732611243
git_commit_sha	`92e8023`	`5811241`
release_version	1.44.0-SNAPSHOT~92e8023155	1.44.0-SNAPSHOT~58112410a8
start_time	2024-11-26T09:03:13	2024-11-26T09:10:11

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1732612578	1732612578
ci_job_id	720140157	720140157
ci_pipeline_id	49939720	49939720
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~58112410a8, baseline=1.44.0-SNAPSHOT~92e8023155
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.413 µs) : 357, 398
.   : milestone, 377,
iast (489.994 µs) : 468, 512
.   : milestone, 490,
iast_FULL (651.82 µs) : 630, 673
.   : milestone, 652,
iast_GLOBAL (523.231 µs) : 501, 546
.   : milestone, 523,
iast_HARDCODED_SECRET_DISABLED (490.982 µs) : 470, 512
.   : milestone, 491,
iast_INACTIVE (452.599 µs) : 431, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (482.044 µs) : 460, 504
.   : milestone, 482,
tracing (453.262 µs) : 432, 474
.   : milestone, 453,
section candidate
no_agent (374.202 µs) : 355, 394
.   : milestone, 374,
iast (487.156 µs) : 466, 508
.   : milestone, 487,
iast_FULL (651.179 µs) : 630, 673
.   : milestone, 651,
iast_GLOBAL (519.564 µs) : 497, 542
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (489.244 µs) : 468, 511
.   : milestone, 489,
iast_INACTIVE (452.203 µs) : 431, 474
.   : milestone, 452,
iast_TELEMETRY_OFF (483.932 µs) : 462, 506
.   : milestone, 484,
tracing (452.154 µs) : 430, 474
.   : milestone, 452,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.413 µs [357.251 µs, 397.574 µs]	-
iast	489.994 µs [468.292 µs, 511.696 µs]	112.581 µs (29.8%)
iast_FULL	651.82 µs [630.184 µs, 673.456 µs]	274.407 µs (72.7%)
iast_GLOBAL	523.231 µs [500.86 µs, 545.602 µs]	145.818 µs (38.6%)
iast_HARDCODED_SECRET_DISABLED	490.982 µs [469.691 µs, 512.272 µs]	113.569 µs (30.1%)
iast_INACTIVE	452.599 µs [430.903 µs, 474.295 µs]	75.186 µs (19.9%)
iast_TELEMETRY_OFF	482.044 µs [460.363 µs, 503.725 µs]	104.632 µs (27.7%)
tracing	453.262 µs [432.247 µs, 474.277 µs]	75.849 µs (20.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	374.202 µs [354.751 µs, 393.654 µs]	-
iast	487.156 µs [465.825 µs, 508.487 µs]	112.954 µs (30.2%)
iast_FULL	651.179 µs [629.624 µs, 672.734 µs]	276.977 µs (74.0%)
iast_GLOBAL	519.564 µs [497.407 µs, 541.72 µs]	145.361 µs (38.8%)
iast_HARDCODED_SECRET_DISABLED	489.244 µs [467.633 µs, 510.856 µs]	115.042 µs (30.7%)
iast_INACTIVE	452.203 µs [430.731 µs, 473.674 µs]	78.0 µs (20.8%)
iast_TELEMETRY_OFF	483.932 µs [461.654 µs, 506.21 µs]	109.73 µs (29.3%)
tracing	452.154 µs [430.332 µs, 473.975 µs]	77.951 µs (20.8%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~58112410a8, baseline=1.44.0-SNAPSHOT~92e8023155
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1365
.   : milestone, 1346,
appsec (1.739 ms) : 1714, 1765
.   : milestone, 1739,
appsec_no_iast (1.74 ms) : 1715, 1764
.   : milestone, 1740,
iast (1.509 ms) : 1487, 1532
.   : milestone, 1509,
profiling (1.497 ms) : 1473, 1520
.   : milestone, 1497,
tracing (1.502 ms) : 1478, 1526
.   : milestone, 1502,
section candidate
no_agent (1.359 ms) : 1339, 1378
.   : milestone, 1359,
appsec (1.741 ms) : 1717, 1764
.   : milestone, 1741,
appsec_no_iast (1.754 ms) : 1729, 1779
.   : milestone, 1754,
iast (1.524 ms) : 1502, 1546
.   : milestone, 1524,
profiling (1.509 ms) : 1484, 1534
.   : milestone, 1509,
tracing (1.474 ms) : 1449, 1499
.   : milestone, 1474,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.346 ms [1.327 ms, 1.365 ms]	-
appsec	1.739 ms [1.714 ms, 1.765 ms]	393.294 µs (29.2%)
appsec_no_iast	1.74 ms [1.715 ms, 1.764 ms]	393.638 µs (29.2%)
iast	1.509 ms [1.487 ms, 1.532 ms]	163.436 µs (12.1%)
profiling	1.497 ms [1.473 ms, 1.52 ms]	150.868 µs (11.2%)
tracing	1.502 ms [1.478 ms, 1.526 ms]	155.808 µs (11.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.359 ms [1.339 ms, 1.378 ms]	-
appsec	1.741 ms [1.717 ms, 1.764 ms]	382.135 µs (28.1%)
appsec_no_iast	1.754 ms [1.729 ms, 1.779 ms]	395.453 µs (29.1%)
iast	1.524 ms [1.502 ms, 1.546 ms]	165.402 µs (12.2%)
profiling	1.509 ms [1.484 ms, 1.534 ms]	150.262 µs (11.1%)
tracing	1.474 ms [1.449 ms, 1.499 ms]	115.018 µs (8.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/security-controls
git_commit_date	1732608616	1732611243
git_commit_sha	`92e8023`	`5811241`
release_version	1.44.0-SNAPSHOT~92e8023155	1.44.0-SNAPSHOT~58112410a8

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1732613117	1732613117
ci_job_id	720140160	720140160
ci_pipeline_id	49939720	49939720
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~58112410a8, baseline=1.44.0-SNAPSHOT~92e8023155
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.362 ms) : 2320, 2404
.   : milestone, 2362,
iast (2.094 ms) : 2042, 2147
.   : milestone, 2094,
iast_GLOBAL (2.135 ms) : 2082, 2188
.   : milestone, 2135,
profiling (1.954 ms) : 1912, 1996
.   : milestone, 1954,
tracing (1.939 ms) : 1899, 1980
.   : milestone, 1939,
section candidate
no_agent (1.475 ms) : 1463, 1487
.   : milestone, 1475,
appsec (2.348 ms) : 2306, 2389
.   : milestone, 2348,
iast (2.104 ms) : 2051, 2157
.   : milestone, 2104,
iast_GLOBAL (2.147 ms) : 2094, 2201
.   : milestone, 2147,
profiling (2.45 ms) : 2262, 2638
.   : milestone, 2450,
tracing (1.936 ms) : 1896, 1977
.   : milestone, 1936,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.463 ms, 1.486 ms]	-
appsec	2.362 ms [2.32 ms, 2.404 ms]	887.733 µs (60.2%)
iast	2.094 ms [2.042 ms, 2.147 ms]	620.156 µs (42.1%)
iast_GLOBAL	2.135 ms [2.082 ms, 2.188 ms]	660.919 µs (44.8%)
profiling	1.954 ms [1.912 ms, 1.996 ms]	479.814 µs (32.5%)
tracing	1.939 ms [1.899 ms, 1.98 ms]	465.09 µs (31.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.463 ms, 1.487 ms]	-
appsec	2.348 ms [2.306 ms, 2.389 ms]	872.538 µs (59.2%)
iast	2.104 ms [2.051 ms, 2.157 ms]	628.736 µs (42.6%)
iast_GLOBAL	2.147 ms [2.094 ms, 2.201 ms]	672.308 µs (45.6%)
profiling	2.45 ms [2.262 ms, 2.638 ms]	974.703 µs (66.1%)
tracing	1.936 ms [1.896 ms, 1.977 ms]	461.49 µs (31.3%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~58112410a8, baseline=1.44.0-SNAPSHOT~92e8023155
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.925 s) : 14925000, 14925000
.   : milestone, 14925000,
appsec (14.979 s) : 14979000, 14979000
.   : milestone, 14979000,
iast (18.514 s) : 18514000, 18514000
.   : milestone, 18514000,
iast_GLOBAL (17.862 s) : 17862000, 17862000
.   : milestone, 17862000,
profiling (14.735 s) : 14735000, 14735000
.   : milestone, 14735000,
tracing (15.141 s) : 15141000, 15141000
.   : milestone, 15141000,
section candidate
no_agent (15.51 s) : 15510000, 15510000
.   : milestone, 15510000,
appsec (15.011 s) : 15011000, 15011000
.   : milestone, 15011000,
iast (18.456 s) : 18456000, 18456000
.   : milestone, 18456000,
iast_GLOBAL (18.258 s) : 18258000, 18258000
.   : milestone, 18258000,
profiling (14.961 s) : 14961000, 14961000
.   : milestone, 14961000,
tracing (15.003 s) : 15003000, 15003000
.   : milestone, 15003000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.925 s [14.925 s, 14.925 s]	-
appsec	14.979 s [14.979 s, 14.979 s]	54.0 ms (0.4%)
iast	18.514 s [18.514 s, 18.514 s]	3.589 s (24.0%)
iast_GLOBAL	17.862 s [17.862 s, 17.862 s]	2.937 s (19.7%)
profiling	14.735 s [14.735 s, 14.735 s]	-190.0 ms (-1.3%)
tracing	15.141 s [15.141 s, 15.141 s]	216.0 ms (1.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.51 s [15.51 s, 15.51 s]	-
appsec	15.011 s [15.011 s, 15.011 s]	-499.0 ms (-3.2%)
iast	18.456 s [18.456 s, 18.456 s]	2.946 s (19.0%)
iast_GLOBAL	18.258 s [18.258 s, 18.258 s]	2.748 s (17.7%)
profiling	14.961 s [14.961 s, 14.961 s]	-549.0 ms (-3.5%)
tracing	15.003 s [15.003 s, 15.003 s]	-507.0 ms (-3.3%)

jandro996 added the comp: asm iast Application Security Management (IAST) label Nov 22, 2024

datadog-datadog-prod-us1 bot reviewed Nov 22, 2024

View reviewed changes

jandro996 added 16 commits November 25, 2024 10:22

formatter and config POC

33e591f

more changes

bd5ca47

Not working maybe need to rollback

029e3d1

use IastSystem

10e5312

First working version

108cb99

Add more stacktrace cases

212a37a

first review

cfeab27

Fix test and forbidden apis

9fe5818

fix spotless

5277b60

fix spotless

803b881

fix test

34f763c

fix test

b565177

Add test and fix coverage

1b20b62

remove security control enabled env var

64435a2

fix classVisitor

2d3298c

change array for list

7362963

jandro996 force-pushed the alejandro.gonzalez/security-controls branch from 43c6e55 to 7362963 Compare November 25, 2024 09:23

jandro996 added 8 commits November 25, 2024 10:51

fix test

2617fcd

Add unit test for IastSecurityControlTransformer

ec4f68d

improve test

0d1fec6

fix onUnexpectedException message

2641d7d

Merge branch 'master' into alejandro.gonzalez/security-controls

863083f

fix codenarc

570a3c9

change to forked tests

bfc618d

fix spotless

5811241

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alejandro.gonzalez/security controls #7997

Alejandro.gonzalez/security controls #7997

jandro996 commented Nov 22, 2024

datadog-datadog-prod-us1 bot Nov 22, 2024

pr-commenter bot commented Nov 22, 2024 •

edited

Loading

Alejandro.gonzalez/security controls #7997

Are you sure you want to change the base?

Alejandro.gonzalez/security controls #7997

Conversation

jandro996 commented Nov 22, 2024

What Does This Do

Motivation

Additional Notes

Contributor Checklist

datadog-datadog-prod-us1 bot Nov 22, 2024

Choose a reason for hiding this comment

🟠 Code Quality Violation

pr-commenter bot commented Nov 22, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

pr-commenter bot commented Nov 22, 2024 •

edited

Loading