-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Muzzle classes for Groovy instrumentations #8004
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/generate-muzzle-for-groovy-instrumentations
Nov 27, 2024
Merged
Generate Muzzle classes for Groovy instrumentations #8004
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/generate-muzzle-for-groovy-instrumentations
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.43.0-SNAPSHOT~7ca94c8ef1, baseline=1.43.0-SNAPSHOT~79ca6e471f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1096120
Total [baseline] (8.675 s) : 0, 8674989
Agent [candidate] (1.089 s) : 0, 1089002
Total [candidate] (8.634 s) : 0, 8633570
section iast
Agent [baseline] (1.217 s) : 0, 1217169
Total [baseline] (9.191 s) : 0, 9191255
Agent [candidate] (1.215 s) : 0, 1214753
Total [candidate] (9.19 s) : 0, 9189819
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.219 s) : 0, 1219470
Total [baseline] (9.207 s) : 0, 9207476
Agent [candidate] (1.218 s) : 0, 1217921
Total [candidate] (9.212 s) : 0, 9212292
section iast_TELEMETRY_OFF
Agent [baseline] (1.214 s) : 0, 1213926
Total [baseline] (9.19 s) : 0, 9190208
Agent [candidate] (1.215 s) : 0, 1215079
Total [candidate] (9.186 s) : 0, 9186102
gantt
title insecure-bank - break down per module: candidate=1.43.0-SNAPSHOT~7ca94c8ef1, baseline=1.43.0-SNAPSHOT~79ca6e471f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.209 ms) : 0, 696209
BytebuddyAgent [candidate] (692.193 ms) : 0, 692193
GlobalTracer [baseline] (319.077 ms) : 0, 319077
GlobalTracer [candidate] (317.182 ms) : 0, 317182
AppSec [baseline] (54.964 ms) : 0, 54964
AppSec [candidate] (54.484 ms) : 0, 54484
Remote Config [baseline] (686.482 µs) : 0, 686
Remote Config [candidate] (683.496 µs) : 0, 683
Telemetry [baseline] (11.378 ms) : 0, 11378
Telemetry [candidate] (10.738 ms) : 0, 10738
section iast
BytebuddyAgent [baseline] (810.019 ms) : 0, 810019
BytebuddyAgent [candidate] (808.034 ms) : 0, 808034
GlobalTracer [baseline] (306.852 ms) : 0, 306852
GlobalTracer [candidate] (306.325 ms) : 0, 306325
AppSec [baseline] (56.987 ms) : 0, 56987
AppSec [candidate] (57.089 ms) : 0, 57089
IAST [baseline] (21.463 ms) : 0, 21463
IAST [candidate] (21.529 ms) : 0, 21529
Remote Config [baseline] (613.433 µs) : 0, 613
Remote Config [candidate] (617.928 µs) : 0, 618
Telemetry [baseline] (7.498 ms) : 0, 7498
Telemetry [candidate] (7.477 ms) : 0, 7477
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (809.964 ms) : 0, 809964
BytebuddyAgent [candidate] (809.853 ms) : 0, 809853
GlobalTracer [baseline] (307.369 ms) : 0, 307369
GlobalTracer [candidate] (306.681 ms) : 0, 306681
AppSec [baseline] (56.46 ms) : 0, 56460
AppSec [candidate] (58.377 ms) : 0, 58377
IAST [baseline] (23.758 ms) : 0, 23758
IAST [candidate] (21.025 ms) : 0, 21025
Remote Config [baseline] (624.28 µs) : 0, 624
Remote Config [candidate] (633.607 µs) : 0, 634
Telemetry [baseline] (7.544 ms) : 0, 7544
Telemetry [candidate] (7.596 ms) : 0, 7596
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (805.983 ms) : 0, 805983
BytebuddyAgent [candidate] (807.352 ms) : 0, 807352
GlobalTracer [baseline] (307.662 ms) : 0, 307662
GlobalTracer [candidate] (307.366 ms) : 0, 307366
AppSec [baseline] (58.294 ms) : 0, 58294
AppSec [candidate] (57.462 ms) : 0, 57462
IAST [baseline] (20.313 ms) : 0, 20313
IAST [candidate] (21.134 ms) : 0, 21134
Remote Config [baseline] (625.902 µs) : 0, 626
Remote Config [candidate] (644.642 µs) : 0, 645
Telemetry [baseline] (7.373 ms) : 0, 7373
Telemetry [candidate] (7.405 ms) : 0, 7405
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.43.0-SNAPSHOT~7ca94c8ef1, baseline=1.43.0-SNAPSHOT~79ca6e471f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1093027
Total [baseline] (10.489 s) : 0, 10489176
Agent [candidate] (1.09 s) : 0, 1090245
Total [candidate] (10.443 s) : 0, 10442914
section appsec
Agent [baseline] (1.225 s) : 0, 1225271
Total [baseline] (10.763 s) : 0, 10763170
Agent [candidate] (1.228 s) : 0, 1228498
Total [candidate] (10.753 s) : 0, 10753195
section iast
Agent [baseline] (1.216 s) : 0, 1215965
Total [baseline] (10.984 s) : 0, 10983656
Agent [candidate] (1.218 s) : 0, 1217774
Total [candidate] (10.958 s) : 0, 10957888
section profiling
Agent [baseline] (1.324 s) : 0, 1323616
Total [baseline] (10.853 s) : 0, 10852889
Agent [candidate] (1.326 s) : 0, 1326360
Total [candidate] (10.905 s) : 0, 10905456
gantt
title petclinic - break down per module: candidate=1.43.0-SNAPSHOT~7ca94c8ef1, baseline=1.43.0-SNAPSHOT~79ca6e471f
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.673 ms) : 0, 697673
BytebuddyAgent [candidate] (694.141 ms) : 0, 694141
GlobalTracer [baseline] (317.713 ms) : 0, 317713
GlobalTracer [candidate] (318.434 ms) : 0, 318434
AppSec [baseline] (54.513 ms) : 0, 54513
AppSec [candidate] (54.677 ms) : 0, 54677
Remote Config [baseline] (697.551 µs) : 0, 698
Remote Config [candidate] (684.159 µs) : 0, 684
Telemetry [baseline] (8.614 ms) : 0, 8614
Telemetry [candidate] (8.569 ms) : 0, 8569
section appsec
BytebuddyAgent [baseline] (710.669 ms) : 0, 710669
BytebuddyAgent [candidate] (712.934 ms) : 0, 712934
GlobalTracer [baseline] (314.505 ms) : 0, 314505
GlobalTracer [candidate] (315.651 ms) : 0, 315651
AppSec [baseline] (167.98 ms) : 0, 167980
AppSec [candidate] (166.246 ms) : 0, 166246
IAST [baseline] (20.536 ms) : 0, 20536
IAST [candidate] (19.921 ms) : 0, 19921
Remote Config [baseline] (655.851 µs) : 0, 656
Remote Config [candidate] (648.174 µs) : 0, 648
Telemetry [baseline] (7.484 ms) : 0, 7484
Telemetry [candidate] (9.318 ms) : 0, 9318
section iast
BytebuddyAgent [baseline] (808.316 ms) : 0, 808316
BytebuddyAgent [candidate] (809.846 ms) : 0, 809846
GlobalTracer [baseline] (306.483 ms) : 0, 306483
GlobalTracer [candidate] (306.963 ms) : 0, 306963
AppSec [baseline] (57.621 ms) : 0, 57621
AppSec [candidate] (57.353 ms) : 0, 57353
IAST [baseline] (21.687 ms) : 0, 21687
IAST [candidate] (21.734 ms) : 0, 21734
Remote Config [baseline] (621.903 µs) : 0, 622
Remote Config [candidate] (622.955 µs) : 0, 623
Telemetry [baseline] (7.553 ms) : 0, 7553
Telemetry [candidate] (7.531 ms) : 0, 7531
section profiling
BytebuddyAgent [baseline] (691.976 ms) : 0, 691976
BytebuddyAgent [candidate] (691.081 ms) : 0, 691081
GlobalTracer [baseline] (436.335 ms) : 0, 436335
GlobalTracer [candidate] (439.032 ms) : 0, 439032
AppSec [baseline] (53.559 ms) : 0, 53559
AppSec [candidate] (54.222 ms) : 0, 54222
Remote Config [baseline] (675.769 µs) : 0, 676
Remote Config [candidate] (661.697 µs) : 0, 662
Telemetry [baseline] (7.814 ms) : 0, 7814
Telemetry [candidate] (7.826 ms) : 0, 7826
ProfilingAgent [baseline] (93.935 ms) : 0, 93935
ProfilingAgent [candidate] (94.283 ms) : 0, 94283
Profiling [baseline] (93.958 ms) : 0, 93958
Profiling [candidate] (94.307 ms) : 0, 94307
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~7ca94c8ef1, baseline=1.43.0-SNAPSHOT~79ca6e471f
dateFormat X
axisFormat %s
section baseline
no_agent (374.131 µs) : 354, 394
. : milestone, 374,
iast (491.82 µs) : 470, 514
. : milestone, 492,
iast_FULL (650.523 µs) : 629, 672
. : milestone, 651,
iast_GLOBAL (512.272 µs) : 491, 534
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (489.779 µs) : 468, 511
. : milestone, 490,
iast_INACTIVE (450.839 µs) : 429, 472
. : milestone, 451,
iast_TELEMETRY_OFF (479.679 µs) : 458, 501
. : milestone, 480,
tracing (438.478 µs) : 418, 459
. : milestone, 438,
section candidate
no_agent (375.688 µs) : 356, 395
. : milestone, 376,
iast (483.74 µs) : 462, 505
. : milestone, 484,
iast_FULL (654.604 µs) : 633, 676
. : milestone, 655,
iast_GLOBAL (512.1 µs) : 491, 533
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (487.14 µs) : 466, 508
. : milestone, 487,
iast_INACTIVE (453.883 µs) : 432, 476
. : milestone, 454,
iast_TELEMETRY_OFF (472.431 µs) : 451, 494
. : milestone, 472,
tracing (438.912 µs) : 418, 460
. : milestone, 439,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.43.0-SNAPSHOT~7ca94c8ef1, baseline=1.43.0-SNAPSHOT~79ca6e471f
dateFormat X
axisFormat %s
section baseline
no_agent (1.347 ms) : 1326, 1367
. : milestone, 1347,
appsec (1.743 ms) : 1718, 1767
. : milestone, 1743,
appsec_no_iast (1.751 ms) : 1727, 1776
. : milestone, 1751,
iast (1.479 ms) : 1456, 1502
. : milestone, 1479,
profiling (1.509 ms) : 1485, 1533
. : milestone, 1509,
tracing (1.492 ms) : 1468, 1516
. : milestone, 1492,
section candidate
no_agent (1.35 ms) : 1331, 1370
. : milestone, 1350,
appsec (1.741 ms) : 1717, 1765
. : milestone, 1741,
appsec_no_iast (1.759 ms) : 1735, 1784
. : milestone, 1759,
iast (1.489 ms) : 1467, 1512
. : milestone, 1489,
profiling (1.514 ms) : 1489, 1539
. : milestone, 1514,
tracing (1.487 ms) : 1463, 1510
. : milestone, 1487,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~7ca94c8ef1, baseline=1.43.0-SNAPSHOT~79ca6e471f
dateFormat X
axisFormat %s
section baseline
no_agent (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
appsec (14.736 s) : 14736000, 14736000
. : milestone, 14736000,
iast (18.817 s) : 18817000, 18817000
. : milestone, 18817000,
iast_GLOBAL (18.034 s) : 18034000, 18034000
. : milestone, 18034000,
profiling (15.01 s) : 15010000, 15010000
. : milestone, 15010000,
tracing (15.199 s) : 15199000, 15199000
. : milestone, 15199000,
section candidate
no_agent (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
appsec (14.879 s) : 14879000, 14879000
. : milestone, 14879000,
iast (18.459 s) : 18459000, 18459000
. : milestone, 18459000,
iast_GLOBAL (17.937 s) : 17937000, 17937000
. : milestone, 17937000,
profiling (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
tracing (15.022 s) : 15022000, 15022000
. : milestone, 15022000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.43.0-SNAPSHOT~7ca94c8ef1, baseline=1.43.0-SNAPSHOT~79ca6e471f
dateFormat X
axisFormat %s
section baseline
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (2.333 ms) : 2292, 2374
. : milestone, 2333,
iast (2.086 ms) : 2034, 2139
. : milestone, 2086,
iast_GLOBAL (2.118 ms) : 2066, 2171
. : milestone, 2118,
profiling (1.964 ms) : 1921, 2007
. : milestone, 1964,
tracing (1.92 ms) : 1880, 1960
. : milestone, 1920,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (2.335 ms) : 2294, 2376
. : milestone, 2335,
iast (2.076 ms) : 2024, 2128
. : milestone, 2076,
iast_GLOBAL (2.115 ms) : 2063, 2167
. : milestone, 2115,
profiling (1.951 ms) : 1909, 1992
. : milestone, 1951,
tracing (1.918 ms) : 1879, 1958
. : milestone, 1918,
|
ygree
approved these changes
Nov 27, 2024
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/generate-muzzle-for-groovy-instrumentations
branch
November 27, 2024 22:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates the build logic so that
$Muzzle
classes are generated for instrumentations that are written in Groovy.Motivation
Currently the Muzzle classes are only generated for Java, Scala, and Kotlin code.
There are instrumentations written in Groovy (
gradle-3.0
andgradle-8.3
).Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: SCV-208