Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use method enter advices for vert.x session blocking #8225

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Use method enter advices for vert.x session blocking #8225

merged 1 commit into from
Jan 16, 2025

Conversation

manuel-alvarez-alvarez
Copy link
Member

What Does This Do

Move blocking behavior to method enter in vert.x session tracking.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@manuel-alvarez-alvarez manuel-alvarez-alvarez added tag: no release notes Changes to exclude from release notes type: refactoring comp: asm waf Application Security Management (WAF) inst: vertx Eclipse Vert.x instrumentation labels Jan 16, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-vertx-session-fix branch from 956d7b9 to d88adb1 Compare January 16, 2025 10:10
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title Malvarez/waf vertx session fix Use method enter advices for vert.x session blocking Jan 16, 2025
amarziali
amarziali approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for IDM. It only concerns asm

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-vertx-session-fix
git_commit_date 1737020324 1737022214
git_commit_sha 148aef9 d88adb1
release_version 1.46.0-SNAPSHOT~148aef92ab 1.46.0-SNAPSHOT~d88adb1f94
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737024615 1737024615
ci_job_id 768641857 768641857
ci_pipeline_id 53162153 53162153
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~d88adb1f94, baseline=1.46.0-SNAPSHOT~148aef92ab

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055743
Total [baseline] (10.639 s) : 0, 10639450
Agent [candidate] (1.057 s) : 0, 1057216
Total [candidate] (10.533 s) : 0, 10533168
section appsec
Agent [baseline] (1.195 s) : 0, 1194885
Total [baseline] (10.705 s) : 0, 10705090
Agent [candidate] (1.2 s) : 0, 1200025
Total [candidate] (10.768 s) : 0, 10768442
section iast
Agent [baseline] (1.191 s) : 0, 1190567
Total [baseline] (10.981 s) : 0, 10980582
Agent [candidate] (1.193 s) : 0, 1192631
Total [candidate] (11.129 s) : 0, 11128577
section profiling
Agent [baseline] (1.255 s) : 0, 1254502
Total [baseline] (10.823 s) : 0, 10822545
Agent [candidate] (1.254 s) : 0, 1254162
Total [candidate] (10.865 s) : 0, 10864956
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.195 s 139.142 ms (13.2%)
Agent iast 1.191 s 134.824 ms (12.8%)
Agent profiling 1.255 s 198.759 ms (18.8%)
Total tracing 10.639 s -
Total appsec 10.705 s 65.641 ms (0.6%)
Total iast 10.981 s 341.133 ms (3.2%)
Total profiling 10.823 s 183.096 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent appsec 1.2 s 142.81 ms (13.5%)
Agent iast 1.193 s 135.416 ms (12.8%)
Agent profiling 1.254 s 196.946 ms (18.6%)
Total tracing 10.533 s -
Total appsec 10.768 s 235.274 ms (2.2%)
Total iast 11.129 s 595.409 ms (5.7%)
Total profiling 10.865 s 331.788 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~d88adb1f94, baseline=1.46.0-SNAPSHOT~148aef92ab

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.571 ms) : 0, 714571
BytebuddyAgent [candidate] (715.163 ms) : 0, 715163
GlobalTracer [baseline] (256.391 ms) : 0, 256391
GlobalTracer [candidate] (256.185 ms) : 0, 256185
AppSec [baseline] (55.286 ms) : 0, 55286
AppSec [candidate] (55.468 ms) : 0, 55468
Remote Config [baseline] (725.42 µs) : 0, 725
Remote Config [candidate] (739.846 µs) : 0, 740
Telemetry [baseline] (13.79 ms) : 0, 13790
Telemetry [candidate] (14.58 ms) : 0, 14580
section appsec
BytebuddyAgent [baseline] (735.299 ms) : 0, 735299
BytebuddyAgent [candidate] (738.31 ms) : 0, 738310
GlobalTracer [baseline] (254.204 ms) : 0, 254204
GlobalTracer [candidate] (255.381 ms) : 0, 255381
AppSec [baseline] (171.257 ms) : 0, 171257
AppSec [candidate] (172.213 ms) : 0, 172213
IAST [baseline] (19.636 ms) : 0, 19636
IAST [candidate] (19.656 ms) : 0, 19656
Remote Config [baseline] (663.895 µs) : 0, 664
Remote Config [candidate] (678.245 µs) : 0, 678
Telemetry [baseline] (8.526 ms) : 0, 8526
Telemetry [candidate] (8.37 ms) : 0, 8370
section iast
BytebuddyAgent [baseline] (837.808 ms) : 0, 837808
BytebuddyAgent [candidate] (839.674 ms) : 0, 839674
GlobalTracer [baseline] (248.414 ms) : 0, 248414
GlobalTracer [candidate] (248.884 ms) : 0, 248884
AppSec [baseline] (58.214 ms) : 0, 58214
AppSec [candidate] (58.234 ms) : 0, 58234
IAST [baseline] (21.519 ms) : 0, 21519
IAST [candidate] (21.257 ms) : 0, 21257
Remote Config [baseline] (684.983 µs) : 0, 685
Remote Config [candidate] (672.87 µs) : 0, 673
Telemetry [baseline] (8.878 ms) : 0, 8878
Telemetry [candidate] (8.715 ms) : 0, 8715
section profiling
BytebuddyAgent [baseline] (703.198 ms) : 0, 703198
BytebuddyAgent [candidate] (703.83 ms) : 0, 703830
GlobalTracer [baseline] (349.707 ms) : 0, 349707
GlobalTracer [candidate] (350.141 ms) : 0, 350141
AppSec [baseline] (54.395 ms) : 0, 54395
AppSec [candidate] (53.646 ms) : 0, 53646
Remote Config [baseline] (669.913 µs) : 0, 670
Remote Config [candidate] (672.206 µs) : 0, 672
Telemetry [baseline] (8.812 ms) : 0, 8812
Telemetry [candidate] (8.856 ms) : 0, 8856
ProfilingAgent [baseline] (95.664 ms) : 0, 95664
ProfilingAgent [candidate] (94.952 ms) : 0, 94952
Profiling [baseline] (95.687 ms) : 0, 95687
Profiling [candidate] (94.977 ms) : 0, 94977
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~d88adb1f94, baseline=1.46.0-SNAPSHOT~148aef92ab

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061086
Total [baseline] (8.633 s) : 0, 8632548
Agent [candidate] (1.076 s) : 0, 1076105
Total [candidate] (8.709 s) : 0, 8709383
section iast
Agent [baseline] (1.19 s) : 0, 1189692
Total [baseline] (9.266 s) : 0, 9266474
Agent [candidate] (1.185 s) : 0, 1185404
Total [candidate] (9.191 s) : 0, 9190858
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1182925
Total [baseline] (9.158 s) : 0, 9158171
Agent [candidate] (1.184 s) : 0, 1183923
Total [candidate] (9.207 s) : 0, 9207157
section iast_TELEMETRY_OFF
Agent [baseline] (1.186 s) : 0, 1185797
Total [baseline] (9.196 s) : 0, 9195776
Agent [candidate] (1.178 s) : 0, 1177594
Total [candidate] (9.189 s) : 0, 9188856
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent iast 1.19 s 128.606 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.183 s 121.84 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.186 s 124.711 ms (11.8%)
Total tracing 8.633 s -
Total iast 9.266 s 633.927 ms (7.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.158 s 525.623 ms (6.1%)
Total iast_TELEMETRY_OFF 9.196 s 563.228 ms (6.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.185 s 109.299 ms (10.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.184 s 107.818 ms (10.0%)
Agent iast_TELEMETRY_OFF 1.178 s 101.489 ms (9.4%)
Total tracing 8.709 s -
Total iast 9.191 s 481.475 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.207 s 497.774 ms (5.7%)
Total iast_TELEMETRY_OFF 9.189 s 479.473 ms (5.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~d88adb1f94, baseline=1.46.0-SNAPSHOT~148aef92ab

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.234 ms) : 0, 718234
BytebuddyAgent [candidate] (730.308 ms) : 0, 730308
GlobalTracer [baseline] (257.194 ms) : 0, 257194
GlobalTracer [candidate] (259.757 ms) : 0, 259757
AppSec [baseline] (55.454 ms) : 0, 55454
AppSec [candidate] (56.016 ms) : 0, 56016
Remote Config [baseline] (727.212 µs) : 0, 727
Remote Config [candidate] (729.012 µs) : 0, 729
Telemetry [baseline] (14.34 ms) : 0, 14340
Telemetry [candidate] (13.978 ms) : 0, 13978
section iast
BytebuddyAgent [baseline] (837.017 ms) : 0, 837017
BytebuddyAgent [candidate] (833.785 ms) : 0, 833785
GlobalTracer [baseline] (248.202 ms) : 0, 248202
GlobalTracer [candidate] (247.19 ms) : 0, 247190
AppSec [baseline] (58.127 ms) : 0, 58127
AppSec [candidate] (58.088 ms) : 0, 58088
IAST [baseline] (21.741 ms) : 0, 21741
IAST [candidate] (21.663 ms) : 0, 21663
Remote Config [baseline] (685.318 µs) : 0, 685
Remote Config [candidate] (684.838 µs) : 0, 685
Telemetry [baseline] (8.959 ms) : 0, 8959
Telemetry [candidate] (8.924 ms) : 0, 8924
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.055 ms) : 0, 832055
BytebuddyAgent [candidate] (832.406 ms) : 0, 832406
GlobalTracer [baseline] (247.062 ms) : 0, 247062
GlobalTracer [candidate] (247.246 ms) : 0, 247246
AppSec [baseline] (58.038 ms) : 0, 58038
AppSec [candidate] (58.12 ms) : 0, 58120
IAST [baseline] (21.291 ms) : 0, 21291
IAST [candidate] (21.677 ms) : 0, 21677
Remote Config [baseline] (668.904 µs) : 0, 669
Remote Config [candidate] (677.985 µs) : 0, 678
Telemetry [baseline] (8.724 ms) : 0, 8724
Telemetry [candidate] (8.745 ms) : 0, 8745
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.536 ms) : 0, 834536
BytebuddyAgent [candidate] (827.76 ms) : 0, 827760
GlobalTracer [baseline] (248.309 ms) : 0, 248309
GlobalTracer [candidate] (246.591 ms) : 0, 246591
AppSec [baseline] (57.699 ms) : 0, 57699
AppSec [candidate] (57.968 ms) : 0, 57968
IAST [baseline] (20.835 ms) : 0, 20835
IAST [candidate] (20.966 ms) : 0, 20966
Remote Config [baseline] (671.586 µs) : 0, 672
Remote Config [candidate] (675.041 µs) : 0, 675
Telemetry [baseline] (8.595 ms) : 0, 8595
Telemetry [candidate] (8.625 ms) : 0, 8625
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-16T10:20:10 2025-01-16T10:27:16
git_branch master malvarez/waf-vertx-session-fix
git_commit_date 1737020324 1737022214
git_commit_sha 148aef9 d88adb1
release_version 1.46.0-SNAPSHOT~148aef92ab 1.46.0-SNAPSHOT~d88adb1f94
start_time 2025-01-16T10:19:56 2025-01-16T10:27:02
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737023596 1737023596
ci_job_id 768641858 768641858
ci_pipeline_id 53162153 53162153
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~d88adb1f94, baseline=1.46.0-SNAPSHOT~148aef92ab
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.764 µs) : 360, 400
.   : milestone, 380,
iast (515.533 µs) : 493, 538
.   : milestone, 516,
iast_FULL (746.971 µs) : 725, 769
.   : milestone, 747,
iast_GLOBAL (565.805 µs) : 543, 589
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (512.43 µs) : 491, 534
.   : milestone, 512,
iast_INACTIVE (460.55 µs) : 440, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (499.02 µs) : 477, 521
.   : milestone, 499,
tracing (455.007 µs) : 434, 476
.   : milestone, 455,
section candidate
no_agent (381.071 µs) : 361, 401
.   : milestone, 381,
iast (511.866 µs) : 490, 534
.   : milestone, 512,
iast_FULL (747.17 µs) : 725, 770
.   : milestone, 747,
iast_GLOBAL (558.893 µs) : 537, 581
.   : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (510.656 µs) : 489, 532
.   : milestone, 511,
iast_INACTIVE (463.926 µs) : 443, 485
.   : milestone, 464,
iast_TELEMETRY_OFF (503.791 µs) : 481, 526
.   : milestone, 504,
tracing (455.481 µs) : 435, 476
.   : milestone, 455,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.764 µs [359.64 µs, 399.889 µs] -
iast 515.533 µs [493.49 µs, 537.577 µs] 135.769 µs (35.8%)
iast_FULL 746.971 µs [725.038 µs, 768.903 µs] 367.206 µs (96.7%)
iast_GLOBAL 565.805 µs [542.853 µs, 588.757 µs] 186.041 µs (49.0%)
iast_HARDCODED_SECRET_DISABLED 512.43 µs [490.587 µs, 534.272 µs] 132.665 µs (34.9%)
iast_INACTIVE 460.55 µs [439.508 µs, 481.592 µs] 80.786 µs (21.3%)
iast_TELEMETRY_OFF 499.02 µs [477.206 µs, 520.834 µs] 119.256 µs (31.4%)
tracing 455.007 µs [434.171 µs, 475.843 µs] 75.243 µs (19.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 381.071 µs [361.423 µs, 400.718 µs] -
iast 511.866 µs [489.69 µs, 534.042 µs] 130.796 µs (34.3%)
iast_FULL 747.17 µs [724.716 µs, 769.623 µs] 366.099 µs (96.1%)
iast_GLOBAL 558.893 µs [536.896 µs, 580.889 µs] 177.822 µs (46.7%)
iast_HARDCODED_SECRET_DISABLED 510.656 µs [488.989 µs, 532.323 µs] 129.586 µs (34.0%)
iast_INACTIVE 463.926 µs [442.646 µs, 485.207 µs] 82.856 µs (21.7%)
iast_TELEMETRY_OFF 503.791 µs [481.47 µs, 526.111 µs] 122.72 µs (32.2%)
tracing 455.481 µs [434.856 µs, 476.107 µs] 74.411 µs (19.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~d88adb1f94, baseline=1.46.0-SNAPSHOT~148aef92ab
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.369 ms) : 1349, 1388
.   : milestone, 1369,
appsec (1.777 ms) : 1753, 1801
.   : milestone, 1777,
appsec_no_iast (1.767 ms) : 1743, 1791
.   : milestone, 1767,
iast (1.522 ms) : 1499, 1546
.   : milestone, 1522,
profiling (1.554 ms) : 1527, 1581
.   : milestone, 1554,
tracing (1.501 ms) : 1477, 1526
.   : milestone, 1501,
section candidate
no_agent (1.369 ms) : 1349, 1389
.   : milestone, 1369,
appsec (1.753 ms) : 1729, 1777
.   : milestone, 1753,
appsec_no_iast (1.739 ms) : 1715, 1762
.   : milestone, 1739,
iast (1.502 ms) : 1477, 1526
.   : milestone, 1502,
profiling (1.533 ms) : 1509, 1558
.   : milestone, 1533,
tracing (1.488 ms) : 1462, 1513
.   : milestone, 1488,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.369 ms [1.349 ms, 1.388 ms] -
appsec 1.777 ms [1.753 ms, 1.801 ms] 408.243 µs (29.8%)
appsec_no_iast 1.767 ms [1.743 ms, 1.791 ms] 398.155 µs (29.1%)
iast 1.522 ms [1.499 ms, 1.546 ms] 153.485 µs (11.2%)
profiling 1.554 ms [1.527 ms, 1.581 ms] 185.265 µs (13.5%)
tracing 1.501 ms [1.477 ms, 1.526 ms] 132.691 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.369 ms [1.349 ms, 1.389 ms] -
appsec 1.753 ms [1.729 ms, 1.777 ms] 384.181 µs (28.1%)
appsec_no_iast 1.739 ms [1.715 ms, 1.762 ms] 369.977 µs (27.0%)
iast 1.502 ms [1.477 ms, 1.526 ms] 132.59 µs (9.7%)
profiling 1.533 ms [1.509 ms, 1.558 ms] 164.462 µs (12.0%)
tracing 1.488 ms [1.462 ms, 1.513 ms] 118.933 µs (8.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-vertx-session-fix
git_commit_date 1737020324 1737022214
git_commit_sha 148aef9 d88adb1
release_version 1.46.0-SNAPSHOT~148aef92ab 1.46.0-SNAPSHOT~d88adb1f94
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1737024232 1737024232
ci_job_id 768641859 768641859
ci_pipeline_id 53162153 53162153
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~d88adb1f94, baseline=1.46.0-SNAPSHOT~148aef92ab
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (2.358 ms) : 2315, 2400
.   : milestone, 2358,
iast (2.112 ms) : 2058, 2167
.   : milestone, 2112,
iast_GLOBAL (2.153 ms) : 2099, 2207
.   : milestone, 2153,
profiling (1.968 ms) : 1925, 2011
.   : milestone, 1968,
tracing (1.955 ms) : 1913, 1997
.   : milestone, 1955,
section candidate
no_agent (1.482 ms) : 1471, 1494
.   : milestone, 1482,
appsec (2.378 ms) : 2335, 2421
.   : milestone, 2378,
iast (2.114 ms) : 2060, 2169
.   : milestone, 2114,
iast_GLOBAL (2.164 ms) : 2109, 2219
.   : milestone, 2164,
profiling (1.986 ms) : 1942, 2030
.   : milestone, 1986,
tracing (1.955 ms) : 1913, 1997
.   : milestone, 1955,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.466 ms, 1.489 ms] -
appsec 2.358 ms [2.315 ms, 2.4 ms] 880.297 µs (59.6%)
iast 2.112 ms [2.058 ms, 2.167 ms] 634.934 µs (43.0%)
iast_GLOBAL 2.153 ms [2.099 ms, 2.207 ms] 675.71 µs (45.7%)
profiling 1.968 ms [1.925 ms, 2.011 ms] 490.92 µs (33.2%)
tracing 1.955 ms [1.913 ms, 1.997 ms] 477.63 µs (32.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.471 ms, 1.494 ms] -
appsec 2.378 ms [2.335 ms, 2.421 ms] 895.935 µs (60.4%)
iast 2.114 ms [2.06 ms, 2.169 ms] 632.342 µs (42.7%)
iast_GLOBAL 2.164 ms [2.109 ms, 2.219 ms] 681.606 µs (46.0%)
profiling 1.986 ms [1.942 ms, 2.03 ms] 504.078 µs (34.0%)
tracing 1.955 ms [1.913 ms, 1.997 ms] 472.745 µs (31.9%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~d88adb1f94, baseline=1.46.0-SNAPSHOT~148aef92ab
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.211 s) : 15211000, 15211000
.   : milestone, 15211000,
appsec (15.196 s) : 15196000, 15196000
.   : milestone, 15196000,
iast (18.808 s) : 18808000, 18808000
.   : milestone, 18808000,
iast_GLOBAL (17.952 s) : 17952000, 17952000
.   : milestone, 17952000,
profiling (15.054 s) : 15054000, 15054000
.   : milestone, 15054000,
tracing (14.908 s) : 14908000, 14908000
.   : milestone, 14908000,
section candidate
no_agent (14.726 s) : 14726000, 14726000
.   : milestone, 14726000,
appsec (15.305 s) : 15305000, 15305000
.   : milestone, 15305000,
iast (18.816 s) : 18816000, 18816000
.   : milestone, 18816000,
iast_GLOBAL (18.382 s) : 18382000, 18382000
.   : milestone, 18382000,
profiling (14.97 s) : 14970000, 14970000
.   : milestone, 14970000,
tracing (15.12 s) : 15120000, 15120000
.   : milestone, 15120000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.211 s [15.211 s, 15.211 s] -
appsec 15.196 s [15.196 s, 15.196 s] -15.0 ms (-0.1%)
iast 18.808 s [18.808 s, 18.808 s] 3.597 s (23.6%)
iast_GLOBAL 17.952 s [17.952 s, 17.952 s] 2.741 s (18.0%)
profiling 15.054 s [15.054 s, 15.054 s] -157.0 ms (-1.0%)
tracing 14.908 s [14.908 s, 14.908 s] -303.0 ms (-2.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.726 s [14.726 s, 14.726 s] -
appsec 15.305 s [15.305 s, 15.305 s] 579.0 ms (3.9%)
iast 18.816 s [18.816 s, 18.816 s] 4.09 s (27.8%)
iast_GLOBAL 18.382 s [18.382 s, 18.382 s] 3.656 s (24.8%)
profiling 14.97 s [14.97 s, 14.97 s] 244.0 ms (1.7%)
tracing 15.12 s [15.12 s, 15.12 s] 394.0 ms (2.7%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit ae1aa30 into master Jan 16, 2025
174 of 175 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/waf-vertx-session-fix branch January 16, 2025 11:39
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@amarziali amarziali amarziali approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov was automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) inst: vertx Eclipse Vert.x instrumentation tag: no release notes Changes to exclude from release notes type: enhancement
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
3 participants
@manuel-alvarez-alvarez @smola @amarziali