fix sample rate resulting in incorrect metrics #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Verhoog
reviewed
Sep 7, 2018
src/opentracing/span.js
Outdated
| super() | ||
|
|
||
| const startTime = fields.startTime || platform.now() | ||
| const operationName = fields.operationName | ||
| const parent = fields.parent || null | ||
| const tags = fields.tags || {} | ||
| const metrics = { | ||
| _sample_rate: sampler.rate() |
There was a problem hiding this comment.
This key should probably be a constant.
Kyle-Verhoog
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the metrics being incorrect when a sample rate is set. The agent expects to receive a
_sample_ratemetrics so it knows to calculate the correct average according to this value. Since this value was not sent, the metrics would be calculated with the assumption that all traces are sampled at the client.