add ioredis integration #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelchcki
reviewed
Sep 21, 2018
There was a problem hiding this comment.
Overall looks good - I really like how clean the implementation is.
However looking at how command.promise worked here,
got me thinking that it might be worthwhile to add some tests that ensures that data returned in command. promise.then is correctly propagated back to the caller.
Also if you're connecting here to a real Redis instance, would it be possible to create a "round trip" test, i.e set 'x' 'y' get 'x' == 'y'?
WDYT ?
pawelchcki
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
ioredis. For now only 4.x is supported since supporting older versions will require support for Bluebird as well which is not yet available.Closes #259