Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error in graphql when field depth is higher than config #318

Merged
merged 1 commit into from
Oct 17, 2018
Merged

fix error in graphql when field depth is higher than config #318

merged 1 commit into from
Oct 17, 2018

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Oct 17, 2018

This PR fixes an error in the GraphQL integration when the actual depth field is higher than the maximum configured depth.

@rochdev rochdev added bug Something isn't working integrations labels Oct 17, 2018
@rochdev rochdev added this to the 0.6.1 milestone Oct 17, 2018
tylerbenson
tylerbenson approved these changes Oct 17, 2018
View reviewed changes
Copy link

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What could possibly go wrong! :shipit:

@rochdev rochdev merged commit df417e5 into master Oct 17, 2018
@rochdev rochdev deleted the fix-graphql-depth branch October 17, 2018 05:17
rochdev added a commit that referenced this pull request Oct 18, 2018
@rochdev
fix error in graphql when field depth is higher than config (#318)
7a3736a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbenson tylerbenson tylerbenson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working integrations
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@rochdev @tylerbenson