fix missing out.* tags when using a mongodb replica set #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelchcki
approved these changes
Nov 23, 2018
| @@ -75,6 +81,10 @@ function wrapCallback (tracer, span, done) { | |||
| }) | |||
| } | |||
|
|
|||
| if (cursor) { | |||
| addHost(span, cursor.server) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes missing
out.*tags when using a MongoDB replica set. Since the cursor is able to use any topology, it doesn't necessarily have the hostname and port upfront when sending the query. By attempting to set the tags before and after the query, we can ensure that the tags should be set in almost all cases. This issue doesn't apply to the rest of the integration since the Server topology is instrumented directly.