Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing configuration values to telemetry #4580

Merged
merged 8 commits into from
Aug 9, 2024

Conversation

simon-id
Copy link
Member

@simon-id simon-id commented Aug 7, 2024

Recreates #4553

Copy link

github-actions bot commented Aug 7, 2024

Overall package size

Self size: 6.95 MB
Deduped: 58.17 MB
No deduping: 58.45 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Aug 7, 2024

Benchmarks

Benchmark execution time: 2024-08-09 15:37:29

Comparing candidate commit 1a42ea7 in PR branch ida613/add-missing-telemetry-config with baseline commit 2bf83d7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

@ida613 ida613 marked this pull request as ready for review August 7, 2024 13:43
@ida613 ida613 requested a review from a team as a code owner August 7, 2024 13:43
ida613
ida613 previously approved these changes Aug 7, 2024
@ida613 ida613 requested review from a team as code owners August 9, 2024 01:16
@ida613 ida613 requested a review from tonyredondo August 9, 2024 01:16
@ida613 ida613 force-pushed the ida613/add-missing-telemetry-config branch from bdf54df to 86cefe1 Compare August 9, 2024 01:24
@ida613 ida613 marked this pull request as draft August 9, 2024 01:25
@ida613 ida613 requested review from a team and removed request for a team and tonyredondo August 9, 2024 01:26
@ida613 ida613 marked this pull request as ready for review August 9, 2024 01:33
@ida613 ida613 removed the request for review from a team August 9, 2024 01:34
@simon-id simon-id changed the title Ida613/add missing telemetry config Add missing telemetry config Aug 9, 2024
@simon-id simon-id changed the title Add missing telemetry config Add missing configuration values to telemetry Aug 9, 2024
@simon-id
Copy link
Member Author

simon-id commented Aug 9, 2024

LGTM

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.48%. Comparing base (cd2f45d) to head (0198020).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4580      +/-   ##
==========================================
+ Coverage   84.19%   92.48%   +8.29%     
==========================================
  Files         260      103     -157     
  Lines       11664     3352    -8312     
  Branches       33       33              
==========================================
- Hits         9820     3100    -6720     
+ Misses       1844      252    -1592     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ida613
ida613 previously approved these changes Aug 9, 2024
@ida613 ida613 force-pushed the ida613/add-missing-telemetry-config branch from 0198020 to 48bcd87 Compare August 9, 2024 15:08
@ida613 ida613 merged commit 77c1d07 into master Aug 9, 2024
175 checks passed
@ida613 ida613 deleted the ida613/add-missing-telemetry-config branch August 9, 2024 15:40
@uurien uurien mentioned this pull request Aug 13, 2024
uurien pushed a commit that referenced this pull request Aug 13, 2024
Co-authored-by: Ida Liu <119438987+ida613@users.noreply.github.com>
@uurien uurien mentioned this pull request Aug 13, 2024
uurien pushed a commit that referenced this pull request Aug 13, 2024
Co-authored-by: Ida Liu <119438987+ida613@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants