Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly handle 128 bit traceids in log injection #4601

Merged

Conversation

khanayan123
Copy link
Collaborator

What does this PR do?

use the span context's toTraceId helper method to set the trace_id instead of constructing it manually

Motivation

Addressing a bug where log injection outputs a 192 bit trace id when the traceId in the span context is already 128 bits

@khanayan123 khanayan123 requested a review from a team as a code owner August 12, 2024 21:59
@khanayan123 khanayan123 changed the title correctly handle 128 bits traceids in log injection correctly handle 128 bit traceids in log injection Aug 12, 2024
Copy link

Overall package size

Self size: 6.93 MB
Deduped: 58.16 MB
No deduping: 58.44 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.24%. Comparing base (77c1d07) to head (babb962).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4601      +/-   ##
==========================================
+ Coverage   64.91%   72.24%   +7.32%     
==========================================
  Files         260      308      +48     
  Lines       11807    13323    +1516     
  Branches       33       33              
==========================================
+ Hits         7665     9625    +1960     
+ Misses       4142     3698     -444     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Aug 12, 2024

Benchmarks

Benchmark execution time: 2024-08-12 22:05:17

Comparing candidate commit babb962 in PR branch khanayan123/correctly-handle-128-bit-ids-in-log-injection with baseline commit 77c1d07 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 263 metrics, 3 unstable metrics.

@khanayan123 khanayan123 merged commit 3e179d0 into master Aug 13, 2024
175 of 176 checks passed
@khanayan123 khanayan123 deleted the khanayan123/correctly-handle-128-bit-ids-in-log-injection branch August 13, 2024 01:31
@uurien uurien mentioned this pull request Aug 13, 2024
@uurien uurien mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants