Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROF-10330: Emit SSI information in the profile system info #4607

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented Aug 14, 2024

What does this PR do?

Adds SSI-related metadata to profile system info within even.json. Essentially:

{ …
  info: { …
    profiler: { …
      activation: $ACTIVATION,
      ssi: {
        enabled: $SSI_ENABLED,
        mechanism: $SSI_MECHANISM
      }
    }
  }
}

Where

  • $ACTIVATION is 'manual', 'auto', or 'injection' depending on whether profiling is enabled with DD_PROFILING_ENABLED=true, DD_PROFILING_ENABLED=auto, or DD_INJECTION_ENABLED=…,profiler,…, respectively.
  • $SSI_ENABLED is true or false depending on whether DD_INJECTION_ENABLED is defined or not
  • $SSI_MECHANISM is 'injected_agent' or undefined depending on whether $SSI_ENABLED is true or false.

Motivation

We want to be able to filter profiles (and emit metrics) based on SSI enablement.

Copy link

github-actions bot commented Aug 14, 2024

Overall package size

Self size: 6.95 MB
Deduped: 58.18 MB
No deduping: 58.46 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Qard
Qard previously approved these changes Aug 15, 2024
@pr-commenter
Copy link

pr-commenter bot commented Aug 16, 2024

Benchmarks

Benchmark execution time: 2024-08-16 08:20:10

Comparing candidate commit 6a8375f in PR branch szegedi/emit-ssi-profile-information with baseline commit 4df8c4d in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics.

@szegedi szegedi enabled auto-merge (squash) August 19, 2024 17:41
@szegedi szegedi merged commit e568fe3 into master Aug 20, 2024
175 checks passed
@szegedi szegedi deleted the szegedi/emit-ssi-profile-information branch August 20, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants