Add Plugin for @azure/functions #4716

duncanpharvey · 2024-09-23T13:23:12Z

What does this PR do?

Adds plugin for @azure/functions package.

Motivation

Create a root span for Azure Function invocations via HTTP requests.

https://datadoghq.atlassian.net/browse/SVLS-4929

Plugin Checklist

No unit tests but there is an integration test. Unit testing is cumbersome due to how Azure Functions can be tested locally. They must be started using the func start Azure Functions Core Tools cli command.

Additional Notes

Builds off the plugin work started by @gord02 in Gordon.hamilton/azure functions integration #4599
Uses web utils to avoid rewriting logic for http related span tags
Only http related triggers are instrumented as part of this PR. Other triggers (CosmosDB, EventGrid, EventHub, Service Bus Queue, Service Bus Topic, Storage Blob, Storage Queue, and Timer) will be instrumented in future PRs.
- https://learn.microsoft.com/en-us/javascript/api/@azure/functions/app?view=azure-node-latest

github-actions · 2024-09-23T13:24:07Z

Overall package size

Self size: 7.46 MB
Deduped: 63.23 MB
No deduping: 63.51 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.1.1 | 18.67 MB | 18.68 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.59 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 9.0.0 | 580.4 kB | 1.03 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

codecov · 2024-09-23T13:25:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.16%. Comparing base (bb0bbcc) to head (91a2dd9).
Report is 33 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4716       +/-   ##
===========================================
- Coverage   91.42%   63.16%   -28.27%     
===========================================
  Files         112       30       -82     
  Lines        3475     1778     -1697     
  Branches       33        0       -33     
===========================================
- Hits         3177     1123     -2054     
- Misses        298      655      +357

Flag	Coverage Δ
	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pr-commenter · 2024-09-24T14:27:39Z

Benchmarks

Benchmark execution time: 2024-10-10 20:07:40

Comparing candidate commit c3f9565 in PR branch duncan-harvey/azure-functions-integration with baseline commit ce0bdce in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 257 metrics, 9 unstable metrics.

tlhunter · 2024-10-03T16:27:24Z

packages/datadog-plugin-azure-functions/src/index.js

+function extractPath (url) {
+  const regex = /https?:\/\/[^/]+(\/.*$)/
+  const match = url.match(regex)
+  return match ? match[1] : ''
+}


I'd recommend using the built-in URL parsers instead of rolling one ourselves:

extractPath('http://www.google.com/asdf?asdf') // '/asdf?asdf' url.parse('http://www.google.com/asdf?asdf').path // if search query is needed // '/asdf?asdf' (new URL('http://www.google.com/asdf?asdf')).pathname // if search query isn't needed // '/asdf'

packages/dd-trace/src/plugins/util/web.js

.gitignore

index.d.ts

packages/datadog-plugin-azure-functions/src/index.js

packages/datadog-plugin-azure-functions/test/integration-test/client.spec.js

Co-authored-by: Roch Devost <roch.devost@datadoghq.com>

This reverts commit 3c004c5.

This reverts commit 91a2dd9.

* adds azure functions plugin * adds azure_functions plugin to API documentation * add typescript test for azure functions plugin * adds integration test for azure-functions plugin * add licenses for added dev packages * add azure-functions plugin to github workflow * use pipe for azure-functions integration test child process * update azure-functions integration test api route * refactor azure-functions integration test * add azure func command to path * remove yarn.lock file from azure-functions integration test * allow span kind to be server for azure functions * Update index.d.ts Co-authored-by: Roch Devost <roch.devost@datadoghq.com> * add serverless util * use built in url parser * remove serverless logic from web util * remove wait-on dependency * remove find-process dependency * Revert "remove find-process dependency" This reverts commit 3c004c5. * call func start directly and remove find-process dependency * simplify serverless util * Revert "simplify serverless util" This reverts commit 91a2dd9. * simplify serverless util --------- Co-authored-by: Roch Devost <roch.devost@datadoghq.com>

duncanpharvey added 2 commits September 20, 2024 16:16

adds azure functions plugin

53c0632

adds azure_functions plugin to API documentation

a82c482

duncanpharvey added semver-minor serverless labels Sep 23, 2024

add typescript test for azure functions plugin

45db12c

duncanpharvey added 4 commits September 27, 2024 16:03

adds integration test for azure-functions plugin

6bd7123

add licenses for added dev packages

f9749c7

add azure-functions plugin to github workflow

b8b2316

use pipe for azure-functions integration test child process

1aa235f

duncanpharvey marked this pull request as ready for review September 27, 2024 20:26

duncanpharvey requested review from a team as code owners September 27, 2024 20:26

duncanpharvey and others added 6 commits September 27, 2024 16:31

update azure-functions integration test api route

500103c

Merge branch 'master' into duncan-harvey/azure-functions-integration

ba88022

refactor azure-functions integration test

195082c

add azure func command to path

d5a3c8d

remove yarn.lock file from azure-functions integration test

f1cf495

allow span kind to be server for azure functions

6b405c7

tlhunter reviewed Oct 3, 2024

View reviewed changes

packages/dd-trace/src/plugins/util/web.js Outdated Show resolved Hide resolved

rochdev requested changes Oct 4, 2024

View reviewed changes

duncanpharvey and others added 6 commits October 4, 2024 10:46

Update index.d.ts

201d9c0

Co-authored-by: Roch Devost <roch.devost@datadoghq.com>

add serverless util

766e740

use built in url parser

bcd230e

remove serverless logic from web util

119da9f

remove wait-on dependency

8a81f3c

remove find-process dependency

3c004c5

duncanpharvey added 5 commits October 8, 2024 17:01

Revert "remove find-process dependency"

a088120

This reverts commit 3c004c5.

call func start directly and remove find-process dependency

4a6c8a6

simplify serverless util

91a2dd9

Revert "simplify serverless util"

6967f7d

This reverts commit 91a2dd9.

simplify serverless util

21c85af

duncanpharvey force-pushed the duncan-harvey/azure-functions-integration branch from aea5293 to 21c85af Compare October 10, 2024 15:56

rochdev approved these changes Oct 10, 2024

View reviewed changes

Merge branch 'master' into duncan-harvey/azure-functions-integration

c3f9565

jcstorms1 approved these changes Oct 10, 2024

View reviewed changes

rochdev merged commit 5a113b2 into master Oct 10, 2024
198 checks passed

rochdev deleted the duncan-harvey/azure-functions-integration branch October 10, 2024 21:04

duncanpharvey mentioned this pull request Oct 10, 2024

Gordon.hamilton/azure functions integration #4599

Closed

6 tasks

This was referenced Oct 16, 2024

V4.48.0 proposal #4787

Merged

V5.24.0 proposal #4788

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Plugin for @azure/functions #4716

Add Plugin for @azure/functions #4716

duncanpharvey commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

codecov bot commented Sep 23, 2024 •

edited

Loading

pr-commenter bot commented Sep 24, 2024 •

edited

Loading

tlhunter Oct 3, 2024

duncanpharvey Oct 7, 2024

Add Plugin for @azure/functions #4716

Add Plugin for @azure/functions #4716

Conversation

duncanpharvey commented Sep 23, 2024 • edited Loading

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

github-actions bot commented Sep 23, 2024 • edited Loading

Overall package size

codecov bot commented Sep 23, 2024 • edited Loading

Codecov Report

pr-commenter bot commented Sep 24, 2024 • edited Loading

Benchmarks

tlhunter Oct 3, 2024

Choose a reason for hiding this comment

duncanpharvey Oct 7, 2024

Choose a reason for hiding this comment

duncanpharvey commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

codecov bot commented Sep 23, 2024 •

edited

Loading

pr-commenter bot commented Sep 24, 2024 •

edited

Loading