v4.47.0 #4735
Merged
v4.47.0 #4735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jordi Bertran de Balanda <jordi.bertran@datadoghq.com>
…4645) * Add DSM support for KafkaJS batch consume operation
Remote Config updates coming from the Agent needs to be acknowledged. This PR
changes the existing behavior by optionally allowing the acknowledgement to be
async. This is achieved by:
- Changing the way you register products from using the `EventEmitter` API to a
custom API that only allows a single handler per product (event emitters can
have more than one listener, which is problematic as we can't support more
than one of the listeners to acknowledge the config). The new API is as
follows:
- `rc.setProductHandler(product, handler)` (prevously `rc.on(product,
handler)`)
- `rc.removeProductHandler(product)` (prevously `rc.off(product, handler)`)
- The new product handler is called similar to the old event listener, with the
following exception: A new optional 4th argument is supplied called `ack`.
This is a callback which can be called (sync or async) either without any
arguments (to set the state to `ACKNOWLEDGED`) or with a single error argument
(to set the state to `ERROR`).
- If the handler function signature takes less than 4 arguments or doesn't use
the rest operator (`...args`), and...
- ...the handler doesn't return a `Promise`: The state is set to
`ACKNOWLEDGED` right away without the handler having to do anything
(existing behavior)
- ...the handler returns a `Promise`, we wait until the promise is resolved
or rejected and set the state accordingly (new behavior)
- If the handler function signature takes 4 or more arguments or use the rest
operator (`...args`): The state is left as `UNACKNOWLEDGED` until the `ack`
callback is called (new behavior)
- In any case, the state is still set to `ERROR` if the handler throws
(existing behavior)
The `RemoteConfigManager` is still an `EventEmitter` however because the
`kPreUpdate` symbol is still being emitted.
#4651) * fix * test * remove .only
* Check WAF context disposal before run * Tests for disposal check and warn log * Move the check to the beginning of run() * Merge tests
These snug in via PR #4309 last week
--------- Co-authored-by: simon-id <simon.id@datadoghq.com>
Indicating that a backoff has expired isn't enough information to diagnose what's causing the backoff in the first place, so rather than creating a new error object, this change just passes the last error along.
Prepare the Node.js tracer to be used with the Dynamic Instrumentation product (DI). Probes are added as breakpoints using the V8 Inspector Protocol. The inspector runs in a worker thread and will pause the main thread temporarily while gathering the required information related to the probe (as of this commit no information is gathered, but this is a required step once we start to gather the local state snapshot). DI features included in this commit: - Support for line based log probes - Support for loading probes via Remote Configuration - Support for sending probe status to the debugger-backend - Support for sending log data to debugger-backend Please note, that with this commit it's still not possible to use DI with the Node.js tracer as support for using the Node.js tracer with DI has not yet been enabled in the Datadog UI.
Two files have been modified, which was added to the repo 5 years ago and never touched again: The `.vscode/launch.json` file was outdated and didn't actually work, as it expected `tdd` to exist in the path. Read more about `launch.json` attributes here: https://code.visualstudio.com/Docs/editor/debugging#_launchjson-attributes The `.vscode/settings.json` file was outdated and used a config property no longer supported. The proper equivalent setting would have been: "debug.javascript.autoAttachFilter": "always" But I don't think we want that as it will auto-attach a debugger to every script you run in the console. I've opted for removing this altogether. Read more about auto-attaching here: https://code.visualstudio.com/docs/nodejs/nodejs-debugging#_auto-attach
* use DD_VERSION as version for tracer computed stats if available * test version for tracer computed stats
Separating Rhea into its own CI test job.
If the payload being sent to the agent contained any two-or-more-byte characters, the calculation would be incorrect because `str.length` returns the number of characters and not the number of bytes in the string. If the payload was JSON, this would make it malformed and the receiver would not be able to parse it (as it would be missing one or more bytes from the end of the payload).
Overall package sizeSelf size: 7.21 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.1.1 | 18.67 MB | 18.68 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 7.01 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 9.0.0 | 580.4 kB | 1.03 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com>
BenchmarksBenchmark execution time: 2024-10-01 08:14:08 Comparing candidate commit 2c3ce03 in PR branch Found 0 performance improvements and 7 performance regressions! Performance is the same for 769 metrics, 22 unstable metrics. scenario:log-skip-log-16
scenario:log-with-debug-16
scenario:log-with-error-16
scenario:log-without-log-16
scenario:scope-manager-async_hooks-18
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4.x #4735 +/- ##
=======================================
Coverage ? 65.36%
=======================================
Files ? 280
Lines ? 12137
Branches ? 33
=======================================
Hits ? 7933
Misses ? 4204
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
uurien
previously approved these changes
Sep 30, 2024
wconti27
previously approved these changes
Sep 30, 2024
juan-fernandez
dismissed stale reviews from wconti27 and uurien
via
5b17775
juan-fernandez
force-pushed
the
v4.47.0-proposal
branch
from
c9d64df
to
5b17775
Compare
…vailable (#4741) * fix dsm checkpointing when no parent context is available when consuming
juan-fernandez
force-pushed
the
v4.47.0-proposal
branch
from
5b17775
to
2c3ce03
Compare
uurien
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
@jest/test-sequencerinstrumentation #4678Features
Improvements
Excluded from Release notes