Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Refactor integration tests #4817

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

watson
Copy link
Collaborator

@watson watson commented Oct 23, 2024

Group Dynamic Instrumentation integration tests into separate files based on the type of target application that is needed.

As more and more complex tests needs to be written in the future, this will become more and more important, as the current single Fastify app quickly becomes too complicated. Without this refactor, tests needing a small change in the target app might suddenly break a lot of existing tests.

Group integration tests into separate files based on the type of target
application that is needed.

As more and more complex tests needs to be written in the future, this
will become more and more important, as the current single Fastify app
quickly becomes too complicated. Without this refactor, tests needing a
small change in the target app might suddenly break a lot of existing
tests.
@watson watson requested review from a team as code owners October 23, 2024 18:56
@watson watson self-assigned this Oct 23, 2024
Copy link
Collaborator Author

watson commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @watson and the rest of your teammates on Graphite Graphite

Copy link

Overall package size

Self size: 7.6 MB
Deduped: 62.91 MB
No deduping: 63.25 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Oct 23, 2024

Benchmarks

Benchmark execution time: 2024-10-23 19:05:17

Comparing candidate commit 67b70d6 in PR branch watson/DEBUG-2804/refactor-integration-tests with baseline commit 81d6947 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 8 unstable metrics.

@watson watson merged commit 24e846e into master Oct 28, 2024
205 checks passed
@watson watson deleted the watson/DEBUG-2804/refactor-integration-tests branch October 28, 2024 09:20
rochdev pushed a commit that referenced this pull request Oct 31, 2024
rochdev pushed a commit that referenced this pull request Oct 31, 2024
rochdev pushed a commit that referenced this pull request Oct 31, 2024
rochdev pushed a commit that referenced this pull request Nov 6, 2024
rochdev pushed a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants