[test optimization] Fix active span being null in cypress #4863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 7.98 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-11-14 09:45:51 Comparing candidate commit b52022f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 257 metrics, 9 unstable metrics. |
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
.github/workflows/project.yml
Outdated
| - uses: actions/checkout@v4 | ||
| - uses: ./.github/actions/node/setup | ||
| - uses: ./.github/actions/install | ||
| - uses: actions/setup-node@v3 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
.github/workflows/project.yml
Outdated
| DD_CIVISIBILITY_AGENTLESS_ENABLED: 1 | ||
| DD_API_KEY: ${{ secrets.DD_API_KEY_CI_APP }} | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4863 +/- ##
===========================================
- Coverage 93.86% 61.12% -32.74%
===========================================
Files 107 301 +194
Lines 3373 14060 +10687
===========================================
+ Hits 3166 8594 +5428
- Misses 207 5466 +5259 ☔ View full report in Codecov by Sentry. |
juan-fernandez
force-pushed
the
juan-fernandez/fix-cypress-active-span-check
branch
from
65409e1
to
b52022f
Compare
juan-fernandez
commented
Nov 14, 2024
| const { state, error, isRUMActive, testSourceLine, testSuite, testName, isNew, isEfdRetry } = test | ||
| if (this.activeTestSpan) { |
There was a problem hiding this comment.
no changes here, just returning earlier if this.activeTestSpan is null.
tonyredondo
approved these changes
Nov 14, 2024
juan-fernandez
deleted the
juan-fernandez/fix-cypress-active-span-check
branch
rochdev
pushed a commit
that referenced
this pull request
Nov 14, 2024
rochdev
pushed a commit
that referenced
this pull request
Nov 14, 2024
rochdev
pushed a commit
that referenced
this pull request
Nov 19, 2024
rochdev
pushed a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Do not run the telemetry tag addition if
this.activeTestSpanis empty.Motivation
Running this code without checking if
this.activeTestSpanis dangerous.Plugin Checklist
Pending: I don't know exactly how to trigger this condition 😓 . This should nonetheless make the code safer.