Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix race condition in initialization file on latest node #4942

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix race condition in initialization file on latest node #4942

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d59d29a
fix race condition in initialization file on latest node
rochdev Nov 26, 2024
d6d23d6
remove awaits entirely from init code
rochdev Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions initialize.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

import { isMainThread } from 'worker_threads'

import * as Module from 'node:module'
import { fileURLToPath } from 'node:url'
import {
load as origLoad,
Expand Down Expand Up @@ -49,12 +50,9 @@ export async function getSource (...args) {
}

if (isMainThread) {
// Need this IIFE for versions of Node.js without top-level await.
(async () => {
await import('./init.js')
const { register } = await import('node:module')
if (register) {
register('./loader-hook.mjs', import.meta.url)
}
})()
const require = Module.createRequire(import.meta.url)
require('./init.js')
if (Module.register) {
Module.register('./loader-hook.mjs', import.meta.url)
}
}
Loading